Archives/koreader
2
0
Fork 0
mirror of https://github.com/koreader/koreader synced 2024-11-04 12:00:25 +00:00
Code Issues Projects Releases Wiki Activity

[plugin] Statistics: fix sync caused by semicolon in SQL comment (#10503)

Browse Source 
Follow-up to <https://github.com/koreader/koreader/pull/10498>.
This commit is contained in:
Glen Sawyer 2023-05-30 14:56:25 -06:00 committed by GitHub
parent 2aa11b13ad
commit 128f205324
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/statistics.koplugin/main.lua
View File

@ -3050,11 +3050,11 @@ function ReaderStatistics.onSync(local_path, cached_path, income_path)
return false
end
-- NOTE: We could replace this first `UPDATE` with an "upsert" by adding an `ON CONFLICT` clause to the
-- following `INSERT`, but using `ON CONFLICT` unnecessarily increments the autoincrement for the table.
-- See https://sqlite.org/forum/info/98d4fb9ced866287
sql = sql .. [[
-- If book was opened more recently on another device, then update local db's `last_open` field
-- NOTE: We could do this as an "upsert" by adding an `ON CONFLICT` clause to the following `INSERT`
-- but using `ON CONFLICT` unnecessarily increments the autoincrement for the table;
-- see https://sqlite.org/forum/info/98d4fb9ced866287
-- If book was opened more recently on another device, then update local last_open field
UPDATE book AS b
SET last_open = i.last_open
FROM income_db.book AS i