From 0ea8bee4e1fa4324999d08ae0865f96b01407202 Mon Sep 17 00:00:00 2001 From: NiLuJe Date: Tue, 28 Sep 2021 01:37:13 +0200 Subject: [PATCH] TextBoxWidget: Unbreak Wikipedia (#8275) Turns out we can't release line_num_to_image early, so, delay it until the final, full widget teardown. (Regression since #8250, c.f., https://github.com/koreader/koreader/pull/8250#discussion_r716646211) --- frontend/ui/widget/textboxwidget.lua | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frontend/ui/widget/textboxwidget.lua b/frontend/ui/widget/textboxwidget.lua index d9c8eaf87..ec830993a 100644 --- a/frontend/ui/widget/textboxwidget.lua +++ b/frontend/ui/widget/textboxwidget.lua @@ -1134,7 +1134,6 @@ function TextBoxWidget:free(full) self.cursor_restore_bb:free() self.cursor_restore_bb = nil end - self.line_num_to_image = nil if full ~= false then -- final free(): free all remaining resources if self.use_xtext and self._xtext then -- Allow not waiting until Lua gc() to cleanup C XText malloc'ed stuff @@ -1143,6 +1142,9 @@ function TextBoxWidget:free(full) self._xtext = nil -- logger.dbg("TextBoxWidget:_xtext:free()") end + + self.line_num_to_image = nil + self.vertical_string_list = nil end end