Archives/koreader
2
0
Fork 0
mirror of https://github.com/koreader/koreader synced 2024-11-13 19:11:25 +00:00
Code Issues Projects Releases Wiki Activity
c7a3c17ce0
koreader/.luacheckrc

157 lines
5.2 KiB
Plaintext
Raw Normal View History

build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
unused_args = false
std = "luajit"
uimanager(refactor): replace autosuspend if check with noop
2016-03-29 07:56:29 +00:00
-- ignore implicit self
self = false
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
globals = {
"G_reader_settings",
}
read_globals = {
chore: fix all luacheck errors for plugins
2016-11-08 05:24:34 +00:00
"_ENV",
minor: a lot of luacheck fixes
2016-02-16 07:10:07 +00:00
"KOBO_TOUCH_MIRRORED",
"KOBO_SYNC_BRIGHTNESS_WITH_NICKEL",
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
"DHINTCOUNT",
"DRENDER_MODE",
"DGLOBAL_CACHE_SIZE_MINIMUM",
"DGLOBAL_CACHE_FREE_PROPORTION",
"DGLOBAL_CACHE_SIZE_MAXIMUM",
"DBACKGROUND_COLOR",
"DOUTER_PAGE_COLOR",
Update UI layout code to use new SVG icons - Add IconWidget, use it for icons instead of ImageWidget. Specify icons by name only, look for them (with either .svg or .png suffixes) in multiple directories (including koreader/settings/icons/ to allow customizing them). Don't crash when icon name not found, shown a black background warning icon instead. - Don't trust the icons' native sizes: replace scale_for_dpi=true with width/height=DGENERIC_ICON_SIZE, so all icons get the same (tunable) size - except in a few specific use cases. - Top and bottom menu bars: normalize, and have icons properly centered in them, extend vertical line separators up to the edges. - TOC: adjust expand/collapse icons size to items size
2020-12-19 11:18:30 +00:00
"DGENERIC_ICON_SIZE",
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
"DCREREADER_VIEW_MODE",
"DSHOWOVERLAP",
"DSHOWHIDDENFILES",
"DLANDSCAPE_CLOCKWISE_ROTATION",
"DCREREADER_TWO_PAGE_THRESHOLD",
"DOVERLAPPIXELS",
"FOLLOW_LINK_TIMEOUT",
"DTAP_ZONE_MENU",
[RFC] Make default UI tapzones more generous (#6918) * Top menu & bottom menu tapzones are now full-width, thanks to the now sane override system. * A separate, extra tapzone was also created for each of them to provide a taller, but narrower tapzone extension (one that doesn't clash with the prev/next tapzones). * The footer tapzone was made much taller.
2020-12-03 16:33:54 +00:00
"DTAP_ZONE_MENU_EXT",
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
"DTAP_ZONE_CONFIG",
[RFC] Make default UI tapzones more generous (#6918) * Top menu & bottom menu tapzones are now full-width, thanks to the now sane override system. * A separate, extra tapzone was also created for each of them to provide a taller, but narrower tapzone extension (one that doesn't clash with the prev/next tapzones). * The footer tapzone was made much taller.
2020-12-03 16:33:54 +00:00
"DTAP_ZONE_CONFIG_EXT",
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
"DTAP_ZONE_MINIBAR",
"DTAP_ZONE_FORWARD",
"DTAP_ZONE_BACKWARD",
"DTAP_ZONE_BOOKMARK",
"DTAP_ZONE_FLIPPING",
[UX] Gesture manager: corner gestures (#4878) Adds configuration to the top corners as well as the additional gestures hold and two-finger tap. Deprecates `DTAP_ZONE_FLIPPING` and `DTAP_ZONE_BOOKMARK`. Fixes #4877.
2019-04-07 17:00:15 +00:00
"DTAP_ZONE_TOP_LEFT",
"DTAP_ZONE_TOP_RIGHT",
"DTAP_ZONE_BOTTOM_LEFT",
"DTAP_ZONE_BOTTOM_RIGHT",
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
"DDOUBLE_TAP_ZONE_NEXT_CHAPTER",
"DDOUBLE_TAP_ZONE_PREV_CHAPTER",
"DCHANGE_WEST_SWIPE_TO_EAST",
"DCHANGE_EAST_SWIPE_TO_WEST",
"DKOPTREADER_CONFIG_FONT_SIZE",
"DKOPTREADER_CONFIG_TEXT_WRAP",
"DKOPTREADER_CONFIG_TRIM_PAGE",
"DKOPTREADER_CONFIG_DETECT_INDENT",
"DKOPTREADER_CONFIG_DEFECT_SIZE",
"DKOPTREADER_CONFIG_PAGE_MARGIN",
"DKOPTREADER_CONFIG_LINE_SPACING",
"DKOPTREADER_CONFIG_RENDER_QUALITY",
"DKOPTREADER_CONFIG_AUTO_STRAIGHTEN",
"DKOPTREADER_CONFIG_JUSTIFICATION",
"DKOPTREADER_CONFIG_MAX_COLUMNS",
"DKOPTREADER_CONFIG_CONTRAST",
"DKOPTREADER_CONFIG_WORD_SPACINGS",
"DKOPTREADER_CONFIG_DEFAULT_WORD_SPACING",
"DKOPTREADER_CONFIG_DOC_LANGS_TEXT",
"DKOPTREADER_CONFIG_DOC_LANGS_CODE",
"DKOPTREADER_CONFIG_DOC_DEFAULT_LANG_CODE",
"DCREREADER_CONFIG_FONT_SIZES",
"DCREREADER_CONFIG_DEFAULT_FONT_SIZE",
Give more control over CRe margins (#4945) Without having to resort to weird custom defaults. * Split the current margins setting in three: * Horizontal margins (because you generally want those two to be balanced). * Top margin & Bottom margin (because you may want to tweak those separately to deal with quirky status bar/final line shenanigans). * Also, add a "Reclaim bar height from bottom margin" toggle to the status bar menu, to optionally make sure the status bar won't eat into the bottom margin. * Includes a free fix to diacritics popup refresh handling in the keyboard ;).
2019-05-01 00:09:01 +00:00
"DCREREADER_CONFIG_H_MARGIN_SIZES_SMALL",
"DCREREADER_CONFIG_H_MARGIN_SIZES_MEDIUM",
"DCREREADER_CONFIG_H_MARGIN_SIZES_LARGE",
"DCREREADER_CONFIG_H_MARGIN_SIZES_X_LARGE",
"DCREREADER_CONFIG_H_MARGIN_SIZES_XX_LARGE",
"DCREREADER_CONFIG_H_MARGIN_SIZES_XXX_LARGE",
"DCREREADER_CONFIG_H_MARGIN_SIZES_HUGE",
"DCREREADER_CONFIG_H_MARGIN_SIZES_X_HUGE",
"DCREREADER_CONFIG_H_MARGIN_SIZES_XX_HUGE",
"DCREREADER_CONFIG_T_MARGIN_SIZES_SMALL",
"DCREREADER_CONFIG_T_MARGIN_SIZES_MEDIUM",
"DCREREADER_CONFIG_T_MARGIN_SIZES_LARGE",
"DCREREADER_CONFIG_T_MARGIN_SIZES_X_LARGE",
"DCREREADER_CONFIG_T_MARGIN_SIZES_XX_LARGE",
"DCREREADER_CONFIG_T_MARGIN_SIZES_XXX_LARGE",
"DCREREADER_CONFIG_T_MARGIN_SIZES_HUGE",
"DCREREADER_CONFIG_T_MARGIN_SIZES_X_HUGE",
"DCREREADER_CONFIG_T_MARGIN_SIZES_XX_HUGE",
"DCREREADER_CONFIG_B_MARGIN_SIZES_SMALL",
"DCREREADER_CONFIG_B_MARGIN_SIZES_MEDIUM",
"DCREREADER_CONFIG_B_MARGIN_SIZES_LARGE",
"DCREREADER_CONFIG_B_MARGIN_SIZES_X_LARGE",
"DCREREADER_CONFIG_B_MARGIN_SIZES_XX_LARGE",
"DCREREADER_CONFIG_B_MARGIN_SIZES_XXX_LARGE",
"DCREREADER_CONFIG_B_MARGIN_SIZES_HUGE",
"DCREREADER_CONFIG_B_MARGIN_SIZES_X_HUGE",
"DCREREADER_CONFIG_B_MARGIN_SIZES_XX_HUGE",
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
"DCREREADER_CONFIG_LIGHTER_FONT_GAMMA",
"DCREREADER_CONFIG_DEFAULT_FONT_GAMMA",
"DCREREADER_CONFIG_DARKER_FONT_GAMMA",
Add more granularity in line-height settings with CRe (#4785) 70 -> 130, in steps of 5 ;).
2019-03-14 23:34:46 +00:00
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_X_TINY",
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_TINY",
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_XX_SMALL",
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_X_SMALL",
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_SMALL",
Add more granularity in line-height settings with CRe (#4785) 70 -> 130, in steps of 5 ;).
2019-03-14 23:34:46 +00:00
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_L_SMALL",
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_MEDIUM",
Add more granularity in line-height settings with CRe (#4785) 70 -> 130, in steps of 5 ;).
2019-03-14 23:34:46 +00:00
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_L_MEDIUM",
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_XL_MEDIUM",
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_XXL_MEDIUM",
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_LARGE",
Add more granularity in line-height settings with CRe (#4785) 70 -> 130, in steps of 5 ;).
2019-03-14 23:34:46 +00:00
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_X_LARGE",
"DCREREADER_CONFIG_LINE_SPACE_PERCENT_XX_LARGE",
bump crengine: word spacing and hyphenation tweaks Includes: - New option to tune word spacing: space width scale percent - Text: look for hyphenation in more words if needed - CSS: fix "hyphens:none" should override inherited "hyphens:auto" - getHtml(): grab dir= and lang= attributes from upper nodes Replace our Word Gap/Space condensing toggle/setting with a new Word Spacing toggle/setting, made of 2 values: - 1st number scales the normal width of spaces in all font (100% uses the font space width untouched) - 2nd number applies after the 1st has been applied, and tells how much these spaces can additionally be condensed to make more text fit on a line.
2019-11-28 21:39:06 +00:00
"DCREREADER_CONFIG_WORD_SPACING_SMALL",
"DCREREADER_CONFIG_WORD_SPACING_MEDIUM",
"DCREREADER_CONFIG_WORD_SPACING_LARGE",
Adds Word Expansion: use of letter spacing for justification Bump crengine: - Text: fix occasional BiDi bad word splitting - Font: fix HB fallback measurement/drawing mismatches - Font: do not add letter spacing on diacritics - Text: tunable use of letter spacing for justification - Text: dont adjust space after initial quotation mark/dash (rework) - Text: fix possible bad widths after collapsed spaces xtext.cpp: pick crengine fix with HB fallback measurement/drawing mismatches Adds "Word Expansion" to bottom Font size menu, and moved "Word Spacing" there too, to balance the panels' heights to 4 items.
2020-05-03 16:06:58 +00:00
"DCREREADER_CONFIG_WORD_EXPANSION_NONE",
"DCREREADER_CONFIG_WORD_EXPANSION_SOME",
"DCREREADER_CONFIG_WORD_EXPANSION_MORE",
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
"DMINIBAR_CONTAINER_HEIGHT",
"DGESDETECT_DISABLE_DOUBLE_TAP",
"FRONTLIGHT_SENSITIVITY_DECREASE",
"DALPHA_SORT_CASE_INSENSITIVE",
"KOBO_LIGHT_ON_START",
"NETWORK_PROXY",
chore: more luacheck fixes
2016-01-03 09:18:54 +00:00
"DUSE_TURBO_LIB",
stardict path override
2020-04-14 17:36:44 +00:00
"STARDICT_DATA_DIR",
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
"cre",
"lfs",
"lipc",
Font rendering: add some helpers for use by xtext bump base for libkoreader-xtext.so: - ffi/pic.lua: fix memory leak with some unsupported PNG files - FreeType ffi: add methods for use with Harfbuzz shaping - thirdparty: adds libunibreak - Adds libkoreader-xtext.so: enhanced text shaping Add a getFallbackFont(N) to each Lua font object to instantiate (if not yet done) and return the Nth fallback font for the font. Fallback fonts list: add NotoSansArabicUI-Regular.ttf Add RenderText:getGlyphByIndex() to get a glyph bitmap by glyph index, which is what we'll get from Harfbuzz shaping. (RenderText:getGlyph() works with unicode charcode).
2019-11-15 14:14:36 +00:00
"xtext",
build: add luacheck for static analysis
2015-04-27 00:43:32 +00:00
}
build: enforce luacheck in travis build
2016-02-10 07:01:52 +00:00
exclude_files = {
"frontend/luxl.lua",
Simple News (RSS/Atom) downloader plugin (#2592) * Simple News (RSS/Atom) downloader plugin * Limit news from sources * new News Downloader menu entry - goto news dir * Initial configuration logic * Download each feed source to separate folder * 2 feed sources in example config
2017-04-19 15:59:45 +00:00
"plugins/newsdownloader.koplugin/lib/handler.lua",
NewsDownloader: add date time to filename (#3863) * Download all files from ftp server(Not only epub). Show failed download number * add date and time to filename * optimalization - decrese max redirect number * remove new external lib from luacheck * add new lib licence info
2018-04-12 14:05:50 +00:00
"plugins/newsdownloader.koplugin/lib/LICENSE_LuaXML",
Simple News (RSS/Atom) downloader plugin (#2592) * Simple News (RSS/Atom) downloader plugin * Limit news from sources * new News Downloader menu entry - goto news dir * Initial configuration logic * Download each feed source to separate folder * 2 feed sources in example config
2017-04-19 15:59:45 +00:00
"plugins/newsdownloader.koplugin/lib/xml.lua",
NewsDownloader: add date time to filename (#3863) * Download all files from ftp server(Not only epub). Show failed download number * add date and time to filename * optimalization - decrese max redirect number * remove new external lib from luacheck * add new lib licence info
2018-04-12 14:05:50 +00:00
"plugins/newsdownloader.koplugin/lib/LICENCE_lua-feedparser",
"plugins/newsdownloader.koplugin/lib/dateparser.lua",
build: enforce luacheck in travis build
2016-02-10 07:01:52 +00:00
}
ci(fix): ignore 631 warnings from luacheck
2017-03-05 07:30:26 +00:00
Travis: run luacheck on unit tests (#3059) * Travis: run luacheck on unit tests
2017-08-08 20:35:40 +00:00
-- don't balk on busted stuff in spec
files["spec/unit/*"].std = "+busted"
files["spec/unit/*"].globals = {
luacheckrc: allow busted's "match" global for spec/ (#8369) This was fixed in luacheck 0.24.0 but our CI still uses an older version at the moment. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
2021-10-24 13:31:22 +00:00
"match", -- can be removed once luacheck 0.24.0 or higher is used
Travis: run luacheck on unit tests (#3059) * Travis: run luacheck on unit tests
2017-08-08 20:35:40 +00:00
"package",
"requireBackgroundRunner",
"stopBackgroundRunner",
Tame BackgroundRunner: stop running when no more job (#6605) A BackgroundRunner plugin instance will stop running (rescheduling a check every 2 seconds) when there is no (or no more) job to run. Clients of this service now have to emit an event after adding a job into PluginShare.backgroundJobs, so an already loaded but stopped BackgroundRunner can notice it and start running again.
2020-08-31 14:48:29 +00:00
"notifyBackgroundJobsUpdated",
Travis: run luacheck on unit tests (#3059) * Travis: run luacheck on unit tests
2017-08-08 20:35:40 +00:00
}
ci(fix): ignore 631 warnings from luacheck
2017-03-05 07:30:26 +00:00
-- TODO: clean up and enforce max line width (631)
Replace remaining 'local gettext' with '_' (#4160)
2018-08-15 19:56:35 +00:00
-- https://luacheck.readthedocs.io/en/stable/warnings.html
-- 211 - Unused local variable
-- 631 - Line is too long
ignore = {
"211/__*",
[statistics] Remove conversion message on new installations (#5120)
2019-07-17 13:15:21 +00:00
"231/__",
Replace remaining 'local gettext' with '_' (#4160)
2018-08-15 19:56:35 +00:00
"631",
[feat] Add dictionary download option (#3176) You can now download pretty much all of the easily available freely licensed dictionaries I could find.
2018-12-13 06:27:49 +00:00
"dummy",
Replace remaining 'local gettext' with '_' (#4160)
2018-08-15 19:56:35 +00:00
}
Reference in New Issue Copy Permalink