Handle channels with empty home pages

2024-11-09 01:10:27 +00:00 · 2021-06-26 18:50:02 -07:00 · 2021-06-26 18:50:02 -07:00 · efd53285cf
commit efd53285cf
parent 7662d925e4
30 changed files with 64 additions and 28 deletions
--- a/locales/ar.json
+++ b/locales/ar.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/de.json
+++ b/locales/de.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/el.json
+++ b/locales/el.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/en-US.json
+++ b/locales/en-US.json
@ -449,5 +449,6 @@
    "Licenses": "Licences",
    "Privacy": "Privacy",
    "short": "Short (< 4 minutes)",
-    "long": "Long (> 20 minutes)"
+    "long": "Long (> 20 minutes)",
+    "This channel doesn't have any content.": "This channel doesn't have any content."
 }
--- a/locales/eo.json
+++ b/locales/eo.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/es.json
+++ b/locales/es.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/fa.json
+++ b/locales/fa.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/fi.json
+++ b/locales/fi.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/fr.json
+++ b/locales/fr.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/he.json
+++ b/locales/he.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/hr.json
+++ b/locales/hr.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/id.json
+++ b/locales/id.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/is.json
+++ b/locales/is.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/it.json
+++ b/locales/it.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/ja.json
+++ b/locales/ja.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/nb-NO.json
+++ b/locales/nb-NO.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/nl.json
+++ b/locales/nl.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/pl.json
+++ b/locales/pl.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/pt-BR.json
+++ b/locales/pt-BR.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/pt-PT.json
+++ b/locales/pt-PT.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/ro.json
+++ b/locales/ro.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/ru.json
+++ b/locales/ru.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/sv-SE.json
+++ b/locales/sv-SE.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/tr.json
+++ b/locales/tr.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/uk.json
+++ b/locales/uk.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/zh-CN.json
+++ b/locales/zh-CN.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/locales/zh-TW.json
+++ b/locales/zh-TW.json
@ -449,5 +449,6 @@
    "Licenses": "",
    "Privacy": "",
    "short": "",
-    "long": ""
+    "long": "",
+    "This channel doesn't have any content.": ""
 }
--- a/src/invidious/helpers/extractors.cr
+++ b/src/invidious/helpers/extractors.cr
@ -311,6 +311,9 @@ private class YoutubeTabsExtractor < ItemsContainerExtractor
      elsif items_container = renderer_container_contents["channelVideoPlayerRenderer"]?
        # Parsing for channel trailer is already taken elsewhere
        next
+      elsif items_container = renderer_container_contents["messageRenderer"]?
+        # Likely an error message regarding content being empty
+        next
      else
        items_container = renderer_container_contents
      end
--- a/src/invidious/routes/channels.cr
+++ b/src/invidious/routes/channels.cr
@ -16,7 +16,7 @@ class Invidious::Routes::Channels < Invidious::Routes::BaseRoute
    items = fetch_channel_home(ucid, channel)

    has_trailer = false
-    if items[0].is_a? Video
+    if !items.empty? && items[0].is_a? Video
      has_trailer = true
    end

--- a/src/invidious/views/channel/home.ecr
+++ b/src/invidious/views/channel/home.ecr
@ -57,4 +57,10 @@
            </div>
        <% end %>
    <% end %>
+
+    <% if items.size == 0 %>
+        <h3 class="pure-u-1 h-box">
+            <%= translate(locale, "This channel doesn't have any content.")%>
+        </h3>
+    <% end %>
 </div>