From bcc8ba73bf8d6f4d2ee9083927f6991ce3f15bd3 Mon Sep 17 00:00:00 2001
From: Omar Roth <omarroth@hotmail.com>
Date: Tue, 9 Oct 2018 17:24:29 -0500
Subject: [PATCH] Fix update_feeds job

---
 config/config.yml                |  2 +-
 src/invidious.cr                 | 17 +++++++++-----
 src/invidious/helpers/helpers.cr |  2 +-
 src/invidious/jobs.cr            | 39 +++++++++++++++++++++++++++-----
 4 files changed, 46 insertions(+), 14 deletions(-)

diff --git a/config/config.yml b/config/config.yml
index 309be236..768fe699 100644
--- a/config/config.yml
+++ b/config/config.yml
@@ -1,5 +1,6 @@
 crawl_threads: 1
 channel_threads: 1
+feed_threads: 1
 video_threads: 1
 db:
   user: kemal
@@ -10,4 +11,3 @@ db:
 full_refresh: false
 https_only: false
 geo_bypass: true
-update_feeds: true
diff --git a/src/invidious.cr b/src/invidious.cr
index 4ba4f960..5f7cec7a 100644
--- a/src/invidious.cr
+++ b/src/invidious.cr
@@ -31,6 +31,7 @@ HMAC_KEY = CONFIG.hmac_key || Random::Secure.random_bytes(32)
 
 crawl_threads = CONFIG.crawl_threads
 channel_threads = CONFIG.channel_threads
+feed_threads = CONFIG.feed_threads
 video_threads = CONFIG.video_threads
 
 Kemal.config.extra_options do |parser|
@@ -51,6 +52,14 @@ Kemal.config.extra_options do |parser|
       exit
     end
   end
+  parser.on("-f THREADS", "--feed-threads=THREADS", "Number of threads for refreshing feeds (default: #{feed_threads})") do |number|
+    begin
+      feed_threads = number.to_i
+    rescue ex
+      puts "THREADS must be integer"
+      exit
+    end
+  end
   parser.on("-v THREADS", "--video-threads=THREADS", "Number of threads for refreshing videos (default: #{video_threads})") do |number|
     begin
       video_threads = number.to_i
@@ -85,6 +94,8 @@ end
 
 refresh_channels(PG_DB, channel_threads, CONFIG.full_refresh)
 
+refresh_feeds(PG_DB, feed_threads)
+
 video_threads.times do |i|
   spawn do
     refresh_videos(PG_DB)
@@ -98,12 +109,6 @@ spawn do
   end
 end
 
-if CONFIG.update_feeds
-  spawn do
-    update_feeds(PG_DB)
-  end
-end
-
 decrypt_function = [] of {name: String, value: Int32}
 spawn do
   update_decrypt_function do |function|
diff --git a/src/invidious/helpers/helpers.cr b/src/invidious/helpers/helpers.cr
index 46e1e931..20bf47ef 100644
--- a/src/invidious/helpers/helpers.cr
+++ b/src/invidious/helpers/helpers.cr
@@ -2,6 +2,7 @@ class Config
   YAML.mapping({
     crawl_threads:   Int32,
     channel_threads: Int32,
+    feed_threads:    Int32,
     video_threads:   Int32,
     db:              NamedTuple(
       user: String,
@@ -15,7 +16,6 @@ class Config
     hmac_key:     String?,
     full_refresh: Bool,
     geo_bypass:   Bool,
-    update_feeds: Bool,
   })
 end
 
diff --git a/src/invidious/jobs.cr b/src/invidious/jobs.cr
index 14ddf679..6f5481c9 100644
--- a/src/invidious/jobs.cr
+++ b/src/invidious/jobs.cr
@@ -104,15 +104,42 @@ def refresh_videos(db)
   end
 end
 
-def update_feeds(db)
-  loop do
-    users = db.query_all("SELECT email FROM users", as: String)
+def refresh_feeds(db, max_threads = 1)
+  max_channel = Channel(Int32).new
 
-    users.each do |email|
-      view_name = "subscriptions_#{sha256(email)[0..7]}"
-      db.exec("REFRESH MATERIALIZED VIEW #{view_name}")
+  spawn do
+    max_threads = max_channel.receive
+    active_threads = 0
+    active_channel = Channel(Bool).new
+
+    loop do
+      db.query("SELECT email FROM users") do |rs|
+        rs.each do
+          email = rs.read(String)
+          view_name = "subscriptions_#{sha256(email)[0..7]}"
+
+          if active_threads >= max_threads
+            if active_channel.receive
+              active_threads -= 1
+            end
+          end
+
+          active_threads += 1
+          spawn do
+            begin
+              db.exec("REFRESH MATERIALIZED VIEW #{view_name}")
+            rescue ex
+              STDOUT << "REFRESH " << email << " : " << ex.message << "\n"
+            end
+
+            active_channel.send(true)
+          end
+        end
+      end
     end
   end
+
+  max_channel.send(max_threads)
 end
 
 def pull_top_videos(config, db)