From 5918ecf9a06f266f06027c804af3cf49a7eb48f2 Mon Sep 17 00:00:00 2001
From: sezanzeb <proxima@hip70890b.de>
Date: Mon, 16 Nov 2020 16:27:18 +0100
Subject: [PATCH] chmod proper permissions

---
 data/key-mapper.glade |  6 ------
 keymapper/X.py        | 12 ++++++++----
 2 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/data/key-mapper.glade b/data/key-mapper.glade
index b1b19b65..399b2a97 100644
--- a/data/key-mapper.glade
+++ b/data/key-mapper.glade
@@ -290,9 +290,6 @@
                   <object class="GtkComboBoxText" id="device_selection">
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
-                    <items>
-                      <item translatable="yes"> </item>
-                    </items>
                     <signal name="changed" handler="on_select_device" swapped="no"/>
                   </object>
                   <packing>
@@ -428,9 +425,6 @@
                         <property name="width_request">200</property>
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
-                        <items>
-                          <item translatable="yes"> </item>
-                        </items>
                         <signal name="changed" handler="on_select_preset" swapped="no"/>
                       </object>
                       <packing>
diff --git a/keymapper/X.py b/keymapper/X.py
index cfd50f52..15b0da94 100644
--- a/keymapper/X.py
+++ b/keymapper/X.py
@@ -34,7 +34,7 @@ Resources:
 
 import os
 import re
-import shutil
+import stat
 import subprocess
 
 from keymapper.paths import get_usr_path, KEYCODES_PATH, \
@@ -67,13 +67,17 @@ def create_preset(device, name=None):
         os.makedirs(os.path.dirname(path), exist_ok=True)
         os.mknod(path)
 
-    # give those files to the user
-    # TODO or should they stay root
+    # add the same permissions as other symbol files, only root may write.
+    os.chmod(path, stat.S_IREAD | stat.S_IWRITE | stat.S_IRGRP | stat.S_IROTH)
+
+    """# give this file and the directories to the user
+    # For now keep them with root to avoid doing too much unconventional
+    # stuff.
     user = os.getlogin()
     for root, dirs, files in os.walk(USERS_SYMBOLS):
         shutil.chown(root, user, user)
         for file in files:
-            shutil.chown(os.path.join(root, file), user, user)
+            shutil.chown(os.path.join(root, file), user, user)"""
 
     return name