MarcLeclair 4c45f615bb [fenix] 16900 make navgraph inflation asynchronous (https://github.com/mozilla-mobile/fenix/pull/18889) ... * For https://github.com/mozilla-mobile/fenix/issues/16900: implement async navgraph inflation For https://github.com/mozilla-mobile/fenix/issues/16900: removed nav graph from xml For https://github.com/mozilla-mobile/fenix/issues/16900: inflate navGraph programatically For https://github.com/mozilla-mobile/fenix/issues/16900: Made NavGraph inflation asynchronous For https://github.com/mozilla-mobile/fenix/issues/16900: Changed to block with runBlocking For https://github.com/mozilla-mobile/fenix/issues/16900: Refactored blocking call into a function For 16900: NavGraph inflation is now async We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController). This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key. If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph to the navcontroller (and the inflation of the latter too) For 16900: rebased upstream master For 16900: Rebase on master For https://github.com/mozilla-mobile/fenix/issues/16900: Fixed Async Navgraph navigation per review comments. 1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher 2)The Job is tracked through a WeakHashMap from Controller --> NavGraph 3)The Coroutine scope doesn't use MainScope() anymore 4)The Coroutine is cancelled if the Activity is destroyed 5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup() For https://github.com/mozilla-mobile/fenix/issues/16900: inflateNavGraphAsync now takes navController For https://github.com/mozilla-mobile/fenix/issues/16900: Pass lifecycleScope to NavGraphProvider For https://github.com/mozilla-mobile/fenix/issues/16900: removed unused mock For https://github.com/mozilla-mobile/fenix/issues/16900: Added linter rules for navigate calls We need linting rules to make sure no one calls the NavController.navigate() methods For https://github.com/mozilla-mobile/fenix/issues/16900: Added TestRule to help abstract the mocks in the code For 16900: Fix linting problems For https://github.com/mozilla-mobile/fenix/issues/16900: Cleaned duplicated code in tests For https://github.com/mozilla-mobile/fenix/issues/16900: cleaned up NavGraphTestRule for finished test For https://github.com/mozilla-mobile/fenix/issues/16900: had to revert an accidentally edited file For https://github.com/mozilla-mobile/fenix/issues/16900: rebased master * For https://github.com/mozilla-mobile/fenix/issues/16900: Review nits for async navgraph This is composed of squash commits, the original messages can be found below: -> DisableNavGraphProviderAssertionRule + kdoc. Use test rule in RobolectricApplication. Fix failing CrashReporterControllerTest Fix blame by -> navigate in tests. This commit was generated by the following commands only: ``` find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \; find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \; git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker ``` Fix various blame This is expected to be squashed into the first commit so, if so, it'd fix the blame. Move test rule to helpers pkg. add missing license header Add import change I missed fix unused imports Replace robolectricTestrunner with test rule. Improve navGraphProvider docs Remove unnecessary rule as defined by robolectric. add clarifying comment to robolectric remove unnecessary space * For https://github.com/mozilla-mobile/fenix/issues/16900: nit fixes for MozillaNavigateCheck and lint fixes 3 squash commits: *Changed violation message and fixed the lint rule for MozillaNavigateCheck *Added suppression to NavController.kt *Fixed detekt violations * For 16900: Fixed failing tests Co-authored-by: Michael Comella <michael.l.comella@gmail.com>		2021-04-13 20:48:45 -04:00
..
main	[fenix] 16900 make navgraph inflation asynchronous (https://github.com/mozilla-mobile/fenix/pull/18889)	2021-04-13 20:48:45 -04:00
test/java/org/mozilla/fenix/detektrules/perf	[fenix] No issue: move relevant :mozilla-detekt-rules to perf/ pkg.	2020-11-13 16:07:59 -08:00