You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
 
 
Go to file
Gabriel Luong 98a540b81d [fenix] For https://github.com/mozilla-mobile/fenix/issues/23350 - Revert changes from removing duplicate icons that already exists in ui-icons (https://github.com/mozilla-mobile/fenix/pull/23527)
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Override @color/mozac_ui_icons_fill with ?primaryText attribute"

This reverts commit 4c630eba96182254daa4cdd2bbfeac23ab04690d.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_share with @drawable/mozac_ic_share"

This reverts commit 072d3a3c9f87b77ed6381c36af7d9c812b8b371d.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_storage_enabled with @drawable/mozac_ic_storage"

This reverts commit 10dde2baa6fd320443690a49dd6551938a2d83db.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_notifications_enabled with @drawable/mozac_ic_notification"

This reverts commit 90943cfda427fd06d5e77b1e4fd0463bbe21e449.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_microphone_enabled with @drawable/mozac_ic_microphone"

This reverts commit 200fd14d288b4b21c1711995f63d548f58fb1dc8.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_location_enabled with @drawable/mozac_ic_location"

This reverts commit e85998bdc24dcdd17585581bd99aab35d5147f93.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_autoplay_disabled with @drawable/mozac_ic_autoplay_blocked"

This reverts commit 0e408dc26e069719c895ae5279d3c11df6677699.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_camera_enabled with @drawable/mozac_ic_video"

This reverts commit ceab2d77490b9b9b545ebbc14ee2a7b3811d3064.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/mozac_ic_extensions_black with @drawable/mozac_ic_extensions"

This reverts commit 7bc005927acee0481c8936d000737ba7f738e2ba.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_top_sites with @drawable/mozac_ic_pin"

This reverts commit f4d58ff722baa5dc9f7f811a758de75699bb8ccb.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_search with @drawable/mozac_ic_search"

This reverts commit ac8f8632557ac07c32d040fbb0ddfa3cf1a0e5f6.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_readermode with @drawable/mozac_ic_reader_mode"

This reverts commit d1953045b062a5b6fbedd990252834e9e1a6ca4f.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_menu with @drawable/mozac_ic_menu"

This reverts commit 682b02101aa7e5ce82868de81d9b034701629976.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_login with @drawable/mozac_ic_login"

This reverts commit 982c695260aaa10fc1f0ee7e6d2e271e9a214ce3.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_internet with @drawable/mozac_ic_globe"

This reverts commit d248bfc21fff644bdc2141c4e24ae5bc125a41d2.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_download with @drawable/mozac_ic_download"

This reverts commit 4cdceb393ac411a7b59d9c0e1164fddfb62bc494.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_lock with @drawable/mozac_ic_lock"

This reverts commit 3878a83e30f318293b099bc49c690f953c2f3def.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_desktop with @drawable/mozac_ic_device_desktop"

This reverts commit 8c4e6e23e0bf1ed762d9c3ab8566aff4df0a8eb1.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_close with @drawable/mozac_ic_close"

This reverts commit 7f61c95923600eeabb8046380a31c1eaa4968525.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_delete with @drawable/mozac_ic_delete"

This reverts commit b8814f62bffde0c192f078f8cd5e808d0f07af9d.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_chevron_up with @drawable/mozac_ic_arrowhead_up"

This reverts commit 265b0a47cae6bed39ce9e8cc9af465705d1a2363.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_chevron_down with @drawable/mozac_ic_arrowhead_down"

This reverts commit fe8a0b604941bbbb9dacff176cd17ce0485431ed.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_back_button with @drawable/mozac_ic_back"

This reverts commit fb236b1c6175c1f8b5e6b1bf6d9f02c6a7fff9b9.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_arrowhead_right with @drawable/mozac_ic_arrowhead_right"

This reverts commit ae2f768ac02aa6b161b0bcbba7922f5f12e31e80.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_new with @drawable/mozac_ic_new"

This reverts commit ce5bb35a7cdbd189bb177900ec19bc6cb5a9bfa7.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_addons_extensions with @drawable/mozac_ic_extensions"

This reverts commit 1006637673965ebf70ad5e18e9a3598cf736347b.
3 years ago
.github [fenix] update which bot is used (https://github.com/mozilla-mobile/fenix/pull/22923) 3 years ago
app [fenix] For https://github.com/mozilla-mobile/fenix/issues/23350 - Revert changes from removing duplicate icons that already exists in ui-icons (https://github.com/mozilla-mobile/fenix/pull/23527) 3 years ago
automation [fenix] No issue: Update references and doc in parse-ui-test.py (https://github.com/mozilla-mobile/fenix/pull/23354) 3 years ago
buildSrc [fenix] Update Android Components version to 98.0.20220201143153. (https://github.com/mozilla-mobile/fenix/pull/23524) 3 years ago
certificates
config [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Remove the `kotlin-android-extensions` plugin 3 years ago
docs [fenix] add reviewer comments 3 years ago
fastlane
gradle/wrapper [fenix] Update to Gradle 7 and Android plugin 7. 3 years ago
mozilla-detekt-rules [fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unused imports 3 years ago
mozilla-lint-rules [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Remove the Kotlin synthetics Lint detector 3 years ago
taskcluster [fenix] closes https://github.com/mozilla-mobile/fenix/issues/23504: download focus wallpapers at runtime (https://github.com/mozilla-mobile/fenix/pull/23505) 3 years ago
tools [fenix] Close https://github.com/mozilla-mobile/fenix/issues/22956: Define "tags" for metrics in the app repository 3 years ago
.adjust_token
.cron.yml [fenix] Ship nightlies to Google Play twice a day 3 years ago
.editorconfig
.experimenter.json [fenix] First use of Nimbus FML plugin (https://github.com/mozilla-mobile/fenix/pull/23400) 3 years ago
.gitattributes
.gitignore [fenix] closes https://github.com/mozilla-mobile/fenix/issues/23504: download focus wallpapers at runtime (https://github.com/mozilla-mobile/fenix/pull/23505) 3 years ago
.mergify.yml [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22198: Mergify: Replace deprecated "strict mode" merge action 3 years ago
.taskcluster.yml [fenix] Remove remnants of github-release support 3 years ago
CODE_OF_CONDUCT.md
Gemfile
Jenkinsfile [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/11427 - Rename master branch to main (https://github.com/mozilla-mobile/fenix/pull/20457) 3 years ago
LICENSE
README.md [fenix] No issue: updating README.md 3 years ago
bors.toml [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9295 - Add back non-blocking bors to trigger CI on contributor PRs (https://github.com/mozilla-mobile/fenix/pull/9843) (https://github.com/mozilla-mobile/fenix/pull/14967) 4 years ago
build.gradle [fenix] First use of Nimbus FML plugin (https://github.com/mozilla-mobile/fenix/pull/23400) 3 years ago
codecov.yml
gradle.properties [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16855: disable jetifier. 3 years ago
gradlew
gradlew.bat
l10n-release.toml [fenix] Add Bulgarian (bg), Central Kurdish (ckb), Interlingua (ia), Tatar (tt) locales to Fenix (https://github.com/mozilla-mobile/fenix/pull/19711) 3 years ago
l10n-uplift.py [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/11427 - Rename master branch to main (https://github.com/mozilla-mobile/fenix/pull/20457) 3 years ago
l10n.toml [fenix] Import l10n. 3 years ago
nimbus.fml.yaml [fenix] First use of Nimbus FML plugin (https://github.com/mozilla-mobile/fenix/pull/23400) 3 years ago
settings.gradle [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/11427 - Rename master branch to main (https://github.com/mozilla-mobile/fenix/pull/20457) 3 years ago
version.txt [fenix] Update version.txt to 98.0.0-beta.1 3 years ago

README.md

Firefox for Android

Task Status codecov

Fenix (internal codename) is the all-new Firefox for Android browser, based on GeckoView and Mozilla Android Components.

Get it on Google Play

Getting Involved

Please read the Community Participation Guidelines and the Bugzilla Etiquette guidelines before filing an issue. This is our professional working environment as much as it is our bug tracker, and we want to keep our workspace clean and healthy.

Beginners! - Watch out for Issues with the "Good First Issue" label. These are easy bugs that have been left for first timers to have a go, get involved and make a positive contribution to the project!

I want to open a Pull Request!

We encourage you to participate in this open source project. We love Pull Requests, Bug Reports, ideas, (security) code reviews or any other kind of positive contribution.

Since we are a small team, however, we do not have the bandwidth to review unsolicited PRs. Please follow our Pull Request guidelines, or we may close the PR.

To make it easier to review, we have these PR requirements:

  • Every PR must have exactly one issue associated with it.
  • Write a clear explanation of what the code is doing when opening the pull request, and optionally add comments to the PR.
  • Make sure there are tests - or ask for help on how the code should be tested in the Issue!
  • Keep PRs small and to the point. For extra code-health changes, either file a separate issue, or make it a separate PR that can be easily reviewed.
  • Use micro-commits. This makes it easier and faster to review.
  • Add a screenshot for UX changes (this is part of the PR checklist)

As a small team, we have to prioritize our work, and reviewing PRs takes time. We receive lots of PRs every day, so if you can keep your PRs small, it helps our small team review and merge code faster, minimizing stale code.

Keep in mind that the team is very overloaded, so PRs sometimes wait for a very long time. However this is not for lack of interest, but because we find ourselves in a constant need to prioritize certain issues/PRs over others. If you think your issue/PR is very important, try to popularize it by getting other users to comment and share their point of view.

I want to file an issue!

Great! We encourage you to participate in this open source project. We love Pull Requests, Bug Reports, ideas, (security) code reviews or any other kind of positive contribution.

To make it easier to triage, we have these issue requirements:

  • Please do your best to search for duplicate issues before filing a new issue so we can keep our issue board clean.
  • Every issue should have exactly one bug/feature request described in it. Please do not file meta feedback list tickets as it is difficult to parse them and address their individual points.
  • Feature Requests are better when theyre open-ended instead of demanding a specific solution -ie “I want an easier way to do X” instead of “add Y”
  • Issues are not the place to go off topic or debate. If you have questions, please join the #fenix:mozilla.org channel.
  • Please always remember our Community Participation Guidelines
  • Please do not tag specific team members to try to get your issue looked at faster. We have a triage process that will tag and label issues correctly in due time. If you think an issue is very severe, you can ask about it in Matrix.

Please keep in mind that even though a feature you have in mind may seem like a small ask, as a small team, we have to prioritize our planned work and every new feature adds complexity and maintenance and may take up design, research, marketing, product, and engineering time. We appreciate everyones passion but we will not be able to incorporate every feature request or even fix every bug. That being said, just because we haven't replied, doesn't mean we don't care about the issue, please be patient with our response times as we're very busy.

Build Instructions

Pre-requisites:

  • Android SDK
  • To run command line tools, you'll need to configure Java: see our how-to guide.
  1. Clone or Download the repository:
git clone https://github.com/mozilla-mobile/fenix
  1. Import the project into Android Studio or build on the command line:
./gradlew clean app:assembleDebug

If this errors out, make sure that you have an ANDROID_SDK_ROOT environment variable pointing to the right path.

  1. Make sure to select the correct build variant in Android Studio. See the next section.

  2. Make sure to select "Default APK" under Installation Options inside Run/Debug configuration: see this bug.

Build Variants

For general development, we recommend the debug build variant. Here's an explanation of each variant:

  • debug: the default for developers, similar to most other Android apps. It is debuggable, uses a Nightly GeckoView with debug symbols, adds tools like LeakCanary for troublingshooting, and does not strip unused code.
  • nightly: what we ship to the Firefox Nightly channel, using GeckoView Nightly.
  • beta: what we ship to the Firefox Beta channel, using GeckoView Beta. It is more stable than nightly.
  • release: what we ship as Firefox for Android, using GeckoView Release. It is the most stable.

nightly, beta, and release are unsigned and debuggable=false by default. If you want these variants to be:

Performance Build Variants

For accurate performance measurements, read this section!

To analyze performance during local development build a production variant locally (this could either be the Nightly, beta or release). Otherwise, you could also grab a pre-existing APK if you don't need to test some local changes. Then, use the Firefox profiler to profile what you need!

For more information on how to use the profiler or how to use the build, refer to this how to measure performance with the build

If you want to run performance tests/benchmarks in automation or locally use a production build since it is much closer in behavior compared to what users see in the wild.

Before you can install any release builds, You will need to sign production build variants: see Automatically signing release builds for details.

Known disabled-by-default features

Some features are disabled by default when Fenix is built locally. This can be problematic at times for checking performance since you might want to know how your code behaves with those features. The known features that are disabled by default are:

  • Sentry
  • Adjust
  • Mozilla Location Services (also known as MLS)
  • Firebase Push Services
  • Telemetry (only disabled by default in debug builds)
  • Nimbus

Pre-push hooks

To reduce review turn-around time, we'd like all pushes to run tests locally. We'd recommend you use our provided pre-push hook in config/pre-push-recommended.sh. Using this hook will guarantee your hook gets updated as the repository changes. This hook tries to run as much as possible without taking too much time.

Before you can run the hook, you'll need to configure Java properly because it relies on command line tools: see our how-to guide.

To add it on Mac/Linux, run this command from the project root:

ln -s ../../config/pre-push-recommended.sh .git/hooks/pre-push

or for Windows run this command using the Command Prompt with administrative privileges:

mklink .git\hooks\pre-push ..\..\config\pre-push-recommended.sh

or using PowerShell:

New-Item -ItemType SymbolicLink -Path .git\hooks\pre-push -Value (Resolve-Path config\pre-push-recommended.sh)

To push without running the pre-push hook (e.g. doc updates):

git push <remote> --no-verify

Note: If while pushing you encounter this error "Could not initialize class org.codehaus.groovy.runtime.InvokerHelper" and are currently on Java14 then downgrading your Java version to Java13 or lower can resolve the issue

Steps to downgrade Java Version on Mac with Brew:

  1. Install Homebrew (https://brew.sh/)
  2. run brew update
  3. To uninstall your current java version, run sudo rm -fr /Library/Java/JavaVirtualMachines/<jdk-version>
  4. run brew tap homebrew/cask-versions
  5. run brew search java
  6. If you see java11, then run brew install java11
  7. Verify java-version by running java -version

local.properties helpers

You can speed up local development by setting a few helper flags available in local.properties. Some flags will make it easy to work across multiple layers of the dependency stack - specifically, with android-components, geckoview or application-services.

Automatically sign release builds

To sign your release builds with your debug key automatically, add the following to <proj-root>/local.properties:

autosignReleaseWithDebugKey

With this line, release build variants will automatically be signed with your debug key (like debug builds), allowing them to be built and installed directly through Android Studio or the command line.

This is helpful when you're building release variants frequently, for example to test feature flags and or do performance analyses.

Building debuggable release variants

Nightly, Beta and Release variants are getting published to Google Play and therefore are not debuggable. To locally create debuggable builds of those variants, add the following to <proj-root>/local.properties:

debuggable

Setting raptor manifest flag

To set the raptor manifest flag in Nightly, Beta and Release variants, add the following to <proj-root>/local.properties:

raptorEnabled

Auto-publication workflow for android-components and application-services

If you're making changes to these projects and want to test them in Fenix, auto-publication workflow is the fastest, most reliable way to do that.

In local.properties, specify a relative path to your local android-components and/or application-services checkouts. E.g.:

  • autoPublish.android-components.dir=../android-components
  • autoPublish.application-services.dir=../application-services

Once these flags are set, your Fenix builds will include any local modifications present in these projects.

See a demo of auto-publication workflow in action.

In order to build successfully, you need to check out a commit in the dependency repository that has no breaking changes. The two best ways to do this are:

  • Run the <android-components>/tools/list_compatible_dependency_versions.py script to output a compatible commit
  • Check out the latest commit from main in this repository and the dependency repository. However, this may fail if there were breaking changes added recently to the dependency.

Using Nimbus servers during local development

If you're working with the Nimbus experiments platform, by default for local development Fenix configures Nimbus to not use a server.

If you wish to use a Nimbus server during local development, you can add a https:// or file:// endpoint to the local.properties file.

  • nimbus.remote-settings.url

Testing experimental branches should be possible without a server.

GeckoView

Specify a relative path to your local mozilla-central checkout via dependencySubstitutions.geckoviewTopsrcdir, and optional a path to m-c object directory via dependencySubstitutions.geckoviewTopobjdir.

If these are configured, local builds of GeckoView will be used instead of what's configured in Dependencies.kt. For more details, see https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/geckoview-quick-start.html#include-geckoview-as-a-dependency

See notes on building successfully in the android-components auto-publication section.

License

This Source Code Form is subject to the terms of the Mozilla Public
License, v. 2.0. If a copy of the MPL was not distributed with this
file, You can obtain one at http://mozilla.org/MPL/2.0/