You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
233f0a8a1d
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask the storage to remove metadata (on its IO thread), then navigate to Home Screen. This resulted in a race we could end-up on the Home Screen before delete finishes, so the search groups do not appear to be removed (but, refreshing the Home Screen again shows that they are removed). This also resulted in an unnecessary navigation which felt very janky (screen will "scroll" to the top) and was way more work than necessary. After this patch, we: - dispatch two actions (on browserstore, on homefragmentstore) which remove the search groups from any relevant in-memory state; any UI bound to this state will be automatically "refreshed" - no longer navigate as part of the remove action, so the UI doesn't move and removal happens "in-place" |
3 years ago | |
|---|---|---|
| .. | ||
| intent | 3 years ago | |
| mozonline | 3 years ago | |
| recentbookmarks | 3 years ago | |
| recenttabs | 3 years ago | |
| sessioncontrol | 3 years ago | |
| tips | 3 years ago | |
| topsites | 3 years ago | |
| HomeFragment.kt | 3 years ago | |
| HomeFragmentStore.kt | 3 years ago | |
| HomeMenu.kt | 3 years ago | |
| HomeScreenViewModel.kt | 3 years ago | |
| ImageViewTopCrop.kt | 5 years ago | |
| Mode.kt | 4 years ago | |
| PocketUpdatesMiddleware.kt | 3 years ago | |
| PrivateBrowsingButtonView.kt | 4 years ago | |
| SharedViewModel.kt | 4 years ago | |