You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
iceraven-browser/app/src/test/java/org/mozilla/fenix/tabstray
Michael Comella cc380695b8 No issue: remove unnecessary robolectric annotations.
Theoretically, this should marginally decrease the duration of our unit
test suite. In my testing, for 1 iteration each (i.e. noise is very
possible), the duration changed from 9m 32s to 8m 21s – a 71s
improvement.

---

To identify tests that were running with robolectric that didn't need to
be, I removed the @RunWith(FenixRobo... from all relevant files:
    sed -i '' "/@RunWith(FenixRobolectric/d" app/src/test/**/*.kt

I ran the tests and discovered which ones failed from the Classes tab of
the index.html test result file. Something like:
    tests = document.querySelectorAll('table')[3].querySelectorAll('tr');
    failureElements = tests.querySelectorAll('.failures');
    // TODO: extract the test names

Then I copied these results to a text file and compared them to all the
files that had robolectric test runners to figure out which ones still
pass:
    comm -1 -2 failures.txt changed_files.txt > robolectric_not_needed.txt

And undid the changes to the failing files:
    for i in $(cat robolectric_not_needed.txt); do git checkout $i; done

Then I removed the import statements on those files:
    for i in $(cut changed_files.txt); do sed -i '' "/import.*RunWith/d" $i; done
    for i in $(cat changed_files.txt); do sed -i '' "/import.*RobolectricTestRunner/d" $i; done
3 years ago
..
browser Issue #20663: Make inactive card collapsible 3 years ago
ext Issue #20664: Do not consider newly created tabs as inactive 3 years ago
syncedtabs Issue #19175: Fix SyncTabs list not updating on changes 3 years ago
viewholders Issue #20349: Add inactive tab grouping to tabs tray 3 years ago
CloseOnLastTabBindingTest.kt For #20367 - Fixes removeAllTabs adding to recently closed 3 years ago
DefaultTabsTrayControllerTest.kt No issue: remove unnecessary robolectric annotations. 3 years ago
DefaultTabsTrayInteractorTest.kt For #19475 - Introduce a DefaultTabsTrayInteractor 3 years ago
FloatingActionButtonBindingTest.kt For #19938: Remove a11y workaround for tab tray new tab button. 3 years ago
MenuIntegrationTest.kt Closes #19003: Add account setting to tabstray synced tab menu (#19034) 3 years ago
NavigationInteractorTest.kt Run ktlintFormat to adapt to latest formatting rules. 3 years ago
SecureTabsTrayBindingTest.kt For #20250 - Adds FLAG_SECURE to TabsTray dialog 3 years ago
TabCounterBindingTest.kt No issue: Observe only normal tabs when updating counter 3 years ago
TabLayoutMediatorTest.kt No issue: remove unnecessary robolectric annotations. 3 years ago
TabLayoutObserverTest.kt For #19475 - Cleanup - respect naming scheme in TabsTrayController 3 years ago
TabSheetBehaviorManagerTest.kt For #19135 - Set different offsets for expanded trays 3 years ago
TabsTrayDialogTest.kt Close #18774: Migrate mutli-selection to store 3 years ago
TabsTrayFragmentTest.kt Run ktlintFormat to adapt to latest formatting rules. 3 years ago
TabsTrayInfoBannerBindingTest.kt No issue: fix glean metrics tests for expired metrics (#20621) 3 years ago
TabsTrayStoreTest.kt Closes #18946: Add undo toast for tabstray 3 years ago