Commit Graph

9 Commits (fec7662d8e8f10b40fd122ce1a1c7843b655aadb)

Author SHA1 Message Date
Michael Comella 0934b7fe93 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - review: add clarifying comments. 4 years ago
Michael Comella 19904397b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add MozillaStrictModeSuppression detekt check. 4 years ago
Michael Comella 7a4230df00 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: improve custom detekt violation output.
Before it used to output the violations all one one line. Now it looks
like:
```
MozillaStrictModeSuppression:
    'import mozilla.components.support.ktx.android.os.resetAfter' at
(17,1) in /StrictModeManager.kt
    Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.

MozillaStrictModeSuppression:
    'setThreadPolicy(threadPolicy.build())' at (56,24) in
/StrictModeManager.kt
    Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.

MozillaStrictModeSuppression:
    'setVmPolicy(builder.build())' at (71,24) in /StrictModeManager.kt
    NOT YET IMPLEMENTED: please consult the perf team about
implementing`StrictModeManager.resetAfter`: we want to understand the
performance implications of suppressing setVmPolicy before allowing it.
```
4 years ago
Michael Comella e1ffe1108f [fenix] No issue: replace LintUnitTestRunner with detekt implementation.
This should be more performant and easier to maintain.
4 years ago
Tiger Oakes 5de89421d7 [fenix] Suppress YamlConfig deprecation 4 years ago
Michael Comella aba1c4cb5a [fenix] No issue: remove assertJ.
It was only used for 3 checks so it's not worth having a dependency on
it.
4 years ago
Emily Kager 522aca44f4 [fenix] Upgrade to detekt 1.6.0 (https://github.com/mozilla-mobile/fenix/pull/9306)
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes https://github.com/mozilla-mobile/fenix/issues/7360.  Also use more exact test glob.

Co-authored-by: Andrew Gaul <andrew@gaul.org>
4 years ago
Sawyer Blatz 17e74ecd6b [fenix] For https://github.com/mozilla-mobile/fenix/issues/7698: Adds search back button animation (https://github.com/mozilla-mobile/fenix/pull/7840)
* For https://github.com/mozilla-mobile/fenix/issues/7698: Adds search back button animation

* Refactor for searchController
5 years ago
Will Hawkins 78e86d8f2b [fenix] No Issue: Add custom detekt rule to blacklist certain properties
Add a custom detekt rule to blacklist certain properties. This is
immediately useful for making sure that developers do not configure
runtime behavior using the `BuildConfig.DEBUG` property but it is
useful in a wider context.
5 years ago