Commit Graph

3553 Commits (fba1e732efd5f3b4f6a4590ca797066073e110a7)
 

Author SHA1 Message Date
Mozilla L10n Automation Bot 9baa18640c [fenix] Import l10n. 4 years ago
mcarare 290141865c [fenix] For https://github.com/mozilla-mobile/fenix/issues/9798: Disable buttons on hiding and enable on showing.
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
4 years ago
Simon Chae fdd629b61f [fenix] Update not yet unavailable add-on string (https://github.com/mozilla-mobile/fenix/pull/9677) 4 years ago
Roger Yang cc81201934 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/9827: Support display cutouts 4 years ago
Christian Sadilek 07b1f84ec6 [fenix] No issue: Re-use existing usecases for addons 4 years ago
ekager b57314cc8e [fenix] For https://github.com/mozilla-mobile/fenix/issues/2818 - Adds Picture-in-Picture feature 4 years ago
MickeyMoz 2981adfb4b [fenix] Update Android Components version to 39.0.20200409130114. 4 years ago
Johan Lorenzo 20d8491b59 [fenix] Bug 1568466 - part 3: Enable shipit graph (https://github.com/mozilla-mobile/fenix/pull/7314) 4 years ago
Mozilla L10n Automation Bot a1cf9f7780 [fenix] Import l10n. 4 years ago
Michael Comella b9fe826cef [fenix] No issue: Move Do and OpenClass to utils pkg.
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
4 years ago
ekager 9ca3ce6589 [fenix] No issue: Update androidx appcompat to 1.2.0-beta01 4 years ago
Johan Lorenzo 4e98ca4bcc [fenix] Bug 1628413 - Disable Nightlies until Google Play catches up (https://github.com/mozilla-mobile/fenix/pull/9810) 4 years ago
MickeyMoz ee7ef93b0c [fenix] Update Android Components version to 39.0.20200408130125. 4 years ago
mcarare c579e388d3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9797: Set min height of dialog edit text to 48dp. 4 years ago
Abhay Agarwal bcd9f52607 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9495: Dismiss the ShareFragment in onPause() 4 years ago
Sawyer Blatz 7001260885 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9682: Reduces size of branding (https://github.com/mozilla-mobile/fenix/pull/9784) 4 years ago
Christian Sadilek 7df242c354 [fenix] No issue: Refactor readerview to use browser-state 4 years ago
Christian Sadilek 6c022d5376 [fenix] Upgrade to Android Components 38.0.20200407190120 4 years ago
Sawyer Blatz 42a823fe24 [fenix] No issue: Add more settings animations (https://github.com/mozilla-mobile/fenix/pull/9750) 4 years ago
MickeyMoz 6935516ce7 [fenix] Update Android Components version to 38.0.20200407130106. 4 years ago
Mihai Eduard Badea 68a5b44663 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2768 - Prevent screenshots in private mode
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
4 years ago
Mugurell 8fd1b5ef87 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9770 - Disable pull to refresh pending changes 4 years ago
Richard Pappalardo 52e3beffb6 [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/9461 - Re-trigger taskcluster jobs on dep download fail (https://github.com/mozilla-mobile/fenix/pull/9606) 4 years ago
Mozilla L10n Automation Bot 8f65dd9856 [fenix] Import l10n. 4 years ago
Michael Comella 18a639a64d [fenix] For https://github.com/mozilla-mobile/fenix/issues/9631: remove assertk dependency. 4 years ago
Michael Comella f2dbaf24d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9631: replace assertk assertions with junit.
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
4 years ago
Jeff Boek 4371996382 [fenix] For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker (https://github.com/mozilla-mobile/fenix/pull/9191)
* For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker

* For https://github.com/mozilla-mobile/fenix/issues/220 - Updates Android Components
4 years ago
Aaron Train 789ee895a6 [fenix] No issue: Set all Flank templates to one AVD (https://github.com/mozilla-mobile/fenix/pull/9745) 4 years ago
Mihai Adrian 8f1876407b [fenix] For https://github.com/mozilla-mobile/fenix/issues/9687: Refactor onboarding cards to follow app architecture (https://github.com/mozilla-mobile/fenix/pull/9743)
* For https://github.com/mozilla-mobile/fenix/issues/9687: Refactor onboarding cards to follow app architecture

* For https://github.com/mozilla-mobile/fenix/issues/9687: Update unit test to new controller parameters
4 years ago
Arturo Mejia 174af614f4 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9647 Crash when tapping settings after quickly
enabling/disabling add-on
4 years ago
Michael Droettboom 461853e252 [fenix] Fix errors in top_sites_count metric
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.

[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
4 years ago
MickeyMoz f534fdb690 [fenix] Update Android Components version to 38.0.20200406130135. 4 years ago
Mozilla L10n Automation Bot ff708e4ff1 [fenix] Import l10n. 4 years ago
MickeyMoz 6b642c9c92 [fenix] Update Android Components version to 38.0.20200405130126. 4 years ago
mcarare 3647494de3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9663: Allow more than one line for onboarding card header 5 years ago
Mozilla L10n Automation Bot 50bb5be4db [fenix] Import l10n. 5 years ago
Aaron Train 4d216e26ea [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9688: Disable ReaderViewTest for intermittent investigation in detection issues 5 years ago
Oana Horvath 47366000e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9670: Disabled intermittent tabMediaControlButton test (https://github.com/mozilla-mobile/fenix/pull/9679)
and removed file created by mistake -e

added reason for disabled tests
5 years ago
Mugurell dca4c74a30 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3262 - Enable pull down to refresh in Nightly 5 years ago
Aaron Train ff77588851 [fenix] No issue: Restore num-flaky-test-attempts in flank-x86.yml (https://github.com/mozilla-mobile/fenix/pull/9675) 5 years ago
Michael Comella 09253e7566 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 - review: clarify comments in new test runner. 5 years ago
Michael Comella ebaa5bcbd4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 - review: lintUnitTestRunner depends on compile.
See added comments for explanation.
5 years ago
Michael Comella 74fbc518db [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: Add LintUnitTestRunner gradle task.
This will prevent us from regressing on adding older versions of the
unit test runner.
5 years ago
Michael Comella 5d2c577c64 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: TestApplication -> FenixRobolectricTestApplication.
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
5 years ago
Michael Comella dff3a69dc3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: move TestApplication to the helpers package.
The helpers/ package is created to separate the test support code from
the code under test.
5 years ago
Michael Comella f11bb37121 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: replace unit test runners with FenixRobolectricTestRunner.
This is how we can apply the new test runner to remove duplication.

This commit was generated programmatically with the following commands:
```
  // Replace test runners with new one.
  find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
  find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +

  // Replace imports of old test runners with new one
  find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
  find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +

  // Remove unused imports
  find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```

Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
5 years ago
Michael Comella b401d400b3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: add FenixRobolectricTestRunner.
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.

This class is adapted from Firefox for Fire TV:
  https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
5 years ago
Michael Comella 774a07d5f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: remove unnecessary @RunWith(Robolectric in unit tests.
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.

Between this change and the last one, the unit test runtime was reduced
by ~10s.
5 years ago
Michael Comella b9ffb3ddcc [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: remove unnecessary @RunWith(AndroidJUnit4) in unit tests.
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
5 years ago
Aaron Train 3489fe1e22 [fenix] No issue: re-enable libraryMenuItemsTest and backButtonTest (https://github.com/mozilla-mobile/fenix/pull/9639) 5 years ago