2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-09 19:10:42 +00:00
Commit Graph

1538 Commits

Author SHA1 Message Date
Emily Kager
fb1d655d96 Closes #4822 - Update Bookmark State in onResume (#4823) 2019-08-19 16:22:20 -07:00
Mihai Adrian
bf42abb21c fixes #4179 removed control highlight from disconnect button (#4806)
set colorControlHighlight to transparent in activity theme.
property cannot be set in view because it is overwritten by activity theme.
2019-08-19 16:16:06 -07:00
Sawyer Blatz
0d4eceed56 For #2706: Refactor Glean to reduce errors (#4753)
* For #2706: Adds recording for untracked events

* For #2706: Adds key alignment to Metrics
2019-08-19 15:25:48 -07:00
Sawyer Blatz
4731977f5d
For #4421: Fixes issues with new glean events (#4816) 2019-08-19 14:49:48 -07:00
Sawyer Blatz
73e3db8fe0 For #4804: Resolves issue with crash reporter stack 2019-08-19 16:40:41 -04:00
Aaron Train
ae05bf98e2
Closes #4618 - Stub Library UI tests (#4619)
See #4572
2019-08-19 14:05:10 -04:00
Arturo Mejia
210868f5bc Use Mozilla Android Components 9.0.0-SNAPSHOT. (#4750) 2019-08-19 10:29:10 -07:00
Suraj Shah
806961094b Fixes #4704 (#4728)
* Fixes #4704. Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.

* Updates CHANGELOG.md

* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
2019-08-19 09:23:12 -07:00
Mugurell
645674c9bd Closes #4396 - Add a Bookmarks Controller (#4593)
* For #4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For #4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For #4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Tiger Oakes
de14962e3f Extract quick action sheet observer code (#4368) 2019-08-19 08:28:33 -07:00
Emily Kager
7d02354f4f For #4799 #4790 - Don't use passed in sessions in BrowserToolbarController (#4800) 2019-08-18 20:36:40 -05:00
Colin Lee
d1aed157dd
For #4686: Fix potential security issue (#4764) 2019-08-16 16:50:54 -05:00
Yeon Taek Jeong
727457f0ed No issue: fixes click failures on search widget icon 2019-08-16 13:58:29 -07:00
Emily Kager
c9598bc4d1 For #4688 - Try to use context instead of targetContext (#4765) 2019-08-16 10:12:56 -07:00
Yeon Taek Jeong
d4c83f9668 For #4736: Display search shortcuts only from home or search widget 2019-08-15 12:24:54 -04:00
Emily Kager
d07d74e8d3 For #4688 - Try slightly different Context class for MockWebServer (#4747) 2019-08-15 08:05:23 -07:00
Emily Kager
3f820366a6 Closes #4680 - Align collection creation text center vertical 2019-08-14 20:17:01 -04:00
Yeon Taek Jeong
a680d733c8 For #4384: Hide mic icon if speech-to-text is unavailable (#4701) 2019-08-14 16:40:21 -07:00
Yeon Taek Jeong
2441592ef2 For #4516: Use full width for large search widgets (#4659) 2019-08-14 16:00:13 -07:00
Emily Kager
f71106cb51 Closes #3860 - Update description text for collections 2019-08-14 17:13:52 -04:00
Sawyer Blatz
b7ca520787 For #4421: Adds Leanplum events and attributes (#4626)
* For #4421: Adds Leanplum events and attributes

* For #4421: Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
Yeon Taek Jeong
67f3b63ae5
For #4421: Add search widget attribute to Leanplum (#4694) 2019-08-14 12:00:29 -07:00
Yeon Taek Jeong
f5ffe3734c
For #4457: Adds telemetry for search widget actions (#4714) 2019-08-14 11:39:54 -07:00
Yeon Taek Jeong
2f265eccbd
For #4732: Fix search engine display issue (#4735) 2019-08-14 11:03:14 -07:00
Mihai Adrian
1a4ef1535c For #4434 - made close button for collections more accessible. (#4443)
* fixes #4434 - made close button for collections more accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for #4193 - close button for tabs

* fixes #4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button

set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
2019-08-14 10:12:39 -07:00
Michael Cooper
12371ca9c1 Add no-op experiment to test service-experiments integration (#4551)
* Add no-op experiment to test service-experiments integration

* Shorten metric name to meet schema

* Add active_experiment metric to docs

* Add approved data review
2019-08-14 12:07:41 -05:00
Tiger Oakes
3acabeb6c3 Use global navigation action for browser fragment (#4691) 2019-08-14 11:58:29 -05:00
isabelrios
7729cb63a7 Fix UI Screenshot TabMenuTest (#4730) 2019-08-14 11:57:36 -05:00
Colin Lee
5b4a441bcb For #1667: Screen reader can't reach other UI items when QAB expanded (#4695) 2019-08-14 09:56:29 -07:00
Emily Kager
1328d686aa No issue - Autoformatting (#4715) 2019-08-14 09:40:46 -05:00
Sebastian Kaspari
b733fcdbd5 Closes #4719: Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. (#4722) 2019-08-14 09:10:24 -05:00
Colin Lee
e6f9445d11
For #4709: Fix Bugzilla issue 1573549 (#4710) 2019-08-13 22:16:23 -05:00
Sourabh
42e3b2771e fix #4633: show toast only on first login (#4676)
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
2019-08-13 16:28:34 -05:00
(´⌣`ʃƪ)
5aac05859d Fix #4436: hide onboarding before navigating to settings (#4675)
* Fix #4436: hide onboarding before navigating to settings

* No issue: Rename emitAccountChanges to emitModeChanges
2019-08-13 15:49:42 -05:00
Sebastian Kaspari
d03c15d15c Issue #4431: Integrate feature-media component (Nightly and debug builds only). (#4683) 2019-08-13 15:02:20 -05:00
Colin Lee
0c8bcd39be For #4652: HomeFragment Crash "Can not.. after onSaveInstanceState" 2019-08-12 15:51:49 -04:00
Jorge De Los Santos
337ad1e88e For #3424 - Make talkback ignore ImageButton in Collection Sele… (#3792)
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
2019-08-12 11:49:25 -04:00
Grisha Kruglov
b38b94ed79 Closes #4671: Fix a potential NPE in BookmarkFragment 2019-08-12 11:16:28 -04:00
Grisha Kruglov
634ee184a6 No issue: add some BookmarkFragmentInteractor tests 2019-08-09 17:27:58 -07:00
Grisha Kruglov
f323105163 No issue: reduce code duplication in BookmarkFragmentInteractor 2019-08-09 17:27:58 -07:00
Christian Sadilek
5fe05e919a For #4125: Suppress coroutine warning to fix release build 2019-08-09 17:30:27 -04:00
Sawyer Blatz
0ec92d716f
For #4123: Adds telemetry for quick action open in app (#4629) 2019-08-09 13:51:12 -07:00
Yeon Taek Jeong
b24793d863 ktlint fix 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
aac73a8fe2 Finish adding tests 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
6c9ce784b1 Fix, add some tests 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
2a6069bfb7 Fix rest of issues 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
69434a765f Fix most issues 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
faf0ecbcc0 For #4125: Migrate Sign in to Sync to Libstate 2019-08-09 13:39:51 -07:00
Axel Hecht
65de521ccf Import strings from android-l10n (#4643)
State: mozilla-l10n/android-l10n@ab580f757c
2019-08-09 14:55:05 -05:00
Colin Lee
7f07eabbd8
For #4652: Crash "Can not perform this action after onSaveInstanceState" (#4654) 2019-08-09 14:46:40 -05:00