Codrut Topliceanu
b2d81076f9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7978 - Put views above button in scrollView ( https://github.com/mozilla-mobile/fenix/pull/8819 )
2020-04-02 10:13:32 -07:00
Gabriel Luong
e754578cef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6174 - Add telemetry for WebExtensions ( https://github.com/mozilla-mobile/fenix/pull/8318 )
2020-04-02 10:12:31 -07:00
Mihai Adrian
2f02eeb972
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9604 : Swap and adjust margin with padding to avoid text being cut ( https://github.com/mozilla-mobile/fenix/pull/9617 )
2020-04-02 09:40:29 -07:00
Gregory Mierzwinski
1e231c8e57
[fenix] Bug 1625971 - Add google-search-restaurants to pageload tests in browsertime. ( https://github.com/mozilla-mobile/fenix/pull/9622 )
...
* Add google-search-restaurants to pageload tests in browsertime.
* Temporarily change the activity to pass tests.
* Change Raptor Fenix activity name.
* Remove test trigger for browsertime test.
2020-04-02 18:29:23 +02:00
MickeyMoz
235efb8a55
[fenix] Update Android Components version to 38.0.20200402130113.
2020-04-02 11:44:11 -04:00
Michael Comella
aba1c4cb5a
[fenix] No issue: remove assertJ.
...
It was only used for 3 checks so it's not worth having a dependency on
it.
2020-04-02 07:57:19 -07:00
Michael Comella
006e32c454
[fenix] No issue: remove unused FirefoxTestRunner.
...
It would be used for on device tests but it doesn't seem to hooked up
currently.
2020-04-02 07:57:09 -07:00
MickeyMoz
e6357ddec5
[fenix] Update Android Components version to 38.0.20200401130040.
2020-04-02 13:43:34 +03:00
Mozilla L10n Automation Bot
f7f452367d
[fenix] Import l10n.
2020-04-02 13:42:58 +03:00
mcarare
7e54f731db
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9422 : Nit: Fix xml indenting
2020-04-02 09:11:31 +03:00
mcarare
34394af021
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9422 : Align widget text to viewStart to support RTL layouts
2020-04-02 09:11:31 +03:00
Emily Kager
2ec2ee395b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/768 : Add first time PWA dialog ( https://github.com/mozilla-mobile/fenix/pull/9308 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
2020-04-01 22:56:12 -04:00
Sebastian Kaspari
548a18ba32
[fenix] Use same configuration for "forPerformanceTest" builds like we do for "fennec" flavor builds.
2020-04-01 17:51:32 -07:00
Aaron Train
b6f578da39
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9433 : Update Flank version in ui-tests Dockerfile ( https://github.com/mozilla-mobile/fenix/pull/9466 )
...
fix: flank_snapshot requires direct shard value
-1 shards -> 50 shards
fix: adjust flank-x86.yml shard value
try old results generator in flank-x86.yml
fix: legacy-junit-report -> legacy-junit-result
revert to modern reporting
2020-04-01 15:43:45 -07:00
David Walsh
a96fa3b790
[fenix] Prevent favicons from flashing when items are selected in History ( https://github.com/mozilla-mobile/fenix/pull/9233 )
2020-04-01 15:43:21 -07:00
Emily Kager
522aca44f4
[fenix] Upgrade to detekt 1.6.0 ( https://github.com/mozilla-mobile/fenix/pull/9306 )
...
Changelog:
https://arturbosch.github.io/detekt/changelog.html
Fixes https://github.com/mozilla-mobile/fenix/issues/7360 . Also use more exact test glob.
Co-authored-by: Andrew Gaul <andrew@gaul.org>
2020-04-01 15:42:46 -07:00
Mihai Adrian
66d28a700c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating ( https://github.com/mozilla-mobile/fenix/pull/9353 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating
* For https://github.com/mozilla-mobile/fenix/issues/9336 Update unit test to check for navigateSafe
2020-04-01 15:36:56 -07:00
Mihai Adrian
d6fe360148
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9423 : Align preference title and summary to viewStart ( https://github.com/mozilla-mobile/fenix/pull/9426 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9423 : Align preference title and summary to viewStart
* Update checkbox_left_preference_etp.xml
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2020-04-01 15:36:01 -07:00
ekager
8224f61cb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9533 - Switch to using enum for Library Item Selected Telemetry
2020-04-01 15:29:08 -07:00
Grisha Kruglov
4b91238222
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9553 : Only update account UI state once when creating SettingsFragment
2020-04-01 15:28:39 -07:00
ekager
ea9add8d2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8125 - Send top sites count with metrics ping
2020-04-01 15:27:39 -07:00
mcarare
ef2d26efee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9365 : Partially reverse menu items order when using top toolbar
2020-04-01 15:21:22 -07:00
mcarare
011b4f7fbd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9365 : Update naming to reflect history item
2020-04-01 15:21:22 -07:00
Kate Glazko
67bf4073ad
[fenix] NoIssueFixMetropolisAccountPref
2020-04-01 15:13:03 -07:00
Sawyer Blatz
eb99ae1fef
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9598 & https://github.com/mozilla-mobile/fenix/issues/8697 : Fixes force expand crash ( https://github.com/mozilla-mobile/fenix/pull/9599 )
2020-04-01 12:32:00 -07:00
codrut.topliceanu
7b333febc0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9549 - Scrolling to top sites now includes header.
2020-04-01 10:28:04 -07:00
mcarare
c0b09436d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9574 : Remove category layout from LeakCanary SwitchPreference
2020-04-01 10:17:21 -07:00
ekager
d1d0a09f21
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9564 : Fixes cut off strings in ETP panel
2020-04-01 10:16:51 -07:00
Johan Lorenzo
41a4de7b8e
[fenix] Bug 1622339 - Move android-sdk installation into a toolchain task ( https://github.com/mozilla-mobile/fenix/pull/9394 )
2020-04-01 18:29:35 +02:00
Mihai Branescu
d80763ee11
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9109 - remove the sync error highlight from three-dot menu
2020-04-01 10:42:00 +03:00
Kate Glazko
1ccd93d99a
[fenix] For 3687 Use Metropolis Font for Header
2020-03-31 19:31:15 -07:00
Mozilla L10n Automation Bot
9cb58154bb
[fenix] Import l10n.
2020-03-31 17:52:51 -07:00
Grisha Kruglov
12e3619a2e
[fenix] Make sure reconnect item is displayed in HomeMenu in case of account problems
...
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
2020-03-31 16:07:35 -07:00
Grisha Kruglov
8d1befd34c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9561 : Fix initialization order in HomeMenu
...
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.
Simply re-ordering initialization fixes the problem.
2020-03-31 16:07:35 -07:00
Arturo Mejia
12237fdca1
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8520 : Polish Add-on manager UIs
2020-03-31 17:20:20 -04:00
Sawyer Blatz
72e91ad94a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9472 : ForceExpand browser toolbar when navigating ( https://github.com/mozilla-mobile/fenix/pull/9552 )
2020-03-31 11:16:40 -07:00
Oana Horvath
8dbcd4ed35
[fenix] Updated the method to verify system notifications and added new tests for media notifications ( https://github.com/mozilla-mobile/fenix/pull/9330 )
2020-03-31 21:11:41 +03:00
ValentinTimisica
7d57c791f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8412 : Passes error handling function to 'CustomTabWindowFeature' ( https://github.com/mozilla-mobile/fenix/pull/8903 )
...
* For https://github.com/mozilla-mobile/fenix/issues/8412 : Passes error handling function to 'CustomTabWindowFeature'
Change required for showing error message when the app can't handle a specific
scheme. Implemented in AC:
https://github.com/mozilla-mobile/android-components/pull/6122
* Upgrade AC version
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2020-03-31 10:17:29 -07:00
Grisha Kruglov
3d7f7cbe5d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9530 : Don't crash on failed avatar fetches
2020-03-31 09:17:17 -07:00
Mozilla L10n Automation Bot
59910e8d82
[fenix] Import l10n.
2020-03-30 22:00:19 -07:00
Grisha Kruglov
423d7cfdda
[fenix] Part 6: Kick-off account manager initialization after visual completeness
...
In order to hide the time it takes for the account manager to be initialized
(which always involves disk IO, and often network IO), let's kick it off
after "visual completeness".
This makes sure that for most users, by the time they interact with the account
manager-related functionality (e.g. in Settings), it's ready to go.
Also, for signed-in users, this will establish background sync workers.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
1a25bc758e
[fenix] Part 5: Refactor HomeMenu<->HomeFragment interaction
...
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.
Once that's in place, we start observing account manager changes (once its ready)
for account problems.
This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
2020-03-30 21:43:38 -07:00
Grisha Kruglov
13deec03a1
[fenix] Part 4: Make sure 'sync is on' snackbar does not initialize account manager
2020-03-30 21:43:38 -07:00
Grisha Kruglov
71564af97d
[fenix] Part 3: Mark accountManager as 'lazy' in Mode.kt
...
This is enough to cause it to be initialized only if we're going through onboarding.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
1a6e1c0b7f
[fenix] Part 2: Do not eagerly initilize account manager within HomeActivity
...
Instead of always kicking off accountManager's init and telling it to sync right away in
'onResume', we move these tasks to some abstract point later on, whenever account manager
is available.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
4e308faf35
[fenix] Part 1: Add 'accountManagerReady' queue to BackgroundServices
...
This gives us an ability to perform tasks against 'accountManager' without
causing its immediate initialization.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
ccb08070a7
[fenix] Pre: introduce a RunWhenReadyQueue
...
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.
This ability to either execute or queue a task will be useful later on in the
commit series.
2020-03-30 21:43:38 -07:00
Aaron Train
e8cfeeb0a1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9189 : Fixes "static asset not found" error in doNotSaveLoginFromPromptTest, saveLoginFromPromptTest UI tests ( https://github.com/mozilla-mobile/fenix/pull/9439 )
...
AndroidAssetDispatcher class dispatcher was attempting to open a local asset with a query suffix from the request. If query suffix is found, remove it. Re-enable saveLoginFromPromptTest() and doNotSaveLoginFromPromptTest()
2020-03-30 18:01:58 -04:00
David Walsh
207fa5752a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9525 - Add bottom margin to top sites header
2020-03-30 14:48:45 -07:00
Sawyer Blatz
e488ed1773
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9132 : Update to search animation for top toolbar ( https://github.com/mozilla-mobile/fenix/pull/9524 )
...
* let animation in top toolbar mode play nicely.
* remove duplicate methods, make code readable.
* migrate getToolbarNavOptions method to BrowserAnimator, one method to rule them all.
* Update linting
Co-authored-by: ahmedmamdouh13 <ahmedmamdouh13196@gmail.com>
2020-03-30 12:07:00 -07:00