Arturo Mejia
fa157d252b
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8520 : Improve add-ons UI
2020-04-13 19:01:58 -04:00
ekager
101d815231
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9890 - Do not display full screen snackbar with toolbar padding
2020-04-13 14:56:51 -07:00
ekager
cf3f14b795
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9703 - Exit full screen on pause if pip not entered
2020-04-13 14:31:57 -07:00
Sawyer Blatz
92ea1cc5b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9892 : Set dynamicToolbarMaxHeigtht to 0 for PWAs ( https://github.com/mozilla-mobile/fenix/pull/9893 )
2020-04-13 13:08:08 -07:00
ekager
27adb232c7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9692 - Fix "Install" PWA menu item labeling
2020-04-13 10:09:37 -07:00
ekager
089e2db827
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7208 For https://github.com/mozilla-mobile/fenix/issues/7212 - Update parameterized strings
2020-04-13 09:40:47 -07:00
mcarare
fca63c72d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9698 : Use extension to ensure fallback to English and avoid crash
2020-04-13 09:40:00 +03:00
mcarare
79e3a1c328
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9698 : Add Context extension to avoid format IllegalArgumentException
2020-04-13 09:40:00 +03:00
mcarare
290141865c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9798 : Disable buttons on hiding and enable on showing.
...
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
2020-04-09 16:06:11 -07:00
Simon Chae
fdd629b61f
[fenix] Update not yet unavailable add-on string ( https://github.com/mozilla-mobile/fenix/pull/9677 )
2020-04-09 15:25:08 -04:00
Roger Yang
cc81201934
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/9827 : Support display cutouts
2020-04-09 10:13:37 -07:00
Christian Sadilek
07b1f84ec6
[fenix] No issue: Re-use existing usecases for addons
2020-04-09 12:53:47 -04:00
ekager
b57314cc8e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2818 - Adds Picture-in-Picture feature
2020-04-09 08:56:48 -07:00
Michael Comella
b9fe826cef
[fenix] No issue: Move Do and OpenClass to utils pkg.
...
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
2020-04-08 12:39:22 -07:00
mcarare
c579e388d3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9797 : Set min height of dialog edit text to 48dp.
2020-04-08 10:12:20 -04:00
Abhay Agarwal
bcd9f52607
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9495 : Dismiss the ShareFragment in onPause()
2020-04-08 13:10:37 +03:00
Christian Sadilek
7df242c354
[fenix] No issue: Refactor readerview to use browser-state
2020-04-07 16:31:03 -04:00
Sawyer Blatz
42a823fe24
[fenix] No issue: Add more settings animations ( https://github.com/mozilla-mobile/fenix/pull/9750 )
2020-04-07 10:44:23 -07:00
Mihai Eduard Badea
68a5b44663
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2768 - Prevent screenshots in private mode
...
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.
This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.
The setting is by default set to true (screenshots are allowed to be taken)
2020-04-07 17:23:06 +03:00
Mugurell
8fd1b5ef87
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9770 - Disable pull to refresh pending changes
2020-04-07 17:06:43 +03:00
Jeff Boek
4371996382
[fenix] For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker ( https://github.com/mozilla-mobile/fenix/pull/9191 )
...
* For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker
* For https://github.com/mozilla-mobile/fenix/issues/220 - Updates Android Components
2020-04-06 14:29:52 -07:00
Mihai Adrian
8f1876407b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9687 : Refactor onboarding cards to follow app architecture ( https://github.com/mozilla-mobile/fenix/pull/9743 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9687 : Refactor onboarding cards to follow app architecture
* For https://github.com/mozilla-mobile/fenix/issues/9687 : Update unit test to new controller parameters
2020-04-06 11:00:47 -07:00
Arturo Mejia
174af614f4
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9647 Crash when tapping settings after quickly
...
enabling/disabling add-on
2020-04-06 13:47:21 -04:00
Michael Droettboom
461853e252
[fenix] Fix errors in top_sites_count metric
...
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.
[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
2020-04-06 10:34:52 -07:00
Mugurell
dca4c74a30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3262 - Enable pull down to refresh in Nightly
2020-04-03 19:40:08 +03:00
MickeyMoz
0487e0ad62
[fenix] Update Android Components version to 38.0.20200403130109.
2020-04-03 16:15:31 +02:00
Michael Comella
cb29b33e21
[fenix] No issue: add kdoc to HomeActivity.
...
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
2020-04-02 16:27:00 -07:00
Sawyer Blatz
9e5e780a9a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9128 & https://github.com/mozilla-mobile/fenix/issues/9222 & https://github.com/mozilla-mobile/fenix/issues/9499 : Refactors snackbar creation and fixes placement ( https://github.com/mozilla-mobile/fenix/pull/9628 )
2020-04-02 12:30:13 -07:00
Gabriel Luong
e754578cef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6174 - Add telemetry for WebExtensions ( https://github.com/mozilla-mobile/fenix/pull/8318 )
2020-04-02 10:12:31 -07:00
Emily Kager
2ec2ee395b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/768 : Add first time PWA dialog ( https://github.com/mozilla-mobile/fenix/pull/9308 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
2020-04-01 22:56:12 -04:00
David Walsh
a96fa3b790
[fenix] Prevent favicons from flashing when items are selected in History ( https://github.com/mozilla-mobile/fenix/pull/9233 )
2020-04-01 15:43:21 -07:00
Mihai Adrian
66d28a700c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating ( https://github.com/mozilla-mobile/fenix/pull/9353 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating
* For https://github.com/mozilla-mobile/fenix/issues/9336 Update unit test to check for navigateSafe
2020-04-01 15:36:56 -07:00
ekager
8224f61cb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9533 - Switch to using enum for Library Item Selected Telemetry
2020-04-01 15:29:08 -07:00
Grisha Kruglov
4b91238222
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9553 : Only update account UI state once when creating SettingsFragment
2020-04-01 15:28:39 -07:00
ekager
ea9add8d2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8125 - Send top sites count with metrics ping
2020-04-01 15:27:39 -07:00
mcarare
ef2d26efee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9365 : Partially reverse menu items order when using top toolbar
2020-04-01 15:21:22 -07:00
mcarare
011b4f7fbd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9365 : Update naming to reflect history item
2020-04-01 15:21:22 -07:00
Sawyer Blatz
eb99ae1fef
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9598 & https://github.com/mozilla-mobile/fenix/issues/8697 : Fixes force expand crash ( https://github.com/mozilla-mobile/fenix/pull/9599 )
2020-04-01 12:32:00 -07:00
codrut.topliceanu
7b333febc0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9549 - Scrolling to top sites now includes header.
2020-04-01 10:28:04 -07:00
Mihai Branescu
d80763ee11
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9109 - remove the sync error highlight from three-dot menu
2020-04-01 10:42:00 +03:00
Grisha Kruglov
12e3619a2e
[fenix] Make sure reconnect item is displayed in HomeMenu in case of account problems
...
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
2020-03-31 16:07:35 -07:00
Grisha Kruglov
8d1befd34c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9561 : Fix initialization order in HomeMenu
...
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.
Simply re-ordering initialization fixes the problem.
2020-03-31 16:07:35 -07:00
Arturo Mejia
12237fdca1
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8520 : Polish Add-on manager UIs
2020-03-31 17:20:20 -04:00
Sawyer Blatz
72e91ad94a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9472 : ForceExpand browser toolbar when navigating ( https://github.com/mozilla-mobile/fenix/pull/9552 )
2020-03-31 11:16:40 -07:00
ValentinTimisica
7d57c791f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8412 : Passes error handling function to 'CustomTabWindowFeature' ( https://github.com/mozilla-mobile/fenix/pull/8903 )
...
* For https://github.com/mozilla-mobile/fenix/issues/8412 : Passes error handling function to 'CustomTabWindowFeature'
Change required for showing error message when the app can't handle a specific
scheme. Implemented in AC:
https://github.com/mozilla-mobile/android-components/pull/6122
* Upgrade AC version
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2020-03-31 10:17:29 -07:00
Grisha Kruglov
3d7f7cbe5d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9530 : Don't crash on failed avatar fetches
2020-03-31 09:17:17 -07:00
Grisha Kruglov
423d7cfdda
[fenix] Part 6: Kick-off account manager initialization after visual completeness
...
In order to hide the time it takes for the account manager to be initialized
(which always involves disk IO, and often network IO), let's kick it off
after "visual completeness".
This makes sure that for most users, by the time they interact with the account
manager-related functionality (e.g. in Settings), it's ready to go.
Also, for signed-in users, this will establish background sync workers.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
1a25bc758e
[fenix] Part 5: Refactor HomeMenu<->HomeFragment interaction
...
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.
Once that's in place, we start observing account manager changes (once its ready)
for account problems.
This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
2020-03-30 21:43:38 -07:00
Grisha Kruglov
13deec03a1
[fenix] Part 4: Make sure 'sync is on' snackbar does not initialize account manager
2020-03-30 21:43:38 -07:00
Grisha Kruglov
71564af97d
[fenix] Part 3: Mark accountManager as 'lazy' in Mode.kt
...
This is enough to cause it to be initialized only if we're going through onboarding.
2020-03-30 21:43:38 -07:00