Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Code Issues Releases Wiki Activity
4,934 Commits 67 Branches 116 Tags 1.2 GiB
f38acf1529
Commit Graph

4239 Commits

Author SHA1 Message Date
Shen
b52c4320f0 For #9619 hide overflow menu for all history items in selected mode 2020-08-01 22:26:43 -04:00
Mozilla L10n Automation Bot
65793f7fd7 Import l10n. 2020-08-01 21:44:35 -04:00
mozilla-l10n-automation-bot
76d49fc050
Import l10n. (#13189) 2020-07-31 17:31:52 -07:00
Michael Comella
849e5b3a09 For #12802 - review: update metrics for data review. 2020-07-31 16:05:06 -07:00
Michael Comella
5d8c900391 For #12802: add StorageStats glean metrics. 2020-07-31 16:05:06 -07:00
Tiger Oakes
70c66185d8 Renamed Metrics to Event 2020-07-31 14:14:45 -07:00
Tiger Oakes
661ffdfae2 Moved MetricsService to its own file 2020-07-31 14:14:45 -07:00
Tiger Oakes
f6b38552d2 Move MetricController to its own file 2020-07-31 14:14:45 -07:00
Kainalu Hagiwara
e1653f629e For #13127 - Make sure tabPreview is added after browserLayout. 2020-07-31 14:14:05 -07:00
ekager
f14b6d0385 For #13117 - Don't show add to collections button in private tabs tray 2020-07-31 14:13:12 -07:00
Tiger Oakes
1d28f63737
Closes #12522: Reuse exceptions code (#13047) 2020-07-31 13:24:14 -07:00
ekager
8b923fc7a4 For #13135 - Replace about top header with Firefox Daylight 2020-07-31 16:21:39 -04:00
prabhat3108
5e38ccc5e4 swapped deleted and save icon in bookmarks_edit menu. closes#11490 2020-07-31 16:19:02 -04:00
Kainalu Hagiwara
52e19ec743 For #12888 - Add highlight to current page in tab history. 2020-07-31 12:54:42 -07:00
Mihai Branescu
64072a1256 For #11498/#11499 - added/fixed unit tests 2020-07-31 21:42:57 +03:00
Mihai Branescu
ff50dae8e9 For #11498 - removed SignIn ViewHolder and unified with the Error one 2020-07-31 21:42:57 +03:00
Mihai Branescu
5d1aeb5ea7 For #11499 - replaced string for no tabs available 2020-07-31 21:42:57 +03:00
Mihai Branescu
bfc955cd40 For #11498 - add Sync tabs error view (including sign-in CTA) 2020-07-31 21:42:57 +03:00
Kadeem
78126122ad For #12769: Refactored Background Service Test into multiple test cases. 2020-07-31 10:47:11 -07:00
Mugurell
ab2ea8e682 For #13037 - Use email to sign in to fxa if device has no camera 
App can be installed on devices with no camera modules. Like Android TV boxes.
Will skip presenting the option to sign in by scanning a qr code in this case
and default to login with email and password.
 2020-07-31 20:02:23 +03:00
ekager
0f0aee5e97 For #6846 - Don't show ToolbarPopupWindow if nothing to show 2020-07-31 12:55:09 -04:00
Mihai Eduard Badea
58e24b81aa For issue #12400 - Refresh swiped collection tab view 
Item is now refreshed by calling notifyDataSetChanged on the adapter when the last tab from the collection has been swiped away and the user cancels the deletion by pressing the cancel button from the dialog.
Also added a "wasSwiped" flag to onCollectionRemoveTab in order to check if the tab was deleted from a swipe action and not by pressing the "X" button.
 2020-07-31 12:48:32 -04:00
Mozilla L10n Automation Bot
29d07e8153 Import l10n. 2020-07-31 12:37:11 +03:00
Tiger Oakes
5ddf8beea7 Fix suggestions, extract layout for tab history 2020-07-30 17:54:09 -07:00
Tiger Oakes
6152469ffd Add tests for tab history 2020-07-30 17:54:09 -07:00
Tiger Oakes
4c1e6eeb25 For #12887: Use ListAdapter to diff history 2020-07-30 17:54:09 -07:00
ekager
6cdf304d10 No issue: Adds sameAs function for TopSiteList AdapterItem 2020-07-30 17:46:03 -04:00
ekager
3d3153039c For #11690 - Add contentsSameAs to avoid rebind of items in SessionControlAdapter 2020-07-30 15:18:04 -04:00
Tiger Oakes
d8ff6179fe
For #7992: Use favicon style from AC (#12608) 2020-07-30 11:21:17 -07:00
Tiger Oakes
e265bd7266 Use uplifted addon date code 2020-07-30 10:29:40 -07:00
jhugman
79c3f3c925
For #11664 — Fixup MissingResourceExceptions being thrown in exotic Locales (#13124) 
Our kotlin code is not catching the `MissingResourceException` in the `LeanplumMetricsService` which results in the app crashing when the locale isn't known by the device.

Catches the exception, and falls back to the ISO 639 language code. This isn't a great solution, because ISO 639 isn't especially stable.

In practice however this is almost certainly never going to be a problem because Leanplum isn't going to be supported in such exotic locales.

In this case, using the ISO 639 language code allows the error message to be more informative.
 2020-07-30 18:28:26 +01:00
ekager
0356bea50e For #13117 - Hide save to collection button for private tabs in tab tray 2020-07-30 11:53:29 -04:00
mcarare
ed8a9bd1a0 For #12565: Remove activity from DefaultTabTrayController constructor. 2020-07-30 13:33:02 +03:00
Mozilla L10n Automation Bot
ef4e865105 Import l10n. 2020-07-29 21:52:03 -04:00
Tiger Oakes
1a51b7f874 For #13084 - Use runBlockingTest 2020-07-29 21:51:28 -04:00
Kate Glazko
611adf83e5 remove unused import 2020-07-29 17:47:18 -07:00
Kate Glazko
151e8595b6 For AC #7673 Move DownloadStatus to DownloadState Fenix Side Changes 2020-07-29 17:47:18 -07:00
Tiger Oakes
0e3acfcd94 Move config to robolectric.properties 2020-07-29 17:46:26 -07:00
Jeff Boek
a72f9c75f0 For #12570 - Correctly removes search suggestions when search query and url is empty 2020-07-29 16:03:10 -07:00
Jeff Boek
12b95b4902 For #11579 - Adds telemetry for autoplay settings in Site Permissions 2020-07-29 15:10:25 -07:00
Tiger Oakes
f75be41d3a Add metric tests 2020-07-29 14:58:48 -07:00
Kainalu Hagiwara
57c7955637 For #12865, #12990 - Disable swipe to switch tabs gesture when the keyboard is visible. 2020-07-29 14:55:03 -07:00
mozilla-l10n-automation-bot
d5b105097e
Import l10n. (#13088) 2020-07-29 13:51:01 -07:00
Sawyer Blatz
4b646c03cb For #9730: Add Login Dialog Prompt telemetry 2020-07-29 12:59:35 -07:00
ekager
1497e4886e For #13084 - Update SavedLoginsStorageControllerTest 2020-07-29 15:15:18 -04:00
ekager
19ffb84cf9 For #11654 - Adds leanplum ETP changed event 2020-07-29 13:35:16 -04:00
Sawyer Blatz
bb03049fb5 Add documentation 2020-07-29 13:35:16 -04:00
Sawyer Blatz
8bfc493568 For #12103: Add ChangedDefaultBrowser event for leanplum 2020-07-29 13:35:16 -04:00
Sawyer Blatz
2b1122bc77 For #11531: Add search widget installed leanplum event 2020-07-29 13:35:16 -04:00
ekager
6b6e1956ca For #13071 - Only return to home when session doesn't have parent session to select 2020-07-29 09:50:58 -07:00
Antti Vainikka
579a69b477 Closes #12692: Remove www. prefix in tab tray urls 
Use separate imports instead of a wildcard import

Use toShortUrl String extension instead of removing prefix from url host

Add missing import
 2020-07-29 12:16:32 -04:00
mcarare
048f6a49fe For #12565: Pass passwordsStorage instead of context in constructor. 2020-07-29 12:15:16 -04:00
ekager
87a7b6f9ec For #12992 - Correctly notifies concat adapters about mode changes 2020-07-29 11:58:04 -04:00
Mozilla L10n Automation Bot
2c0511c92f Import l10n. 2020-07-29 11:42:30 -04:00
ekager
6a27c209b5 For #13042 - Remove bottomSheetCallback in multiselect mode 2020-07-29 11:19:47 -04:00
Mihai Adrian Carare
ac870634ff
For #12533: Align main settings categories according to specs. (#12534) 2020-07-29 10:08:00 -05:00
mcarare
4b74ff186b For #12565: Remove context from DeleteBrowsingDataController constructor 2020-07-29 17:46:43 +03:00
mozilla-l10n-automation-bot
e2e684b4d4
Import l10n. (#13048) 2020-07-28 18:37:50 -07:00
sraturi
537d95c04d for #11830 created class containing the logic for sending AllStartup telemetry logic 
lint check

renamed the intentReceived telemetry to appOpenedAllSource

added comments

removed unused code

moved lifecycle process to AppAllSourceStartTelemetry

moved tracking event out of init function

lint fix

moved appAllStartTelemetry to components

added bit more info about the metrics

added the  onReceivedIntent metric back

minor fix

change discriptions based on the comments frm MR

wrote test cases for AppAllSourceStartTelemetry.kt

lint fix

test case to mock application going background

post rebase:

post rebase:

fixed nit from comments

fixed nit from comments

fixed nit from comments

lint fix

lint fix
 2020-07-28 17:09:42 -07:00
Sachin
6a618aa318
for #11698 added on demand workmanager initialization (#12739) 2020-07-28 16:26:18 -07:00
Kainalu Hagiwara
bef98698cb For #12904 - Conditionally inflate SwipeGestureLayout in BaseBrowserFragment. 
Changing the root view of BaseBrowserFragment from a CoordinatorLayout
to a SwipeGestureLayout has caused some regressions, particularly in
snackbar behavior. Lets prevent those regressions from occuring in
builds where the feature flag for gestures is off by only adding the
SwipeGestureLayout when the feature flag is on.
 2020-07-28 14:54:18 -07:00
Leonardo Murça
0c8c87e56d For #12755 - Replace @+id by @id when referencing already declared ids 
When referencing an Android resource ID, you do not need the
plus-symbol if you declared before.
Caution: make sure that the resource you are referring to
is defined EARLIER and not LATER.
 2020-07-28 14:46:09 -07:00
Kainalu Hagiwara
6aa70977e7 For #12861 - Swap order of tabs for tab switching gesture. 2020-07-28 14:37:45 -07:00
amkcpu
af020d0af1 For #12706 - Add vertical scrollbar to bookmarks screen 2020-07-28 16:47:18 -04:00
amkcpu
791eac50f3 For #12704 - Add vertical scrollbar to history screen 2020-07-28 16:47:09 -04:00
amkcpu
210f1ab898 For #12707 - Add vertical scrollbar to search suggestions 2020-07-28 16:46:51 -04:00
Tiger Oakes
8d1bd10e6b Test paged history provider 2020-07-28 12:35:34 -07:00
Jonathan Almeida
239e3de5e9 For #12856: Add save to collections button to Tabs Tray 
Using the ConcatAdapter, we're now able to insert multiple data sources
of information into one RecyclerView and preserve layout/scrolling in
addition to adding the 'Save to Collection' button.
 2020-07-28 11:14:08 -07:00
ekager
33bb86b1aa For #12992 - Hide tab close button while in multiselect mode 2020-07-28 11:10:45 -07:00
Hakkı Kaan Çalışkan
12e68ac18d For #12622: Visually indicate different types of suggestions in the search screen 2020-07-28 11:08:35 -07:00
Aaron Train
5b997ff1d8 Closes #13021: Fix verifyAboutFirefoxPreview UI test 2020-07-28 11:02:21 -07:00
Kainalu Hagiwara
272c380755 For #13028 - Add feature flag for tab history. 2020-07-28 11:01:59 -07:00
Roger Yang
b7fabdd2f1 Closes #12670: Add lastUri as a parameter in RequestInterceptor 2020-07-28 13:24:03 -04:00
Oana Horvath
b0dfdd57dc
For #12968: Re-enables Search settings tests (#13020) 2020-07-28 09:22:46 -04:00
Jonathan Almeida
53a4f63393 For #12983: Fix deep link scheme for nightly builds 
When we simplified our variants, our deep link scheme for nightly was
lost.
 2020-07-28 08:31:12 -04:00
Mozilla L10n Automation Bot
33db252797 Import l10n. 2020-07-27 21:05:00 -04:00
ekager
0657bf41d3 For #12991 - Set height to recommended touch target size for collect button 2020-07-27 20:17:48 -04:00
Elise Richards
b7325a3833
For #12571: Rename shortcuts to search engine on search screen (#12839) 
* Rename shortcuts to search engine on search screen

* Remove deprecated pref key

* Re-add deprecated string
 2020-07-27 17:19:31 -05:00
Tiger Oakes
5d772337a8 Fix AccountUiView ui failures 2020-07-27 17:40:15 -04:00
Elise Richards
52a9acf87d
Enable editing saved logins on all channels (#12841) 2020-07-27 15:48:28 -05:00
Jeff Boek
46f010f247 For #2681 - Adds ability to bypass cache when reloading 2020-07-27 12:11:11 -07:00
Tiger Oakes
57ac6fc36d Extract navigation subgraphs 2020-07-27 15:04:28 -04:00
Tiger Oakes
61d6b333de Update LongParameterList baseline 2020-07-27 14:20:34 -04:00
Tiger Oakes
eab9660146 For #1146: Extract AccountUiView from settings 2020-07-27 21:05:47 +03:00
Tiger Oakes
d640f58316 For #12565 - Clean up controller and add tests 2020-07-27 10:40:09 -07:00
Mugurell
596300591e For #12772 - Opt-out of scoped storage 
Targeting Android 10 means we need to support scoped storage or we need to
opt-out of that using requestLegacyExternalStorage="true".

This patch adds the opting-out leaving investigations for what changes we need
for fully supporting scoped storage to be done in issue #12822.
 2020-07-27 10:39:47 -07:00
ekager
e5e62fa79a For #6846: Added quick actions for nav bar in home 2020-07-27 13:28:28 -04:00
ekager
1d604d327c For #12966 - Fixes session removal show home logic 2020-07-27 10:27:39 -07:00
Tiger Oakes
52de2b8f38 Fix license on remaining files 2020-07-27 13:04:55 -04:00
Mihai Eduard Badea
b1e7e60665 For issue #12181 - Convert String to sentence case 
Changed the string values capitalization to sentence case.
 2020-07-27 12:31:13 -04:00
Kadeem M
1353e157cd
Created UI tests for Addon Settings (#9258) 2020-07-27 11:00:35 -04:00
ekager
9c4fba4565 Closes #12954 - Remove all ConstraintLayout casts in SearchEngineListPreference 2020-07-27 09:49:43 -04:00
Oana Horvath
808584b75f For: #12894, #12899, #12968, #11239, disables failing UI tests 2020-07-27 13:34:56 +03:00
Mihai Branescu
1cbc4eec52 For #7716 - modified xml to let 'Learn more' button have min 48dp for a11y 
Added a margin top of 20dp as well on the buttons so as not to change UI
 2020-07-27 10:16:31 +03:00
ekager
6f5faa332d For #12947 - Adjust tab selected state on bind 2020-07-25 20:07:30 -04:00
Tiger Oakes
6ea94fd9af Add concept-menu dependency 2020-07-25 19:38:35 -04:00
ekager
058f44e82d For #12721 - Remove SessionManager usages in TabCounter 2020-07-25 18:37:45 -04:00
Hakkı Kaan Çalışkan
3be6393ea5 For #12929: Change cast to LinearLayout 2020-07-25 10:14:48 -04:00
Hakkı Kaan Çalışkan
b3b7566fcf For #12804: Set min height for search engine radio button 2020-07-24 22:10:24 -04:00
ekager
46511d6f8e For #10163 - Adds tab multiselect mode 2020-07-24 18:18:26 -04:00
Jonathan Almeida
d15b8381a6 For #10925: Fix breaking APIs in tabs tray 2020-07-24 16:52:06 -04:00
Tiger Oakes
8c1d3dc827
For #12871 - Use local TWA DAL API (#12872) 2020-07-24 13:08:24 -07:00
Kainalu Hagiwara
cac0be43e6 For #12880 - Pass a CoordinatorLayout to Snackbars created by the context menu. 2020-07-24 12:30:46 -07:00
Sawyer Blatz
95d786a79f No issue: fix master 2020-07-24 15:06:38 -04:00
ekager
6edbb82591 For #12364 - Improve PWA onboarding timing logic 2020-07-24 14:43:28 -04:00
Sawyer Blatz
9c56e1905b For #12793: Improve snackbars for tabs tray 2020-07-24 10:56:54 -07:00
Sawyer Blatz
6c58098fef For #12791: Fix issue with undo snackbar last tab 2020-07-24 10:56:54 -07:00
Sawyer Blatz
c48159d76f
For #10997: Remove scrolling from home (#12866) 2020-07-24 10:43:53 -07:00
Michael Comella
923d841403 For #12345: replace Activity.reportFullyDrawnSafe with a-c impl. 2020-07-24 10:30:03 -07:00
Oana Horvath
a07f8a5041
For #12893: Disables failing deleteAllHistoryTest (#12902) 2020-07-24 11:47:59 -04:00
Oana Horvath
a116950fc8
For #12473: Disable failing verifyContextCopyLink (#12891) 2020-07-24 10:29:22 -04:00
mcarare
3883703ed5 For #10026: Update scroll flags on a11y state change. 2020-07-24 10:35:33 +03:00
mcarare
e7a5613afb For #10026: Add a11y state listener to BaseBrowserFragment. 2020-07-24 10:35:33 +03:00
mcarare
cf0126e079 For #10026: Add Context extension to get AccessibilityManager. 2020-07-24 10:35:33 +03:00
Kainalu Hagiwara
8f32b18dfa For #12868 - Fix tab counter menu snackbar position. 2020-07-23 18:30:04 -07:00
Sawyer Blatz
0e438ef9a7 For #12430: Hide the mic when not using Google 2020-07-23 19:29:26 -04:00
Tiger Oakes
d3a07e95c9 For #12565: Don't pass contest to SortingStrategy 2020-07-23 19:05:11 -04:00
Aaron Train
aa495b4526
No issue: Fix recent UI test breakage (#12869) 2020-07-23 14:17:54 -07:00
Tiger Oakes
652af79e95
Migrate from Session.toTab to BrowserStore (#12221) 2020-07-23 12:27:39 -07:00
Tiger Oakes
9af167ba0a
Add tests for some classes in home/browser (#12837) 2020-07-23 11:17:52 -07:00
Tiger Oakes
0d77f761e9
Test sync adapter (#12810) 2020-07-23 11:16:11 -07:00
Arturo Mejia
6530a45eb9
For issue #11676: Features phone that doesn't a site permission exception shouldn't be shown (#12855) 
exception shouldn't be shown
 2020-07-23 09:12:22 -07:00
Mozilla L10n Automation Bot
7f829e1752 Import l10n. 2020-07-23 10:40:10 +03:00
Tiger Oakes
8f5a37733d
Create ToolbarPosition enum (#12747) 2020-07-22 19:23:38 -07:00
Jonathan Almeida
c143f95819 Issue #11333: Set ContentBlocking settings directly on GeckoRuntime 
We set the ContentBlockingSettings directly on the GeckoRuntime now to
improve the startup of the engine.

This change has requirements from Android Components and GeckoView, so
we would only see the full perf benefits in Nightly as the changes ride
the train, although we might start to see some of them as we're updating
the GeckoProvider for the `geckoBeta` variant as well.

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2020-07-22 16:28:18 -04:00
Kainalu Hagiwara
b26e39906d No issue - Fix compilation error caused by removed extension function. 2020-07-22 13:00:07 -07:00
Kainalu Hagiwara
58ccc64386 Fix UI tests. 
We need to pass a CoordinatorLayout instead of a SwipeGestureLayout to
FenixSnackbar.make() in BaseBrowserFragment to prevent UI tests from
breaking. We also need to remove a few view IDs from the tab preview.
 2020-07-22 11:26:15 -07:00
Kainalu Hagiwara
e7dc5580b2 For #3481 - Implement swipe on toolbar to switch tabs. 2020-07-22 11:26:15 -07:00
Mozilla L10n Automation Bot
9a2da5bb0f Import l10n. 2020-07-22 11:25:16 -07:00
Kainalu Hagiwara
921b16233b For #1048 - Add ability to view tab history by long-pressing the back or forward button. 2020-07-22 11:20:47 -07:00
Hakkı Kaan Çalışkan
2a0a11f740 For #12571: Rename 'Shortcuts' to 'Search engines' 
Co-Authored-By: Khushraj Rathod <khushrajrathod@gmail.com>
 2020-07-22 11:05:04 -07:00
Tiger Oakes
c2d940cf06
Use AC RunWhenReadyQueue (#12800) 2020-07-22 09:48:36 -07:00
Tiger Oakes
d9357f1e32 For #12801 - Extra debug menu trigger, disable if already triggered 2020-07-22 19:28:48 +03:00
Jonathan Almeida
d5fbc17ccf Update to Android Components 52.0.20200722023149 
Fixes breaking APIs in SyncedTabsFeature and
BookmarksStorageSuggestionProvider
 2020-07-22 10:52:14 -04:00
Michael Comella
2ae88aec81 No issue: add missing newline. 2020-07-21 15:52:34 -07:00
Michael Comella
6e06c7fda1 No issue: clean up initVisualCompletenessQueue... method. 
A no-op clean up.
 2020-07-21 15:52:34 -07:00
Michael Comella
633bc4f2f2 No issue: extract initVisualCompletenessQueueAndQueueTasks. 
This refactor, done entirely by IDE, is a no-op cleanup.
 2020-07-21 15:52:34 -07:00
Michael Comella
169071ac61 No issue: extract startMetricsIfEnabled function. 
This refactor, done entirely by IDE, is a no-op clean-up of this file.
 2020-07-21 15:52:34 -07:00
Jeff Boek
11e2137fab
For #12806 - Adds unit tests to cover ToolbarView.update() (#12807) 2020-07-21 14:34:07 -07:00
Jonathan Almeida
99354174a9 For #12797: Use measured height/width for loading a thumbnail 
Using `onNextLayout` has the side-effect of showing the thumbnail with
the tab.id from a recycled view.

The root cause of needing that call is to retrieve the measured
height/width from the view first before requesting. A simpler solution
to avoid the complexity is to retrieve these values from the dimen
resources.

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2020-07-21 16:38:49 -04:00
Sawyer Blatz
b483067bd9 For #12461: Update content description for tabs tray open tab count 2020-07-21 15:48:38 -04:00
Sebastian Kaspari
96121a79fa Issue #7877: Add SearchActionProvider for faster responses that mirror entered text. 2020-07-21 14:41:00 -04:00
Tiger Oakes
c08d375c18
Move settings in components (#12675) 2020-07-21 10:47:10 -07:00
Mihai Eduard Badea
c3041bcb64 For issue #12387 - Display tab tray using .show 
Replaced the global navigation action used for displaying the tab tray with the .show() function.
 2020-07-21 10:31:24 -07:00
mcarare
8826f99ef7 For #9722: Refactor onboarding buttons with text. 
Add title and description to button text, remove extra Textviews.
 2020-07-21 10:28:45 -07:00
Tiger Oakes
0abb2c4f8b Add tests for web push integration 2020-07-21 10:12:06 -07:00
mcarare
9a7154e95e For android-l10n #241: Mark a11y link type as not translatable. 2020-07-21 17:59:17 +03:00
Johan Lorenzo
7e7d69cb8e
Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta (#12225) 2020-07-21 16:42:08 +02:00
TejaswiKarasani
899f6e63ad
No issue: verify ETP toolbar shield icon is not displayed if ETP is OFF globally in ETP UI tests (#12623) 2020-07-21 09:33:06 -04:00
Oana Horvath
6ab6f3efe9
Fix UI tests from #12752 #12637 #12764 (#12779) 
* For #12752 & #12764: Fixes tabs tray behavior in UI tests

* For #12637: fixes goBackTest
 2020-07-21 08:49:24 -04:00
Tiger Oakes
e809df0858 Pass settings and metrics to CFR 2020-07-21 09:01:09 +03:00
mozilla-l10n-automation-bot
80b3b2dd82
Import l10n. (#12766) 2020-07-20 18:26:00 -07:00
Richard Pappalardo
41c256e474
Fixes #12752, #12764 - Temp disable openHistoryInNewTabTest intermittent UI test failures (#12754) 
* Fixes #12752 - Temp disable intermittent failing test
 2020-07-20 18:09:01 -07:00
Kainalu Hagiwara
02a929a926 No issue - Suppress new warnings from detekt update 2020-07-20 17:01:50 -07:00
Sawyer Blatz
284ec7b58f For #12461: Add tab count to tab tray 2020-07-20 19:16:47 -04:00
Tiger Oakes
f73411b924
For #5499 - Unify CFR drawables and dimens (#12749) 2020-07-20 16:00:57 -07:00
Hakkı Kaan Çalışkan
aeabd3e91b
For #12532: Quick fix for radio button alignment (#12691) 2020-07-20 15:33:32 -07:00
Kainalu Hagiwara
cd2532349d For #12551 - Implement swipe to delete for bookmarks. 2020-07-20 14:54:20 -07:00
Kainalu Hagiwara
313e5abf6a Rename tab_tray_background.xml 2020-07-20 14:54:20 -07:00
Michael Comella
fcb84d940a No issue: correct position of StartupTimeline; add warning. 2020-07-20 14:27:41 -07:00
Sawyer Blatz
445593b719
For #10466: Add search privately to top of list (#12744) 2020-07-20 13:25:36 -07:00
Tiger Oakes
51937e73fc
Closes #10924 - Cleanup SavedLoginsAuthFragment (#10930) 2020-07-20 13:25:24 -07:00
Kainalu Hagiwara
1121d844e6 For #12730 - Fix ripple for font size setting. 2020-07-20 13:00:59 -07:00
Sawyer Blatz
afbb039a08
For #11851: Close tab tray when last tab closed (#12615) 2020-07-20 11:05:32 -07:00
ekager
1dc0ad39f4 For #10784 - Fixes memory leak in BrowserAnimator 2020-07-20 13:50:18 -04:00
Sawyer Blatz
f0c6bc0226
For #12735: Fixes issue with tab deletion undo (#12737) 2020-07-20 10:48:16 -07:00
Hakkı Kaan Çalışkan
3f25a28cf7 For #12554: Helper class for password reveal on logins 2020-07-20 13:45:46 -04:00
mozilla-l10n-automation-bot
c66480d6dd
Import l10n. (#12687) 2020-07-19 21:30:11 -07:00
Christian Sadilek
16b6776938 Update Android Components to 51.0.20200717190031 2020-07-17 19:32:02 -04:00
Tiger Oakes
499f185fc0
Fix lint issues (#12683) 2020-07-17 16:20:08 -07:00
Tiger Oakes
693af257aa
Change enabled lint rules (#12517) 2020-07-17 15:17:16 -07:00
Tiger Oakes
13949d6968
Test migration classes (#12677) 2020-07-17 14:35:13 -07:00
Tiger Oakes
67fda80453
Add tests for login exceptions (#12681) 2020-07-17 14:25:45 -07:00
Tiger Oakes
aa31eb0fa5
Fix failure in handleWhatsNewGetAnswersClicked (#12682) 2020-07-17 14:25:35 -07:00
Mihai Adrian Carare
9c1b586e45
For #7966: Update toolbar content description. (#12667) 2020-07-17 16:22:13 -05:00
Elise Richards
37af9df3ad
For #12532: Align Settings -> Site permissions -> Sub-pages to 72dp keyline (#12680) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-17 15:54:57 -05:00
Mihai-Eduard Badea
1823fdb66d
For issue #9949 - Bookmarks/History deletion inconsistencies (#12630) 
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648.

Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
 2020-07-17 15:13:18 -05:00
Tiger Oakes
eed20b43b9
Test session control controller (#12652) 2020-07-17 13:07:01 -07:00
Hakkı Kaan Çalışkan
aa7655f4d6 For #12509: Set height of remove add on button to 36dp 2020-07-17 12:55:36 -07:00
ekager
455e7b8f99 Update ContextMenuUseCases to just take a store 2020-07-17 14:49:10 -04:00
ekager
e1ef5f55ec For #12453 - Sets secure flags on private tab of tabs tray 2020-07-17 13:24:25 -04:00
ekager
e358f95eed For #12364 - Only show PWA prompt the third time a user visits installable site 2020-07-17 12:37:03 -04:00
Tiger Oakes
ac3df6bc5e
Add tests for adapters in collections (#12649) 2020-07-17 09:04:16 -07:00
Kainalu Hagiwara
2fe17a6220
For #12531: Align Settings -> Private browsing to 72dp keyline (#12654) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-16 22:26:49 -07:00
Elise Richards
023a4983fa
For #10173: login duplicates and save (#11208) 
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
 2020-07-16 17:08:04 -05:00
Tiger Oakes
4dd0c0f224
For #12457: Add MockK matcher for intents (#12612) 2020-07-16 15:05:01 -07:00
Mugurell
e1fc0cc038
Ensure logins deletion (#12507) 
* For #11227 - Cleanup saved logins list when one is selected

Selecting a saved login will open a detail screen for it from where users can
change details or even delete that particular login.
After the change is made the user is brought back to the list of saved logins
where for a brief moment (< 1s) until we get a new response from
passwordsStorage.list() the user can see and even interact with the old list
of items, which may still contain the just deleted one.

To avoid users seeing obsolete logins or even interacting with them (selecting
a previosuly deleted item will result in a crash) we will clean the list of
logins just before the selected login is opened in the detailed view.
When returning for a brief moment the users may see the "loading" UX until
passwordsStorage.list() returns the up-to-date list of logins to display.

* For #11227 - Refactor SavedLoginsView to be closer to MVI

- Interactors should only get passed other Interactors or Controllers as
dependencies to which they should delegate user actions.
- Controllers should hold most of the business logic and get passed all final
dependencies they need to do their job.
 2020-07-16 14:40:08 -05:00
Tiger Oakes
2d066d77ad
Add tests for sync, wifi, and push (#12581) 2020-07-16 12:25:38 -07:00
Tiger Oakes
2291fb07aa
For #12565: Add Locale settings tests & use activity (#12579) 2020-07-16 11:43:27 -07:00
jhugman
3373f8b987
For #12600 - remove AddonInstalled event when the permission dialog is shown (#12601) r=csadilek,sblatz 2020-07-16 19:40:39 +01:00
Mihai Branescu
9373e7fcf4
For #12201 - forced callbacks to be on the main thread (#12543) 2020-07-16 13:39:31 -05:00
Elise Richards
4fe1fb8f4a
No issue: Delete unnecessary to-dos (#12603) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-16 13:38:07 -05:00
Hakkı Kaan Çalışkan
b997fba953 No issue: Move dp's to dimens.xml 2020-07-16 13:08:55 -04:00
Kainalu Hagiwara
b867e0de45 Update TabTrayViewHolder with A-C thumbnail changes. 2020-07-16 12:50:33 -04:00
Roger Yang
7923255fda For #12118: Add isSubframeRequest parameter for app links 2020-07-16 12:50:33 -04:00
Christian Sadilek
a0d9cdc450 For #12248: Webcompat reporter not active in Nightly 2020-07-16 12:24:21 -04:00
jhugman
fb1d7e12e6
For #11704 Add leanplum attributes for tracking protection (#11965) r=sblatz 
* For 11657: add LP attribute for tracking protection

* For #11704: added tracking_protection_enabled attribute

* Added docs for the new attributes, linking to data-review to the mma.md

* Rename null to none when no ETP is enabled
 2020-07-16 17:09:32 +01:00
Hakkı Kaan Çalışkan
057711e6fb No issue: Uncomment forgotten assert 2020-07-16 11:45:53 -04:00
Tiger Oakes
667261f511 Closes #12493: Remove kapt plugin 2020-07-16 10:38:03 -04:00
Hakkı Kaan Çalışkan
cdd5d206fd For #12105: Follow ux mock on Settings --> Accessibility screen 2020-07-16 10:37:20 -04:00
James Hugman
798c1bf743 Address review comments 2020-07-16 10:37:03 -04:00
James Hugman
22689a9ff5 Remove need to specify component names for new intents 2020-07-16 10:37:03 -04:00
James Hugman
98a33ea82b Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is 2020-07-16 10:37:03 -04:00
James Hugman
1629878a66 Add install_search_widget 2020-07-16 10:37:03 -04:00
James Hugman
4573d09fd8 Add UI tests for deep links 2020-07-16 10:37:03 -04:00
James Hugman
709fedd4d7 Add unit tests for deep links 2020-07-16 10:37:03 -04:00
James Hugman
8130aaa2cc Add deep links for settings and home screens 2020-07-16 10:37:03 -04:00
isabelrios
5b61b44f1a
cron-job-ui-screenshots (#12423) 
Co-authored-by: isabel rios <isabelrios@MacBook-Pro-de-isabel-2.local>
 2020-07-16 16:08:00 +02:00
Mugurell
d449184faa For #12544 - Prevent search engines mixup 
Stricter synchronization by always using the same "loadedSearchEngines"
variable.
With "loadedSearchEngines" calling "refreshAsync()" we also get the fallback
engines to contain reddit and youtube (which are programatically added) and
also now we properly remember and display the engines added by user.
 2020-07-16 16:49:54 +03:00
Oana Horvath
af3c232615 Replaces verifyPageContent in UI tests 2020-07-16 10:55:58 +03:00
Tiger Oakes
6be39aebde
Add tests for StartupReportFullyDrawn (#12560) 2020-07-15 23:31:59 -07:00
Tiger Oakes
d4bb432e24
Add helper for underlining text (#12520) 2020-07-15 22:38:46 -07:00
Tiger Oakes
a0491b702e
Fix nav graph and theme tests (#12567) 2020-07-15 18:04:36 -07:00
Tiger Oakes
d0e9f1f165
Update Kotlin dependency (#10806) 2020-07-15 18:02:58 -07:00
mcarare
4153c11ea8 For #12503: Add unit tests for permissions details view. 2020-07-15 10:04:40 -04:00
mcarare
800702149b For #12503: Open addon permissions link in app. 2020-07-15 10:04:40 -04:00
Aaron Train
661835a35c No issue: Add a couple Tabs Tray UI tests 2020-07-15 10:49:34 +03:00
ekager
9ed85510ae For #7094 - Adds save login exceptions 2020-07-14 14:47:37 -04:00
Tiger Oakes
69020a1f26
For #12457 - Add MockK matcher for nav directions (#12262) 2020-07-14 10:39:23 -07:00
Tiger Oakes
f5f1a63690
For #12171: Use one-line logo in Nightly (#12555) 2020-07-14 10:37:01 -07:00
Tiger Oakes
1ff64cab67
Add tests for search (#12437) 2020-07-14 10:32:04 -07:00
Tiger Oakes
e9fb1a61c7
Test viewholders in home.sessioncontrol (#12524) 2020-07-14 10:31:50 -07:00
Hakkı Kaan Çalışkan
f424656575 For #12107: Follow ux mock on Settings --> Account screen 2020-07-14 12:25:21 +03:00
Mozilla L10n Automation Bot
07e01c5b86 Import l10n. 2020-07-14 11:40:19 +03:00
ekager
88af736065 For #11099 For #12189 For #7532 - Clean up bottom navigation bar colors 2020-07-13 13:46:35 -04:00
Sawyer Blatz
98ad7ace49 For #10466: Put call & email at top of context list 2020-07-13 10:33:55 -07:00
Hakkı Kaan Çalışkan
ca30fef579 For #12106: Follow ux mock on Settings --> Logins screen 2020-07-13 11:14:32 -04:00
Oana Horvath
4624bf5c50 For #10911: disables flaky createBookmarkFolderTest 2020-07-13 15:40:50 +03:00
Mugurell
ea10d2a872 For #11875 - Prevent mixup of region / locale based search engines 
We have two search engine types:
- one based on MLS reported region,
- one based only on Locale.

There are multiple steps involved in returning the default search engine for
example and though at each step we could verify if a certain operation is
completed we are still exposed to concurrency issues.
Simplest and most effective way to make sure the MLS engines do not mix with
Locale based engines is to use the same type of engines for the entire duration
of the app. At the next cold start we'll verify again which engines to use.

Using the Locale based engines (fallbacks) is expected to only happen once, at
the first run of the application after being installed.
 2020-07-13 13:41:34 +03:00
Mozilla L10n Automation Bot
ca352c555b Import l10n. 2020-07-13 07:59:10 +03:00
jhugman
9df13ae121
For #11655: add leanplum event for installing an addon (#12136) r=elise 
* For #11655: add leanplum event for installing an addon

* Add link to data-review request in PR

* Addressed CI comments
 2020-07-12 23:47:34 +01:00
Grisha Kruglov
31248b835c Synced Tabs: make sure to stop 'loading' when we encounter an error 2020-07-10 19:02:55 -07:00
Tiger Oakes
c265a7089a
Fix Robolectric tests SDK version (#12464) 2020-07-10 17:21:10 -07:00
ekager
0add94e353 For #11324 - Adds trash icon to swipe to delete 2020-07-10 20:16:57 -04:00
Michael Comella
9fa241fbb0 No issue - post: mock profiler object in DefaultTabTrayControllerTest. 
Without this line, the tests fail when running the full suite (but not
this test in isolation, for some reason).
 2020-07-10 16:43:06 -07:00
Nazım Can Altınova
7319f77114 Add profiler markers for HomeActivity.load and DefaultTabTrayController.onNewTabTapped 2020-07-10 16:43:06 -07:00
Sawyer Blatz
5d9fdd6266 Update app/src/main/java/org/mozilla/fenix/HomeActivity.kt 
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
 2020-07-10 18:44:14 -04:00
Sawyer Blatz
bab0f9d95b No issue: Update AC version 2020-07-10 18:44:14 -04:00
Michael Comella
0df234cf76 For perf-frontend-issues#44: add local property to autosign release builds. 2020-07-10 10:55:32 -07:00
Mihai Eduard Badea
9aab1d1678 For issue #12339 - Collection delete dialog string update 
Set the collection delete dialog title text to "Delete %1$s?"
 2020-07-10 11:38:39 -04:00
Mozilla L10n Automation Bot
c3b06374a1 Import l10n. 2020-07-09 21:39:49 -04:00
Grisha Kruglov
806f6031ae For #12433 - Allow synced tabs pull-to-refresh for non-critical account errors 2020-07-09 16:18:54 -07:00
ekager
ad265be672 For #11303 - Change copy login origin to open in browser 2020-07-09 18:09:41 -04:00
Tiger Oakes
c99a8f5cfa
Fixes #9832 - Change targetSdkVersion to Android 10 (#11014) 2020-07-09 10:50:51 -07:00
Emily Kager
63eb7b3e4e
For #12010: Follow ux mock on Settings --> ETP --> Info screen (#12429) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-09 09:47:09 -07:00
Sebastian Kaspari
a2a7b11425 Issue #12311: BrowserToolbarController: Stop SessionFeature and release session from EngineView. 2020-07-09 12:36:56 -04:00
TejaswiKarasani
1926ddbc22
No Issue: Verify the page main menu items UI Test (#12336) 2020-07-09 09:15:10 -07:00
Mozilla L10n Automation Bot
cba27a3883 Import l10n. 2020-07-09 11:29:38 -04:00
David Walsh
85cebf8796 For 11889 - Fix snackbar for collection creation in browser fragment 2020-07-09 08:50:12 +03:00
mozilla-l10n-automation-bot
6f49e08725
Import l10n. (#12404) 2020-07-08 18:56:37 -07:00
Hakkı Kaan Çalışkan
d76d8d1881 For #11563: Set ic_close.xml to use full width and height 2020-07-08 17:21:25 -04:00
ekager
38657bbfc6 For #11431 - Scroll to restored tab in tab tray 2020-07-08 17:18:16 -04:00
Christian Sadilek
216396d979 For #12353: URL copied to clipboard should not be extension/reader URL 2020-07-08 16:55:32 -04:00
Tiger Oakes
9ae1aa6f16 Add tests for exceptions 2020-07-08 15:52:37 -04:00
MickeyMoz
236b981881 Update Android Components version to 50.0.20200708130551. 2020-07-08 12:44:51 -04:00
isabelrios
8b3f9804b5
No issue: Update screenshots test (#12348) 2020-07-08 12:20:34 -04:00
Tiger Oakes
67ce5ad5d9
Add tests for onboarding viewholders (#11522) 2020-07-08 07:53:22 -07:00
Richard Pappalardo
cf94906e9d fix: disable intermittent test failure 2020-07-08 12:21:25 +03:00
Tiger Oakes
720a590902
Add tests for browser helper classes (#12370) 2020-07-07 19:46:25 -07:00
Mozilla L10n Automation Bot
bedd1d452c Import l10n. 2020-07-07 21:27:37 -04:00
Christian Sadilek
27c608d956 Update built-in extensions for new AC/GV API 
New API (installBuiltIn/ensureBuiltin) requires
- Gecko IDs and new permissions
- Extension will only be re-installed if it has a new version

This includes a gradle task to automatically generate a
new version in manifest.json for every build so we don't
forget to update the version and end up with changes that
are never applied.
 2020-07-07 18:41:12 -04:00
amkcpu
fab64229a5 Closes #11873 - Add scrollbar in tabs tray 2020-07-07 17:50:56 -04:00
ekager
bceb07a05b For #12312 - Disable settings that navigate while authenticating 2020-07-07 16:46:14 -04:00
Michael Comella
3e617245b5 For #12345: catch SecurityException when calling reportFullyDrawn. 
That's amazing! I've got the same combination on my luggage.
 2020-07-07 13:44:09 -07:00
Tiger Oakes
65637e9e2b
Use A-C version of Resources.getSpanned (#12358) 2020-07-07 13:36:29 -07:00
MickeyMoz
4f74f34dba Update Android Components version to 49.0.20200707131055. 2020-07-07 14:49:54 -04:00
Mihai Eduard Badea
eeb8719fa1 For issue #12126 - Tab counter consumeFrom update 
Added a direct call to the updateTabCounter method to account for changes made to the BrowserState while the tabCounter view is not visible.
 2020-07-07 11:12:55 -04:00
Mozilla L10n Automation Bot
f838049e97 Import l10n. 2020-07-07 11:12:02 -04:00
Tiger Oakes
8e8e5aea36
Extract radio group logic into helper (#11493) 2020-07-06 17:09:42 -07:00
ValentinTimisica
4a93a41bb2 For #11763: Fixes unit tests 2020-07-06 17:06:10 -04:00
ValentinTimisica
e39d5b6de7 For #11763: Shows confirmation dialog when deleting last tab from collection 2020-07-06 17:06:10 -04:00
ValentinTimisica
c3acde438a For #11889: Changes collection creation confirmation snackbar strings 
Also I changed the adding tabs to collection confirmation string from
tabtray to take into account the number of tabs.
Example: 1 tab-"Tab saved!"; multiple tabs-"Tabs saved!"
 2020-07-06 17:02:02 -04:00
Tiger Oakes
1ab5fe3eb9
Add method to test fragments in roboletric (#12261) 2020-07-06 13:04:43 -07:00
Hakkı Kaan Çalışkan
426a1ba57d For #12078: Follow ux mock on Settings --> Language screen 2020-07-06 15:47:42 -04:00
mcarare
9bc4f443f5 For #9775: Increase touch target of elements in add search engine screen 2020-07-06 15:47:25 -04:00
ekager
170ae1aa33 For #12263 - Adds end margin to synced tabs header 2020-07-06 15:37:53 -04:00
Hakkı Kaan Çalışkan
331090d1e6 For #12007: Fix add search engine items using wrap content for height 2020-07-06 15:37:28 -04:00
Hakkı Kaan Çalışkan
296bdc5967 For #12016: Follow ux mock on Settings --> Data Collection 2020-07-06 15:27:46 -04:00
Emily Kager
90f43bf350
For #12086: Follow ux mock on Settings --> Customize screen (#12324) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-06 12:25:54 -07:00
MickeyMoz
da39a7e671 Update Android Components version to 49.0.20200705130154. 2020-07-06 15:21:40 -04:00
mcarare
94273bc274 For #12125: Handle visibility updates for add to collection button. 2020-07-06 14:37:39 -04:00
Mozilla L10n Automation Bot
2668a68678 Import l10n. 2020-07-06 14:06:24 -04:00
ekager
822d50192a For #12316 - Allow text wrap on buttons 2020-07-06 20:56:54 +03:00
Tiger Oakes
fd18687ac9 Switch to any calls 2020-07-06 20:38:08 +03:00
Tiger Oakes
41452e945b Move SearchProviderModel extension to class 2020-07-06 20:38:08 +03:00
Oana Horvath
836199ff16 For #11764: doubles long-press delay UI test 2020-07-06 19:13:53 +03:00
Aaron Train
3351a02885
For #12309: Disable verifyContextSaveImage and verifyContextMixedVariations (#12314) 2020-07-06 11:51:06 -04:00
Mugurell
0fb6bbc175 For #10401 - Hide Shortcuts if just one search engine is installed 
Otherwise, the Shortcuts option which allows to choose with what search engines
to search would be redundant.
 2020-07-06 14:36:04 +03:00
Sebastian Kaspari
388c144a62 SearchFragmentStore: Remove Session reference from state and read values from BrowserStore. 2020-07-03 21:01:59 +02:00
Sebastian Kaspari
942b901b81
Closes #12171: (fenixProduction) Add vector image for full Nightly logo. (#12254) 2020-07-03 10:55:26 -07:00
isabelrios
84324f52ae
For #12018 - Sync Int tests fixes (#12252) 2020-07-03 13:49:40 -04:00
Aaron Train
0a4f92a5d0
No issue: Re-enable Context Menu UI tests (#12250) 2020-07-03 13:48:46 -04:00
Aaron Train
901a90643f
Closes #8714: Re-enable toggleShowVisitedSitesAndBookmarks (#12251) 2020-07-03 13:20:39 -04:00
isabelrios
4dc3a00ed0
For #12224 - Fix UI testAboutFirefoxPreview (#12233) 2020-07-03 12:31:47 -04:00
ekager
f863c341e8 Updates AC to 49.0.20200702190156 and fixes breaking changes 2020-07-03 06:40:06 -04:00
ekager
8533d96ee2 For #11320 - Expose login autofill setting to beta dimension 2020-07-03 06:40:06 -04:00
liuche
6ec0aeb843
Issue #12207 - Update "new nightly" link to point to org.mozilla.fenix (#12209) 2020-07-02 12:39:44 -07:00
Sawyer Blatz
8583cac8f8 Revert "For #11183: Redirect user to homescreen after widget added" 
This reverts commit a8ed913654.
 2020-07-02 11:22:18 -07:00
Sawyer Blatz
3cbab45566 For #12157: Don't show two search widget dialogs 2020-07-02 11:22:18 -07:00
mozilla-l10n-automation-bot
321ba02832
Import l10n. (#12175) 2020-07-02 08:29:18 -07:00