Mugurell
57462d612f
For #16054 - Enable pull to refresh webpage in Nightly and Debug ( #16060 )
4 years ago
Elise Richards
7e3c26914c
For #15080 : Handle default search engine when editing or removing ( #15768 )
4 years ago
Juan C. Goncalves
eb0712d9b4
For #11397 - Add lint rule for AppCompatResources instead of ContextCompat ( #16011 )
4 years ago
Sebastian Kaspari
0d97862824
FennecWebAppIntentProcessor: Catch JSONException.
4 years ago
Mihai Adrian Carare
b1bc024ff5
For #11631 : Move report site issue extension to main menu. ( #15884 )
...
* For #11631 : Move report site issue extension to main menu.
* For #11631 : Update UI test for installing add-on.
4 years ago
Tom Klein
57ba92080f
For #15480 - Update the UI when a collection is renamed
4 years ago
mcarare
edd613ace2
For #15688 : Update UI tests.
4 years ago
mcarare
5f01583f25
For #15688 : Update unit tests.
4 years ago
mcarare
9274558e2f
For #15688 : Navigate to home screen with arguments on new tab action.
4 years ago
Mozilla L10n Automation Bot
ae74edecdb
Import l10n.
4 years ago
Sebastian Kaspari
2da24cd91d
Update Android Components, Kotlin, Gradle plugin ( #16021 )
...
* Closes #13262 : Update AGP to 4
* Update to Mozilla Android Components 63.0.20201019090011.
* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.
* Fix new compiler warnings.
* Fix compilation of lint rules module.
* Pin JNA version.
* Fix new lint errors.
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Mihai Adrian Carare
3ed49d8802
For #14744 : Also show Fill link from clipboard with search shortcuts. ( #15885 )
4 years ago
mozilla-l10n-automation-bot
46ff7a182a
Import l10n. ( #16014 )
4 years ago
mozilla-l10n-automation-bot
c941bd99b0
Import l10n. ( #16001 )
4 years ago
mozilla-l10n-automation-bot
1d91f1f087
Import l10n. ( #15986 )
4 years ago
Gabriel Luong
d33bd76e40
For #15796 - Use the device locale for the system locale subtitle ( #15975 )
4 years ago
Gabriel Luong
87ec7a77ae
For #15937 - Remove topFrecentSite feature flag ( #15967 )
...
* For #15937 - Remove the topFrecentSite feature flag
* For #15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
4 years ago
ekager
d208ffe002
For #7345 - Update new shield icons, remove lottie ( #15909 )
4 years ago
Christian Sadilek
c852301c93
Closes #11286 : Add TelemetryMiddleware to remove Session[Manager] observers
4 years ago
Gabriel Luong
412b412d5f
For #15796 - show device language under follow device language ( #15966 )
4 years ago
amkcpu
7ba5e130ba
For #10683 : Show longer tab titles
...
Also update tab tray item layout according to specs posted in the issue.
4 years ago
mozilla-l10n-automation-bot
a2a4284a1a
Import l10n. ( #15945 )
4 years ago
Jeff Boek
55515d8f7c
For #15596 - Removes upgrade faq link from fennec builds ( #15643 )
4 years ago
Gabriel Luong
b79df0ba8f
For #14922 : Use padding instead of margin to use the full screen width for the "Add search engine" button
4 years ago
mcarare
9f14007a98
For #14922 : Adjust margins for add search engine preference.
4 years ago
mcarare
ba0c005ae9
For #14922 : Add divider above address bar preferences.
4 years ago
mcarare
7510b1609f
For #15898 : Add dividers above subheadings in tabs screen.
4 years ago
mcarare
e50cb21fd0
For #15898 : Add dividers above subheadings in customise screen.
4 years ago
Michael Comella
439dfc5cb1
For #15644 : add comment for why we set the app theme in test.
4 years ago
Michael Comella
4a000ab4f9
For #15644 : change apply to with in GleanMetricsService.
...
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.
I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
4 years ago
Michael Comella
690554b5c6
For #15644 : mock package inspection dependencies in GleanMetricsService.
...
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
4 years ago
ekager
2c7789b1a8
Sets theme in FenixRobolectricTestApplication onCreate
4 years ago
ekager
4d348dd26a
Fixes existing lint errors
4 years ago
Gabriel Luong
665a71cbb0
For #15907 - Remove the usage of the TabTrayGridItemDecorator
4 years ago
ekager
508ec8b8ff
For #15347 - Adds telemetry for tabs settings
4 years ago
ekager
b6587455f8
fix detekt errors
4 years ago
Sebastian Kaspari
430282c8ec
Use new SearchEngineProvider interface.
4 years ago
Mozilla L10n Automation Bot
ce99cc9ccf
Import l10n.
4 years ago
Michael Comella
c6b83b10e0
For #15280 : suppress new lint rule in migration code.
4 years ago
ekager
e56043c485
For #15265 - Save cached top sites for metrics ping
4 years ago
ekager
cbe293d3e4
For #12062 - Launch back to browser if we previoulsy had tabs
4 years ago
Mozilla L10n Automation Bot
399c9c57fb
Import l10n.
4 years ago
ekager
7931d66c8e
For #15853 - Always set fontSizeFactor setting with new text scale
4 years ago
Mihai Adrian Carare
0e2657e262
For #14735 : Remove debug logs from release build. ( #15747 )
4 years ago
Mozilla L10n Automation Bot
2751da0372
Import l10n.
4 years ago
Gabriel Luong
ee5f678442
For #15777 - [Grid View] Set the height of the title to 30dp
4 years ago
Gabriel Luong
463f83a79a
For #15758 ⁃ [Grid View] Add a divider between the tab item's title and thumbnail
4 years ago
Mozilla L10n Automation Bot
83b5bae65e
Import l10n.
4 years ago
Mozilla L10n Automation Bot
25c9706cfd
Import l10n.
4 years ago
Grisha Kruglov
2030580fc8
Closes #15812 : Check for a null context during onScanResult
4 years ago
Mozilla L10n Automation Bot
d5bef99834
Import l10n.
4 years ago
Shen
45e3f7805b
For #13168 - Removed the close button from history navigation bar
4 years ago
Michael Comella
4179ab05bb
For #10069 - review: clarify init time for External...Activity.
4 years ago
Michael Comella
a1bbd2589e
For #10069 - review: change extra name to firstFramePreDrawNanos.
4 years ago
sraturi
8f16f9cb37
for #10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types.
4 years ago
mcarare
6516eff5c8
For #13831 : Adjust buttons dimensions to improve a11y.
...
Margins were also adjusted to maintain relative placements.
4 years ago
mcarare
e89b9756ee
For #13831 : Add ripple for the copy password button.
4 years ago
ekager
881e3d6ccd
For #14923 - Removes auto size preference toggle
4 years ago
Sijan Rijal
127d006d66
For #15402 : Hide ETP pop-up if the toolbar is not visible ( #15667 )
...
For #15402 : Hide ETP pop-up when top or bottom toolbar is not visible
4 years ago
Sijan Rijal
70908307fc
For #15497 : Hide and remove the three dot menu from the Desktop Bookmarks folder ( #15649 )
...
For #15497 : Remove and disable the three dot menu button
4 years ago
Mozilla L10n Automation Bot
0fbb28296e
Import l10n.
4 years ago
Jonathan Almeida
666781aa62
Fix lint warnings and test in site permissions
4 years ago
Arturo Mejia
de521192e0
Add support for local storage permission
4 years ago
Gabriel Luong
5153a3f2c5
For #15115 - Part 9: Fix ui tests for the tabs settings
4 years ago
Gabriel Luong
2dd019c05f
For #15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting
4 years ago
Gabriel Luong
af0af7f88a
For #15115 - Part 7: Draw a border around the selected tab
4 years ago
Gabriel Luong
5fcc486caa
For #15115 - Part 6: Display the tab's favicon in the grid view
4 years ago
Gabriel Luong
5fa72cf48c
For #15115 - Part 5: Don't draw any background when swiping to delete a tab
4 years ago
Gabriel Luong
a001004add
For #15115 - Part 4: Formatted TabTrayView.kt
4 years ago
Gabriel Luong
6c77cdab41
For #15115 - Part 3: Implement a grid view layout for the tabs
...
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
4 years ago
Gabriel Luong
2117dfb524
For #15115 - Part 2: Remove unused xmlns:mozac in component_tabstray.xml
4 years ago
Gabriel Luong
ed3986662f
For #15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment
...
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
4 years ago
Michael Comella
7c0d00c800
No issue: fix tests related to inline change.
...
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
4 years ago
Michael Comella
7b5cd8c165
No issue: remove inline from StrictModeManager.resetAfter.
...
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
4 years ago
Mozilla L10n Automation Bot
a72b5b0dd6
Import l10n.
4 years ago
Jonathan Almeida
ee673348bf
Issue #15754 : Disable failing notification UI tests
4 years ago
Jonathan Almeida
23d9951e78
Upgrade to Android Component 62.0.20201006190820 with breaking changes
4 years ago
mcarare
9845626eca
For #15711 : Also add custom engines to fallback list.
4 years ago
mozilla-l10n-automation-bot
0ac7feacb4
Import l10n. ( #15738 )
4 years ago
Elise Richards
13f3304912
For #8765 : Use shared list widget in collections ( #15733 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Michael Comella
4302cd20b2
For #13959 - post: decrement expected suppression count.
...
Running locally, I get the same error: I think that there legitimately
was an reduction in the number of StrictMode suppressions on start up.
4 years ago
Michael Comella
3e96f6b385
For #13959 - review: add clarifying comments.
4 years ago
Michael Comella
50959d997e
For #13959 : add marker when StrictMode is suppressed.
4 years ago
Michael Comella
3b5d6d58d9
For #13959 : add MozillaStrictModeSuppression detekt check.
4 years ago
Michael Comella
b222376cb0
For #13959 : add test to prevent increasing StrictMode suppression count.
4 years ago
Michael Comella
c33aafb024
For #13959 : add HomeActivityTestRule.skipOnboarding.
...
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
homeScreen { }.dismissOnboarding()
Which opens settings to dismiss onboarding.
4 years ago
Michael Comella
4a4edeb184
For #13959 : count StrictMode suppressions on startup.
4 years ago
Jocelyne Abi Haidar
a5de2c0352
For #15675 : Disable Save button when editing saved login until something has been changed
...
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
4 years ago
mozilla-l10n-automation-bot
5fed37cf45
Import l10n. ( #15712 )
4 years ago
Mozilla L10n Automation Bot
ad2b99f9f9
Import l10n.
4 years ago
mcarare
07748f69b7
For #15632 : Improve checking open tabs logic to show collection button.
...
Check now considers selected tab tray mode.
4 years ago
ekager
ec3595d4fc
For #15600 - Move removal of timed out sessions to immediately after restoration
4 years ago
ekager
01eedd159a
No issue: Update biometric, core, and recyclerview libraries
4 years ago
mcarare
b696fc4c4b
For #13031 : Show size in KB for smaller downloaded files.
4 years ago
Mozilla L10n Automation Bot
ee4a5283a4
Import l10n.
4 years ago
Jocelyne
0154c81f81
For #10107 : Show Today and Yesterday labels in History ( #15415 )
4 years ago
Jeff Boek
41a92a8d8b
For #15593 - Reverts back to simple UUID creation without Fenix side caching
4 years ago
Jocelyne
e74a12b442
For #15471 : Show Delete button in red in multi-select overflow menu ( #15576 )
4 years ago
Mozilla L10n Automation Bot
97adee3bd9
Import l10n.
4 years ago
Grisha Kruglov
51dab196c4
Closes #15443 : Use fragment's lifecycleScope for AlertDialog actions
4 years ago
Christian Sadilek
ced92d69d1
Issue #15555 : Set channel to Nightly explicitly for SettingsFragmentTest
4 years ago
mcarare
67310061a3
For #15559 : Allow tabs to stretch in landscape mode for tablets.
...
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
4 years ago
Christian Sadilek
4a06e40e70
Closes #15555 : Intermittent failures in SettingsFragmentTest
4 years ago
Stefan Arentz
ff930175de
For #15537 - Be more verbose about leanplum identifiers ( #15538 )
4 years ago
mcarare
19b377c021
For #15535 : hasOpenTabs now considers the selected tab mode in tray tab.
4 years ago
Michael Comella
56f78cb30c
No issue: elaborate on Components class doc.
...
This is to clarify a misunderstanding I found in PR review.
4 years ago
Sebastian Kaspari
2fda22e857
Revert "For #12565 : Pass metrics to share controller" for debug test failures.
...
This reverts commit bbaca06274
.
4 years ago
Sebastian Kaspari
4de466883b
Revert "For #12565 : Pass bookmark storage to controller" for debug test failures.
...
This reverts commit 3c22100b84
.
4 years ago
Andrew Gaul
cfbad1dae9
Show undo snackbars with padding with static bottom toolbar
...
This specifically fixes the close tab snackbar. This commit mirrors
the logic when not using Undo from
9e876ebc44
. References #14982 .
4 years ago
ekager
01e802fef0
For #15324 - Show tab settings and recently closed items in menu when no tabs
4 years ago
ekager
e49cd9c558
For #15503 - Change recently closed max to 10
4 years ago
TrianguloY
b07af9ccd3
For #13856 - Prevent overscroll in swipe to switch tabs gesture
4 years ago
Tiger Oakes
25f62f1c76
Extract locale settings initial state
4 years ago
Tiger Oakes
acbad66f45
Add test for initial logins list state
4 years ago
Tiger Oakes
f2a6aa4f25
Add tests for initial collection creation state
4 years ago
Sören Hentzschel
01fdb4ac3f
For #11561 - changed inactive heading and menu icon color in dark mode
4 years ago
Mozilla L10n Automation Bot
863b135723
Import l10n.
4 years ago
Tiger Oakes
3c22100b84
For #12565 : Pass bookmark storage to controller
4 years ago
Tiger Oakes
bbaca06274
For #12565 : Pass metrics to share controller
4 years ago
Michael Comella
d767cd199e
For #13959 : fix startup crash by using arg Context.
...
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
4 years ago
Michael Comella
42cca072e2
For #13959 : remove resetAfter & port tests to StrictModeManager.
4 years ago
Michael Comella
dd73cb628b
For #13959 : clean up existing StrictMode test names.
4 years ago
Michael Comella
f19c9920f9
For #13959 : move resetAfter into StrictModeManager.
...
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
4 years ago
Michael Comella
6abeb2d9e7
For #13959 : change StrictModeManager to class from object.
...
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
4 years ago
Christian Sadilek
d4ab728cff
For #14034 : Add debug preference to override AMO collection in Nightly
4 years ago
Michael Comella
a92356fe00
For #13959 : comment about duplication in logic in StrictMode.
...
I had to drop a commit that addressed the issue because it was too hard
to fix.
4 years ago
Michael Comella
e1bd6191c7
For #13959 : add comment to explain why we only resetAfter in certain build modes.
4 years ago
Michael Comella
3bf71ef655
For #13959 : use ac StrictMode.resetAfter rather than duplicating functionality.
4 years ago
Michael Comella
2c1befaa25
For #13959 : rename to attachListenerToDisablePenaltyDeath for clarity.
4 years ago
Michael Comella
c03c7ef793
For #13959 : remove unused penaltyDialog parameter.
...
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
4 years ago
Michael Comella
f05a542060
For #13959 : always enable detectNonSdkApiUsage.
...
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
4 years ago
Sebastian Kaspari
3983c509dc
Use "undo" implementation from Android Components.
...
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
4 years ago
Mozilla L10n Automation Bot
d287e6e9e0
Import l10n.
4 years ago
mcarare
daced89387
For #15310 : Add test for ActivityNotFoundException when sharing to app.
4 years ago
mcarare
6289da892c
For #15310 : Also catch ActivityNotFoundException when sharing to app.
4 years ago
ekager
0d0a28d551
No issue: Update AC to 61.0.20200925190057
4 years ago
ekager
7d5c199e51
For #12383 #15407 #12860 - Switch to using shared view model for session to delete on home
4 years ago
Grisha Kruglov
2999f64d0a
Closes #15434 : Don't try to display a 'signed in' snackbar in a 'headless' mode
4 years ago
Grisha Kruglov
d98eba1d64
Closes #15432 : Invoke UI updates on main thread in response to account events
4 years ago
Grisha Kruglov
24985d54fa
Closes #15436 : Auto-close tabs during startup on the main thread
4 years ago
mcarare
cd53b8fdaf
For #15130 : Remove "what's new card" check in UI test.
4 years ago
mcarare
04e59e0ac5
For #15130 : Remove "what's new card" from onboarding screen.
4 years ago
Mozilla L10n Automation Bot
f32d2011df
Import l10n.
4 years ago
Kate Glazko
e8855c09e6
For #15320 : Ensure Mimetype Other PDF Shows PDF Icon
4 years ago
Elise Richards
1adf467248
For #14280 , #14743 : Remove old search fragment ( #15169 )
...
* Remove search fragment
* Use new folder to search dialog
* Rebase and lint
* Update tests with search dialog nav directions
* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
4 years ago
Jonathan Almeida
add60611b4
For #15349 : Fixes SyncedTabs suggestion not clicking
4 years ago
Grisha Kruglov
f1b0827a0b
For #15296 : Allow excluding bookmark subtrees when editing parent folder
...
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
4 years ago
Mozilla L10n Automation Bot
4fad099b23
Import l10n.
4 years ago
Sawyer Blatz
0fa2509bef
For #14243 : Pre-land visuals for Close Tabs CFR ( #15171 )
4 years ago
Grisha Kruglov
71b51146cb
Update breaking changes in the FxA/Sync integration
4 years ago