Michael Comella
0a83eb56f4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : add comment for why we set the app theme in test.
2020-10-15 09:53:13 -07:00
Michael Comella
aa19f541b2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : change apply to with in GleanMetricsService.
...
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.
I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
2020-10-15 09:53:13 -07:00
Michael Comella
910b7f19aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : mock package inspection dependencies in GleanMetricsService.
...
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
2020-10-15 09:53:13 -07:00
ekager
69a126cbb6
[fenix] Sets theme in FenixRobolectricTestApplication onCreate
2020-10-15 09:53:13 -07:00
Michael Comella
7cc54078d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : escalate many Performance check severity in lint.xml.
...
I exhaustively looked through the list of checks labeled performance and
marked them accordingly. To see all lint checks, type:
<android-sdk>/tools/bin/lint --show
2020-10-15 09:53:13 -07:00
Michael Comella
106a36bcdc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : remove unnecessary lint ignore.
2020-10-15 09:53:13 -07:00
Michael Comella
fec7662d8e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : escalate InefficientWeight to error.
...
All violations of this type were addressed in the previous commit.
2020-10-15 09:53:13 -07:00
ekager
74b4866e3d
[fenix] Fixes existing lint errors
2020-10-15 09:53:13 -07:00
Michael Comella
0e8148f253
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : update Android Gradle Plugin version.
...
This ensures our custom lint rules are running on the command line.
2020-10-15 09:53:13 -07:00
Michael Comella
96e1ee1591
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : update RepoMatching.comAndroid.
...
In Android Gradle Plugin 3.6+, a new dependency is
com.android:zipflinger so we can't assume com.android is following by a
dot.
2020-10-15 09:53:13 -07:00
Gabriel Luong
ef60d82caa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15907 - Remove the usage of the TabTrayGridItemDecorator
2020-10-15 10:02:07 -04:00
ekager
9d876a7076
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15347 - Adds telemetry for tabs settings
2020-10-14 22:53:31 -04:00
ekager
9f67b3df9b
[fenix] fix detekt errors
2020-10-14 18:22:02 -07:00
ekager
171e425db0
[fenix] bump AC version to 63.0.20201014190200
2020-10-14 18:22:02 -07:00
Sebastian Kaspari
3368ddce5c
[fenix] Use new SearchEngineProvider interface.
2020-10-14 18:22:02 -07:00
Mozilla L10n Automation Bot
d064b26fc0
[fenix] Import l10n.
2020-10-14 17:49:27 -07:00
Michael Comella
2b368b4bff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 - review: add license to lint-baseline.xml.
2020-10-14 15:20:28 -07:00
Michael Comella
30208f0345
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 : add current ConstraintLayout warnings to lint baseline.
2020-10-14 15:20:28 -07:00
Michael Comella
88cf7184ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 : suppress new lint rule in migration code.
2020-10-14 15:20:28 -07:00
Michael Comella
169a87a1fb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 : add new lint rule to CODE OWNERS.
2020-10-14 15:20:28 -07:00
Michael Comella
de1a390dba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 : add ConstraintLayoutPerfDetector custom lint rule.
2020-10-14 15:20:28 -07:00
ekager
5baed32e13
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15265 - Save cached top sites for metrics ping
2020-10-14 15:08:54 -07:00
ekager
6ee2d5a8dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Launch back to browser if we previoulsy had tabs
2020-10-14 15:05:20 -07:00
MickeyMoz
77dafca160
[fenix] Update Android Components version to 63.0.20201013204753.
2020-10-14 13:06:11 -04:00
Mugurell
5cdb7f3a73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15890 - Ensure app locale switcher works for Windows builds
...
A hardcoded unix file separator prevented us from building a proper list of
locales for which we actually have packaged translations.
2020-10-14 15:34:39 +02:00
Mozilla L10n Automation Bot
ad43cd47a2
[fenix] Import l10n.
2020-10-13 20:54:10 -04:00
MickeyMoz
2e53f46560
[fenix] Update Android Components version to 63.0.20201013143114.
2020-10-13 12:53:53 -04:00
ekager
3726b8c98b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15853 - Always set fontSizeFactor setting with new text scale
2020-10-13 09:40:43 -07:00
Mihai Adrian Carare
26854525c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14735 : Remove debug logs from release build. ( https://github.com/mozilla-mobile/fenix/pull/15747 )
2020-10-13 09:17:58 -04:00
Mozilla L10n Automation Bot
f0a7f1bce0
[fenix] Import l10n.
2020-10-12 17:50:57 -07:00
Gabriel Luong
312626f8f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15777 - [Grid View] Set the height of the title to 30dp
2020-10-12 10:38:54 -07:00
Gabriel Luong
f977e5af36
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15758 ⁃ [Grid View] Add a divider between the tab item's title and thumbnail
2020-10-12 10:38:54 -07:00
Gabriel Luong
de0419f182
[fenix] No issue - Commit auto-generated glean changes for metrics.md
2020-10-12 10:26:03 -07:00
MickeyMoz
6b4a65f74b
[fenix] Update Android Components version to 63.0.20201010190133.
2020-10-11 22:55:35 -04:00
Mozilla L10n Automation Bot
031b4687c6
[fenix] Import l10n.
2020-10-11 22:55:02 -04:00
MickeyMoz
0c7bbc8944
[fenix] Update Android Components version to 63.0.20201010143128.
2020-10-11 10:05:45 -04:00
Mozilla L10n Automation Bot
f1753eed23
[fenix] Import l10n.
2020-10-11 10:04:34 -04:00
Grisha Kruglov
53244870e9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15812 : Check for a null context during onScanResult
2020-10-09 20:40:03 -07:00
Mozilla L10n Automation Bot
993335b296
[fenix] Import l10n.
2020-10-09 20:42:16 -04:00
Shen
c63bc04bd2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13168 - Removed the close button from history navigation bar
2020-10-09 20:33:37 -04:00
Michael Comella
4fedc9d719
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - post: link to issue, data review.
2020-10-09 15:47:55 -07:00
Michael Comella
88268c18a1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: clarify init time for External...Activity.
2020-10-09 15:47:55 -07:00
Michael Comella
6c86641cbc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: change extra name to firstFramePreDrawNanos.
2020-10-09 15:47:55 -07:00
sraturi
e97a48b48f
[fenix] for https://github.com/mozilla-mobile/fenix/issues/10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types.
2020-10-09 15:47:55 -07:00
mcarare
69db319601
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13831 : Adjust buttons dimensions to improve a11y.
...
Margins were also adjusted to maintain relative placements.
2020-10-09 15:39:31 -07:00
mcarare
1ca3aab28a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13831 : Add ripple for the copy password button.
2020-10-09 15:39:31 -07:00
ekager
bf2e2d545d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14923 - Removes auto size preference toggle
2020-10-09 15:04:57 -07:00
MickeyMoz
e02c3018eb
[fenix] Update Android Components version to 63.0.20201009143108.
2020-10-09 09:38:04 -07:00
Sijan Rijal
3aaded4868
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15402 : Hide ETP pop-up if the toolbar is not visible ( https://github.com/mozilla-mobile/fenix/pull/15667 )
...
For https://github.com/mozilla-mobile/fenix/issues/15402 : Hide ETP pop-up when top or bottom toolbar is not visible
2020-10-09 16:22:57 +03:00
Sijan Rijal
17fc28304a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15497 : Hide and remove the three dot menu from the Desktop Bookmarks folder ( https://github.com/mozilla-mobile/fenix/pull/15649 )
...
For https://github.com/mozilla-mobile/fenix/issues/15497 : Remove and disable the three dot menu button
2020-10-09 14:39:03 +03:00