In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
* Remove search fragment
* Use new folder to search dialog
* Rebase and lint
* Update tests with search dialog nav directions
* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
This also simplifies how we do this. We're no longer creating instances of `DesktopFolder` class
nor creating copies of BookmarkNodes just to display root titles correctly for the 'edit folder' UI.
This also switches to a simpler bookmarks query API ('getBookmark') which doesn't fetch
children. We don't need 'children' for this dialog, and so don't need to do the extra work.
* Feature flag for ETP cookie purging
* Strings for new ETP description
* Remove icons from ETP info screeen and add category for redirect trackers
* ETP policy factory tests
* Remove icons from ETP panel and add cross tracking allowed field.
* Remove icons on ETP panel. Add blocked category for redirect trackers to panel.
* Add margins to tracking protection settings
* Define intent data for activity
* Search dialog shows permissions for allow and deny camera
* Check camera permissions for fxa pairing
* Check camera permissions for old search
* Tests for pairing sync interactor and controller.
* Cleanup
* Use bool pref for setting. Use interfaces and default implementations for the sync interactor and controller.
* Lint
* Add github actions workflows
* Add github actions for CI
* Fix lint and detekt errors
* Add caching to the github actions
* Add the workflow statuses to the README
* Give the jobs more descriptive names
* Consolidate github actions workflows to a single workflow
* Give the steps meaningful names, save detekt and lint results
engineView.setDynamicToolbarMaxHeight(0) vs
engineView.setDynamicToolbarMaxHeight(toolbarHeight)
ensures webpage's bottom elements are aligned to the bottom of the browser.
We also need to make sure that when the toolbar is static it does not cover the
bottom of the page - something desired when the toolbar was dynamic.
For this the engineView will have a toolbarHeight bottom margin.
Tiger Oakes
Michael Comella
Christian Sadilek
Sebastian Kaspari
mcarare
Abhijit Kiran Valluri
interfect
Abhijit Valluri
ekager
Grisha Kruglov
Kate Glazko
Elise Richards
Jonathan Almeida
Sawyer Blatz
Jocelyne
person808
Jeff Boek
Hakkı Kaan Çalışkan
Sören Hentzschel
Arturo Mejia
codrut.topliceanu
Gabriel Luong
Mugurell
ekager