jhugman
9b651a484b
[fenix] First use of Nimbus FML plugin ( https://github.com/mozilla-mobile/fenix/pull/23400 )
...
* Consume Nimbus FML plugin
* Convert Homescreen to use FML
* Convert nimbusValidation to use FML
* Convert legacy experiments to use the feature API and FML
Remove dead helper code and documentation
* Fixup failing test
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-01-28 12:48:05 +00:00
Grisha Kruglov
4ad2c1c592
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22569 : Remove allopen plugin and Mockable annotations
2021-12-15 12:59:57 +00:00
Sebastian Kaspari
6f4c47613a
[fenix] Update Kotlin and Jetpack Compose versions.
2021-10-25 17:59:17 +02:00
Sebastian Kaspari
0e3f24d8ed
[fenix] Add ktlintFormat Gradle task.
2021-07-30 11:58:02 +00:00
Sebastian Kaspari
fd60cf2ec4
[fenix] Update ktlint.
2021-07-30 11:58:02 +00:00
Sebastian Kaspari
d0717965a9
[fenix] Allow insecure protocol usage when using local Nexus in CI.
2021-07-27 10:08:32 +02:00
Michael Comella
40fed783ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19901 : integrate Jetback Benchmark (microbenchmark).
2021-07-22 15:24:35 +00:00
Sebastian Kaspari
b637a576f2
[fenix] Update to Kotlin 1.5.20, Android Gradle plugin 4.2.2 and Gradle 6.7.1.
2021-07-19 09:20:50 +00:00
Sebastian Kaspari
d9ca412bec
[fenix] Update Kotlin to 1.5.10 (and Coroutines to 1.5.0).
2021-07-19 09:20:50 +00:00
Sebastian Kaspari
80b18d32ab
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17819 : Remove JCenter from build files.
2021-05-26 17:00:01 -04:00
isabelrios
abff667349
[fenix] Stop depending on JCenter - Screengrab and Falcon
2021-05-26 11:04:58 +02:00
Sebastian Kaspari
21b40d89d8
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819 : Update detekt to 1.17.1
2021-05-25 17:19:57 -04:00
Sebastian Kaspari
7c11a19369
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19040 : Remove Leanplum (Nightly)
2021-04-26 19:08:10 +02:00
Sebastian Kaspari
41c5267ba7
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819 : Pull trove4j from Maven Central instead of JCenter.
2021-04-08 23:29:49 -04:00
Sebastian Kaspari
23e25d8f8f
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819 : Get leanplum artifacts from leanplum repository.
2021-02-16 17:27:30 +01:00
Sebastian Kaspari
186570c1ba
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819 : Only use JCenter for specific dependencies.
2021-02-10 10:49:03 +01:00
Sebastian Kaspari
63d0555ee4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819 : Remove JCenter from buildscript repositories.
2021-02-10 10:49:03 +01:00
Sebastian Kaspari
d676df89fb
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819 : Add Maven Central repository.
2021-02-10 10:49:03 +01:00
Michael Comella
0e8148f253
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : update Android Gradle Plugin version.
...
This ensures our custom lint rules are running on the command line.
2020-10-15 09:53:13 -07:00
Michael Comella
7e5cad1e66
[fenix] No issue: run detekt on unit test files.
...
detekt still passes after I make this change.
afaik, there isn't a good reason not to run it on unit tests and it can
be valuable to add custom rules for them. Also, detekt is already
running on our androidTest directory.
2020-10-01 16:06:53 -07:00
Tiger Oakes
053781ffbd
[fenix] Gradle configuration avoidance
2020-09-01 18:58:52 -07:00
Tiger Oakes
d9fe2f0cc9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13404 : Update Android lint URL
2020-08-13 15:58:53 -04:00
Tiger Oakes
3d046dcfa2
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/13404 : Update github checks URL ( https://github.com/mozilla-mobile/fenix/pull/13407 )
2020-08-07 15:39:06 -07:00
Tiger Oakes
233708b122
[fenix] Update LongParameterList baseline
2020-07-27 14:20:34 -04:00
liuche
8932298651
[fenix] CI for PR https://github.com/mozilla-mobile/fenix/pull/9705 ( https://github.com/mozilla-mobile/fenix/pull/12748 )
...
* https://github.com/mozilla-mobile/fenix/issues/3880 . Update detekt to 1.9.1
* https://github.com/mozilla-mobile/fenix/issues/3880 . Use `AbsentOrWrongFileLicense` detekt rule
* https://github.com/mozilla-mobile/fenix/issues/3880 . Update detekt baseline
Co-authored-by: Denys M <dector9@gmail.com>
2020-07-20 15:09:58 -07:00
Tiger Oakes
8171bef320
[fenix] Add links in Checks panel for test/lint tasks ( https://github.com/mozilla-mobile/fenix/pull/12222 )
...
* Add lints in Checks panel for test/lint tasks
* Switch to custom task
* Rename github tasks
2020-07-10 11:24:48 -07:00
Tiger Oakes
01faa91808
[fenix] Migrate some SessionManager usage to BrowserStore ( https://github.com/mozilla-mobile/fenix/pull/10789 )
2020-06-03 11:18:44 -07:00
Johan Lorenzo
8413ec21bc
[fenix] Bug 1625126 - Cache external dependencies in a single task and let gradle tasks use it ( https://github.com/mozilla-mobile/fenix/pull/10316 )
2020-05-13 18:36:48 +02:00
Michael Comella
de6bbb791a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9644 : restrict deps to specific repositories ( https://github.com/mozilla-mobile/fenix/pull/9649 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9644 : remove unnecessary leanplum maven repository.
The docs say it is [1] "only needed for Android SDK versions below 4.3.0".
That is API 18 and our min SDK is 21.
[1]: https://docs.leanplum.com/reference#android-setup
* For https://github.com/mozilla-mobile/fenix/issues/9644 : move buildscript block from :app to root project.
This will reduce the amount of duplication we need in specifying
restricted dependencies and centralize repository definitions. Since
we're a one project app, it shouldn't have a significant impact on
performance.
* For https://github.com/mozilla-mobile/fenix/issues/9644 : restrict dependencies following FFTV config.
However, there is a resolution error to be fixed in the next commit.
This is verbatim from FFTV except I removed the no-op "improve security
if code is refactored incorrectly" lines: these lines rarely changed and
I'm not that concerned. It might be better to simplify the
configuration.
Source:
62a2fa680c/buildSrc/src/main/java/org/mozilla/gradle/Dependencies.kt (L7)
62a2fa680c/build.gradle (L31)
* For https://github.com/mozilla-mobile/fenix/issues/9644 : restrict firebase deps to google repo.
This fixes the resolution error from the previous PR.
2020-04-15 10:54:36 -07:00
Emily Kager
522aca44f4
[fenix] Upgrade to detekt 1.6.0 ( https://github.com/mozilla-mobile/fenix/pull/9306 )
...
Changelog:
https://arturbosch.github.io/detekt/changelog.html
Fixes https://github.com/mozilla-mobile/fenix/issues/7360 . Also use more exact test glob.
Co-authored-by: Andrew Gaul <andrew@gaul.org>
2020-04-01 15:42:46 -07:00
Sebastian Kaspari
4169924754
[fenix] Use pinned Android Components Nightly version instead of snapshots.
2020-03-17 12:09:36 +01:00
Will Hawkins
78e86d8f2b
[fenix] No Issue: Add custom detekt rule to blacklist certain properties
...
Add a custom detekt rule to blacklist certain properties. This is
immediately useful for making sure that developers do not configure
runtime behavior using the `BuildConfig.DEBUG` property but it is
useful in a wider context.
2020-01-17 15:46:32 -08:00
Colin Lee
a9a3fdc1fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4064 : Replace prerelease R8 with improved Kotlin coroutines library ( https://github.com/mozilla-mobile/fenix/pull/7153 )
2019-12-13 13:29:27 -06:00
Gabriel
9ed4f7f119
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5574 - Migrate SessionControl to LibState ( https://github.com/mozilla-mobile/fenix/pull/6651 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (https://github.com/mozilla-mobile/fenix/pull/6651 )
In https://github.com/mozilla-mobile/fenix/issues/2205 , the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Removes TabAction
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 15: Introduce a HomeFragmentStore (https://github.com/mozilla-mobile/fenix/pull/6651 )
- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 20: Remove the architecture module. (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 17: Remove duplicate subscribeToTabCollections in BrowserFragment.kt (https://github.com/mozilla-mobile/fenix/pull/6651 )
There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Renames SessionControlUIView to SessionControlView
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 21: Fix white screen on home fragment (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (https://github.com/mozilla-mobile/fenix/pull/6651 )
This ensures that the metrics.track will be called immediately before the tab is removed from the collection.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 24: Use the sessionManager getter in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Removes running CI against the architecture debug build varient
2019-12-04 22:06:05 -05:00
Colin Lee
b472ab03be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4064 : Old R8 & keep rules are inhibiting optimizations ( https://github.com/mozilla-mobile/fenix/pull/4930 )
2019-08-29 10:16:26 -05:00
Jeff Boek
6ec0801d0c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of detekt
2019-08-21 13:50:51 -07:00
Jeff Boek
40ae66fdbb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of ktlint
2019-08-21 13:50:51 -07:00
Sawyer Blatz
f6a3eff2e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 : Update detekt and ktlint dependenies
2019-08-21 13:50:51 -07:00
Sawyer Blatz
8bd4dc98d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4508 : Treats warnings as errors ( https://github.com/mozilla-mobile/fenix/pull/4543 )
2019-08-07 14:00:53 -07:00
Colin Lee
32ec775443
[fenix] No issue: Add OSS licenses link to About page
2019-08-07 12:40:10 -07:00
Stefan Arentz
264f522b37
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/445 - Ship Fenix x86_64 builds ( https://github.com/mozilla-mobile/fenix/pull/2856 )
2019-05-29 09:19:17 -04:00
Ryan Kelly
36686f3fd8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2555 : Remove appservices gradle plugin, perform megazord substitution by hand.
2019-05-23 08:23:17 -07:00
Grisha Kruglov
59f9a71777
[fenix] Remove custom appservices repository
...
Appservices artifacts are now being manually mirrored to m.m.o.
Eventually, they will be automatically published to m.m.o
2019-04-02 19:17:56 -07:00
Colin Lee
6311a7abd1
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/916 , fixes https://github.com/mozilla-mobile/fenix/issues/917 , fixes https://github.com/mozilla-mobile/fenix/issues/920 : Save, share, and delete bookmarks
2019-04-01 16:16:08 -05:00
Grisha Kruglov
e7e1e8503e
[fenix] Declare appservices repository dependency explicitly
2019-03-26 16:50:14 -07:00
Colin Lee
447b6c9526
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1050 : Fenix sessions save and close upon opening
2019-03-18 08:21:30 -07:00
Colin Lee
0a8fe6ad18
[fenix] No issue: Upgrade to stable Navigation library and ignore ktlint issues in generated code
2019-03-15 12:00:40 -07:00
Colin Lee
5cf2fa2389
[fenix] Fix https://github.com/mozilla-mobile/fenix/issues/1032 : Crash altering sessions DB on main thread
2019-03-15 10:41:02 -07:00
Jeff Boek
cf151c0c1a
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/891 - Adds the leanplum sdk
2019-03-08 14:27:00 -08:00
Grisha Kruglov
0898d23c69
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/309 : Consume Fenix megazord; enable Rust logging
2019-02-27 18:07:05 -05:00