Commit Graph

167 Commits (e294521c923eb4398788d68bd6b21538770e7fa5)

Author SHA1 Message Date
Sawyer Blatz 9251597e84 For #2362: Fixes telemetry for history (#4156) 5 years ago
Emily Kager ae3d187909 For #3987 - Convert History to Lib-State and add tests 5 years ago
Emily Kager 8381025ac5 For #2160 - Hide Keyboard in onPause from EditBookmarkFragment 5 years ago
Sawyer Blatz 11d36b5a00
For #2362: Adds telemetry for history (#3940) 5 years ago
Emily Kager 6b4c160d18 Closes #4080 - Trim New Bookmark Folder Title Text 5 years ago
Tiger Oakes 52d4c43916 Merge some library UIView code for toolbar 5 years ago
ekager 706f7d5961 For #3554 - Add DiffUtil to HistoryAdapter 5 years ago
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 5 years ago
Grisha Kruglov fe51bbcf7b Update FxA integration to new APIs 5 years ago
Emily Kager 9e7282cf18 For #1949 - Fixes bookmark separator appearance, removes menu (#3957) 5 years ago
Emily Kager 21c75ca1bb For #3478 - Add Tab sent snackbar confirmation for device sharing 5 years ago
Tiger Oakes 9901514766 Replace deprecated pxToDp (#3932) 5 years ago
Colin Lee 15d887e41f
For #2251 - Add bookmark adapter diffutil (#3936)
* For #2251 - Add bookmark adapter diffutil

* For #2251 - Fix unit tests for bookmark adapter diffutil
5 years ago
Colin Lee 6bb67a9de7
For #3364: Set bookmark root titles onResume (#3828) 5 years ago
Sawyer Blatz dbe29ebbda
For #3174: Adds telemetry for bookmarks (#3724) 5 years ago
Colin Lee 50052c9b9b
For #3551: Tapping a bookmark/history from Library should open new tab (#3832) 5 years ago
Tiger Oakes 8cd1a0cb38 Move adapter Job setup code to helper class (#3407) 5 years ago
Colin Lee 7473126f7c
For #3784: Crash loading bookmarks while detached (#3787) 5 years ago
Colin Lee 386a3f3acc
For #3785: Crash onDestroy of BookmarkFragment when detached (#3786) 5 years ago
Emily Kager 9142e2279c For #1968 - Adds menu option to add new folder in BookmarkFragment menu 5 years ago
Tiger Oakes 606e66219c No issue: Use chains for bookmark items (#3696)
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
5 years ago
Emily Kager c9962a7ad0 Closes #3701 - When deleted use bookmark title if url is null in snackbar (#3716) 5 years ago
Emily Kager 77edb7afe1 For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list 5 years ago
Tiger Oakes 4994554576 No issue: Adds lint exception for when statement (#3685) 5 years ago
Tiger Oakes 30930cdc88 Import variables referred to by path 5 years ago
Tiger Oakes d01bb8c442 Use lifecycleScope for collections fragments 5 years ago
Tiger Oakes 6bf8d6be34 Use @JvmOverloads instead of multiple constructors 5 years ago
Colin Lee 94e99cf877
For #3364: Edit bookmarks should show corrected bookmarks tree (#3446) 5 years ago
royang51 e244aae104 For #3214 - History multi-selection aborted, the same item can't be selected again (#3607) 5 years ago
Andrei Teslovan 2ebe0a2a48 Fixes #3529 - Display "Edit folder" title when editing a bookmark folder (#3549) 5 years ago
Colin Lee 22bcd70edc
For #3213: Fix multi-select bookmarks on return to fragment (#3413) 5 years ago
Andrei Teslovan e458d8b6a1 Fixes #3365 - Set selectedFolder to null if it's already selected (#3415) 5 years ago
Colin Lee f1088222b4
For #3203: Updates edit bookmarks to have user friendly names (#3372)
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
5 years ago
Colin Lee b498f5559b
For #3333: Only show desktop bookmarks if logged in (#3356) 5 years ago
Sawyer Blatz decacbfc97 For #3323 Runs PublicSuffixList synchronously 5 years ago
Arturo Mejia 5df726715f Revert "For #3008, For #2162 Add Simple Logic for Menu Orientation" (#3310)
#3114
5 years ago
Tiger Oakes 82d2a0661b Remove deprecatd support-ktx methods (#3305) 5 years ago
Sawyer Blatz 45c509fbce
For #2648: Updates trimming of url hostname (#3191)
* For #2648: Updates trimming of url hostname

* For #2648: Fix nits
5 years ago
Colin Lee 1e6da54263 For #3238: fixes race condition crash, nav destination unknown 5 years ago
Jeff Boek f26c402f0a For #2395 - Properly takes you back to where you start authentication on completion 5 years ago
Sawyer Blatz 0b3a8b7a54 For #2316: Adds confirmation dialog to delete bookmark 5 years ago
Emily Kager dc0d153580 For #3008, For #2162 Add Simple Logic for Menu Orientation (#3114)
* For #3008 - Adjust orientation of collections menu based on view location

* For #2162 - Add simple menu orientation logic to bookmark menu
5 years ago
Emily Kager d5a9627273 For #2941 - Remove Delete Dialog, Theme Dialogs (#3052) 5 years ago
Jeff Boek a7d5cdcb9d For #2723 - Fixes theme manager 5 years ago
Sawyer Blatz cd19f36b96 For #2227: Fixes issue with bookmark selection (#3021) 5 years ago
Sawyer Blatz b8c04e02e9 For #2327: Fixes nits 5 years ago
Sawyer Blatz fe50e88fc8 For #2327: Adds error state syncing 5 years ago
Grisha Kruglov 5f42a65c2a No issue: improve allowUndo
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on

New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
5 years ago
Jeff Boek 3920cda693 For #2419 - Adds a deletion state to the history component 5 years ago
Denys M 39df4c8522 For #747. Improve `HistoryFragment` readability. 5 years ago