2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-15 18:12:54 +00:00
Commit Graph

292 Commits

Author SHA1 Message Date
Tim D. Smith
43956c9687 [fenix] Fix case of item extras in browser_menu_action event (https://github.com/mozilla-mobile/fenix/pull/19487)
* Fix case of item extras in browser_menu_action event

Update the event description to match the values observed in telemetry.

* Line length
2021-05-19 11:12:27 -05:00
Roger Yang
2d709b67a7 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19147: Move startup metrics to right after Glean initialization (https://github.com/mozilla-mobile/fenix/pull/19252) 2021-05-05 11:11:02 -04:00
William Lachance
283bae5ff1 [fenix] No issue - Properly quote description for ad metric (https://github.com/mozilla-mobile/fenix/pull/19243)
This is pedantic, but strictly something called <provider-name> is considered an HTML tag
unless it's in a code block (backticks). 

See mozilla/glean-dictionaryhttps://github.com/mozilla-mobile/fenix/pull/549 and mozilla/glean-dictionaryhttps://github.com/mozilla-mobile/fenix/pull/497. I'm going to fix this upstream
but figured I might as well file a PR here to fix the underlying issue.
2021-04-26 19:24:23 -04:00
mcarare
6774f41d26 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18852: Add metrics for default browser settings experiment. 2021-04-20 14:48:07 -04:00
Michael Comella
c7f94915cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: add metric perf.startup.startup_type. 2021-04-16 15:30:26 -07:00
Arturo Mejia
2119cfadae [fenix] Telemetry for https://github.com/mozilla-mobile/fenix/issues/18855, https://github.com/mozilla-mobile/fenix/issues/18851 and https://github.com/mozilla-mobile/fenix/issues/18857
For https://github.com/mozilla-mobile/fenix/issues/18857 [Telemetry] Send a Glean event when users change their default browser

For https://github.com/mozilla-mobile/fenix/issues/18855 [Telemetry] Send an event when users open the toolbar menu

For https://github.com/mozilla-mobile/fenix/issues/18851 [Telemetry] Send an event when users click on the "set as default browser" entry in the toolbar menu
2021-04-15 11:29:13 +03:00
Roger Yang
4f9a341746 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18948: Update tabstray telemetry (https://github.com/mozilla-mobile/fenix/pull/19004) 2021-04-14 15:32:45 -04:00
mcarare
8e8a872127 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18854: Add metrics for home screen being displayed. 2021-04-14 21:21:28 +03:00
mcarare
9dede18ff5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18853: Add metrics for default browser new tab experiment. 2021-04-14 19:22:27 +03:00
mcarare
4ff47f6c1d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18856: Add metrics for opening settings screen from home menu. 2021-04-14 18:50:15 +03:00
Michael Comella
073a4dc221 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: note refactor in metrics docs. 2021-04-13 15:10:36 -07:00
Michael Comella
c04e4f392d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18836: replace StartupActivityStateProvider with StartupStateProvider.
The StartupActivityStateProvider uses an imperative implementation,
driven by callbacks, to set the state of the application. This is hard
to follow as you need to understand which callbacks will be called in
which order. For example, to make sense of an implementation like this,
COLD, WARM, AND HOT would likely need to be implemented in separate
ActivityLifecycleCallbacks.

I feel the StartupStateProvider is an improvement because it leverages
the StartupActivityLog to query a linear state for a more understandable
implementation. Furthermore, it seems accessible to write COLD, WARM,
and HOT in the same class because they can all be approached the same
way.
2021-04-13 15:10:36 -07:00
Sebastian Kaspari
a23da507c5 [fenix] Introduce process lifecycle observer to collect metrics about tabs when app goes to foreground/background. 2021-04-09 12:36:27 +02:00
Grisha Kruglov
242ea763de [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17361: Extend perf.awesomebar.* metrics 2021-04-06 11:50:08 -07:00
Michael Comella
b26d782c2f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add data review links. 2021-03-30 10:38:44 -07:00
Michael Comella
9c3ad5608a [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: warn about flaw in app_opened_all_startup probe. 2021-03-30 10:38:44 -07:00
Michael Comella
c5bfc690d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: record cold start duration telemetry. 2021-03-30 10:38:44 -07:00
Michael Comella
f5accce70f [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add StartupActivityStateProvider.
This will be used to filter conditions for the start up telemetry we're
adding.
2021-03-30 10:38:44 -07:00
Michael Comella
ee31fe29c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add ApplicationStartReasonProvider.
We need to know this state to add a correct COLD MAIN probe.
2021-03-30 10:38:44 -07:00
Michael Droettboom
2fb552617a [fenix] Bug 1689162: Update Glean metrics.yaml schema (https://github.com/mozilla-mobile/fenix/pull/18683) 2021-03-29 11:53:45 -04:00
Roger Yang
e1404fab67 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17644: Record when user taps on a add-on's setting (https://github.com/mozilla-mobile/fenix/pull/18504) 2021-03-24 14:31:39 -04:00
Michael Comella
3b2bda7c81 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add measurement probes for long-running lifecycle methods.
In addition to the existing probes for onCreate, this should cover all
lifecycle methods that take a long time in our profiles.
2021-03-19 17:41:03 -07:00
Michael Comella
1f67254b10 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18426: add telemetry for app.onCreate subsections.
Hopefully this will help us understand behavior of the
`application_on_create` probe, specifically that it seems to take longer
in telemetry than in does locally compared to `home_activity_on_create`
(comparing the medians to local runs)..
2021-03-19 11:52:29 -07:00
Mugurell
78b7d0e95c [fenix] For https://github.com/mozilla-mobile/fenix/issues/17869 - New AndroidKeystoreExperiment telemetry 2021-03-15 13:35:49 -07:00
mcarare
1c8387fdb9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17768: Renew telemetry expiring in March. 2021-03-15 19:59:38 +02:00
mcarare
ebde904cfd [fenix] For https://github.com/mozilla-mobile/fenix/issues/18076: Renew telemetry expiring in April. 2021-03-15 19:59:24 +02:00
Roger Yang
1ca7dc61ab [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18178: Rework History Telemetry (https://github.com/mozilla-mobile/fenix/pull/18261) 2021-03-08 19:15:29 -05:00
Roger Yang
f0dcb64716 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18173: Add Telemetry When User Opens a Bookmark (https://github.com/mozilla-mobile/fenix/pull/18174) 2021-03-08 17:11:59 -05:00
Roger Yang
b8342ac6f0 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18068: Use AwesomeBarFacts for AwesomeBar Telemetry (https://github.com/mozilla-mobile/fenix/pull/18090) 2021-03-08 16:34:52 -05:00
Roger Yang
70329154e5 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18163: Use SyncedTabsFacts for Synced Tab Telemetry (https://github.com/mozilla-mobile/fenix/pull/18172) 2021-03-08 15:21:00 -05:00
Sebastian Kaspari
aca64b6eae [fenix] metrics.yaml: Update data review link of engine_tab.kill_foreground_age metric. 2021-03-03 09:23:32 +02:00
Sebastian Kaspari
1368a9bd19 [fenix] Fix metric types of engine telemetry. 2021-03-01 13:10:05 +01:00
Michael Comella
a0f46da9ad [fenix] For https://github.com/mozilla-mobile/fenix/issues/18157: convert clock_ticks_per_second to quantity type.
While we could easily move this into the metrics ping, it's better to
leave it in the other ping because it's less work and because (I think)
we'll be better able to match `framework_secondary` values to the clock
ticks if we combine them in the same ping.
2021-02-26 16:12:59 -08:00
Michael Comella
188fe713ed [fenix] For https://github.com/mozilla-mobile/fenix/issues/17972: split frameworkStart into two metrics.
We do this in order to make it easier to analyze in GLAM: see the metric
descriptions for more details.

Additionally, we change the time unit to milliseconds to make it easier
to analyze in GLAM.
2021-02-19 13:21:31 -08:00
Michael Comella
3ae7379a5f [fenix] For https://github.com/mozilla-mobile/fenix/issues/17969: add duration probes for App.onCreate and HomeActivity.onCreate. 2021-02-19 13:20:34 -08:00
Roger Yang
998a10cdc9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17089: Add metric to track both normal and private URI opened (https://github.com/mozilla-mobile/fenix/pull/17935) 2021-02-19 10:37:07 -05:00
Sebastian Kaspari
5fec5b8d61 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/12731: Collect telemetry about the content process of tabs getting killed. 2021-02-19 11:32:56 +01:00
Codrut Topliceanu
942195bfae [fenix] For https://github.com/mozilla-mobile/fenix/issues/17418 - Added telemetry for Google Default Top Site (https://github.com/mozilla-mobile/fenix/pull/17637)
* For https://github.com/mozilla-mobile/fenix/issues/17418 - Adds channel "ts" to TrackKey

This is used to track if the `InContentTelemetry` is a result of the user using the Google Top Site. It looks for `&channel=ts` within the uri.

* For https://github.com/mozilla-mobile/fenix/issues/17418 - Adds TopSite PerformedSearch back in

* For https://github.com/mozilla-mobile/fenix/issues/17418 - Check now looks for equality with GOOGLE_URL

* For https://github.com/mozilla-mobile/fenix/issues/17418 - Adds test for topSite changes
2021-02-11 11:31:01 -05:00
Gabriel Luong
1430e127b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17418 - Add event ping telemetry for the Google Top Site click (https://github.com/mozilla-mobile/fenix/pull/17862)
Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2021-02-05 12:06:32 -05:00
Elise Richards
b41d6160e5 [fenix] Increase date on expired metrics (https://github.com/mozilla-mobile/fenix/pull/17766) 2021-02-02 12:27:10 -06:00
Michael Comella
76864a8ece [fenix] For https://github.com/mozilla-mobile/fenix/issues/17553: renew storage.stats metrics. 2021-02-01 16:33:08 -05:00
Codrut Topliceanu
5e78e43440 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16828 - Adds telemetry for open in app banner (https://github.com/mozilla-mobile/fenix/pull/17049)
* For https://github.com/mozilla-mobile/fenix/issues/16828 - Adds telemetry for open in app banner

Specifically: Banner displayed, Dismiss action, Go to Settings action.
2021-01-29 10:14:32 +02:00
Elise Richards
fcf3c5f57a [fenix] For https://github.com/mozilla-mobile/fenix/issues/16485: Tabs tray grid view telemetry (https://github.com/mozilla-mobile/fenix/pull/17442)
* Tabs tray CFR telemetry interactions

* Create CFR events and implementation

* Tests for tab tray controller
2021-01-25 15:25:56 -06:00
Codrut Topliceanu
2f57dcfdac [fenix] For https://github.com/mozilla-mobile/fenix/issues/17481 - Remove unused long_press_tapped metric (https://github.com/mozilla-mobile/fenix/pull/17544) 2021-01-21 10:02:26 +02:00
Codrut Topliceanu
b71d813d64 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11580 - Tracks text selection context menu usage (https://github.com/mozilla-mobile/fenix/pull/16968)
* For https://github.com/mozilla-mobile/fenix/issues/11580 - Tracks text selection context menu usage

Tracks Copy, Search, Select All and Share items from the text selection context menu. Uses AC's DefaultSelectionActionDelegate to achieve this.

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2021-01-04 16:28:01 +02:00
Mugurell
4ee2151e75 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11578 - Cleanup download telemetry - metrics ping reference
These pings were implemented first as counters.
When changing to events "send_in_pings: - metrics" still remained causing
confusion.
This patch comes to remove this confusion and potential future issues.
2020-12-16 15:17:11 +02:00
Mugurell
a50340fd25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15367 - Cleanup metrics ping reference (https://github.com/mozilla-mobile/fenix/pull/17071)
These pings were implemented first as counters.
When changing to events "send_in_pings: - metrics" still remained causing
confusion.
This patch comes to remove this confusion and potential future issues.
2020-12-16 14:00:48 +02:00
mcarare
78195c8368 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16827: Send copy url metrics correctly. 2020-12-16 13:50:38 +02:00
mcarare
4d286d91ce [fenix] For https://github.com/mozilla-mobile/fenix/issues/15369: Send synced tabs metrics correctly. 2020-12-16 13:45:55 +02:00
Gabriel Luong
29e329d8f1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16941 - [Telemetry] Bookmark Counts (https://github.com/mozilla-mobile/fenix/pull/16942) 2020-12-15 11:30:24 -05:00
Codrut Topliceanu
35eaf646a9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15368 - Adds telemetry for fullscreen, pip (https://github.com/mozilla-mobile/fenix/pull/16833) 2020-12-15 14:46:15 +02:00
mcarare
20cff480b7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16827: Add documentation for copy url metrics. 2020-12-15 12:14:27 +02:00
mcarare
1e9604d03a [fenix] For https://github.com/mozilla-mobile/fenix/issues/15369: Add documentation for synced tabs opening metrics. 2020-12-15 11:36:47 +02:00
mcarare
d404bd76d2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15366: Add documentation for recently closed tabs metrics. 2020-12-15 10:52:11 +02:00
Mugurell
6019e8c907 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15367 - DownloadsFragment telemetry (https://github.com/mozilla-mobile/fenix/pull/16728)
Adds a counter for how many times the user does the following action:
- opens the Downloads section inside the app
- tap to open an item from inside Downloads / from the download dialog
- tap to delete one or more downloads at once
2020-12-15 09:14:20 +02:00
Mugurell
cf4631c5c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11578 - Add telemetry for how many times we download something (https://github.com/mozilla-mobile/fenix/pull/16730) 2020-12-15 08:39:22 +02:00
Roger Yang
9dee73b238 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16075: Add distribution_id in telemetry startup metrics (https://github.com/mozilla-mobile/fenix/pull/16821) 2020-12-10 09:36:05 -05:00
Mugurell
6486465645 [fenix] For https://github.com/mozilla-mobile/fenix/issues/16076 - Link data review for the share_image telemetry (https://github.com/mozilla-mobile/fenix/pull/16534) 2020-11-12 20:14:59 +02:00
ekager
c129fa2aba [fenix] For https://github.com/mozilla-mobile/fenix/issues/16132 - Rename normal mode menu item, remove telemetry 2020-11-12 09:11:16 -08:00
Codrut Topliceanu
23ff2851e6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15720 - Remove unused telemetry (https://github.com/mozilla-mobile/fenix/pull/15887) 2020-11-09 17:24:46 -05:00
Mihai Adrian Carare
5fb5471df1 [fenix] For # 15929: Remove the search widget discoverability experiment. (https://github.com/mozilla-mobile/fenix/pull/16081)
* For https://github.com/mozilla-mobile/fenix/issues/15929: Remove SearchWidgetCFR telemetry.

* For https://github.com/mozilla-mobile/fenix/issues/15929: Remove SearchWidgetCFR and search widget experiment.

* For https://github.com/mozilla-mobile/fenix/issues/15929: Remove unit tests references to search widget experiment.
2020-10-28 13:46:02 -07:00
ekager
9d876a7076 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15347 - Adds telemetry for tabs settings 2020-10-14 22:53:31 -04:00
Michael Comella
4fedc9d719 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - post: link to issue, data review. 2020-10-09 15:47:55 -07:00
Michael Comella
6c86641cbc [fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: change extra name to firstFramePreDrawNanos. 2020-10-09 15:47:55 -07:00
sraturi
e97a48b48f [fenix] for https://github.com/mozilla-mobile/fenix/issues/10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types. 2020-10-09 15:47:55 -07:00
Chenxia Liu
7ad5f26333 [fenix] Adding link data review request 2020-10-07 11:02:42 -07:00
Chenxia Liu
5ffe145425 [fenix] startup.timeline 2020-10-07 11:02:42 -07:00
Chenxia Liu
86db33910d [fenix] sync, sync_items, telemetry, theme, toolbar_position,
tracking_protection, default_engine
2020-10-07 11:02:42 -07:00
Chenxia Liu
073321049c [fenix] accesssibility, open_links, remote_debugging, search_suggestions,
show_search
2020-10-07 11:02:42 -07:00
Chenxia Liu
7f14d314cb [fenix] search_count, search_widget, tabs_count, toolbar_position 2020-10-07 11:02:42 -07:00
Chenxia Liu
bba0353993 [fenix] has, count: open_tabs, pwa, top_sites 2020-10-07 11:02:42 -07:00
Chenxia Liu
03b5b9f4e8 [fenix] default*browser, mozilla_products 2020-10-07 11:02:42 -07:00
Chenxia Liu
83d6b8d559 [fenix] browser.search, events.total_uri_count, metrics.adjust* 2020-10-07 11:02:42 -07:00
Chenxia Liu
93a4cab155 [fenix] first_session 2020-10-07 11:02:42 -07:00
Chenxia Liu
bf68ea27c5 [fenix] user_specified_search_engine, voice_search 2020-10-07 11:02:42 -07:00
Chenxia Liu
ade609c3ac [fenix] top_sites, tracking_protection 2020-10-07 11:02:42 -07:00
Chenxia Liu
bb3332478b [fenix] tab, tabs_tray, toolbar_settings 2020-10-07 11:02:42 -07:00
Chenxia Liu
278ac8007d [fenix] syenc_account, sync_auth 2020-10-07 11:02:42 -07:00
Chenxia Liu
ed317ac898 [fenix] search_suggestions, search_shortcuts, search_widget 2020-10-07 11:02:42 -07:00
Chenxia Liu
9e4dfdf37c [fenix] private_browsing, qr_scanner 2020-10-07 11:02:42 -07:00
Chenxia Liu
71b1684c5b [fenix] pocket, onboarding 2020-10-07 11:02:42 -07:00
Chenxia Liu
41cb9084bf [fenix] logins, media_notification, media_state 2020-10-07 11:02:42 -07:00
Chenxia Liu
1838f130d1 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/14142 - find_in_page, history, reader_mode, tip 2020-10-07 11:02:42 -07:00
Sawyer Blatz
1a5a88be4b [fenix] For https://github.com/mozilla-mobile/fenix/issues/14565: Add telemetry for top sites 2020-09-17 10:06:39 -07:00
ekager
793b27980d [fenix] For https://github.com/mozilla-mobile/fenix/issues/13926 - MP migration 2020-09-01 16:27:51 -07:00
Michael Droettboom
82e4291457 [fenix] Fix a typo in metric expiry. (https://github.com/mozilla-mobile/fenix/pull/14530)
This was changed to 2020-04-01 in c90c09e2eb697c68b86c1a321c0fca97aa86dca4

I assume this was just a typo, since a lot of metrics got changed to 2021-04-01
in the same commit.
2020-08-31 09:39:39 -07:00
Sachin
8025efc0d7 [fenix] for https://github.com/mozilla-mobile/fenix/issues/12573, added startup type and hasSavedInstance keys to app_startup_type telemetry (https://github.com/mozilla-mobile/fenix/pull/13494) 2020-08-26 23:14:13 -07:00
liuche
56821f7270 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12046 - Renew telemetry probes before migration completion (https://github.com/mozilla-mobile/fenix/pull/13958)
* For https://github.com/mozilla-mobile/fenix/issues/12046 - Renew telemetry probes before migration completion
* Delay remaining probes renewal for one more month.
2020-08-25 10:45:02 -07:00
Michael Comella
e2cd23ab93 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14133: warn opened_link telemetry may be wrong. 2020-08-25 08:39:42 -07:00
Michael Droettboom
c38fe720ed [fenix] Bug 1608838: Add data sensitivity metadata 2020-08-17 17:17:38 -07:00
Elise Richards
1e7d4c3e80 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10261: PWA Telemetry (https://github.com/mozilla-mobile/fenix/pull/11859)
* Add PWA events to metrics.

Track events for add to homescreen and install.

Map PWA facts to events

* Map component facts to local metrics

Add events pings to fragments

Supress long method for events

Move install event to AC and collect facts

Retrieve fg and bg events from Facts. Do not track intent fg/bg events, only views

* Allow onPause in base fragment to send telemetry for PWA in the external app fragment. Track foreground and bg locally in fenix, and route install and home screen taps from AC facts

* Rebase
2020-08-03 13:59:31 -05:00
Michael Comella
56b2adf7e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12802 - review: update metrics for data review. 2020-07-31 16:05:06 -07:00
Michael Comella
19abae1155 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12802: add StorageStats glean metrics. 2020-07-31 16:05:06 -07:00
Jeff Boek
d2d7fceb94 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11579 - Adds telemetry for autoplay settings in Site Permissions 2020-07-29 15:10:25 -07:00
Sawyer Blatz
2a5fdd6054 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9730: Add Login Dialog Prompt telemetry 2020-07-29 12:59:35 -07:00
sraturi
adfcf08a49 [fenix] for https://github.com/mozilla-mobile/fenix/issues/11830 created class containing the logic for sending AllStartup telemetry logic
lint check

renamed the intentReceived telemetry to appOpenedAllSource

added comments

removed unused code

moved lifecycle process to AppAllSourceStartTelemetry

moved tracking event out of init function

lint fix

moved appAllStartTelemetry to components

added bit more info about the metrics

added the  onReceivedIntent metric back

minor fix

change discriptions based on the comments frm MR

wrote test cases for AppAllSourceStartTelemetry.kt

lint fix

test case to mock application going background

post rebase:

post rebase:

fixed nit from comments

fixed nit from comments

fixed nit from comments

lint fix

lint fix
2020-07-28 17:09:42 -07:00
Elise Richards
5b46f572df [fenix] For https://github.com/mozilla-mobile/fenix/issues/10173: login duplicates and save (https://github.com/mozilla-mobile/fenix/pull/11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
2020-07-16 17:08:04 -05:00
Chenxia Liu
a564b2a2fc [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/12044 - Bump expiry by 1mo for release 2020-06-26 18:28:46 -07:00
Sachin
10a018b0b2 [fenix] for https://github.com/mozilla-mobile/fenix/issues/11830 added new metric for collecting startup method from all startup phases (https://github.com/mozilla-mobile/fenix/pull/11940)
* for https://github.com/mozilla-mobile/fenix/issues/11830 added new metric for collecting startup method

move all source startup telemetry into its own logic and added an UNKOWN state

* switched back to onNewIntent solution

* renamed the metric
2020-06-26 17:38:08 -07:00
Sawyer Blatz
44ef22425b [fenix] For https://github.com/mozilla-mobile/fenix/issues/11479: Record open tabs count in metrics ping (https://github.com/mozilla-mobile/fenix/pull/12024) 2020-06-26 17:15:43 -07:00