Commit Graph

505 Commits (d9d01db7cc7a9bd66472d2c2dc6b86d6d1a2cc34)

Author SHA1 Message Date
mcarare d9d01db7cc For #25980: Replace deprecated setHasOptionsMenu with MenuProvider. 2 years ago
Roger Yang 3f7391a322 Close #27147: Add telemetry for bookmark search 2 years ago
Roger Yang e81da189cd Close #24498: Add test for history search telemetry 2 years ago
Roger Yang bc1cfb88e8 Revert "For #11404 - Create open all function"
This reverts commit 9cf42cb7d9.
2 years ago
Roger Yang dff4c31606 Revert "For #11404 - Add 'Open all in private tabs' option as requested."
This reverts commit fe16a81c1d.
2 years ago
Roger Yang cfa376e5d2 Revert "For #11404 - Create alert message when a lot of tabs are to be opened."
This reverts commit c75e331a30.
2 years ago
Pg c75e331a30 For #11404 - Create alert message when a lot of tabs are to be opened.
Current threshold is 15.
2 years ago
Pg fe16a81c1d For #11404 - Add 'Open all in private tabs' option as requested.
https://github.com/mozilla-mobile/fenix/pull/21212#discussion_r739172674

- Add option is tree dot menu
- Edit folder opening to be aware of browsing mode
- Add metrics
- Add unit tests for 'Open all in private tabs'
- Add Android tests for open all in private.
2 years ago
Pg 9cf42cb7d9 For #11404 - Create open all function
- Create element to be displayed

- Update the interface and bind in the view holder
Set the filter to limit this action to FOLDER.

- Create core function
Main logic is done on the controller (has it should be done). The whole
process is done in one coroutine to be non-blocking as many
(sub)folders & links can be present. If folder is empty, a toast is
displayed. Else iterate on items. When item is:
- a FOLDER -> restart process (without toast) on the folder
- a ITEM -> open it
- a SEPARATOR -> do nothing
Once finished, show the tabs tray.

Toast message is defined in fragment to have access to context.

- Create androidTest for openAllInTabs
- Create tests for handleBookmarkFolderOpening
- Display 'open all' options only if folder has at least on child:
A coroutine and suspended functions have to be used, since `getTree`
is async.
2 years ago
mcarare ffcef5ff2e For #26844: Fix ktlint issues and remove them from baseline. 2 years ago
Roger Yang 30814884b5 For #26502: Add time group and private extras in history telemetry 2 years ago
mike a cb3f620507 Closes #26530: add top spacing to header in history list 2 years ago
mike a 8e4effe70a Revert "Closes #25967: add classes to support multiple viewHolders"
This reverts commit f910fcfe76.
2 years ago
mike a c90debfe15 Revert "Closes #24307: add synced history empty fragment, feature flag and history screen showing only local files 2 years ago
mike a 3434c702de Closes #26502: add isLocal parameter for history openItem telemetry event 2 years ago
mavduevskiy 40ef60ca87 Revert "Closes #25942: use HistoryFragment to show synced history"
This reverts commit 6483e1c647.
2 years ago
Alexandru2909 ec4ad984c2 For #26239 - Avoid displaying multiple download items for the same file 2 years ago
mike a 6483e1c647 Closes #25942: use HistoryFragment to show synced history 2 years ago
mcarare 11a7085e46 For #26197: Cancel history list update on fragment destroyed. 2 years ago
mike a 063a09782a Issue #26101: add telementry for deleting history time range 2 years ago
mike a 7982c6b79f Close #25954: add a new delete time range confirmation dialog for history screen 2 years ago
mike a f910fcfe76 Closes #25967: add classes to support multiple viewHolders 2 years ago
Roger Yang 7a5e126f24 Issue #24740: Use unified search bar in bookmark search 2 years ago
Roger Yang 22ac345513 Issue #24740: Use unified search bar in history search 2 years ago
mcarare e81c38e8fd For #25563: Avoid showing delete all dialog twice. 2 years ago
mcarare 78e4875713 For #25563: Ensure popBackStack does not navigate away from HistoryFragment. 2 years ago
mcarare ed480b24c4 For #25563: Show Snackbar only if fragment is still attached. 2 years ago
sunil9211 f89e2f4aca For #20848 - Hide Download List delete icon in multiselect mode 2 years ago
mike a 3904cb9340 Closes #25368: duplicate items in history
Change pagination to be based on loadSize of DataSource
2 years ago
JLRoberts 479e44b0a1 For #23700 - HistoryFragment: Exit edit mode when multi-selection is opened in tabs or shared.
This mirrors behavior currently in Bookmarks library with the same actions.
2 years ago
Roger Yang 7f29461c75 Issue #24299: Add history to the search engine menu 2 years ago
mcarare ffa1ecd300 For #21292: Remove unused MetricController parameters. 2 years ago
mcarare f028dbc03b For #25003: Pop back stack on main thread. 2 years ago
mike a 8e9464fee3 Closes #24307: add synced history empty fragment, feature flag and history screen showing only local files 2 years ago
mike a a066dddce9 Closes #24513: add undo snackbar to history group screen 2 years ago
mavduevskiy 602f55b5d2
For #23665 - Make the undo snackbar for the library screens work globally (#24398)
* Closes #23665: make snackbar work after leaving the fragment it was initiated from

* Closes #23665: bring back the removed bookmark navigation test, sort imports alphabetically

Co-authored-by: mike a <mavduevskiy@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
Arturo Mejia 5982990e17 For #20872: Prevent crash when updating pending Bookmarks to be deleted without a selected folder. 2 years ago
Mugurell a6871f9b7e For #11753 - Update compose to 1.1.1 and Kotlin to 1.6.10
The needed changes are around supporting exhaustive whens for sealed classes
as a new kotlin feature - https://kotlinlang.org/docs/whatsnew1530.html#exhaustive-when-statements-for-sealed-and-boolean-subjects

androidx_activity_compose was removed as a dependency since it isn't used.

Used 1.6.10 for Kotlin although 1.6.20 is available to prevent any issues with
Compose 1.1.1 reported as an error at compile time:
"e: This version (1.1.1) of the Compose Compiler requires Kotlin version 1.6.10
but you appear to be using Kotlin version 1.6.20 which is not known to be
compatible. Please fix your configuration (or
`suppressKotlinVersionCompatibilityCheck` but don't say I didn't warn you!)."
2 years ago
Alexandru2909 e571f0bb3a For #24498 - Remove Event.wrapper for History metrics 2 years ago
mcarare a9c41774ea For #24210: Remove wrapper from recently closed tabs opened event. 2 years ago
Roger Yang 36c271cab3 Close #24550: Hide edit suggestion button for history and bookmarks search suggestions 2 years ago
Alexandru2909 54e17f4e2d For #24512 - Remove Event.wrapper for RecentlyClosedTabs metrics 2 years ago
Alexandru2909 82901297cb For #24214 - Move bookmark removal events to BookmarkController 2 years ago
Alexandru2909 0a5b8c49a0 For #24214 - Remove Event.wrapper for BookmarksManagement metrics 2 years ago
mike a a0f02b27be Closes #24276: add documentation to classes marked as UndocumentedPublicClass by lint 2 years ago
mike a 8ca01de0fa Closes #24276
– capitalize and stylize comments
– fix history items duplication
– fix refresh glitching after removing multiple history items
2 years ago
mike a ebf4ce2fe7 Closes #24276:
– remove unused import
– remove HistoryViewModel
2 years ago
mike a 5b481ad204 Closes #24276:
– make comments inside HistoryDataSource capitalized and informative
– remove scroll to first item in swipe-to-refresh
– change adapter initialization
– fixed SitePermissionsExceptionsFragment flickering empty state
2 years ago
mike a 548ff770f3 Closes #24276: removed unused Log import 2 years ago
mike a b934f3659c Closes #24276: fix history list displaying empty state until refresh 2 years ago