Sawyer Blatz
e247870b9f
For #5277 : Updates string for delete browsing data ( #5309 )
5 years ago
Mihai Adrian
c8bc144114
For #2570 : Hide 3-dots menu when in select mode for bookmarks and history ( #5173 )
...
Show or hide overflow menu for entire list is triggered when mode is changed
For bookmarks, due to implementation of selection and diffUtil,
additional check is necessary for current item (last selected) that is redrawn
5 years ago
Tiger Oakes
4acf48e817
Fixes #5212 - Change tint in onCreateOptionsMenu
...
Also fixes #5213
5 years ago
Tiger Oakes
d0ef2d40c2
Move bookmark navigation listener to separate file
5 years ago
Sawyer Blatz
cd533854e6
No issue: Only use iconTint in XML for bookmark menus ( #5145 )
5 years ago
Grisha Kruglov
231924f5eb
Fix breaking services APIs changes
5 years ago
Sebastian Kaspari
ba05d21657
Fix ktlint MaxLineLength issues.
5 years ago
Sebastian Kaspari
38d97fda8b
Stores: Reduce visibility of reducer functions.
5 years ago
Sebastian Kaspari
2723a55b03
Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action.
5 years ago
Sebastian Kaspari
76063e307a
Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action.
5 years ago
Colin Lee
709588572a
For #5055 : Crash when opening bookmarks ( #5058 )
5 years ago
Suraj Shah
66a8c04967
Fixes #4488 : Shows snackbar on bookmark deletion from edit fragment ( #4792 )
...
* Fixes #4488
Updates changelog
* Removes wildcard imports.
* Removes custom label in use, replaces with let
5 years ago
Emily Kager
a65f220b39
For #4921 - Adds WindowFeature to BaseBrowserFragment
5 years ago
Sourabh
091778a4b9
For #4398 - add HistoryController ( #4837 )
5 years ago
ekager
ffbbe119f3
For #3967 - Invoke pending deletion on back pressed
5 years ago
Tiger Oakes
c475bc87cf
Move classes out of top-level package
5 years ago
Jeff Boek
68f5d211d3
For #4326 - Updates codebase to support latest version of detekt
5 years ago
Emily Kager
c1b1c2f332
For #3967 - Invokes pending deletion with more bookmark actions ( #4522 )
5 years ago
Mugurell
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
5 years ago
Grisha Kruglov
b38b94ed79
Closes #4671 : Fix a potential NPE in BookmarkFragment
5 years ago
Grisha Kruglov
634ee184a6
No issue: add some BookmarkFragmentInteractor tests
5 years ago
Grisha Kruglov
f323105163
No issue: reduce code duplication in BookmarkFragmentInteractor
5 years ago
Tiger Oakes
52542708aa
Consodilate private browsing code
5 years ago
Sawyer Blatz
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
5 years ago
Emily Kager
8194e0778e
For #4026 - Update BookmarkDiffUtil to update on Title or URL change
5 years ago
Emily Kager
0604e9858d
Closes #3939 - Adds strings for delete browsing history
5 years ago
ValentinTimisica
71aedc79fe
Fixes #3922 : Added accessibility announcement for history empty state.
...
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
5 years ago
Emily Kager
23bc8f4320
Fro #4563 - Update delete button alpha when history mode changes
5 years ago
Tiger Oakes
3c1ce90f6f
Fixes #2379 - Generic library selection
5 years ago
Emily Kager
6f7ae227a8
Closes #4540 - Set correct tint for select bookmark folder icon ( #4541 )
5 years ago
Emily Kager
a526e0fad3
For #4455 - Rename history headers by hours and days ( #4478 )
5 years ago
Sören Hentzschel
bfd4849064
For #1427 - enter multi select mode with single click on favicon in library
5 years ago
Nikit Bhandari
671727c3e8
For #4341 use camelCase for views referenced from code
5 years ago
Tiger Oakes
6e2ea0750e
Issue #2379 - Use LibrarySiteItemView in history
5 years ago
mihai-adrian
bac2e40eb2
fixes #4435 - changed title of menuitem for delete and added content description
...
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
5 years ago
Jonathan Almeida
ec96d134ff
No issue: Fix breaking AccountObserver API
5 years ago
Colin Lee
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
5 years ago
Tiger Oakes
c342a680d8
Fix crash for bookmarks
5 years ago
Emily Kager
d42e72fd8b
Closes #4462 - Adjust layout params of select bookmark folder view
5 years ago
Tiger Oakes
ccae66c08a
Issue #2379 - Use LibraryPageView in history
5 years ago
Jeff Boek
2813a3cff7
For #4441 - Keeps the ID 0 based for the recyclerview
5 years ago
Jeff Boek
a75c2f7cfb
No Issue - Fixes the offset key to prevent endless history bug
5 years ago
Jeff Boek
af449c84d5
For #4137 - Fixes HistoryInteractorTest
5 years ago
ekager
4494e40dbc
For #4137 - Adds pagination to the history view
5 years ago
Tiger Oakes
2467588c4a
Create shared custom view for library items
5 years ago
James Hugman
ac359f6970
Closes #1331 - Filter consecutive history items using simplified URL
5 years ago
Tiger Oakes
88c05a5f43
Use glide-like image loading function
5 years ago
Tiger Oakes
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
5 years ago
Christian Sadilek
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
5 years ago
Colin Lee
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
5 years ago
ValentinTimisica
4747f2c165
Fixes #4161 : Modified style of bookmark_folders_sign_in button. ( #4291 )
...
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
5 years ago
Tiger Oakes
edb0a3ed08
For #3633 - Update StoreProvider to use a callback
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
5 years ago
Sawyer Blatz
9251597e84
For #2362 : Fixes telemetry for history ( #4156 )
5 years ago
Emily Kager
ae3d187909
For #3987 - Convert History to Lib-State and add tests
5 years ago
Emily Kager
8381025ac5
For #2160 - Hide Keyboard in onPause from EditBookmarkFragment
5 years ago
Sawyer Blatz
11d36b5a00
For #2362 : Adds telemetry for history ( #3940 )
5 years ago
Emily Kager
6b4c160d18
Closes #4080 - Trim New Bookmark Folder Title Text
5 years ago
Tiger Oakes
52d4c43916
Merge some library UIView code for toolbar
5 years ago
ekager
706f7d5961
For #3554 - Add DiffUtil to HistoryAdapter
5 years ago
Tiger Oakes
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
5 years ago
Grisha Kruglov
fe51bbcf7b
Update FxA integration to new APIs
5 years ago
Emily Kager
9e7282cf18
For #1949 - Fixes bookmark separator appearance, removes menu ( #3957 )
5 years ago
Emily Kager
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
5 years ago
Tiger Oakes
9901514766
Replace deprecated pxToDp ( #3932 )
5 years ago
Colin Lee
15d887e41f
For #2251 - Add bookmark adapter diffutil ( #3936 )
...
* For #2251 - Add bookmark adapter diffutil
* For #2251 - Fix unit tests for bookmark adapter diffutil
5 years ago
Colin Lee
6bb67a9de7
For #3364 : Set bookmark root titles onResume ( #3828 )
5 years ago
Sawyer Blatz
dbe29ebbda
For #3174 : Adds telemetry for bookmarks ( #3724 )
5 years ago
Colin Lee
50052c9b9b
For #3551 : Tapping a bookmark/history from Library should open new tab ( #3832 )
5 years ago
Tiger Oakes
8cd1a0cb38
Move adapter Job setup code to helper class ( #3407 )
5 years ago
Colin Lee
7473126f7c
For #3784 : Crash loading bookmarks while detached ( #3787 )
5 years ago
Colin Lee
386a3f3acc
For #3785 : Crash onDestroy of BookmarkFragment when detached ( #3786 )
5 years ago
Emily Kager
9142e2279c
For #1968 - Adds menu option to add new folder in BookmarkFragment menu
5 years ago
Tiger Oakes
606e66219c
No issue: Use chains for bookmark items ( #3696 )
...
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
5 years ago
Emily Kager
c9962a7ad0
Closes #3701 - When deleted use bookmark title if url is null in snackbar ( #3716 )
5 years ago
Emily Kager
77edb7afe1
For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list
5 years ago
Tiger Oakes
4994554576
No issue: Adds lint exception for when statement ( #3685 )
5 years ago
Tiger Oakes
30930cdc88
Import variables referred to by path
5 years ago
Tiger Oakes
d01bb8c442
Use lifecycleScope for collections fragments
5 years ago
Tiger Oakes
6bf8d6be34
Use @JvmOverloads instead of multiple constructors
5 years ago
Colin Lee
94e99cf877
For #3364 : Edit bookmarks should show corrected bookmarks tree ( #3446 )
5 years ago
royang51
e244aae104
For #3214 - History multi-selection aborted, the same item can't be selected again ( #3607 )
5 years ago
Andrei Teslovan
2ebe0a2a48
Fixes #3529 - Display "Edit folder" title when editing a bookmark folder ( #3549 )
5 years ago
Colin Lee
22bcd70edc
For #3213 : Fix multi-select bookmarks on return to fragment ( #3413 )
5 years ago
Andrei Teslovan
e458d8b6a1
Fixes #3365 - Set selectedFolder to null if it's already selected ( #3415 )
5 years ago
Colin Lee
f1088222b4
For #3203 : Updates edit bookmarks to have user friendly names ( #3372 )
...
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
5 years ago
Colin Lee
b498f5559b
For #3333 : Only show desktop bookmarks if logged in ( #3356 )
5 years ago
Sawyer Blatz
decacbfc97
For #3323 Runs PublicSuffixList synchronously
5 years ago
Arturo Mejia
5df726715f
Revert "For #3008 , For #2162 Add Simple Logic for Menu Orientation" ( #3310 )
...
#3114
5 years ago
Tiger Oakes
82d2a0661b
Remove deprecatd support-ktx methods ( #3305 )
5 years ago
Sawyer Blatz
45c509fbce
For #2648 : Updates trimming of url hostname ( #3191 )
...
* For #2648 : Updates trimming of url hostname
* For #2648 : Fix nits
5 years ago
Colin Lee
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
5 years ago
Jeff Boek
f26c402f0a
For #2395 - Properly takes you back to where you start authentication on completion
5 years ago
Sawyer Blatz
0b3a8b7a54
For #2316 : Adds confirmation dialog to delete bookmark
5 years ago
Emily Kager
dc0d153580
For #3008 , For #2162 Add Simple Logic for Menu Orientation ( #3114 )
...
* For #3008 - Adjust orientation of collections menu based on view location
* For #2162 - Add simple menu orientation logic to bookmark menu
5 years ago
Emily Kager
d5a9627273
For #2941 - Remove Delete Dialog, Theme Dialogs ( #3052 )
5 years ago
Jeff Boek
a7d5cdcb9d
For #2723 - Fixes theme manager
5 years ago
Sawyer Blatz
cd19f36b96
For #2227 : Fixes issue with bookmark selection ( #3021 )
5 years ago
Sawyer Blatz
b8c04e02e9
For #2327 : Fixes nits
5 years ago
Sawyer Blatz
fe50e88fc8
For #2327 : Adds error state syncing
5 years ago
Grisha Kruglov
5f42a65c2a
No issue: improve allowUndo
...
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on
New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
5 years ago
Jeff Boek
3920cda693
For #2419 - Adds a deletion state to the history component
5 years ago
Denys M
39df4c8522
For #747 . Improve `HistoryFragment` readability.
5 years ago
Denys M
13f144f212
For #747 . Fix coroutines leaks in `HistoryFragment`.
5 years ago
Grisha Kruglov
9e7269214c
Closes #2835 : Do not assume bookmarks fragment is attached while processing operations
...
This is mostly necessary when we're running stuff in a coroutine, so the patch likely goes
overboard a bit with the nullability checks... but it shouldn't hurt.
5 years ago
Jonathan Almeida
3da6cfd98a
For #2886 : Fix sending multiple tabs to another device ( #2923 )
...
* For #2886 : Fix sending multiple tabs to another device
* Update share methods to use new API
5 years ago
Emily Kager
bfc0fa36b1
For #2133 - Add destructive text color to delete history button
5 years ago
Emily Kager
7d65e21b83
For #2941 - Creates delete dialog style
5 years ago
Harsh Shandilya
7d9c8726c5
treewide: Resolve compilation warnings ( #2859 )
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
5 years ago
Grisha Kruglov
2ad3a72f6f
Closes #2252 : Show "Desktop Bookmarks" in the Bookmarks library ( #2797 )
...
This patch adds in a virtual "Desktop Bookmarks" folder to the top
of the mobile root child list, and makes sure to change internal
bookmark root names to user friendly labels.
5 years ago
Jonathan Almeida
eb7646f073
Add custom share sheet and send tab support ( #2757 )
...
* Closes #2751 : Add custom app share sheet
* Closes #2753 : Add send tab devices to share sheet
* Closes #2752 : Add build flag for send tab
* Replace Context.share with ShareFragment
5 years ago
Sören Hentzschel
04e28096b2
fixed wrongly named variable
5 years ago
Sören Hentzschel
56dec1ebfb
fixed linting issues
5 years ago
Sören Hentzschel
cc03aeb9f0
For #2435 - adds URL to bookmarks in library
5 years ago
Emily Kager
851f066a2a
For #2377 - Added ability to share multiple history items
5 years ago
Emily Kager
40f8e3b6af
No issue: Use ExcludeTypes instead of filtering after retrieving
5 years ago
Sebastian Kaspari
291df48c4e
Install the "icons" WebExtension to automatically load icons for every visited website.
5 years ago
Sawyer Blatz
c334c77bbe
For #976 : Adds telemetry for library
5 years ago
Emily Kager
028c6cad70
For #2025 - Create and theme Dialog for deleting all history
5 years ago
Emily Kager
fd4de3509d
For #1249 - Create Empty History State
5 years ago
Sawyer Blatz
72d29c2a43
For #2205 & #1578 : Integrates tab collection storage ( #2478 )
...
* For #2205 : Adds TabCollectionStorage
* For #1578 : Adds delete to TabCollection
5 years ago
Sawyer Blatz
334868c283
For #2224 : Removes select bookmark and fixes crash
5 years ago
Jeff Boek
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
5 years ago
Colin Lee
49ac62ab85
Fix ViewModel States ( #2457 )
...
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
5 years ago
Sawyer Blatz
43a4b1b77c
For #563 : Restyles history favicons ( #2455 )
5 years ago
Denys M
fd56b1fef3
Closes #2340 . Set navigation icon color on library screen. ( #2415 )
...
Applying color filter to `toolbar.navigationIcon`.
5 years ago
Sawyer Blatz
e1cdeffe8c
For #563 : Restyles history management ( #2378 )
5 years ago
Colin Lee
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
5 years ago
Colin Lee
96b68948b5
For #1710 : Create scaffolding for Robolectric tests ( #2282 )
5 years ago
Colin Lee
030912bfc5
For #1966 : back button from multi-selection toolbar should cancel ( #2207 )
5 years ago
Colin Lee
548c3be51e
For #1702 : Multiple selection toolbar replaced with "fragment_home' ( #2204 )
5 years ago
Colin Lee
a60d2c071c
For #1967 : Multi-selection toolbar should disappear after deleting ( #2202 )
5 years ago
Colin Lee
a4c201f2ee
For #1870 : Copy bookmark folder does nothing ( #2193 )
5 years ago
Colin Lee
eb0a10078c
No issue: refresh after undoing bookmark deletion ( #2198 )
5 years ago
Colin Lee
c151c4b97b
For #1862 : deleting a bookmark item not hiding it immediately ( #2188 )
5 years ago
Emily Kager
41bbc1ad2b
Closes #2163 - Check if bookmark title is null or blank
5 years ago
Sawyer Blatz
70486039c0
Closes #2147 : Refactors usage of openToBrowserAndLoad
5 years ago
Colin Lee
f1050eaff5
For #1951 : Bookmarks library pane displays everything from root down ( #2135 )
5 years ago
Sawyer Blatz
46924544b6
For #1975 & #1627 : Refactors getSessionById in BrowserFragment
5 years ago
Colin Lee
688cae33c3
For #1877 : Crash on edit or delete the default bookmark folders
5 years ago
Jeff Boek
ff08d0dbb0
For #1843 - Passes selected tabs through the MVI loop
5 years ago
Emily Kager
2162e74f76
Closes #1948 - Shows bookmark url if title is null
5 years ago
Emily Kager
05b9df34d8
For #1922 - Open bookmark in new tab menu should open and show new tab
5 years ago
Emily Kager
df6230182c
Closes #469 - Changes Library String
5 years ago
Colin Lee
78abd43b3e
For #1923 : Title of bookmarks folder is not displayed
5 years ago
Sawyer Blatz
41e8acf05f
For #724 : Adds contrastText color for buttons using accent backgrounds
5 years ago
Sawyer Blatz
b54a1c9c57
Fixes #1886 : Applies theme to toolbar onResume of library fragment ( #1888 )
5 years ago
Emily Kager
23e2b51db2
For #1759 - Try to change copy URL to plainText ( #1850 )
5 years ago
Colin Lee
7c00c2983b
No issue: Fix crash on bookmark folder selection and Snackbar color
5 years ago
Colin Lee
080dadcb7e
For #1817 : Multi-select toolbar changes when minimized
5 years ago
Sawyer Blatz
0f367a018a
For #724 : Corrects colors for all themes
5 years ago