2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Commit Graph

7 Commits

Author SHA1 Message Date
Christian Sadilek
fbbc25b54e Closes #16053: Fix crash when closing private tabs via notification 2020-11-16 13:41:51 -08:00
Tiger Oakes
57e557fd18
Use AC version of PrivateNotificationService (#12459) 2020-08-14 16:08:41 -07:00
Christian Sadilek
64440409b0 For #9100: Follow-up to fix memory leak in NotificationSessionObserver
The observer was moved and is now bound to the activity and its
context. If the activity is re-created we leak the observer and
therefore the activity itself.

With this we make sure to stop the observer and also don't use
the activity context to begin with.
2020-06-25 16:17:38 -04:00
Mihai Branescu
49b617c999
For #9100 - Private browsing notification fixes
Co-authored-by: Seef <Saif Dara>
2020-06-24 21:35:11 -04:00
Tiger Oakes
a7e74e308b
Migrate some SessionManager usage to BrowserStore (#10789) 2020-06-03 11:18:44 -07:00
Michael Comella
6e0d851da3 For #9605: replace unit test runners with FenixRobolectricTestRunner.
This is how we can apply the new test runner to remove duplication.

This commit was generated programmatically with the following commands:
```
  // Replace test runners with new one.
  find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
  find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +

  // Replace imports of old test runners with new one
  find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
  find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +

  // Remove unused imports
  find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```

Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
2020-04-03 09:27:49 -07:00
Severin Rudie
f562c81fb2 For 5334: test NotificationSessionObserver 2019-12-30 11:40:07 +02:00