Commit Graph

2345 Commits (d046d908fcb3e451f68b2a22471eb038cd332360)

Author SHA1 Message Date
Sawyer Blatz 011a9e7d96 For #1216: Add voice search 4 years ago
ekager d46369696f For #10718 - Finish activity after removing external session 4 years ago
Tiger Oakes cd64647a4d For #9286 - Add isDefault to topsites 4 years ago
Juan Goncalves ee62297b4c For #7854 - Update the views only if the bookmark node has changed
As the bookmark node data is loaded from storage every time the fragment's view is created, when the user navigates to the SelectFolderFragment and returns, the bookmark is loaded once again from storage, replacing the EditText's content (title and URL) which causes the loss of user input.

Validating that the loaded bookmark is different from the one that is already referenced in the fragment avoids unnecessarily replacing the `EditText`s values.
4 years ago
Emily Kager 32e74aae61 Revert "For #6313 - On first load, hides engineView until firstContentfulPaint"
This reverts commit d66762910f.
4 years ago
Emily Kager 9b16017d1d Revert "For #7032: Add scroll to dismiss keyboard in search fragment"
This reverts commit 536921bcea.
4 years ago
ekager d66762910f For #6313 - On first load, hides engineView until firstContentfulPaint 4 years ago
Sachin 536921bcea
For #7032: Add scroll to dismiss keyboard in search fragment
* added a onTouch listener to scrollview in search fragment to make it disappear on scroll

* fixed lint issues
4 years ago
Grisha Kruglov d37529e416 Perf telemetry for awesomebar suggestion provider durations
See mozilla-mobile/android-components#6802 for details; requires that PR.
4 years ago
Mihai Branescu 750ae4a340 For #10393 and #10469 - browser fragment now observes collection changes
Useful for links from other apps + adding a page to multiple collections
4 years ago
Christian Sadilek 7993f1017d Migrate feature-accounts to browser-state 4 years ago
sraturi 372bb421cc created kotlin doc for FenixApplication 4 years ago
Simon Chae 7cc4816618
For #10398: Add AddonInstallationDialogFragment support (#10608) 4 years ago
Elise Richards edc75c3ad0
Fixes #9504: Edit logins (#9693)
* Create editable view and fragment. Update login info page to display options menu with edit and delete.

* Create feature flag for edit. Check flag in the login detail fragment and default to just delete.

* Add three-dot kebab options menu in login detail fragment. Add title to the login item.

* Nav to and from edit view on save and back pressed.

* Save login through AC login manager. Clear text in editable field on button click.

* Match colors, fonts, dimens to UX specs for edit logins. Enable password reveal/hide and clearing text fields.

* Refactoring logins fragments. Using component Login object for consistency.

Fetch login list when saved logins are opened. Fetch login details when detail view is opened.

Revert "Fetch login list when saved logins are opened. Fetch login details when detail view is opened."

This reverts commit 44fe17166c3332b330229258b2e8982832672e3b.

* Using parcelable login and Login component class to pass ids and items between fragments

* Retrieve login from storage when viewing login details.

Rename login logic for consistency.

Ktlint cleanup

Fix nits and naming consistency.

* UX consistency for login detail and edit login pages

* Rebasing with logins sort - updating logins store.

* Rebasing with logins sort - merging fragments and controllers.

* Lint and removing unused files.

* UX cleanup.

* Update string description
4 years ago
Tiger Oakes f7b4f1c959
Cache findViewById calls in session control (#10575) 4 years ago
David Walsh 86dabe09c8
For 10503 - Update save to collection flow in tab tray (#10523) 4 years ago
mcarare 58df38105b For #10453: Use TabsTray API to set divider, avoiding related crashes. 4 years ago
Sebastian Kaspari d58c022619 Integrate activity for showing past crashes. 4 years ago
Jeff Boek a249334976
🎲 For #10332 - Adds undo snackbar when closing tabs in the tab tray (#10456) 4 years ago
Simon Chae 5ba9cc6ec9
For #10253: Add disableFirstTimePWAPopup for performance testing (#10442) 4 years ago
ValentinTimisica 15dfe0811d For #10343: Updates metrics accordingly to 'Library' removal 4 years ago
ValentinTimisica b2e5820364 For #10343: Remove 'Library' functionality from the app
Also adds Bookmarks and History items to browser menu.
4 years ago
Simon Chae ca7695854a
For #10552: Set initial add-on details fragment visibility to false (#10565) 4 years ago
Sawyer Blatz 17fb7c1df7
For #10426: Removes installation ping GAID (#10532) 4 years ago
Simon Chae d58e7d3138 For #10473: Fetch the addon from addon manager instead of the store 4 years ago
Sawyer Blatz b87c40d42f
For #10426: Sends GAID to Installation instead of Activation ping. (#10529) 4 years ago
codrut.topliceanu d1005dd236 For #8589 - Fix for accessibility navigation in ETP panel 4 years ago
Arturo Mejia ca01965f90 Fix PictureInPictureFeature breaking change 4 years ago
ekager 7fe6f68e00 For #10485 - Restore block video/audio on cellular data radio button 4 years ago
ValentinTimisica f63cb4e09f For #10244: Creates drawable for add-ons private browsing label.
The drawable is sent to AddonsManagerAdapter.Style constructor and is displayed
near the add-on name if it is allowed to run in private browsing
4 years ago
Jeff Boek 58ca5d0e3a For #10341 - Always show collections placeholder with new tab tray enabled 4 years ago
Mihai Branescu eef5cf3469 For #10482 - made SVG gradient compatible with API < 22 4 years ago
ekager 138d8e647d No issue - Use ViewLifecycleOwner lifecycleScope for Bookmark deletion scope 4 years ago
Sawyer Blatz 02f6e6868e
For #10426: Adds identifier to Glean for 24 hours (#10446) 4 years ago
Jonathan Almeida 57eb2b9549 For #10453: Do not set item decoration when creating ViewHolder 4 years ago
ValentinTimisica 24ba9f2fc8 For #9505: Adds possibility to sort saved logins
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
4 years ago
mcarare 9177871edc For #10408: Check current destination before navigating. 4 years ago
ekager 9fd835de0f For #10433 - Pass in viewLifecycleScope to BrowserAnimator 4 years ago
ekager 9ec1f8e2d8 For #8981 - Sort devices in share list by last access time 4 years ago
Michael Comella 4cf7280916 No issue: add clarifying kdoc for BookmarkFragment. 4 years ago
David Walsh 8b27a48635 For #10329 - Implement tab tray divider 4 years ago
Simon Chae 609936d632
For #10196: Remove clickable locks for enable and private-browsing UI (#10445) 4 years ago
Simon Chae a851b76ea3
Update Android Components version to 41.0.20200506130132 (#10443) 4 years ago
Mihai Branescu 6f97e75579 For #8643 and #7606 - illustrations are now connected to their radio buttons 4 years ago
Mihai Branescu cde31cf785 For #8643 and #7606 - Changed toolbar picker illustrations according to theme 4 years ago
Mihai Branescu 16b7a9399b For #8643 and #7606 - Changed theme picker illustrations according to theme 4 years ago
Mihai Branescu 4c0af91b7b For #8643 and #7606 - Changed tint for onboarding icons 4 years ago
Arturo Mejia 398b516fb7 No issue: Add Fingerprinters to the standard trancking protection policy 4 years ago
Christian Sadilek fee09c3092 No issue: Show article/page url instead of reader extension url 4 years ago
Jeff Boek d72e455c0d No Issue - Update to AC 41.0.20200505190119 4 years ago
Mihai Adrian 43d30793f5
For #9794: Announce installing state for screen readers (#10111) 4 years ago
Mihai Adrian 5106134786
For #10408: Dismiss menu when navigating away. (#10415)
The menu is dismissed when toolbar view is detached from window.
4 years ago
David Walsh 542f31f970
For #10392 - Don't provide a "Save to collection" button in private mode for the tabs tray (#10399) 4 years ago
Sören Hentzschel 10d07912da no issue - removed unused feature flag 4 years ago
Jeff Boek 94cd195dc7
Adds swipe to delete tab (#10355)
* No Issue - Increases tap area of close button

* For #10331 - Adds swipe to delete to the tab tray
4 years ago
Simon Chae 3dcd52ef7a For #10195, #10196: Allow private browsing mode switch to sync with enable state 4 years ago
Jeff Boek 5c7e9b98cd
Fix home navigation (#10350) 4 years ago
Jeff Boek a8a90bd4d6
For #1063: Put tab tray behind a feature flag and hidden pref (#10313)
* For #1063 - Adds feature flag and pref for new tab tray

* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For #1063 - Creates hidden preference to use new tab tray

* For #1063 - Hides tabs on home screen when setting is enabled

* For #1063 - Navigate to new tab tray from browser with setting enabled

* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For #1063 - Fixes crash when toggling to private mode on the home screen

* For #1063 - combines both settings. Cleans up lint errors
4 years ago
Chenxia Liu 390c5a0189 Issue #7996: fix lint issues 4 years ago
Jovan Gerodetti 4a12f1b6aa For #7996: Private mode doesn't play nicely with sites added to home screen
Site Controls Notification should reflect the browsing mode of the
currernt web app session.
4 years ago
Arturo Mejia 56bb3e38ec For issue #10142 Update sitePermissions state when toggling its value 4 years ago
ekager 2e27bbd15d No issue - Remove unused data class TopSiteItem 4 years ago
Sawyer Blatz 38e9b34659
For #10071: Fixes PWA showing toolbar onPause (#10306) 4 years ago
mcarare 4006501d41 For #9728: Add actionbar search for language list. 4 years ago
ekager 52d09930a6 No issue - Update new strings for quarantine 4 years ago
Mihai Eduard Badea 02bd0cc203 For issue #8648 4 years ago
Jonathan Almeida 76002c5987 Fix breaking API changes in CrashReporter 4 years ago
Falaye Iyanuoluwa c86209ff98 Closes #9694 Bug when user denies permission 4 years ago
mcarare 3c5d8d31ea For #10083: Adjust thumb offset to thumb circumference to avoid cutoff 4 years ago
David Walsh 6afcd2cee6 For #10201 - Provide proper button padding and no tabs message visibility in tabs tray 4 years ago
Arturo Mejia e55a4fd274 No issue: Partially update the add-on manager list 4 years ago
mcarare 1aa473b112 For #9913, For #9914: Remove touch delegate when button is disabled. 4 years ago
ekager a9692d9bce For #10204 - Address viewLifecycleOwner IllegalStateException crashes 4 years ago
Mihai Branescu a16bfb27ef For #6557 - added unit tests 4 years ago
Mihai Branescu 0c2d22f595 For #6557 - add in_content telemetry class 4 years ago
Mihai Branescu 28496fecc0 For #6557 - split base extension functionality from ads 4 years ago
Mihai Branescu f09bc4566c For #6557 - added metric for in_content 4 years ago
mcarare e830da59b7 For #10180: Remove touch delegate when button is disabled.
Also refactored multiple if's into a when.
4 years ago
mcarare 3e13927c25 For #10180: Add extension to remove touch delegate from parent. 4 years ago
Mihai Branescu c4d76dce5a For #6558 - cleanup + added unit tests 4 years ago
Mihai Branescu f03d65b13d For #6558 - added logic for ad_clicked metric 4 years ago
Mihai Branescu 93ca1f6d9f For #6558 - added handling of web extension + sending metric for has_ads 4 years ago
Simon Chae f1559ed2da
For #10162: Set switch back to prev state when failed to enable/disable addon (#10164) 4 years ago
mcarare 2edd4b39a4 For #9913, For #9914: Remove button when disabling it.
Setting visibility to GONE allows clicks to parent view in that space.
4 years ago
Arturo Mejia 956bf01cd5 For issue #9493: Reload after cleaning individual site permissions exceptions 4 years ago
David Walsh 6f5f48c30e
For #10148 - Add basic tab tray implementation without exposing to rest of app (#9934) 4 years ago
Vlad Filippov e51e1c878b Add 'useEmail' and 'useEmailProblem' metrics event
Fixes #9834
4 years ago
Simon Chae b3248ec769 For #6123: Expose WebExtensions in private browsing control 4 years ago
mcarare cc67de29bf For #10091 Also disable play/pause button when hiding it. 4 years ago
mcarare 9dd8314d14 For #10091 Add extension to remove and disable button 4 years ago
mcarare 932fd44823 For #7387: Change ETP onboarding from popup to a dialog.
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
4 years ago
mcarare 72fe52fcb8 For #9987: Set FLAG_SECURE to dialog when flag set in activity. 4 years ago
ValentinTimisica da3fca0f29 Fixes #10109: Adds content description for browse privately card content 4 years ago
mcarare e11f1b62dc For #10027: Make toolbar context menu popup dismissible on SDK<23 4 years ago
ekager c4e83367f6 For #6832 - Fix various fragment not attached to a context crashes 4 years ago
ekager 6457a02a82 For #2818 - Enable PiP for all builds 4 years ago
Roger Yang 0227e953ae Close #9760: Add external app links context menu candidate 4 years ago
Sawyer Blatz dce16964c0
For #9208: Adds in-product prompt to homescreen (#9836) 4 years ago
Arturo Mejia 0a23d66756 For issue #7566 Handle deny & don't ask again for site permissions 4 years ago
Arturo Mejia 995da59fa8 For issue #9493: Reload after cleaning all site permissions exceptions 4 years ago
ekager 70755adf6e For #10036 - Workaround for System Theme changes with config change 4 years ago
Michael 1f8b7ff962 Closes #8541: Hide find bar when entering fullscreen 4 years ago
Jeff Boek 164e6cd079 For #9816 - Adds SessionObserver to session on selection 4 years ago
Jonathan Almeida 6ad046714d Close #9338: Enable WebPush engine integration in all builds 4 years ago
ekager f3847d0d7c For #8735 - Adjust fontInflation engine setting when toggling useAutoSize 4 years ago
ekager 66d9a24b28 Closes #9928 - Updates private browsing text description 4 years ago
ekager 5d51c4f059 Don't use ProcessLifecycleOwner for view-tied consume 4 years ago
ekager f801f32027 No issue: Fix leaks in BookmarkFragment 4 years ago
ekager 5014cd78ec No issue: Fix leaking sessionControlInteractor 4 years ago
Grisha Kruglov 853a0acab4 Closes #4046: Always display 'Desktop' bookmarks folder
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.

In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
4 years ago
Jonathan Almeida c16283a923 For #9932: Fix navigation icon theme missing from migration UI
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
4 years ago
Sawyer Blatz a8e624959e
For #6940: Fixes top dynamic toolbar behavior (#9900) 4 years ago
Roger Yang 40550e88de
Close #9960: Launch URI in Fenix if failed to launch in custom tab (#9964) 4 years ago
Christian Sadilek ec1d4e8fca For #8399: Hide keyboard to prevent content resizes
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
4 years ago
Michael Comella f3ed207bdb For #8803 - review: Add clarifying comments to onAppInit capture methods. 4 years ago
Michael Comella f49fc6dad2 For #8803: hook up frameworkStart metric. 4 years ago
Michael Comella dbf733d70a For #8803: add StartupFrameworkStartMeasurement.
This class controls the central logic around the metrics we want to
record.
4 years ago
Michael Comella 7f618a6a7c For #8803: add Stat and test.
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
4 years ago
Emily Kager 39107b4036
For #9703 - Exit fullscreen in onPause and onSessionSelected (#10016)
* For #9703 - Call fullScreenChanged in onPause

* For #10015 - Exit full screen if new session selected
4 years ago
ekager 6f77ec5951 Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver 4 years ago
Grisha Kruglov 0ec6d266e8 Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
4 years ago
Mihai Adrian 72fe9fad0c
For #9987: Set FLAG_SECURE to dialog when flag set in activity. (#9998)
* For #9987: Add extension to secures dialog if parent activity is secured

* For #9987: Set FLAG_SECURE to dialog when flag set in activity
4 years ago
Mihai Eduard Badea 725ba1e856 For #9951 - Removed the extra empty spaces that were causing the spacing issue 4 years ago
mcarare 83d2208c6b For #9536: Open report issue tab depending on current browsing mode.
Checking if session is private uses the new browser state API.
4 years ago
Sawyer Blatz 1f8f69548a For #7158: Fixes browser to search animation fade 4 years ago
Jonathan Almeida 25d5b0d31c For #8422: Add spacing between migration items 4 years ago
ekager 4a06a228f3 For #9981 - Make Bookmark Menu UI respond to session selection 4 years ago
mcarare 25e12e2f77 For #9984: Update addon before settings visibility check 4 years ago
Sawyer Blatz 8185ba793e
For #9857: Create button style (#9858)
* For #9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
4 years ago
Jonathan Almeida 997f6c72d6 For #9409: Add app icon to Leanplum push notifications 4 years ago
Jonathan Almeida e97904662c Remove duplicate FirebasePushService
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
4 years ago
Mihai Branescu bded28a017
For #9420 - relaxed custom engine rules (#9967)
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
4 years ago
ekager aef827e607 For #9887 - Respect screenshot setting when resetting window flags in logins 4 years ago
Arturo Mejia 37a277febb For issue #9930 Do not assume all add-ons have a settings page 4 years ago
Arturo Mejia 8872baef39 Update Android Components version 4 years ago
Arturo Mejia 7c279b6e1f No issue: Fix add-on translate() breaking change 4 years ago
ekager 5b1cdbd8bf For #3194 - Pause media while undo snackbar appears 4 years ago
ekager 9c56a8b387 For #204 - Remove PWA Feature Flag 4 years ago
Jeff Boek 4cbb9aebaf
Cleans up nav_graph.xml (#9829)
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
4 years ago
Arturo Mejia eace991859 For issue #8520: Improve add-ons UI 4 years ago
ekager b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 4 years ago
ekager ac3a557ddf For #9703 - Exit full screen on pause if pip not entered 4 years ago
Sawyer Blatz 7c3394ea7c
For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs (#9893) 4 years ago
ekager 8c238402e2 For #9692 - Fix "Install" PWA menu item labeling 4 years ago
ekager 5039546dc5 For #7208 For #7212 - Update parameterized strings 4 years ago
mcarare a214f04b4a For #9698: Use extension to ensure fallback to English and avoid crash 4 years ago
mcarare 4a1a875233 For #9698: Add Context extension to avoid format IllegalArgumentException 4 years ago
mcarare 177baf58a8 For #9798: Disable buttons on hiding and enable on showing.
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
4 years ago
Simon Chae de311aef85
Update not yet unavailable add-on string (#9677) 4 years ago
Roger Yang c9141c9ae5 Close #9827: Support display cutouts 4 years ago