53b3f105ca
For #4155 : Sets pastedText default value
5 years ago
fdd2b59fb8
For #4155 : Adds popup menu for browser toolbar
5 years ago
f7dde41b3b
For #5021 : Adds telemetry for what's new button
5 years ago
b77c4d2e2e
Clean up SupportUtils
5 years ago
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
5 years ago
ed0b6bd5ef
For #4193 - Makes close button for tabs more accessible ( #4442 )
...
* fixes #4193 - made close button for tabs more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
* Fix margins
5 years ago
3a35233ac0
Remove ThumbnailsFeature. ( #5127 )
...
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
5 years ago
231924f5eb
Fix breaking services APIs changes
5 years ago
09dcdb079d
For #4474 : Adds what's new button to home screen menu ( #5088 )
...
* For #4474 : Adds what's new button to home screen menu
* For #4474 : Adds tests for what's new button
5 years ago
f7087e46e3
Fix #5067 - Refactor ShareController to use SendTabUseCases
...
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
5 years ago
4cf03be236
For #2088 : Use new async API to load default search engine in HomeFragment
5 years ago
5e78420cce
Fixes #3602:navigate to top of home screen after tapping "start browsing"
...
After onboarding.finish(), scrolled homeLayout to top
5 years ago
d87b8a8a5c
For #4658 : Add some private browsing mode telemetry ( #4968 )
5 years ago
cc5408d717
For #2053 : Add persistent notification to close all private browsing tabs ( #4913 )
5 years ago
d1964d6536
Fixes #4771 - Add method for sessions of type ( #4782 )
...
Fixes share tabs to use the new method
5 years ago
b9f6f7fa93
For #4779 : Don't double navigate with global directions in HomeActivity
5 years ago
84b0693fd2
For #4652 : Use workaround for HomeScreenViewModel ( #4887 )
5 years ago
9f154dc3a0
Extract intent processors from HomeActivity ( #4884 )
5 years ago
c475bc87cf
Move classes out of top-level package
5 years ago
68f5d211d3
For #4326 - Updates codebase to support latest version of detekt
5 years ago
6f899c7fb5
For #2834 : Delete all Private Tabs redesign ( #4787 )
5 years ago
c076cc85f9
For #4436 : Dismiss onboarding before navigating away from home ( #4801 )
5 years ago
33f3b14c29
Adds setters and property delegates in `Settings` ( #4809 )
...
* Change Settings to use setters
* Add delegate for shared preferences
5 years ago
ac6c1ec2ee
Closes #2690 - Clean up CreateCollection viewmodel ( #4731 )
5 years ago
ad98b2f3ea
For #4744 - Extract private browsing button ( #4813 )
5 years ago
ab6e7dc52b
Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
5 years ago
b8c93107c0
For #4744 - Extract TransitionPreDrawListener ( #4812 )
5 years ago
a632d8f1dc
For #4744 - Move search bar icon padding to dimens ( #4814 )
5 years ago
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
5 years ago
f71106cb51
Closes #3860 - Update description text for collections
5 years ago
42e3b2771e
fix #4633 : show toast only on first login ( #4676 )
...
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
5 years ago
5aac05859d
Fix #4436 : hide onboarding before navigating to settings ( #4675 )
...
* Fix #4436 : hide onboarding before navigating to settings
* No issue: Rename emitAccountChanges to emitModeChanges
5 years ago
0c8bcd39be
For #4652 : HomeFragment Crash "Can not.. after onSaveInstanceState"
5 years ago
52542708aa
Consodilate private browsing code
5 years ago
ef97173cd9
For #4529 , #4427 : Resuming after restoring instance state breaks UI ( #4571 )
...
* For #4529 , #4427 : Resuming after restoring instance state breaks UI
* Clear up warnings
5 years ago
0b98d43c23
Closes #4602 - Add back transitions
5 years ago
4566bd6fba
Fixes feedback
5 years ago
9d65e665e5
No issue: Removes deprecated usage of ViewModelProviders
5 years ago
969d17b4a9
For #969 : Adds more telemetry for collections ( #4539 )
5 years ago
d0071d0177
For #4495 - Clean up homescreen toolbar focus and content descriptions
5 years ago
015922ddd2
No issue: Fix Crash lower API by setting gradient drawables in onBind
5 years ago
ec96d134ff
No issue: Fix breaking AccountObserver API
5 years ago
da59e36c1b
Fixes #4410 : Modified visibility of 'Add Tab' button.
...
I changed the visibility of 'Add Tab' button according to the number of
opened tabs. If there is at least one tab open, the button is displayed.
5 years ago
ae33234bbc
Closes #2593 : FxA automatic sign-in integration
5 years ago
2e7a61860a
For #969 : Adds more telemetry for collections ( #4358 )
5 years ago
87d8f3b037
Remove redundant super calls
5 years ago
88c05a5f43
Use glide-like image loading function
5 years ago
ccfaa3826b
For #2142 : Added accessibility focus
5 years ago
d5eeadda66
Closes #2142 : Enable private browsing button is focused instead of Search or address
5 years ago
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
5 years ago
c74cb61455
fixes #4176 ( #4175 )
...
adds content description to 'browse privately' card, replacing placeholder %s with the header_text of card
5 years ago
13198f56df
For #969 : Adds telemetry for collections ( #3935 )
5 years ago
6da6ddb095
Use StateListDrawable & resources w/ TabCollection
5 years ago
451093fd9e
Closes #2560 - Updates Private Browsing explanation string
5 years ago
447123367a
Remove unused sessions resources
5 years ago
f8ef0225e1
Use updated feature-tab-collections API. ( #4056 )
5 years ago
5de1678e65
No issue: Use putCompoundDrawables helper ( #3982 )
5 years ago
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
5 years ago
fe51bbcf7b
Update FxA integration to new APIs
5 years ago
c81dd0a4a8
For #3772 - Update FXA sign in UI ( #3933 )
5 years ago
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
5 years ago
5a204f0bbc
For #3818 : Handle crashes accessing view after onDestroyView ( #3942 )
5 years ago
9901514766
Replace deprecated pxToDp ( #3932 )
5 years ago
7a51ee3915
For #3734 - Don't SwipeToDelete RecyclerView without windowfocus ( #3839 )
5 years ago
99209aa9da
Closes #3268 - Change Tab Favicon Border Radius to 4 ( #3856 )
5 years ago
8cd1a0cb38
Move adapter Job setup code to helper class ( #3407 )
5 years ago
7e46e71d00
For #3005 : Closes tabs when saving to collection ( #3723 )
5 years ago
2d6ebb986d
Revert "For #3135 - Reduce swipe to delete sensitivity"
...
This reverts commit 94881f8241
5 years ago
f375eac6bd
For #3732 : Race Condition Crash in HomeFragment onPreDraw ( #3737 )
5 years ago
13df8d7ddd
For #3711 : Fixes save to collection from browser crash ( #3714 )
5 years ago
e8bd090a8e
No issue: Use ImageView rather than rebuilding drawable ( #3616 )
...
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
5 years ago
4994554576
No issue: Adds lint exception for when statement ( #3685 )
5 years ago
30930cdc88
Import variables referred to by path
5 years ago
d01bb8c442
Use lifecycleScope for collections fragments
5 years ago
ddebc98718
No issue: Follow up on optional filter style
5 years ago
718ac5612c
For #3593 For #3581 - Pass sessions to delete to delete all with undo ( #3594 )
5 years ago
07516f47c3
For #3215 : Adds collection restoration with unique IDs ( #3635 )
5 years ago
03a5cb2fb4
For #3620 - Adds automatic theme onboarding content description ( #3629 )
5 years ago
ab6101b0f4
Fixes #3539 - vectordrawablecompat for gradients ( #3541 )
5 years ago
ccc5b91992
Import PR 3500 from ekager
5 years ago
6e6e662c47
Update HomeFragment.kt
5 years ago
90bdbd04e0
No Issue - Capture session manager in scope before creating the delete operation
5 years ago
7ebdfcc87b
For #1116 - Uses alias link for help
5 years ago
5540230e3d
For #1116 - Changes help link ( #3491 )
5 years ago
f323c38be0
For #981 - Adds missing Leanplum events
5 years ago
d5c5587a0c
For #3209 : Disable shared element animations for crash temporarily ( #3482 )
5 years ago
041eaa2a5c
For #3275 : Cleans up feedback from James ( #3398 )
5 years ago
1f1320920f
For #3275 - Invoke pending single session delete job on close all ( #3438 )
5 years ago
510b6f7373
For #2899 - Improve collections scroll and highlight animations
5 years ago
186983b786
For #3275 - Adds PendingSessionDeletion data class to handle multiple emit session calls ( #3393 )
5 years ago
66a836cf3a
For #3314 : Toolbar and QAB unresponsive after Android 6 perms check ( #3373 )
5 years ago
f05eb032d4
For #2684 : Add an extension function Session.toTab to map Session to Tab and clean up their usage
5 years ago
82cf81242f
For #3331 - Delay restoring layout while list restores ( #3354 )
5 years ago
decacbfc97
For #3323 Runs PublicSuffixList synchronously
5 years ago
e57e7b50ee
For #2899 - Scroll to Collections on change, animate new collections ( #3279 )
...
* For #2899 - Scroll to Collections on change, animate new collections
* For #2899 - Scroll to tabs when tabs opened from collection
5 years ago
ab000d2e51
For #3280 : Revert "For #3215 : Restores collections properly" ( #3320 )
...
This reverts commit 3e9ee79c00f4a6b34af74ce7c179e0cbe37decf5.
5 years ago
5df726715f
Revert "For #3008 , For #2162 Add Simple Logic for Menu Orientation" ( #3310 )
...
#3114
5 years ago
054635735a
For #2750 : Removes unecessary invalidate CollectionViewHolder call ( #3264 )
5 years ago
45c509fbce
For #2648 : Updates trimming of url hostname ( #3191 )
...
* For #2648 : Updates trimming of url hostname
* For #2648 : Fix nits
5 years ago
7368a95d29
No issue: Sets up observers for tab collection changes ( #3248 )
5 years ago
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
5 years ago
acea0d5668
For #2785 - Adds back item animator session control ( #3233 )
5 years ago
8537ff10a8
For #3215 : Restores collections properly ( #3219 )
5 years ago
4954aadd84
For #3156 - If only one tab adding to collection make it selected ( #3222 )
5 years ago
704f1e6a3d
For #3004 - Restore MotionLayout on Home View only in onCreateView
5 years ago
14c581c012
For #3004 - Do not restore motionlayout state in ReloadData
5 years ago
94881f8241
For #3135 - Reduce swipe to delete sensitivity
5 years ago
87f6268816
For #3101 - Do not show tab selection screen for 1 tab
5 years ago
dc0d153580
For #3008 , For #2162 Add Simple Logic for Menu Orientation ( #3114 )
...
* For #3008 - Adjust orientation of collections menu based on view location
* For #2162 - Add simple menu orientation logic to bookmark menu
5 years ago
388581f76f
For #3056 - Filter sessions on invoke for pending delete all job
5 years ago
d5a9627273
For #2941 - Remove Delete Dialog, Theme Dialogs ( #3052 )
5 years ago
14f1d40e10
Fixes #3041 - Fixes the string that gets displayed in the FxA Onboarding card
5 years ago
a7d5cdcb9d
For #2723 - Fixes theme manager
5 years ago
8dbed67f7f
No issue: Simplify and speed up shared element transitions
5 years ago
4c970a545d
For #2230 - Fix theme selection radio button for Android 6 ( #3019 )
5 years ago
b8c04e02e9
For #2327 : Fixes nits
5 years ago
fe50e88fc8
For #2327 : Adds error state syncing
5 years ago
caa36c31cd
For #2979 - Prevent double navigation to Create Collection Fragment
5 years ago
5f42a65c2a
No issue: improve allowUndo
...
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on
New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
5 years ago
e61cebf38d
No issue: Check search engine icon exists before setting drawable
5 years ago
8bed44819d
Fixes #2254/#2709. Observe browser sessions changes on `HomeFragment`.
5 years ago
d6c1f65d72
Start MotionLayout animation to end while navigating to search fragment
5 years ago
dee3c059dc
Adds Shared Transition between Home and Search
5 years ago
6a53127ef9
For #2948 : Adds menu button add tab to collection
5 years ago
3da6cfd98a
For #2886 : Fix sending multiple tabs to another device ( #2923 )
...
* For #2886 : Fix sending multiple tabs to another device
* Update share methods to use new API
5 years ago
506f332b85
For #2919 - Invoke Pending Delete Jobs in onPause
5 years ago
7d65e21b83
For #2941 - Creates delete dialog style
5 years ago
250548a72f
For #2823 - Invoke pending jobs with context on switch to private mode
5 years ago
e3031378bc
For #225 - Address small nits, changes default color of ic_delete
5 years ago
01c9317be0
For #2843 - Improve Collections UI and UX ( #2851 )
5 years ago
207a8d6772
Use a ListAdapter for SessionControl
5 years ago
09588dfda6
For #2529 - Remove "Delete Collection" button from private browsing
5 years ago
4e13de3ffd
No issue: Register observers with owner view
5 years ago
0c8ad3ef6e
For #2721 - Reorder onboarding theme settings ( #2817 )
5 years ago
f51e221a99
Remove unused import
5 years ago
895ba021e7
Hide toolbar in activity and remove label from home fragment
5 years ago
c7af502db7
Restore progress
5 years ago
0e64ead75c
Try to pop up to home if it exists on stack from browserfragment
5 years ago
40f2fe5166
For #1287 - Create animation for opening and closing tab from home
5 years ago
832fd71afc
For #2784 : Removes undo from collection deletion ( #2786 )
5 years ago
eb7646f073
Add custom share sheet and send tab support ( #2757 )
...
* Closes #2751 : Add custom app share sheet
* Closes #2753 : Add send tab devices to share sheet
* Closes #2752 : Add build flag for send tab
* Replace Context.share with ShareFragment
5 years ago
bf28462c47
For #2717 - Hides onboarding card when signed into a firefox account
5 years ago
ab590df18b
For #2717 - Adds auto signed in state to the accounts onboarding card
5 years ago
f4f35bdde0
Closes #2713 : Weave in "onboarding state" and split adapter items accordingly
...
we're ensuring that it has been initialized.
I wonder if we could just make background services load eagerly (they're lazy init now), instead.
5 years ago
220a843534
For #2205 : Updates collection title constraints
5 years ago
a1d32127ab
For #2655 : Adds undo snackbar for closing all tabs
5 years ago
5ec783f6e5
For #2719 - Fixes crash by registering to observer with a lifecycle owner
5 years ago
e7ecd49353
For #1578 : Adds delete collection with undo
5 years ago
394a207fea
Revert "For #1578 : Adds delete collection with undo"
...
This reverts commit 63a4567521
5 years ago
63a4567521
For #1578 : Adds delete collection with undo
5 years ago
93d0982a6f
For #1576 : Adds tab collection renaming
5 years ago
f73bb22955
No issue: Removes usage of COLLECTIONS_ENABLED flag
5 years ago
0c022f6646
For #1826 - Create ViewModel for Restoring Home Scroll Position
5 years ago
4b186eb86d
No issue: Save/Restore State in HomeFragment
5 years ago
0080e7d701
For #2584 : Adds opening a single tab from tab collection
5 years ago
a3f25b9f77
For #2584 : Adds opening tab collections
5 years ago
afbe397f94
For #1575 : Enables adding tabs to existing collection
5 years ago
7e7edc8b7a
For #2377 : Adds share to tabs and tab collections
5 years ago
1cd50ba9cb
No Issue - Fixes nits in #2669
5 years ago
a041d9ef74
For #2391 - Dismiss tour when navigating to search or settings
5 years ago
479c00bc5f
No Issue - Always complete motionLayout transition on restore
5 years ago
692724be2f
For #2395 - Navigates to turn on sync on button press
5 years ago
9a76c11dae
For #2389 - Save state on homeview when switching themes
5 years ago
b3650cacff
For #2399 - Wires up tracking protection onboarding card
5 years ago
a2a4524e51
For #982 - Opens privacy policy in a custom tab
5 years ago
591f367806
For #2392 - Adds icon to private browsing onboarding card
5 years ago
2dc76dda6a
For #2392 - Centers private browsing icon
5 years ago
291df48c4e
Install the "icons" WebExtension to automatically load icons for every visited website.
5 years ago
ba790c5dd3
No issue: remove unused restore state code
5 years ago
ec1a0e6c34
Revert #2533 : Removes feature flag for tab collections
5 years ago
3619f1417d
For #1574 : Cleans up unused code and refactors
5 years ago
7861a80715
For #2205 : Truncates tab collection titles
5 years ago
4e6f9b9ef1
For #1574 : Displays previous tab collections when creating
5 years ago
30a643720f
For #1574 : Adds tab collection creation
5 years ago
d347f73e69
For #2389 - Create Theme Onboarding Card
5 years ago
72d29c2a43
For #2205 & #1578 : Integrates tab collection storage ( #2478 )
...
* For #2205 : Adds TabCollectionStorage
* For #1578 : Adds delete to TabCollection
5 years ago
95af2ddcc6
For #2390 - Adds the start browser button
5 years ago
b2e6b59e91
For #2390 - Adds views for every onboarding card
5 years ago
8928b19079
For #2390 - Adds a theme picker card
...
- applies generic styling to cards
- adds margins to headers and onboarding cards
5 years ago
fe16810ddb
For #2390 - Adds onboarding section headers
5 years ago
dfe14e1751
For #2390 - Adds the onboarding welcome message
5 years ago
b14d0fa80c
For #2390 - Applies onboarding mode on start
5 years ago
b3a3c94169
Small refactor before we add onboarding cards ( #2541 )
...
* For #2390 - Cleans up the toAdapterList method before we add onboarding
* For #2514 - Hide tabs menu when no tabs are open
5 years ago
014de10b29
Fixes #2533 - Adds the feature flag to the menu item to create a collection
5 years ago
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
5 years ago
49ac62ab85
Fix ViewModel States ( #2457 )
...
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
5 years ago
917399d897
For #2436 : TransactionTooLargeException saving many tabs ( #2453 )
5 years ago
155353f0ee
For #2449 : App crashes when switching themes ( #2450 )
5 years ago
4070941657
No issue: Refactor dialogs to use nav graph
5 years ago
cfccb997fd
For #1909 : Tabs disappear intermittently ( #2426 )
5 years ago
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
5 years ago
d64f5a2064
For #2205 : Modifies styling of collections and tabs ( #2328 )
...
* For #2205 : Modifies styling of collections and tabs
* Change bounding box
5 years ago
eb4e159101
For #2329 , For #2332 : Invoke pending delete session job on navigate ( #2333 )
5 years ago
37bae3bb38
For #2289 - Null out pending job on undo ( #2303 )
5 years ago
7d577e5953
For #2205 : Adds collections view to home fragment ( #2249 )
...
* For #1574 : Adds collections to home view
* Adds colored icons and expansion
* Adds state change
* Adds more styling
* Adds ItsNotBrokenSnacks
* Adds chevron
* Improves styling of swipe to delete and adds delete action
* Fix nits
* Try to add real saving
5 years ago
0000d6a782
For #2277 - Clean up threading for session control with undo ( #2281 )
5 years ago
e5e448ac8f
For #1694 - Show Snackbar with Undo When Tab is Closed ( #2246 )
5 years ago
73de0cd2e8
Closes #2239 - emit session changes in onstart ( #2240 )
5 years ago
8fd937669b
Closes #2182 - Do not invoke sessionmanager callbacks ( #2236 )
5 years ago
2953b54a84
For #1573 - Polish Collections UI Component ( #2212 )
...
* Adds Keyboard resuming, Snackbar verification, layout edits to collections
Adds Keyboard resuming, Snackbar verification, layout edits to collections
* Adds new strings for collections/tabs management
* Adds constraintsets, hides checkboxes, adds scrim
* Update strings to plurals
5 years ago
Sawyer Blatz
Tiger Oakes
Mihai Adrian
Sebastian Kaspari
Grisha Kruglov
Petru Lingurar
Christian Sadilek
mihai-adrian
Yeon Taek Jeong
Emily Kager
Emily Kager
Jeff Boek
(´⌣`ʃƪ)
Mugurell
Sourabh
Colin Lee
Jonathan Almeida
ValentinTimisica
Andrey Mukamolov
Mihai Adrian
Tiger Oakes
Mihai Tabara
Stefan Arentz
Gabriel Luong
Arturo Mejia
Denys M