Michael Comella
57805b82a8
No issue: run detekt on unit test files.
...
detekt still passes after I make this change.
afaik, there isn't a good reason not to run it on unit tests and it can
be valuable to add custom rules for them. Also, detekt is already
running on our androidTest directory.
2020-10-01 16:06:53 -07:00
Jeff Boek
41a92a8d8b
For #15593 - Reverts back to simple UUID creation without Fenix side caching
2020-10-01 15:51:30 -07:00
MickeyMoz
a19a63db19
Update Android Components version to 62.0.20201001194334.
2020-10-01 14:58:06 -07:00
Michael Comella
a173749ad8
No issue: document list_compatible_dependency_versions script in README.
2020-10-01 13:34:27 -07:00
Jocelyne
e74a12b442
For #15471 : Show Delete button in red in multi-select overflow menu ( #15576 )
2020-10-01 13:10:33 -07:00
Mozilla L10n Automation Bot
97adee3bd9
Import l10n.
2020-10-01 20:13:40 +02:00
Grisha Kruglov
51dab196c4
Closes #15443 : Use fragment's lifecycleScope for AlertDialog actions
2020-09-30 17:42:40 -07:00
Christian Sadilek
ced92d69d1
Issue #15555 : Set channel to Nightly explicitly for SettingsFragmentTest
2020-09-30 18:35:20 -04:00
mcarare
67310061a3
For #15559 : Allow tabs to stretch in landscape mode for tablets.
...
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
2020-09-30 14:46:22 -07:00
Christian Sadilek
4a06e40e70
Closes #15555 : Intermittent failures in SettingsFragmentTest
2020-09-30 14:53:18 -04:00
Stefan Arentz
ff930175de
For #15537 - Be more verbose about leanplum identifiers ( #15538 )
2020-09-30 13:05:28 -04:00
mcarare
19b377c021
For #15535 : hasOpenTabs now considers the selected tab mode in tray tab.
2020-09-30 08:33:38 -07:00
Ben Hearsum
cd6ab45119
Block github tagging on push-apk ( #15546 )
...
Currently, push-apk fails to verify its chain of trust if github tagging
is done before it runs. Until this is fixed, we need to make sure
tagging is blocked on pushing.
2020-09-30 15:28:40 +02:00
Michael Comella
56f78cb30c
No issue: elaborate on Components class doc.
...
This is to clarify a misunderstanding I found in PR review.
2020-09-29 15:39:10 -07:00
Sebastian Kaspari
2fda22e857
Revert "For #12565 : Pass metrics to share controller" for debug test failures.
...
This reverts commit bbaca06274
2020-09-29 10:59:31 +02:00
Sebastian Kaspari
4de466883b
Revert "For #12565 : Pass bookmark storage to controller" for debug test failures.
...
This reverts commit 3c22100b84
2020-09-29 10:59:17 +02:00
Andrew Gaul
cfbad1dae9
Show undo snackbars with padding with static bottom toolbar
...
This specifically fixes the close tab snackbar. This commit mirrors
the logic when not using Undo from
9e876ebc44#14982 .
2020-09-29 10:15:30 +02:00
ekager
01e802fef0
For #15324 - Show tab settings and recently closed items in menu when no tabs
2020-09-28 21:09:30 -07:00
ekager
e49cd9c558
For #15503 - Change recently closed max to 10
2020-09-29 00:03:49 -04:00
TrianguloY
b07af9ccd3
For #13856 - Prevent overscroll in swipe to switch tabs gesture
2020-09-28 20:43:44 -07:00
Tiger Oakes
25f62f1c76
Extract locale settings initial state
2020-09-28 20:39:49 -07:00
Tiger Oakes
acbad66f45
Add test for initial logins list state
2020-09-28 20:39:49 -07:00
Tiger Oakes
f2a6aa4f25
Add tests for initial collection creation state
2020-09-28 20:39:49 -07:00
Sören Hentzschel
01fdb4ac3f
For #11561 - changed inactive heading and menu icon color in dark mode
2020-09-28 20:24:12 -07:00
Mozilla L10n Automation Bot
863b135723
Import l10n.
2020-09-28 20:18:50 -07:00
Tiger Oakes
3c22100b84
For #12565 : Pass bookmark storage to controller
2020-09-28 20:05:50 -07:00
Tiger Oakes
bbaca06274
For #12565 : Pass metrics to share controller
2020-09-28 20:05:50 -07:00
Michael Comella
d767cd199e
For #13959 : fix startup crash by using arg Context.
...
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
2020-09-28 18:01:19 -07:00
Michael Comella
42cca072e2
For #13959 : remove resetAfter & port tests to StrictModeManager.
2020-09-28 18:01:19 -07:00
Michael Comella
dd73cb628b
For #13959 : clean up existing StrictMode test names.
2020-09-28 18:01:19 -07:00
Michael Comella
f19c9920f9
For #13959 : move resetAfter into StrictModeManager.
...
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
2020-09-28 18:01:19 -07:00
Michael Comella
6abeb2d9e7
For #13959 : change StrictModeManager to class from object.
...
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
2020-09-28 18:01:19 -07:00
Christian Sadilek
d4ab728cff
For #14034 : Add debug preference to override AMO collection in Nightly
2020-09-28 17:25:52 -04:00
Michael Comella
a92356fe00
For #13959 : comment about duplication in logic in StrictMode.
...
I had to drop a commit that addressed the issue because it was too hard
to fix.
2020-09-28 13:52:40 -07:00
Michael Comella
e1bd6191c7
For #13959 : add comment to explain why we only resetAfter in certain build modes.
2020-09-28 13:52:40 -07:00
Michael Comella
3bf71ef655
For #13959 : use ac StrictMode.resetAfter rather than duplicating functionality.
2020-09-28 13:52:40 -07:00
Michael Comella
2c1befaa25
For #13959 : rename to attachListenerToDisablePenaltyDeath for clarity.
2020-09-28 13:52:40 -07:00
Michael Comella
c03c7ef793
For #13959 : remove unused penaltyDialog parameter.
...
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
2020-09-28 13:52:40 -07:00
Michael Comella
f05a542060
For #13959 : always enable detectNonSdkApiUsage.
...
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
2020-09-28 13:52:40 -07:00
Sebastian Kaspari
3983c509dc
Use "undo" implementation from Android Components.
...
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
2020-09-28 10:04:46 -07:00
Mozilla L10n Automation Bot
d287e6e9e0
Import l10n.
2020-09-28 17:16:11 +02:00
mcarare
daced89387
For #15310 : Add test for ActivityNotFoundException when sharing to app.
2020-09-28 13:29:17 +03:00
mcarare
6289da892c
For #15310 : Also catch ActivityNotFoundException when sharing to app.
2020-09-28 13:29:17 +03:00
Johan Lorenzo
fc06fdb57e
Bug 1667367 - Change nightly schedule to align with GV and AC nightlies
...
Fixes https://github.com/mozilla-mobile/android-components/pull/8508
2020-09-28 10:48:26 +02:00
ekager
0d0a28d551
No issue: Update AC to 61.0.20200925190057
2020-09-26 12:21:10 +02:00
ekager
7d5c199e51
For #12383 #15407 #12860 - Switch to using shared view model for session to delete on home
2020-09-25 16:54:54 -07:00
Grisha Kruglov
2999f64d0a
Closes #15434 : Don't try to display a 'signed in' snackbar in a 'headless' mode
2020-09-25 15:31:07 -07:00
Grisha Kruglov
d98eba1d64
Closes #15432 : Invoke UI updates on main thread in response to account events
2020-09-25 15:30:48 -07:00
Grisha Kruglov
24985d54fa
Closes #15436 : Auto-close tabs during startup on the main thread
2020-09-25 15:11:21 -07:00
Aaron Train
b15850d9a3
No issue: Update Flank to v20.09.3 ( #15399 )
2020-09-25 13:29:14 -04:00
