Our previous strategy was to code owner all the specific files we should
own but that's fragile and unreasonable. This is simpler. We expect
there will still be edge cases that live outside these directories (e.g.
*Application*kt).
* For #15278: added CoroutineManager to count runBlocking calls
* For #15278: Added actual detekt rule for runblocking and its config to the yaml
* For #15278: Added unit test for RunblockingCounter
* For #15278: renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test
* Lint fix
* For #15278: made runblocking a Long to prevent overflow
* For #15278: fixed MozRunblocking name, description and moved RunBlockingCounter to perf package
* For #15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck
* For #15278: Added setup for unit test, since it failed without restting counter
* For #15278: Fixed naming for RunBlocking lint check
* For #15278: removed changes made to test to use runBlockingIncrement
* For #15728: added test exclusion for runBlocking check
* For #15278: changed null check and added Synchronized to count setter
* For #15278: fix for nits
* For #15278: added StartupExcessiveResourceUseTest to CODEOWNERS
* For #15278: fixed for nits
* For #15278: Moved increment function to extension function and fixed indentation
* For #15278: Added tests for Atomic Integer extension and nit fix
I had to `sdkmanager "ndk;21.0.6113669"` locally too. Gradle is supposed to fetch all the SDK components for me, but for some reason it isn't doing do for this one.
Enabling release automation!! We can now create releases automatically by simply pushing a tag to the repo. Instructions in the README. Updated README to have some emojis that will make some important instructions pop out!
Plus minor fix to the PR template file that creates the boilerplate below.
* Update screenshot for comment with one non-members will see
* Update PR template with instructions suitable for our fork
* Allow users to skip CI checks if necessary
* Add github actions workflows
* Add github actions for CI
* Fix lint and detekt errors
* Add caching to the github actions
* Add the workflow statuses to the README
* Give the jobs more descriptive names
* Consolidate github actions workflows to a single workflow
* Give the steps meaningful names, save detekt and lint results
The "Can you reproduce in Firefox for Android?"-question that is now obsolete since Fennec is EOL. Also, fenix uses the shield icon to open ETP toggle, and not the lock icon
Currently, users file performance issues and it's up to the Fenix team
to triage them and tag them appropriately. I think it'd save the Fenix
team time and ensure the performance team sees more issues if there was
a new issue type.