Gabriel Luong
af0af7f88a
For #15115 - Part 7: Draw a border around the selected tab
4 years ago
Gabriel Luong
5fcc486caa
For #15115 - Part 6: Display the tab's favicon in the grid view
4 years ago
Gabriel Luong
5fa72cf48c
For #15115 - Part 5: Don't draw any background when swiping to delete a tab
4 years ago
Gabriel Luong
a001004add
For #15115 - Part 4: Formatted TabTrayView.kt
4 years ago
Gabriel Luong
6c77cdab41
For #15115 - Part 3: Implement a grid view layout for the tabs
...
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
4 years ago
Gabriel Luong
ed3986662f
For #15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment
...
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
4 years ago
Michael Comella
7c0d00c800
No issue: fix tests related to inline change.
...
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
4 years ago
Michael Comella
7b5cd8c165
No issue: remove inline from StrictModeManager.resetAfter.
...
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
4 years ago
Jonathan Almeida
23d9951e78
Upgrade to Android Component 62.0.20201006190820 with breaking changes
4 years ago
mcarare
9845626eca
For #15711 : Also add custom engines to fallback list.
4 years ago
Elise Richards
13f3304912
For #8765 : Use shared list widget in collections ( #15733 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Michael Comella
3e96f6b385
For #13959 - review: add clarifying comments.
4 years ago
Michael Comella
50959d997e
For #13959 : add marker when StrictMode is suppressed.
4 years ago
Michael Comella
3b5d6d58d9
For #13959 : add MozillaStrictModeSuppression detekt check.
4 years ago
Michael Comella
4a4edeb184
For #13959 : count StrictMode suppressions on startup.
4 years ago
Jocelyne Abi Haidar
a5de2c0352
For #15675 : Disable Save button when editing saved login until something has been changed
...
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
4 years ago
mcarare
07748f69b7
For #15632 : Improve checking open tabs logic to show collection button.
...
Check now considers selected tab tray mode.
4 years ago
ekager
ec3595d4fc
For #15600 - Move removal of timed out sessions to immediately after restoration
4 years ago
ekager
01eedd159a
No issue: Update biometric, core, and recyclerview libraries
4 years ago
mcarare
b696fc4c4b
For #13031 : Show size in KB for smaller downloaded files.
4 years ago
Jocelyne
0154c81f81
For #10107 : Show Today and Yesterday labels in History ( #15415 )
4 years ago
Jeff Boek
41a92a8d8b
For #15593 - Reverts back to simple UUID creation without Fenix side caching
4 years ago
Jocelyne
e74a12b442
For #15471 : Show Delete button in red in multi-select overflow menu ( #15576 )
4 years ago
Grisha Kruglov
51dab196c4
Closes #15443 : Use fragment's lifecycleScope for AlertDialog actions
4 years ago
Stefan Arentz
ff930175de
For #15537 - Be more verbose about leanplum identifiers ( #15538 )
4 years ago
mcarare
19b377c021
For #15535 : hasOpenTabs now considers the selected tab mode in tray tab.
4 years ago
Michael Comella
56f78cb30c
No issue: elaborate on Components class doc.
...
This is to clarify a misunderstanding I found in PR review.
4 years ago
Sebastian Kaspari
2fda22e857
Revert "For #12565 : Pass metrics to share controller" for debug test failures.
...
This reverts commit bbaca06274
.
4 years ago
Sebastian Kaspari
4de466883b
Revert "For #12565 : Pass bookmark storage to controller" for debug test failures.
...
This reverts commit 3c22100b84
.
4 years ago
Andrew Gaul
cfbad1dae9
Show undo snackbars with padding with static bottom toolbar
...
This specifically fixes the close tab snackbar. This commit mirrors
the logic when not using Undo from
9e876ebc44
. References #14982 .
4 years ago
ekager
01e802fef0
For #15324 - Show tab settings and recently closed items in menu when no tabs
4 years ago
ekager
e49cd9c558
For #15503 - Change recently closed max to 10
4 years ago
TrianguloY
b07af9ccd3
For #13856 - Prevent overscroll in swipe to switch tabs gesture
4 years ago
Tiger Oakes
25f62f1c76
Extract locale settings initial state
4 years ago
Tiger Oakes
acbad66f45
Add test for initial logins list state
4 years ago
Tiger Oakes
f2a6aa4f25
Add tests for initial collection creation state
4 years ago
Tiger Oakes
3c22100b84
For #12565 : Pass bookmark storage to controller
4 years ago
Tiger Oakes
bbaca06274
For #12565 : Pass metrics to share controller
4 years ago
Michael Comella
d767cd199e
For #13959 : fix startup crash by using arg Context.
...
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
4 years ago
Michael Comella
42cca072e2
For #13959 : remove resetAfter & port tests to StrictModeManager.
4 years ago
Michael Comella
f19c9920f9
For #13959 : move resetAfter into StrictModeManager.
...
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
4 years ago
Michael Comella
6abeb2d9e7
For #13959 : change StrictModeManager to class from object.
...
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
4 years ago
Christian Sadilek
d4ab728cff
For #14034 : Add debug preference to override AMO collection in Nightly
4 years ago
Michael Comella
a92356fe00
For #13959 : comment about duplication in logic in StrictMode.
...
I had to drop a commit that addressed the issue because it was too hard
to fix.
4 years ago
Michael Comella
e1bd6191c7
For #13959 : add comment to explain why we only resetAfter in certain build modes.
4 years ago
Michael Comella
3bf71ef655
For #13959 : use ac StrictMode.resetAfter rather than duplicating functionality.
4 years ago
Michael Comella
2c1befaa25
For #13959 : rename to attachListenerToDisablePenaltyDeath for clarity.
4 years ago
Michael Comella
c03c7ef793
For #13959 : remove unused penaltyDialog parameter.
...
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
4 years ago
Michael Comella
f05a542060
For #13959 : always enable detectNonSdkApiUsage.
...
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
4 years ago
Sebastian Kaspari
3983c509dc
Use "undo" implementation from Android Components.
...
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
4 years ago
mcarare
6289da892c
For #15310 : Also catch ActivityNotFoundException when sharing to app.
4 years ago
ekager
0d0a28d551
No issue: Update AC to 61.0.20200925190057
4 years ago
ekager
7d5c199e51
For #12383 #15407 #12860 - Switch to using shared view model for session to delete on home
4 years ago
Grisha Kruglov
2999f64d0a
Closes #15434 : Don't try to display a 'signed in' snackbar in a 'headless' mode
4 years ago
Grisha Kruglov
d98eba1d64
Closes #15432 : Invoke UI updates on main thread in response to account events
4 years ago
Grisha Kruglov
24985d54fa
Closes #15436 : Auto-close tabs during startup on the main thread
4 years ago
mcarare
04e59e0ac5
For #15130 : Remove "what's new card" from onboarding screen.
4 years ago
Kate Glazko
e8855c09e6
For #15320 : Ensure Mimetype Other PDF Shows PDF Icon
4 years ago
Elise Richards
1adf467248
For #14280 , #14743 : Remove old search fragment ( #15169 )
...
* Remove search fragment
* Use new folder to search dialog
* Rebase and lint
* Update tests with search dialog nav directions
* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
4 years ago
Jonathan Almeida
add60611b4
For #15349 : Fixes SyncedTabs suggestion not clicking
4 years ago
Grisha Kruglov
f1b0827a0b
For #15296 : Allow excluding bookmark subtrees when editing parent folder
...
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
4 years ago
Sawyer Blatz
0fa2509bef
For #14243 : Pre-land visuals for Close Tabs CFR ( #15171 )
4 years ago
Grisha Kruglov
71b51146cb
Update breaking changes in the FxA/Sync integration
4 years ago
Jocelyne
d45e482373
For #11800 : Hide reveal and clear password icons if the password is empty when editing a saved login ( #15244 )
...
Co-authored-by: Jocelyne Abi Haidar <jocelyne.abihaidar@gotocme.com>
4 years ago
mcarare
c1bf66618e
#274-android-l10n: Update create account string to avoid partial translations.
4 years ago
person808
baccb153b7
For #15219 - Fix tab tray handle size.
...
Also use dimens for the tab history handle.
4 years ago
ekager
24983af94e
For #15291 - Limit current CFRs to show max one every 3 days
4 years ago
mcarare
94d9a2a1ed
For #15263 : Properly update open links in app preference.
4 years ago
ekager
a9075ff87b
For #15272 - Remove bottom margin for toolbar on enter fullscreen
4 years ago
ekager
030d6a5b36
For #15121 - Ensure tabs removed while on browser select an available parent session
4 years ago
mcarare
896c1b7875
For #15268 : Use safe navigation to addon details fragments.
4 years ago
Grisha Kruglov
f51b570654
For #15284 : Process root titles when creating new folders
...
This also simplifies how we do this. We're no longer creating instances of `DesktopFolder` class
nor creating copies of BookmarkNodes just to display root titles correctly for the 'edit folder' UI.
4 years ago
ekager
f16ade33df
For #15089 - Disable recently closed in multiselect
4 years ago
ekager
b5f1e772bd
For #15112 - Still show recently closed when history empty
4 years ago
Grisha Kruglov
5691088787
For #15286 : Don't crash when separators are long-touched
4 years ago
ekager
9a2103a9a7
For #13934 - Make TabHistory work on PWA/Custom Tabs
4 years ago
ekager
407c31fdb3
No issue: Fixes strict mode death in debug custom tab
4 years ago
ekager
9e876ebc44
For #14982 - Show snackbars with padding with static bottom toolbar
4 years ago
ekager
18ca211434
For #14458 - dismiss keyboard on fill link from clipboard
4 years ago
ekager
e162aefbc6
For #15245 - Remove margin for toolbar on toolbar-less PWA
4 years ago
Grisha Kruglov
b7b3ee5ce6
For #2792 : Display bookmark folders at the top of the bookmarks UI
4 years ago
Grisha Kruglov
078843675b
For #15211 : Make sure bookmarks are moved to the end of folders
4 years ago
Grisha Kruglov
027c1f9ea7
Closes #15206 : Only track 'move' event if bookmark parent was changed
4 years ago
Grisha Kruglov
b5b32ba6ea
For #11502 : Make sure to always process root titles for parent folders during edit
...
This also switches to a simpler bookmarks query API ('getBookmark') which doesn't fetch
children. We don't need 'children' for this dialog, and so don't need to do the extra work.
4 years ago
Grisha Kruglov
958474f9fb
For #13157 : Filter out folder being edited from 'select folder' dialog
4 years ago
Grisha Kruglov
fe288edb5d
Rename 'visitedAddBookmark' arg to a less confusing name
4 years ago
Grisha Kruglov
24de85f805
Remove unused nav arg from 'select folder'
4 years ago
Tiger Oakes
b563576335
Closes #14131 : Move constants to dimens.xml ( #14135 )
...
Co-authored-by: Elise Richards <erichards@mozilla.com>
4 years ago
Elise Richards
a4ff782565
For #13812 : add ETP category for redirect trackers ( #15139 )
...
* Feature flag for ETP cookie purging
* Strings for new ETP description
* Remove icons from ETP info screeen and add category for redirect trackers
* ETP policy factory tests
* Remove icons from ETP panel and add cross tracking allowed field.
* Remove icons on ETP panel. Add blocked category for redirect trackers to panel.
* Add margins to tracking protection settings
4 years ago
Jeff Boek
6781018556
For mozilla-mobile/android-components#8429 - Dont initialize MLS if token is null
4 years ago
Jeff Boek
8bdc9d0431
Revert "For #12544 - Prevent search engines mixup"
...
This reverts commit 0a4a170f7e
.
4 years ago
Hakkı Kaan Çalışkan
0afb7a3f25
For #13922 : Add indicator to synced tabs suggestions in awesomebar
4 years ago
Jonathan Almeida
d063cd5396
For #14230 : Stop redrawing all top sites when one is removed
4 years ago
mcarare
5b33044999
For #12829 : Add create account option on the the sign in screen.
4 years ago
mcarare
81985f4179
For #12829 : Update addUnderline extension function to accept parameters.
4 years ago
mcarare
cc9667f722
For #15150 : Do not show open banner if open in app is ON in settings.
4 years ago
mcarare
79135b1df5
For #13943 : Change strict mode penalty to penaltyDeath.
...
Also, keep dialogPenalty as replacement option for penaltyDeath.
4 years ago
Sören Hentzschel
55b5a452d1
For #14933 - Fixed private browsing icon color in preferences fragment
4 years ago
Tiger Oakes
b927b688c9
Merge bookmark item and folder view holders
4 years ago
Tiger Oakes
3059a57747
Change separator to use its own view holder
4 years ago