Colin Lee
4c2a7ac10e
Delete AUTH_SESSIONS with COOKIES
2019-09-09 12:32:28 -07:00
Colin Lee
758f4c13ec
Updates per UX and PR feedback
2019-09-09 12:32:28 -07:00
Colin Lee
2b9efccfca
For #3106 : Granular options for clearing user data
2019-09-09 12:32:28 -07:00
Petru Lingurar
b82024f993
For #4856 - Refactor InflationAwareFeatureTest
...
We previously had a test exactly for checking that "start does nothing" but we
now need to ensure that start actually is propagated to the inner feature that
is to rebind itself to the app to allow for user interactions.
2019-09-06 14:20:02 -04:00
Sawyer Blatz
aef087aae0
No issue: Removes unused nestedScrollQuickActionView ( #5143 )
2019-09-06 09:03:24 -07:00
Sawyer Blatz
2653b5966e
For #964 : Adds ability to disable each suggestion provider ( #5096 )
...
* For #964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
Sawyer Blatz
09dcdb079d
For #4474 : Adds what's new button to home screen menu ( #5088 )
...
* For #4474 : Adds what's new button to home screen menu
* For #4474 : Adds tests for what's new button
2019-09-03 15:16:29 -05:00
Petru Lingurar
46b09395f8
For #5067 - Refactor ShareControllerTest following the use of SendTabUseCases
2019-09-03 12:01:26 -07:00
Sebastian Kaspari
2723a55b03
Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
f3d8a89c63
Rename AccountSettingsStore/State/Action to AccountSettingsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
61e84c161d
Rename SearchStore/State/Action to SearchFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
22446263f1
Rename ExceptionsStore/State/Action to ExceptionsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
ac32a88d45
Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
76063e307a
Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
mihai-adrian
3171f3a1a7
Fixes #4997 : Changed navigation to ShareFragment
...
Changed test for new global navigation to share fragment.
2019-09-03 07:08:08 -10:00
Sebastian Kaspari
9b633f7f0f
Move creation of GeckoRuntime to flavor-specific source set.
...
Since we are now able to build against GeckoView Nightly and GeckoView Beta,
we should create the GeckoRuntime from a flavor-specific source set.
Creating the runtime is not covered by the AC abstraction and so API changes
in GeckoView Nightly can break the build and leaves us with no option to fix
it from a shared code base. Separating the creation of GeckoRuntime
allows us to adapt individually and also to configure the runtimes
differently.
2019-08-30 15:16:12 +02:00
Mugurell
bf5b0e5cda
For 4007 - Add unit tests for the Share Interactor, Controller and list Adapters
2019-08-29 18:12:50 -07:00
Tiger Oakes
f740d4382a
Closes #773 - Add shortcuts to homescreen ( #4925 )
2019-08-29 14:45:11 -05:00
Tiger Oakes
d1964d6536
Fixes #4771 - Add method for sessions of type ( #4782 )
...
Fixes share tabs to use the new method
2019-08-27 13:04:03 -07:00
Sourabh
091778a4b9
For #4398 - add HistoryController ( #4837 )
2019-08-27 10:33:40 -07:00
Tiger Oakes
9f154dc3a0
Extract intent processors from HomeActivity ( #4884 )
2019-08-22 13:31:40 -05:00
Tiger Oakes
c475bc87cf
Move classes out of top-level package
2019-08-21 13:52:30 -07:00
Jeff Boek
e601fe7c9f
For #4326 - Updates codebase to support latest version of ktlint
2019-08-21 13:50:51 -07:00
Colin Lee
051ae9f584
For #3869 : Switch to A-C SearchLocalizationProvider ( #4858 )
...
* For #3869 : Switch to A-C SearchLocalizationProvider
* Fix test
2019-08-21 11:14:59 -07:00
Sourabh
672462f230
add tests for DefaultQuickActionSheetController ( #4835 )
2019-08-21 08:52:01 -07:00
Tiger Oakes
aab357845b
No issue: Clean up preferences code ( #4699 )
2019-08-21 08:38:14 -07:00
Emily Kager
c1b1c2f332
For #3967 - Invokes pending deletion with more bookmark actions ( #4522 )
2019-08-21 08:36:41 -07:00
Tiger Oakes
33f3b14c29
Adds setters and property delegates in Settings
( #4809 )
...
* Change Settings to use setters
* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
Tiger Oakes
ac6c1ec2ee
Closes #2690 - Clean up CreateCollection viewmodel ( #4731 )
2019-08-20 10:45:41 -07:00
Tiger Oakes
ad98b2f3ea
For #4744 - Extract private browsing button ( #4813 )
2019-08-20 10:41:18 -07:00
Tiger Oakes
95ef312b1e
Issue #1000 - Remove isCustomTab flag ( #4656 )
2019-08-20 10:00:49 -07:00
Sourabh
1afc0eacd8
For #4399 : Create LibState Controller for Search ( #4673 )
...
* For #4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
2019-08-20 09:07:00 -07:00
Mugurell
c3d981e5a3
For 4827 - Remove TransitionPreDrawListenerTest pending tests refactoring
...
New tests for `FragmentPreDrawManager` are to be added in #4828
2019-08-20 13:45:55 +02:00
Tiger Oakes
b8c93107c0
For #4744 - Extract TransitionPreDrawListener ( #4812 )
2019-08-19 16:27:43 -07:00
Mugurell
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Tiger Oakes
de14962e3f
Extract quick action sheet observer code ( #4368 )
2019-08-19 08:28:33 -07:00
Emily Kager
7d02354f4f
For #4799 #4790 - Don't use passed in sessions in BrowserToolbarController ( #4800 )
2019-08-18 20:36:40 -05:00
Colin Lee
d1aed157dd
For #4686 : Fix potential security issue ( #4764 )
2019-08-16 16:50:54 -05:00
Colin Lee
5b4a441bcb
For #1667 : Screen reader can't reach other UI items when QAB expanded ( #4695 )
2019-08-14 09:56:29 -07:00
Sebastian Kaspari
b733fcdbd5
Closes #4719 : Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. ( #4722 )
2019-08-14 09:10:24 -05:00
Grisha Kruglov
634ee184a6
No issue: add some BookmarkFragmentInteractor tests
2019-08-09 17:27:58 -07:00
Yeon Taek Jeong
b24793d863
ktlint fix
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
aac73a8fe2
Finish adding tests
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
6c9ce784b1
Fix, add some tests
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
faf0ecbcc0
For #4125 : Migrate Sign in to Sync to Libstate
2019-08-09 13:39:51 -07:00
Jonathan Almeida
353ecab44e
No issue: Disable failing ActivationPingTest
2019-08-09 15:22:38 -04:00
Tiger Oakes
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
Jonathan Almeida
23f5ac0fb9
For #4066 : Create InflationAwareFeature for lazy inflation
2019-08-09 11:48:55 -04:00
Emily Kager
e1f0c9f48b
No issue: Update testing dependencies
2019-08-08 11:37:16 -07:00
Sawyer Blatz
ff6e9bccb7
For #4451 : Adds tests for DefaultBrowserToolbarController ( #4493 )
...
* For #4451 : Adds tests for DefaultBrowserToolbarController
* Continue working
* Large refactoring of test
* Mock analytics
* Fix merge conflicts
2019-08-08 09:02:42 -07:00
Sawyer Blatz
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
ValentinTimisica
59c60ef189
Fixes #4354 : Updated SearchFragment state after returning from SearchEngineFragment.
...
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
2019-08-07 13:19:53 -07:00
Tiger Oakes
3c1ce90f6f
Fixes #2379 - Generic library selection
2019-08-06 11:10:50 -07:00
Yeon Taek Jeong
83ceec6289
For #201 : Search Widget
2019-08-02 11:26:48 -07:00
Colin Lee
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
2019-08-02 10:11:21 -07:00
Sawyer Blatz
97f7d5ba87
For #2267 : Fixes telemetry for reader view ( #4328 )
2019-07-31 17:58:37 -07:00
Jeff Boek
e7ec6246fd
For #4137 - Fixes HistoryStoreTest
2019-07-31 14:35:33 -07:00
Jeff Boek
af449c84d5
For #4137 - Fixes HistoryInteractorTest
2019-07-31 14:35:33 -07:00
Sawyer Blatz
6fa022c2f8
For #4124 : Migrate BrowserToolbar to Libstate ( #4279 )
...
* For #4124 : Migrate BrowserToolbar to Libstate
* Restores QuickActionSheetReducer
* Improve tests
* Make QuickActionSheetController
* Finalize tests
* Breaks out QuickActionSheetState
* Fix comments
* Adds BrowserStoreTest
2019-07-29 12:39:36 -07:00
Colin Lee
48aeb19db1
For #3695 : Make SessionSuggestionProvider link to existing tab ( #4280 )
2019-07-26 09:49:25 -05:00
Colin Lee
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
2019-07-25 21:55:51 -05:00
Emily Kager
be10d427e8
For #4127 - Converts Exceptions to LibState and adds tests
2019-07-22 17:21:06 -04:00
Sawyer Blatz
7588251f8b
Closes #3986 & Closes #3661 : Migrate QuickActionSheet to LibState & add tests ( #4058 )
...
* Closes #3986 : Migrate QuickActionSheet to LibState
* Closes #3661 : Add tests for QuickActionSheet
Co-authored-by: boek <jeff@jeffboek.com>
* For #3986 : Fix feedback
2019-07-22 10:31:31 -07:00
Tiger Oakes
edb0a3ed08
For #3633 - Update StoreProvider to use a callback
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-07-18 18:16:49 -04:00
Jeff Boek
e294521c92
Fix search metrics ( #4150 )
...
* For #4082 - Changes lifecycles for metrics
* For #4082 - Replaces the SearchEngine name with the identifier for
countLabel
2019-07-18 14:35:34 -07:00
Tiger Oakes
6da6ddb095
Use StateListDrawable & resources w/ TabCollection
2019-07-18 15:29:06 -04:00
Emily Kager
ae3d187909
For #3987 - Convert History to Lib-State and add tests
2019-07-17 17:23:09 -07:00
Christian Sadilek
c04dcec03f
Closes #4096 : IllegalStateException in SearchFragment ( #4131 )
2019-07-17 15:10:24 -05:00
Christian Sadilek
e91a2e61a2
For #3633 : Add unit tests for SearchStore
2019-07-15 13:47:01 -04:00
Jeff Boek
e4ff70c542
For #3633 - Refactors the search screen to use lib-state
...
* For #3633 - Adds SearchStore
* For #3633 - Refactors AwesomeBarUIView
* For #3633 - Refactors ToolbarUIView to use lib-state
* For #3633 - Fixes a couple of state bugs
* For #3633 - Moves all user interaction to SearchInteractor
* For #3633 - Adds kdocs to SearchStore and SearchInteractor
* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property
* For #3633 - Creates `StateViewModel` to handle state restoration
* For #3633 - Adds a test for onTextChanged
* For #3633 - Adds tests for SearchInteractor
* For #3633 - Fixes bugs and adds documentation
2019-07-12 16:32:00 -07:00
Tiger Oakes
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
Colin Lee
15d887e41f
For #2251 - Add bookmark adapter diffutil ( #3936 )
...
* For #2251 - Add bookmark adapter diffutil
* For #2251 - Fix unit tests for bookmark adapter diffutil
2019-07-08 14:00:25 -05:00
Colin Lee
d28bb76d25
No issue: Fix broken Settings test
2019-06-24 19:17:08 -07:00
Denys M
6d6b240e48
Add unit tests for Settings
.
...
Add unit tests for `Settings`.
2019-06-24 16:02:34 -07:00
Colin Lee
f1088222b4
For #3203 : Updates edit bookmarks to have user friendly names ( #3372 )
...
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
2019-06-12 14:10:43 -05:00
Jeff Boek
e7e644f07e
For #2395 - Fixes test suite
2019-06-05 10:47:21 -07:00
Grisha Kruglov
6a8d0f324e
Closes #2770 : Allow receiving tabs from FxA devices ( #2772 )
...
* Closes #2770 : Allow receiving tabs from FxA devices
Now that we're on a-c 0.54, we can land this since it supports device
capability migration.
This patch adds a SEND_TAB device capability, making Fenix a valid target
in the Send Tab device list on Desktop Firefox.
Additionally, it adds a notification manager which manages notification
channels and knows how to display "received tabs" notifications".
* Post: remove unusued test file that's causing issues
2019-05-23 13:13:27 -07:00
Tiger Oakes
cfca683a14
Use UpdateTrackingProtectionUseCase
...
mozilla-mobile/android-components#2746
2019-05-20 19:39:20 -07:00
Sawyer Blatz
72d29c2a43
For #2205 & #1578 : Integrates tab collection storage ( #2478 )
...
* For #2205 : Adds TabCollectionStorage
* For #1578 : Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
Jeff Boek
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Sawyer Blatz
e1cdeffe8c
For #563 : Restyles history management ( #2378 )
2019-05-10 09:58:54 -07:00
Colin Lee
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
2019-05-09 23:06:12 +00:00
Colin Lee
78f8354fbb
Fix build breakage over FragmentScenario integration
2019-05-08 10:27:24 -05:00
Colin Lee
96b68948b5
For #1710 : Create scaffolding for Robolectric tests ( #2282 )
2019-05-07 16:36:37 -05:00
Alessio Placitelli
0d82431195
Generate the activation
ping and send it with Glean ( #1707 )
...
This fetches the Google Advertising ID, salts it and
then applies hashing before sending a ping with it,
at startup. Hashing and salting are used in order
to prevent ourselves to correlate advertising IDs
from the same user running different products we
own off a single device. We will never send the
client_id and the Google Advertising ID in the same
ping.
2019-05-03 09:40:21 -05:00
Colin Lee
a60d2c071c
For #1967 : Multi-selection toolbar should disappear after deleting ( #2202 )
2019-05-01 13:51:37 -05:00
Colin Lee
bc1b7e0b43
For #1539 : Add bookmark multi-select features
2019-04-12 13:35:28 -05:00
Colin Lee
b54d4d1d58
Closes #1312 , #1236 , #1237 , #1238 , #1239 : Creating, Editing, and Deleting Bookmarks and Bookmark Folders
2019-04-08 14:48:36 -05:00
Grisha Kruglov
0bcad0d364
History UI limits: visit type & time
...
These are temporary limitations to make History UI somewhat functional,
until we get relevant UI and API changes in place.
2019-04-04 16:16:45 -07:00
Colin Lee
bd81e72239
Fixes #916 , fixes #917 , fixes #920 : Save, share, and delete bookmarks
2019-04-01 16:16:08 -05:00
Jeff Boek
9227f67545
Fixes HsitoryCOmponentTest
2019-03-25 16:04:19 -05:00
Colin Lee
5cf61c95db
Fixes #589 : Add sample unit tests for a component
2019-02-20 09:20:40 -08:00
Colin Lee
b2b6a530d0
Make ktlint and detekt style changes
2019-01-30 11:08:25 -06:00
Jeff Boek
e34f7e166d
Initializes Android project
...
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
2018-12-07 15:25:38 -05:00