Commit Graph

376 Commits (ba2af02407754bad35b2c641321c2a268390bdd7)

Author SHA1 Message Date
Elise Richards 7fdad978a3
For FNXV2-17067: always show home in background behind search dialog (#20573)
* Navigate to home on toolbar click. Handle back press from search dialog

Update tests to show home behind search dialog. Remove unused test.

Jump back in show all button is clickable behind search dialog

Recently saved bookmarks show all button is clickable behind search dialog

* Add feature flag

* Past explorations show all button is clickable behind search dialog

Handle keyboard in controllers instead of viewholders. Update tests.

Allow collections to be visible behind search dialog

Dismiss keyboard and search dialog with navigateUp instead of just dismissing the keyboard

Verify navigateUp in tests

Adding ignore for flaky UI test

Only resize home behind search dialog

Add ignore for collection intermittent test

Cleanup
3 years ago
Christian Sadilek 01555c2bea
Update Android Components version to 92.0.20210806164329 (#20722)
Addresses breaking change in ShortcutsSuggestionProvider
3 years ago
Mugurell 27d3a3f0dd For #20584 - Use CombinedHistorySuggestionProvider for history suggestions
This should ensure user is always presented with history results for his
searches.
3 years ago
Gabriel Luong 0f861236c1 Add history metadata feature to the settings menu 3 years ago
Sebastian Kaspari 971b419d77 Run ktlintFormat to adapt to latest formatting rules. 3 years ago
Gabriel Luong 973070ab50 For #20259 - Add HistoryMetadataSuggestionProvider in AwesomeBar 3 years ago
Mugurell f95567912f For #20229 - Use the AC common implementation for ads/search telemetry
Everything should work exactly as before.
3 years ago
Roger Yang 74c1cc82fb Closes #19921: Update appcompat and fragment dependencies to 1.3.x 3 years ago
rxumoz 3a4f73be19
For #10300 - Fix Baidu search telemetry (#19127) 3 years ago
Dharan Aditya 6cbc35b7d8
Fixed mozilla-mobile#18641: [Bug] Fill link from clipboard overlaps search engines (#18657) 3 years ago
Sebastian Kaspari 6a1b5875b0 Use new SearchSuggestionProvider flag. 3 years ago
Sebastian Kaspari cf4847dc17 Remove browser-search references. 3 years ago
Mugurell abe3036065 For #18439 - Open link from QR code only if activity is not null 3 years ago
Roger Yang 10eace2f99
Closes #18068: Track custom fill link from clipboard clicked (#18827) 3 years ago
Mihai Adrian Carare ccfb275b03
For #17800 - Request desktop site from home screen. (#18653) 3 years ago
Arturo Mejia 54db8f3fde Revert "For #17805 - Fix adjustResize deprecation (#18252)"
This reverts commit 38f906a6
3 years ago
Codrut Topliceanu 38f906a685
For #17805 - Fix adjustResize deprecation (#18252)
* For #17805 - Fix adjustResize deprecation

To handle the deprecation of `adjustResize` I've moved it from `styles.xml` and `AndroidManifest.xml` to `Activity.kt` as a fallback for devices with Android < 11. For Android 11 and up `setDecorFitsSystemWindows(false)` and `OnApplyWindowInsetsListener` will be used to handle app insets. Normal use activities should call `enableSystemInsetsHandling` in `onCreate` as to properly display system bars and for proper keyboard handling.
3 years ago
Gabriel Luong 3a056bf850
For #18036 - Add TrackKeyInfo to Ad Click Metrics (#18159) 3 years ago
Arturo Mejia 0e8dc6164d Target Android 11 3 years ago
mcarare 9e20de21a8 For #16044: Suggest search engines based on typed text. 3 years ago
Codrut Topliceanu d56b4a2b92
For #17418 - Added telemetry for Google Default Top Site (#17637)
* For #17418 - Adds channel "ts" to TrackKey

This is used to track if the `InContentTelemetry` is a result of the user using the Google Top Site. It looks for `&channel=ts` within the uri.

* For #17418 - Adds TopSite PerformedSearch back in

* For #17418 - Check now looks for equality with GOOGLE_URL

* For #17418 - Adds test for topSite changes
3 years ago
Sebastian Kaspari f4a7b4c066 Remove TabsUseCases methods that take a Session object. 3 years ago
mcarare 994ec4d55a For #17364: Make hint scrollable and do not overlap other elements. 3 years ago
mcarare d7ad203544 For #17364: Do not show search suggestion hint before starting to type. 3 years ago
mawen7 1df656cd0e
Include selected session in session suggestions if opened from home fragment (#17127) 3 years ago
Codrut Topliceanu 20f2135578
For #17377 - Fix for empty awesomeBar on searchFragment open (#17435)
The awesomeBar was set to stay hidden for the first consumeFrom(store) if the SearchDialogFragment.kt. However, recent changes send an additional store update when the view is created. To work around it we can take a look at AwesomeBarView.update(), we see that the awesomeBar suggestions get provided only if the query != url. So we can use the same method to keep the awesomeBar hidden until the user changes anything in the url.
3 years ago
Sebastian Kaspari fb64c7c076 SearchDialogController: Pass tab ID instead of Session instance. 4 years ago
mcarare 156dee29d8 For #15464: Always dismiss search dialog on url committed. 4 years ago
mcarare 04bd9c61a6 For #16483: Rotate edit arrow when toolbar position is set to bottom. 4 years ago
ekager 419f895364 For #16973 - Use controller handled action instead of toolbar focus 4 years ago
Michael Debertol 95860eba49
For #4333: Open the keyboard when a search engine is selected (#14353)
Co-authored-by: Elise Richards <erichards@mozilla.com>
4 years ago
mcarare a2ad9f7a27 For #16894: Handle adding voice search button depending on state. 4 years ago
ekager 2bb7bea258 For #16668 - Fix keyboard show/hide from search dialog fragment 4 years ago
Elise Richards 77f061c362 Closes #8791: Use A-C tab counter and upgrades to A-C 69.0.20201203202830
Upgrades to A-C 69.0.20201203202830 and addresses breaking changes:
- Upgrades androidx workmanager to 2.4.0 in line with A-C.
- RecordingDevicesNotificationFeature was removed
- SearchUseCases accept parent session ID instead of session itself
4 years ago
ekager b9737bde95 For #16351 - Add divider lines for search dialog 4 years ago
Sebastian Kaspari 2b759e9d6f Integrate new search code from Android Components into Fenix. 4 years ago
ekager b7fe809ae4 For #16351 - Make homescreen interactive when search dialog is up 4 years ago
mcarare cf162c69d1 For #15788: Remove nested layouts in search dialog layout. 4 years ago
mcarare 0d37c8f268 For #16420: Make search bar first view focused by a11y services on open. 4 years ago
Codrut Topliceanu 6e4393a199
For #15720 - Remove unused telemetry (#15887) 4 years ago
mcarare 5b0bdda974 For #15430: Fix StrictMode death on opening app from widget text search. 4 years ago
Mihai Adrian Carare 0ee7e1c28d
For # 15929: Remove the search widget discoverability experiment. (#16081)
* For #15929: Remove SearchWidgetCFR telemetry.

* For #15929: Remove SearchWidgetCFR and search widget experiment.

* For #15929: Remove unit tests references to search widget experiment.
4 years ago
Juan C. Goncalves eb0712d9b4
For #11397 - Add lint rule for AppCompatResources instead of ContextCompat (#16011) 4 years ago
Mihai Adrian Carare 3ed49d8802
For #14744: Also show Fill link from clipboard with search shortcuts. (#15885) 4 years ago
ekager b6587455f8 fix detekt errors 4 years ago
Sebastian Kaspari 430282c8ec Use new SearchEngineProvider interface. 4 years ago
Elise Richards 1adf467248
For #14280, #14743: Remove old search fragment (#15169)
* Remove search fragment

* Use new folder to search dialog

* Rebase and lint

* Update tests with search dialog nav directions

* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
4 years ago
Jonathan Almeida add60611b4 For #15349: Fixes SyncedTabs suggestion not clicking 4 years ago
Hakkı Kaan Çalışkan 0afb7a3f25 For #13922: Add indicator to synced tabs suggestions in awesomebar 4 years ago
Elise Richards 9afe9679d8
For #15079: handle QR permissions when changed in Android settings (#15097)
* Define intent data for activity

* Search dialog shows permissions for allow and deny camera

* Check camera permissions for fxa pairing

* Check camera permissions for old search

* Tests for pairing sync interactor and controller.

* Cleanup

* Use bool pref for setting. Use interfaces and default implementations for the sync interactor and controller.

* Lint
4 years ago
Hakkı Kaan Çalışkan f87ca730a9 For #11245: Integrate Synced Tabs AwesomeBar suggestions
fix pr
4 years ago
Jeff Boek f9b2d65993 For #5745 - Create preference to disable domain autocompletion 4 years ago
Elise Richards 87bd44145f
For #14239: Notification for QR scan when permissions have been denied (#14553)
* Show dialog when permissions are denied

* Add qr permissions dialog to search dialog fragment

* Add qr permissions dialog to the pairing screen

* Show dialog after permissions have been denied

* Reset focus after denying permissions

* Show dialog after permissions denied in search frag and par frag

* Use shared preferences to store camera permission state

* Move dialog creation into the search controller and add tests

* Dialog controller implementation and test

* Route to intent with correct activity. Set focus when dismissing dialog

* Get preferences in old search
4 years ago
Tiger Oakes a8291bf641
Remove un-needed nullables (#13816) 4 years ago
Tiger Oakes f81b401738
Remove unneeded tint for ic_link (#14381) 4 years ago
Tiger Oakes e067ad5363
For #8157: Redirect about:addons search (#13990) 4 years ago
Jeff Boek 9a56dcd786 For #13784 - Addresses nits 4 years ago
Tiger Oakes 1fab28f043 Add createInitialSearchFragmentState function 4 years ago
Jonathan Almeida 9568bdaed8 Update Android Components and fix breaking tests 4 years ago
Kirill Rakhman bee2ae6c83 Closes #8043 Hook up AwesomeBarView.setOnEditSuggestionListener 4 years ago
Jeff Boek 6492773fc7
Progress on new search experience with Toolbar and Awesomebar placeholders (#13314)
* For #13272 - Adds the ToolbarView to the SearchDialogFragment

* For #13273 - Replaces container dependency with context in AwesomebarView

* For #13276 - Hacks together the awesomebar and toolbar in the new search experience
4 years ago
Jeff Boek a72f9c75f0 For #12570 - Correctly removes search suggestions when search query and url is empty 4 years ago
Hakkı Kaan Çalışkan 12e68ac18d For #12622: Visually indicate different types of suggestions in the search screen 4 years ago
Elise Richards b7325a3833
For #12571: Rename shortcuts to search engine on search screen (#12839)
* Rename shortcuts to search engine on search screen

* Remove deprecated pref key

* Re-add deprecated string
4 years ago
Tiger Oakes d640f58316 For #12565 - Clean up controller and add tests 4 years ago
Tiger Oakes 52de2b8f38 Fix license on remaining files 4 years ago
Sawyer Blatz 0e438ef9a7 For #12430: Hide the mic when not using Google 4 years ago
Jonathan Almeida d5fbc17ccf Update to Android Components 52.0.20200722023149
Fixes breaking APIs in SyncedTabsFeature and
BookmarksStorageSuggestionProvider
4 years ago
Jeff Boek 11e2137fab
For #12806 - Adds unit tests to cover `ToolbarView.update()` (#12807) 4 years ago
Sebastian Kaspari 96121a79fa Issue #7877: Add SearchActionProvider for faster responses that mirror entered text. 4 years ago
Mihai Adrian Carare 9c1b586e45
For #7966: Update toolbar content description. (#12667) 4 years ago
Tiger Oakes a0491b702e
Fix nav graph and theme tests (#12567) 4 years ago
Tiger Oakes d0e9f1f165
Update Kotlin dependency (#10806) 4 years ago
Tiger Oakes 1ff64cab67
Add tests for search (#12437) 4 years ago
Christian Sadilek 27c608d956 Update built-in extensions for new AC/GV API
New API (installBuiltIn/ensureBuiltin) requires
- Gecko IDs and new permissions
- Extension will only be re-installed if it has a new version

This includes a gradle task to automatically generate a
new version in manifest.json for every build so we don't
forget to update the version and end up with changes that
are never applied.
4 years ago
Tiger Oakes 65637e9e2b
Use A-C version of Resources.getSpanned (#12358) 4 years ago
Tiger Oakes fd18687ac9 Switch to any calls 4 years ago
Tiger Oakes 41452e945b Move SearchProviderModel extension to class 4 years ago
Mugurell 0fb6bbc175 For #10401 - Hide Shortcuts if just one search engine is installed
Otherwise, the Shortcuts option which allows to choose with what search engines
to search would be redundant.
4 years ago
Sebastian Kaspari 388c144a62 SearchFragmentStore: Remove Session reference from state and read values from BrowserStore. 4 years ago
ekager 60069395eb Update AC to 48.0.20200627130132 and fix breaking changes 4 years ago
Michael Comella 5ef6b49aa1
For #8795: remove redundant ConstraintLayout around BrowserToolbar. (#12014)
This is functionally equivalent to the code before this patch but should
be slightly more performant in theory because ConstraintLayout is
expensive to inflate.

The elevation and layoutParams set dynamically appeared to have no effect
with the wrapping view but broke the view when used by itself so I had
to remove them. I also updated a few other unnecessary params.

Theoretically this may have some perf benefits but I didn't see anything
outside noise levels after I took the numbers (but I didn't try very
hard).
4 years ago
Mihai Branescu 93247e0b2f For #9425 - SearchFragment now reacts to undo operation for base engines 4 years ago
Mihai Branescu e6e3166d2d For #9425 - SearchFragment now reacts to undo operation for custom engines
When you remove a search engine from our list, an undo snackbar that outlives the fragment is shown. If you go back to the search fragment and press undo, now the shortcut list gets updated
4 years ago
ekager c77ddd8d26 For #11866 - Update back press logic for SearchFragment 4 years ago
Sachin 988513aa89
for #10568 moved awesomebar and toolbar into fragment_search (#11744) 4 years ago
Sawyer Blatz 82facbfa00 For #1216: Remove feature flag for voice search 4 years ago
Sawyer Blatz b06be1fcde For #9488 Add telemetry for search widget CFR 4 years ago
Sawyer Blatz 94d741864e For #9488: Add search widget CFR 4 years ago
Sawyer Blatz 27a85d86dc
For #10803: Hide voice icon in search if not available (#11005) 4 years ago
Tiger Oakes 2397695fe5
For #10596 - Redirect moz://a URL (#10688) 4 years ago
sraturi 29d1893430 for #7032 add scroll listener to make the keyboard disappear on scroll.
touch listener was blocking the scroll
4 years ago
sraturi 4ee65755dc for #7032 fixed issue where pressing back button exited the application 4 years ago
sraturi 2c85a62a5e for #7032 removed recyclerview scroll listener from Awesomebarview 4 years ago
sraturi c8ec25fde9 fixed lint issues 4 years ago
sraturi 703a8ed565 added a onTouch listener to scrollview in search fragment to make it disappear on scroll 4 years ago
Sawyer Blatz 477493e197
For #10465: Add telemetry for voice search (#10785) 4 years ago
Sawyer Blatz 535e020683 For #1216: Put voice search behind a nightly & debug flag 4 years ago
Sawyer Blatz d33edd8841 No issue: Clean up SearchFragment a bit 4 years ago
Sawyer Blatz 011a9e7d96 For #1216: Add voice search 4 years ago