Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-10-27 15:46:27 +00:00
Code Issues Releases Wiki Activity
3,494 Commits 67 Branches 112 Tags 1.2 GiB
b9fe826cef
Commit Graph

3009 Commits

Author SHA1 Message Date
Michael Comella
b9fe826cef [fenix] No issue: Move Do and OpenClass to utils pkg. 
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
 2020-04-08 12:39:22 -07:00
mcarare
c579e388d3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9797: Set min height of dialog edit text to 48dp. 2020-04-08 10:12:20 -04:00
Abhay Agarwal
bcd9f52607 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9495: Dismiss the ShareFragment in onPause() 2020-04-08 13:10:37 +03:00
Sawyer Blatz
7001260885 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9682: Reduces size of branding (https://github.com/mozilla-mobile/fenix/pull/9784) 2020-04-07 14:05:07 -07:00
Christian Sadilek
7df242c354 [fenix] No issue: Refactor readerview to use browser-state 2020-04-07 16:31:03 -04:00
Sawyer Blatz
42a823fe24 [fenix] No issue: Add more settings animations (https://github.com/mozilla-mobile/fenix/pull/9750) 2020-04-07 10:44:23 -07:00
Mihai Eduard Badea
68a5b44663 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2768 - Prevent screenshots in private mode 
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
 2020-04-07 17:23:06 +03:00
Mugurell
8fd1b5ef87 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9770 - Disable pull to refresh pending changes 2020-04-07 17:06:43 +03:00
Mozilla L10n Automation Bot
8f65dd9856 [fenix] Import l10n. 2020-04-07 10:30:26 +03:00
Michael Comella
18a639a64d [fenix] For https://github.com/mozilla-mobile/fenix/issues/9631: remove assertk dependency. 2020-04-06 16:56:40 -07:00
Michael Comella
f2dbaf24d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9631: replace assertk assertions with junit. 
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
 2020-04-06 16:56:40 -07:00
Jeff Boek
4371996382 [fenix] For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker (https://github.com/mozilla-mobile/fenix/pull/9191) 
* For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker

* For https://github.com/mozilla-mobile/fenix/issues/220 - Updates Android Components
 2020-04-06 14:29:52 -07:00
Mihai Adrian
8f1876407b [fenix] For https://github.com/mozilla-mobile/fenix/issues/9687: Refactor onboarding cards to follow app architecture (https://github.com/mozilla-mobile/fenix/pull/9743) 
* For https://github.com/mozilla-mobile/fenix/issues/9687: Refactor onboarding cards to follow app architecture

* For https://github.com/mozilla-mobile/fenix/issues/9687: Update unit test to new controller parameters
 2020-04-06 11:00:47 -07:00
Arturo Mejia
174af614f4 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9647 Crash when tapping settings after quickly 
enabling/disabling add-on
 2020-04-06 13:47:21 -04:00
Michael Droettboom
461853e252 [fenix] Fix errors in top_sites_count metric 
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.

[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
 2020-04-06 10:34:52 -07:00
Mozilla L10n Automation Bot
ff708e4ff1 [fenix] Import l10n. 2020-04-06 12:20:41 +03:00
mcarare
3647494de3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9663: Allow more than one line for onboarding card header 2020-04-03 17:47:11 -07:00
Mozilla L10n Automation Bot
50bb5be4db [fenix] Import l10n. 2020-04-03 17:38:26 -07:00
Aaron Train
4d216e26ea [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9688: Disable ReaderViewTest for intermittent investigation in detection issues 2020-04-03 22:04:43 +03:00
Oana Horvath
47366000e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9670: Disabled intermittent tabMediaControlButton test (https://github.com/mozilla-mobile/fenix/pull/9679) 
and removed file created by mistake -e

added reason for disabled tests
 2020-04-03 20:39:33 +03:00
Mugurell
dca4c74a30 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3262 - Enable pull down to refresh in Nightly 2020-04-03 19:40:08 +03:00
Michael Comella
09253e7566 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 - review: clarify comments in new test runner. 2020-04-03 09:27:49 -07:00
Michael Comella
74fbc518db [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: Add LintUnitTestRunner gradle task. 
This will prevent us from regressing on adding older versions of the
unit test runner.
 2020-04-03 09:27:49 -07:00
Michael Comella
5d2c577c64 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: TestApplication -> FenixRobolectricTestApplication. 
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
 2020-04-03 09:27:49 -07:00
Michael Comella
dff3a69dc3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: move TestApplication to the helpers package. 
The helpers/ package is created to separate the test support code from
the code under test.
 2020-04-03 09:27:49 -07:00
Michael Comella
f11bb37121 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: replace unit test runners with FenixRobolectricTestRunner. 
This is how we can apply the new test runner to remove duplication.

This commit was generated programmatically with the following commands:
```
  // Replace test runners with new one.
  find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
  find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +

  // Replace imports of old test runners with new one
  find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
  find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +

  // Remove unused imports
  find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```

Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
 2020-04-03 09:27:49 -07:00
Michael Comella
b401d400b3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: add FenixRobolectricTestRunner. 
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.

This class is adapted from Firefox for Fire TV:
  https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
 2020-04-03 09:27:49 -07:00
Michael Comella
774a07d5f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: remove unnecessary @RunWith(Robolectric in unit tests. 
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.

Between this change and the last one, the unit test runtime was reduced
by ~10s.
 2020-04-03 09:27:49 -07:00
Michael Comella
b9ffb3ddcc [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: remove unnecessary @RunWith(AndroidJUnit4) in unit tests. 
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
 2020-04-03 09:27:49 -07:00
Aaron Train
3489fe1e22 [fenix] No issue: re-enable libraryMenuItemsTest and backButtonTest (https://github.com/mozilla-mobile/fenix/pull/9639) 2020-04-03 10:37:03 -04:00
MickeyMoz
0487e0ad62 [fenix] Update Android Components version to 38.0.20200403130109. 2020-04-03 16:15:31 +02:00
Mozilla L10n Automation Bot
caded80288 [fenix] Import l10n. 2020-04-03 16:19:33 +03:00
Michael Comella
cb29b33e21 [fenix] No issue: add kdoc to HomeActivity. 
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
 2020-04-02 16:27:00 -07:00
Sawyer Blatz
9e5e780a9a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9128 & https://github.com/mozilla-mobile/fenix/issues/9222 & https://github.com/mozilla-mobile/fenix/issues/9499: Refactors snackbar creation and fixes placement (https://github.com/mozilla-mobile/fenix/pull/9628) 2020-04-02 12:30:13 -07:00
Codrut Topliceanu
b2d81076f9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7978 - Put views above button in scrollView (https://github.com/mozilla-mobile/fenix/pull/8819) 2020-04-02 10:13:32 -07:00
Gabriel Luong
e754578cef [fenix] For https://github.com/mozilla-mobile/fenix/issues/6174 - Add telemetry for WebExtensions (https://github.com/mozilla-mobile/fenix/pull/8318) 2020-04-02 10:12:31 -07:00
Mihai Adrian
2f02eeb972 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9604: Swap and adjust margin with padding to avoid text being cut (https://github.com/mozilla-mobile/fenix/pull/9617) 2020-04-02 09:40:29 -07:00
Michael Comella
006e32c454 [fenix] No issue: remove unused FirefoxTestRunner. 
It would be used for on device tests but it doesn't seem to hooked up
currently.
 2020-04-02 07:57:09 -07:00
Mozilla L10n Automation Bot
f7f452367d [fenix] Import l10n. 2020-04-02 13:42:58 +03:00
mcarare
7e54f731db [fenix] For https://github.com/mozilla-mobile/fenix/issues/9422: Nit: Fix xml indenting 2020-04-02 09:11:31 +03:00
mcarare
34394af021 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9422: Align widget text to viewStart to support RTL layouts 2020-04-02 09:11:31 +03:00
Emily Kager
2ec2ee395b [fenix] For https://github.com/mozilla-mobile/fenix/issues/768: Add first time PWA dialog (https://github.com/mozilla-mobile/fenix/pull/9308) 
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
 2020-04-01 22:56:12 -04:00
Sebastian Kaspari
548a18ba32 [fenix] Use same configuration for "forPerformanceTest" builds like we do for "fennec" flavor builds. 2020-04-01 17:51:32 -07:00
David Walsh
a96fa3b790 [fenix] Prevent favicons from flashing when items are selected in History (https://github.com/mozilla-mobile/fenix/pull/9233) 2020-04-01 15:43:21 -07:00
Mihai Adrian
66d28a700c [fenix] For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating (https://github.com/mozilla-mobile/fenix/pull/9353) 
* For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating

* For https://github.com/mozilla-mobile/fenix/issues/9336 Update unit test to check for navigateSafe
 2020-04-01 15:36:56 -07:00
Mihai Adrian
d6fe360148 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9423: Align preference title and summary to viewStart (https://github.com/mozilla-mobile/fenix/pull/9426) 
* For https://github.com/mozilla-mobile/fenix/issues/9423: Align preference title and summary to viewStart

* Update checkbox_left_preference_etp.xml

Co-authored-by: Jeff Boek <jeff@jeffboek.com>
 2020-04-01 15:36:01 -07:00
ekager
8224f61cb3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9533 - Switch to using enum for Library Item Selected Telemetry 2020-04-01 15:29:08 -07:00
Grisha Kruglov
4b91238222 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9553: Only update account UI state once when creating SettingsFragment 2020-04-01 15:28:39 -07:00
ekager
ea9add8d2b [fenix] For https://github.com/mozilla-mobile/fenix/issues/8125 - Send top sites count with metrics ping 2020-04-01 15:27:39 -07:00
mcarare
ef2d26efee [fenix] For https://github.com/mozilla-mobile/fenix/issues/9365: Partially reverse menu items order when using top toolbar 2020-04-01 15:21:22 -07:00