Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-15 18:12:54 +00:00
Code Issues Releases Wiki Activity
2,029 Commits 67 Branches 116 Tags 1.2 GiB
b6f2e8da35
Commit Graph

1746 Commits

Author SHA1 Message Date
Tiger Oakes
d1964d6536 Fixes #4771 - Add method for sessions of type (#4782) 
Fixes share tabs to use the new method
 2019-08-27 13:04:03 -07:00
Emily Kager
1cf8a40059 For #4295 - Adds Experiments Pref to Data Collection Settings (#4915) 2019-08-27 12:56:16 -07:00
Sebastian Kaspari
c322343248 Closes #4431: Enable feature-media component for all builds. (#4898) 2019-08-27 12:51:27 -07:00
Mihai Adrian
594569164d Fixes #4211 changed SeekBar height to wrap_content to prevent misaligned dot (#4832) 
Changed height from match_constrained to wrap_content.
 2019-08-27 12:50:00 -07:00
Emily Kager
a65f220b39 For #4921 - Adds WindowFeature to BaseBrowserFragment 2019-08-27 15:33:59 -04:00
Arturo Mejia
24f79b3263 Fix safe browsing API breaking change. (#4946) 2019-08-27 13:43:22 -05:00
Aaron Train
2bbb4c29ff
Closes #4926: Add basic UI test for regular/private tabs (#4928) 2019-08-27 13:56:12 -04:00
Sourabh
091778a4b9 For #4398 - add HistoryController (#4837) 2019-08-27 10:33:40 -07:00
Mihai Adrian
5d13c53706 Fixes #4440 changed padding for account_preference (#4830) 
Changed padding to default value in @android:style/Preference.Material.Category.
Also changed paddingEnd value to default value.
 2019-08-27 10:26:32 -07:00
Amaan Marfatia
dc9fdd9db3 Fixes #4067 besides snackbar (#4777) 
* Fixes #4067 besides snackbar

Makes layout hierarchy more shallow to increase performance.

* Fix #4067 Feedback

Make sure quick_action_overlay appears on top and use horizontal chain in tab_header.
 2019-08-27 10:09:55 -07:00
Axel Hecht
1621229a7f Import strings from android-l10n 
State: mozilla-l10n/android-l10n@349efdbc8f
 2019-08-27 08:22:42 -07:00
Colin Lee
153af588af For #4885: D8 Build failure on attempt to execute UI test (#4903) 
* For #4885: D8 Build failure on attempt to execute UI test

* Disabled screengrab tests until AndroidX fix is available
 2019-08-23 13:37:52 -07:00
Tiger Oakes
66e14959ba Add custom tab fragment 2019-08-23 16:12:19 -04:00
ekager
ffbbe119f3 For #3967 - Invoke pending deletion on back pressed 2019-08-23 15:32:27 -04:00
ekager
b07df9698a For #4868 - Update content description of tabs button with number of tabs 2019-08-23 09:21:32 -07:00
Grisha Kruglov
282c2dc182 No issue: only sync once on startup 2019-08-23 12:08:11 -04:00
Emily Kager
b9f6f7fa93 For #4779 : Don't double navigate with global directions in HomeActivity 2019-08-23 12:01:28 -04:00
Axel Hecht
c236c3e34c Import strings from android-l10n 
State: mozilla-l10n/android-l10n@90a28fd458
 2019-08-23 14:36:01 +02:00
Sebastian Kaspari
35ff0a5110 Use version name/code override. (#4895) 2019-08-23 07:08:37 -05:00
Emily Kager
84b0693fd2 For #4652 : Use workaround for HomeScreenViewModel (#4887) 2019-08-22 13:35:51 -05:00
Tiger Oakes
9f154dc3a0 Extract intent processors from HomeActivity (#4884) 2019-08-22 13:31:40 -05:00
Sebastian Kaspari
4bd94f0f9b Rename "nightly" source folder to "fenixNightly". 2019-08-22 19:46:40 +02:00
Tiger Oakes
79e58250fc Make Settings.instance private 2019-08-22 08:14:08 -07:00
Sebastian Kaspari
f62e295fc6 Closes #4874: Use new build types in FeatureFlags class. 2019-08-22 08:12:49 -07:00
Emily Kager
44421392bf Adds experiments preferences strings 2019-08-21 19:55:26 -07:00
Emily Kager
a6483c528b No issue: Land strings for Delete Browsing Data on Quit 2019-08-21 19:55:26 -07:00
Colin Lee
48be48d1b8 For #4064: Dispatchers.Main still has long cold start delay (Phase II) 2019-08-21 14:32:44 -07:00
Tiger Oakes
c475bc87cf Move classes out of top-level package 2019-08-21 13:52:30 -07:00
Richard Pappalardo
ca24dd6ea8 Stub out Settings tests 2019-08-21 13:52:03 -07:00
Jeff Boek
68f5d211d3 For #4326 - Updates codebase to support latest version of detekt 2019-08-21 13:50:51 -07:00
Jeff Boek
e601fe7c9f For #4326 - Updates codebase to support latest version of ktlint 2019-08-21 13:50:51 -07:00
Emily Kager
1b2757be98 No issue: Land new string for delete browsing data prompt (#4859) 2019-08-21 11:17:34 -07:00
Colin Lee
051ae9f584 For #3869: Switch to A-C SearchLocalizationProvider (#4858) 
* For #3869: Switch to A-C SearchLocalizationProvider

* Fix test
 2019-08-21 11:14:59 -07:00
Nick Alexander
23b9a41059 Consume new substitute-local-geckoview.gradle script from Bug 1533465. 2019-08-21 19:52:01 +02:00
Mihai Adrian
df3e1bf9d3 Fixes #4795 fixed requestDesktopStateProvider value from private to desktopMode (#4810) 
RequestDesktopStateProvider was taken from private instead of desktopMode
 2019-08-21 09:10:06 -07:00
Sourabh
672462f230 add tests for DefaultQuickActionSheetController (#4835) 2019-08-21 08:52:01 -07:00
Tiger Oakes
aab357845b No issue: Clean up preferences code (#4699) 2019-08-21 08:38:14 -07:00
Emily Kager
c1b1c2f332 For #3967 - Invokes pending deletion with more bookmark actions (#4522) 2019-08-21 08:36:41 -07:00
Mitchell Hentges
6c020a0bc4 Configure either geckoview beta or nightly at compile-time (#4851) 
* Remove "abi" product flavor and introduce "engine" product flavor.

This patch will allow us to build Fenix against GeckoView Nightly and GeckoView Beta by
introducing a new flavor dimension: engine = [geckoNightly, geckoBeta].

In addition to that it adds a "fenix"  prefix to the nightly, beta and production flavors
to reduce the ambiguity between fenix beta/nightly and GeckoView beta/nightly.

For now the build types have the following engine variants enabled:

**debug**: geckoNightly, geckoBeta
Both variants enabled for local development and testing.

**forPerformanceTest**: geckoNightly, geckoBeta
Both variants enabled unless the perf team only cares about Nightly (tbd)

**fenixNightlyLegacy**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). This release type will eventualyl be decommissioned once we switch to a separate
Nightly app on Google Play.

**fenixNightly**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). Changing this build to use GeckoView Nightly is currently being discussed.

**fenixBeta**: geckoBeta
Fenix Beta uses GeckoView Beta.

**fenixProduction**
Fenix Production uses GeckoView Beta (69) currently.

* gradle.py/variant.py: Replace "abi" with "engine".

* Disable enableUnitTestBinaryResources until we can switch to Android Gradle plugin 3.5.

* Fenix nightly should use both geckoview nightly and beta

* Updates automation to use apk splitting and support different engine
 2019-08-21 08:32:01 -07:00
Jonathan Almeida
71a2478f4d Use Mozilla Android Components 10.0.0 2019-08-21 10:06:05 -04:00
Emily Kager
aa4ed36e46 No issue: Land new strings for ETP and delete browsing data 2019-08-21 10:59:12 +02:00
Yeon Taek Jeong
26c9d5d297 For #2834: Add contentDescription to tabs button icons 2019-08-20 16:34:05 -07:00
Emily Kager
416e25e8a5 No issue: Don't show session provider in private mode 2019-08-20 16:09:55 -07:00
Yeon Taek Jeong
6f899c7fb5
For #2834: Delete all Private Tabs redesign (#4787) 2019-08-20 13:10:08 -07:00
(´⌣`ʃƪ)
c076cc85f9 For #4436: Dismiss onboarding before navigating away from home (#4801) 2019-08-20 10:56:28 -07:00
Tiger Oakes
33f3b14c29 Adds setters and property delegates in Settings (#4809) 
* Change Settings to use setters

* Add delegate for shared preferences
 2019-08-20 10:47:55 -07:00
Tiger Oakes
ac6c1ec2ee Closes #2690 - Clean up CreateCollection viewmodel (#4731) 2019-08-20 10:45:41 -07:00
Tiger Oakes
9ee8c00928 For #4774 - Use vector drawable compat (#4811) 2019-08-20 10:43:02 -07:00
Tiger Oakes
ad98b2f3ea For #4744 - Extract private browsing button (#4813) 2019-08-20 10:41:18 -07:00
Tiger Oakes
090e8006b0 Color the system bars in custom tabs (#4819) 2019-08-20 10:13:01 -07:00
Tiger Oakes
95ef312b1e Issue #1000 - Remove isCustomTab flag (#4656) 2019-08-20 10:00:49 -07:00
Sourabh
1afc0eacd8 For #4399: Create LibState Controller for Search (#4673) 
* For #4399: Create LibState Controller for Search

* fix code format

* add unit tests for DefaultSearchController

* add more test

* fix unit tests
 2019-08-20 09:07:00 -07:00
Mugurell
c3d981e5a3 For 4827 - Remove TransitionPreDrawListenerTest pending tests refactoring 
New tests for `FragmentPreDrawManager` are to be added in #4828
 2019-08-20 13:45:55 +02:00
Mugurell
ab6e7dc52b Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout 
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.

`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
 2019-08-20 13:45:55 +02:00
Emily Kager
115833c78a Update strings.xml 
Remove space in placeholder for es (temp for release)
 2019-08-19 19:14:22 -07:00
Axel Hecht
5e444eccff Import strings from android-l10n 
State: mozilla-l10n/android-l10n@413e05dba4
 2019-08-19 19:14:22 -07:00
Tiger Oakes
b8c93107c0 For #4744 - Extract TransitionPreDrawListener (#4812) 2019-08-19 16:27:43 -07:00
Tiger Oakes
a632d8f1dc For #4744 - Move search bar icon padding to dimens (#4814) 2019-08-19 16:22:51 -07:00
Emily Kager
fb1d655d96 Closes #4822 - Update Bookmark State in onResume (#4823) 2019-08-19 16:22:20 -07:00
Mihai Adrian
bf42abb21c fixes #4179 removed control highlight from disconnect button (#4806) 
set colorControlHighlight to transparent in activity theme.
property cannot be set in view because it is overwritten by activity theme.
 2019-08-19 16:16:06 -07:00
Sawyer Blatz
0d4eceed56 For #2706: Refactor Glean to reduce errors (#4753) 
* For #2706: Adds recording for untracked events

* For #2706: Adds key alignment to Metrics
 2019-08-19 15:25:48 -07:00
Sawyer Blatz
4731977f5d
For #4421: Fixes issues with new glean events (#4816) 2019-08-19 14:49:48 -07:00
Sawyer Blatz
73e3db8fe0 For #4804: Resolves issue with crash reporter stack 2019-08-19 16:40:41 -04:00
Aaron Train
ae05bf98e2
Closes #4618 - Stub Library UI tests (#4619) 
See #4572
 2019-08-19 14:05:10 -04:00
Arturo Mejia
210868f5bc Use Mozilla Android Components 9.0.0-SNAPSHOT. (#4750) 2019-08-19 10:29:10 -07:00
Suraj Shah
806961094b Fixes #4704 (#4728) 
* Fixes #4704. Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.

* Updates CHANGELOG.md

* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
 2019-08-19 09:23:12 -07:00
Mugurell
645674c9bd Closes #4396 - Add a Bookmarks Controller (#4593) 
* For #4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For #4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For #4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
 2019-08-19 08:34:57 -07:00
Tiger Oakes
de14962e3f Extract quick action sheet observer code (#4368) 2019-08-19 08:28:33 -07:00
Emily Kager
7d02354f4f For #4799 #4790 - Don't use passed in sessions in BrowserToolbarController (#4800) 2019-08-18 20:36:40 -05:00
Colin Lee
d1aed157dd
For #4686: Fix potential security issue (#4764) 2019-08-16 16:50:54 -05:00
Yeon Taek Jeong
727457f0ed No issue: fixes click failures on search widget icon 2019-08-16 13:58:29 -07:00
Emily Kager
c9598bc4d1 For #4688 - Try to use context instead of targetContext (#4765) 2019-08-16 10:12:56 -07:00
Yeon Taek Jeong
d4c83f9668 For #4736: Display search shortcuts only from home or search widget 2019-08-15 12:24:54 -04:00
Emily Kager
d07d74e8d3 For #4688 - Try slightly different Context class for MockWebServer (#4747) 2019-08-15 08:05:23 -07:00
Emily Kager
3f820366a6 Closes #4680 - Align collection creation text center vertical 2019-08-14 20:17:01 -04:00
Yeon Taek Jeong
a680d733c8 For #4384: Hide mic icon if speech-to-text is unavailable (#4701) 2019-08-14 16:40:21 -07:00
Yeon Taek Jeong
2441592ef2 For #4516: Use full width for large search widgets (#4659) 2019-08-14 16:00:13 -07:00
Emily Kager
f71106cb51 Closes #3860 - Update description text for collections 2019-08-14 17:13:52 -04:00
Sawyer Blatz
b7ca520787 For #4421: Adds Leanplum events and attributes (#4626) 
* For #4421: Adds Leanplum events and attributes

* For #4421: Adds Leanplum deep links
 2019-08-14 13:48:45 -07:00
Yeon Taek Jeong
67f3b63ae5
For #4421: Add search widget attribute to Leanplum (#4694) 2019-08-14 12:00:29 -07:00
Yeon Taek Jeong
f5ffe3734c
For #4457: Adds telemetry for search widget actions (#4714) 2019-08-14 11:39:54 -07:00
Yeon Taek Jeong
2f265eccbd
For #4732: Fix search engine display issue (#4735) 2019-08-14 11:03:14 -07:00
Mihai Adrian
1a4ef1535c For #4434 - made close button for collections more accessible. (#4443) 
* fixes #4434 - made close button for collections more accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for #4193 - close button for tabs

* fixes #4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button

set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
 2019-08-14 10:12:39 -07:00
Michael Cooper
12371ca9c1 Add no-op experiment to test service-experiments integration (#4551) 
* Add no-op experiment to test service-experiments integration

* Shorten metric name to meet schema

* Add active_experiment metric to docs

* Add approved data review
 2019-08-14 12:07:41 -05:00
Tiger Oakes
3acabeb6c3 Use global navigation action for browser fragment (#4691) 2019-08-14 11:58:29 -05:00
isabelrios
7729cb63a7 Fix UI Screenshot TabMenuTest (#4730) 2019-08-14 11:57:36 -05:00
Colin Lee
5b4a441bcb For #1667: Screen reader can't reach other UI items when QAB expanded (#4695) 2019-08-14 09:56:29 -07:00
Emily Kager
1328d686aa No issue - Autoformatting (#4715) 2019-08-14 09:40:46 -05:00
Sebastian Kaspari
b733fcdbd5 Closes #4719: Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. (#4722) 2019-08-14 09:10:24 -05:00
Colin Lee
e6f9445d11
For #4709: Fix Bugzilla issue 1573549 (#4710) 2019-08-13 22:16:23 -05:00
Sourabh
42e3b2771e fix #4633: show toast only on first login (#4676) 
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
 2019-08-13 16:28:34 -05:00
(´⌣`ʃƪ)
5aac05859d Fix #4436: hide onboarding before navigating to settings (#4675) 
* Fix #4436: hide onboarding before navigating to settings

* No issue: Rename emitAccountChanges to emitModeChanges
 2019-08-13 15:49:42 -05:00
Sebastian Kaspari
d03c15d15c Issue #4431: Integrate feature-media component (Nightly and debug builds only). (#4683) 2019-08-13 15:02:20 -05:00
Colin Lee
0c8bcd39be For #4652: HomeFragment Crash "Can not.. after onSaveInstanceState" 2019-08-12 15:51:49 -04:00
Jorge De Los Santos
337ad1e88e For #3424 - Make talkback ignore ImageButton in Collection Sele… (#3792) 
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
 2019-08-12 11:49:25 -04:00
Grisha Kruglov
b38b94ed79 Closes #4671: Fix a potential NPE in BookmarkFragment 2019-08-12 11:16:28 -04:00
Grisha Kruglov
634ee184a6 No issue: add some BookmarkFragmentInteractor tests 2019-08-09 17:27:58 -07:00
Grisha Kruglov
f323105163 No issue: reduce code duplication in BookmarkFragmentInteractor 2019-08-09 17:27:58 -07:00
Christian Sadilek
5fe05e919a For #4125: Suppress coroutine warning to fix release build 2019-08-09 17:30:27 -04:00
Sawyer Blatz
0ec92d716f
For #4123: Adds telemetry for quick action open in app (#4629) 2019-08-09 13:51:12 -07:00
Yeon Taek Jeong
b24793d863 ktlint fix 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
aac73a8fe2 Finish adding tests 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
6c9ce784b1 Fix, add some tests 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
2a6069bfb7 Fix rest of issues 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
69434a765f Fix most issues 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
faf0ecbcc0 For #4125: Migrate Sign in to Sync to Libstate 2019-08-09 13:39:51 -07:00
Axel Hecht
65de521ccf Import strings from android-l10n (#4643) 
State: mozilla-l10n/android-l10n@ab580f757c
 2019-08-09 14:55:05 -05:00
Colin Lee
7f07eabbd8
For #4652: Crash "Can not perform this action after onSaveInstanceState" (#4654) 2019-08-09 14:46:40 -05:00
Jonathan Almeida
353ecab44e No issue: Disable failing ActivationPingTest 2019-08-09 15:22:38 -04:00
Tiger Oakes
52542708aa Consodilate private browsing code 2019-08-09 11:00:41 -07:00
Jonathan Almeida
23f5ac0fb9 For #4066: Create InflationAwareFeature for lazy inflation 2019-08-09 11:48:55 -04:00
Colin Lee
519c3bde5d For #4066: Provide lazy inflation of Find In Page View 2019-08-09 11:48:55 -04:00
Sawyer Blatz
167b2ef002 No issue: Removes deprecated usage of InstrumentationRegistry 2019-08-08 17:35:13 -07:00
Colin Lee
71c48692da
For #4507 Enable codecov (#4520) 2019-08-08 19:09:54 -05:00
Colin Lee
c9c43260c9
For #4529: Handle crash initializing CreateCollectionViewModel late (#4628) 2019-08-08 17:40:55 -05:00
ValentinTimisica
63d50d9827 Fixes #4323: Modified UI of component_collection_creation. 
To fix the overlapping issue I used Guideline and
layout_constraintWidth_default property. I also used the
layout_constraintHorizontal_bias property to make the back_button to
lean to the left and the select_all_button to lean to the right.
 2019-08-08 12:57:19 -07:00
Christian Sadilek
e26570054a Suppress warning in LeanplumMetricsService to fix release builds 2019-08-08 15:17:12 -04:00
Emily Kager
e1f0c9f48b No issue: Update testing dependencies 2019-08-08 11:37:16 -07:00
Mathieu Leplatre
04daf21437 Fix #4612: Fetch experiments from Remote Settings CDN 2019-08-08 10:15:01 -07:00
Colin Lee
ef97173cd9
For #4529, #4427: Resuming after restoring instance state breaks UI (#4571) 
* For #4529, #4427: Resuming after restoring instance state breaks UI

* Clear up warnings
 2019-08-08 11:05:01 -05:00
Emily Kager
c21c91eac5 No issue: Update testing dependencies and deprecated method (#4608) 2019-08-08 09:03:39 -07:00
Sawyer Blatz
ff6e9bccb7
For #4451: Adds tests for DefaultBrowserToolbarController (#4493) 
* For #4451: Adds tests for DefaultBrowserToolbarController

* Continue working

* Large refactoring of test

* Mock analytics

* Fix merge conflicts
 2019-08-08 09:02:42 -07:00
Hakkı Kaan Çalışkan
0ea595743d Fixes #4562: Add a-c git hash to about page 2019-08-07 16:59:11 -07:00
Emily Kager
0b98d43c23 Closes #4602 - Add back transitions 2019-08-07 16:56:21 -07:00
Sawyer Blatz
4566bd6fba Fixes feedback 2019-08-07 16:41:29 -07:00
Sawyer Blatz
4d14735935 For #3060: Adds Leanplum attributes for fxa syncing 2019-08-07 16:41:29 -07:00
Sawyer Blatz
9d65e665e5 No issue: Removes deprecated usage of ViewModelProviders 2019-08-07 19:21:41 -04:00
Yeon Taek Jeong
ec4d62c895 Fix ktlint 2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
00bd26abe3 Remove task flags 2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
f952234c57 Keep CLEAR_TASK 2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
c87468d031 Remove popBackStack 2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
a8526a0606 For #4438: Fix crash when opening any URL from URL bar w/ long press 2019-08-07 19:17:56 -04:00
Sawyer Blatz
969d17b4a9
For #969: Adds more telemetry for collections (#4539) 2019-08-07 16:05:20 -07:00
Tiger Oakes
8698ade699 Minify the fenix 2019-08-07 14:24:32 -07:00
Sawyer Blatz
da06b0fb15
For #4508: Treats warnings as errors (#4543) 2019-08-07 14:00:53 -07:00
Grisha Kruglov
f23f3b7489 Closes #4467: Use a-c version of FirefoxAccountsAuthFeature 2019-08-07 13:42:39 -07:00
ValentinTimisica
59c60ef189 Fixes #4354: Updated SearchFragment state after returning from SearchEngineFragment. 
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
 2019-08-07 13:19:53 -07:00
Colin Lee
a514cb3f8c No issue: Add OSS licenses link to About page 2019-08-07 12:40:10 -07:00
Sawyer Blatz
f9288c7fbd
For #969: Finalizes collections telemetry (#4592) 2019-08-07 10:26:52 -07:00
Richard Pappalardo
422818c917
Stub out tabs tests (#4573) 2019-08-07 09:54:38 -07:00
Emily Kager
8194e0778e For #4026 - Update BookmarkDiffUtil to update on Title or URL change 2019-08-07 00:37:16 -04:00
Jeff Boek
cf169da2fc For #4557 #3860 - Add string for collection empty state 2019-08-06 21:36:54 -07:00
Emily Kager
0604e9858d Closes #3939 - Adds strings for delete browsing history 2019-08-06 16:06:56 -07:00
Emily Kager
b20c381af9 For #1749 - Land ETP Strings 2019-08-06 14:55:47 -07:00
ValentinTimisica
71aedc79fe Fixes #3922: Added accessibility announcement for history empty state. 
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
 2019-08-06 12:32:59 -07:00
Tiger Oakes
631b7ba7cb Issue #1000 - Split out common browser functions 2019-08-06 12:31:25 -07:00
Emily Kager
23bc8f4320 Fro #4563 - Update delete button alpha when history mode changes 2019-08-06 12:26:25 -07:00
Tiger Oakes
3c1ce90f6f Fixes #2379 - Generic library selection 2019-08-06 11:10:50 -07:00
Emily Kager
4bbb291e8d No issue: Update UI tests with new engine shortcuts behavior (#4552) 2019-08-06 08:30:15 -07:00
ekager
0320efee84 No issue: Removes focusableInTouchMode from home searchbar view 2019-08-05 15:42:21 -07:00
Yeon Taek Jeong
6f962d3376
For #1744: Open search shortcuts when entering search mode (#4536) 2019-08-05 15:07:03 -07:00
Emily Kager
6f7ae227a8 Closes #4540 - Set correct tint for select bookmark folder icon (#4541) 2019-08-05 14:54:39 -07:00
Emily Kager
ad448b37ae Closes #4537 - Adds description for onboarding placeholder string (#4542) 2019-08-05 14:51:11 -07:00
ekager
5edc9d0b4e For #2021 - Update custom preferences' views with email/account changes 2019-08-05 09:53:27 -07:00
Travis Long
51218bc93e Integrate service-experiments component (#4098) 2019-08-05 11:14:42 -05:00
Emily Kager
a526e0fad3 For #4455 - Rename history headers by hours and days (#4478) 2019-08-05 11:12:22 -05:00
Nikit Bhandari
8aecc2b850 For #4530 Reduce build warnings (#4531) 2019-08-05 11:10:57 -05:00
ekager
d0071d0177 For #4495 - Clean up homescreen toolbar focus and content descriptions 2019-08-05 08:58:03 -07:00
Emily Kager
890833d7ac No issue: Fix failing UI tests because of renamed views (#4527) 2019-08-05 10:09:34 -05:00
Sören Hentzschel
bfd4849064 For #1427 - enter multi select mode with single click on favicon in library 2019-08-03 16:43:51 -07:00
Nikit Bhandari
671727c3e8 For #4341 use camelCase for views referenced from code 2019-08-03 09:25:55 -07:00
Nikit Bhandari
1cb9f88787 For #4199 make checkbox disabled when there is no data (#4200) 
* For #4199 make checkbox unclickable when there is no data
 2019-08-02 17:42:39 -07:00
Tiger Oakes
1e4399ee38 Use auto pause with BrowserFragment observers 2019-08-02 17:32:58 -07:00
Tiger Oakes
cbd811dcfb Closes #1657 - Use Gecko for downloads (#4296) 2019-08-02 17:28:30 -07:00
Tiger Oakes
6e2ea0750e Issue #2379 - Use LibrarySiteItemView in history 2019-08-02 17:15:41 -07:00
mihai-adrian
bac2e40eb2 fixes #4435 - changed title of menuitem for delete and added content description 
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
 2019-08-02 17:09:24 -07:00
Yeon Taek Jeong
3a262a429b For #3907: Hide 'Go back' button for bad websites from new tabs 2019-08-02 17:00:48 -07:00
ekager
015922ddd2 No issue: Fix Crash lower API by setting gradient drawables in onBind 2019-08-02 16:18:34 -07:00
ekager
79160255c8 No issue: Just use TextView, not AppCompatTextView 2019-08-02 13:23:55 -07:00
Yeon Taek Jeong
83ceec6289 For #201: Search Widget 2019-08-02 11:26:48 -07:00
Jonathan Almeida
ec96d134ff No issue: Fix breaking AccountObserver API 2019-08-02 13:40:50 -04:00
Sawyer Blatz
29f089c414 For #2203: Polishes BrowserToolbarMenu 2019-08-02 13:40:50 -04:00
Colin Lee
33e881ca8a For #1539: Only allow delete when folders multi-selected (#4062) 2019-08-02 10:11:21 -07:00
ValentinTimisica
da59e36c1b Fixes #4410: Modified visibility of 'Add Tab' button. 
I changed the visibility of 'Add Tab' button according to the number of
opened tabs. If there is at least one tab open, the button is displayed.
 2019-08-02 08:49:50 -07:00
Grisha Kruglov
ae33234bbc Closes #2593: FxA automatic sign-in integration 2019-08-01 17:03:45 -07:00
Grisha Kruglov
210864186b Reflect current sync status when opening account settings 2019-08-01 17:03:45 -07:00
Sawyer Blatz
f89cefe92c No issue: Fixes failing UI test on master 2019-08-01 19:10:51 -04:00
Tiger Oakes
c342a680d8 Fix crash for bookmarks 2019-08-01 18:57:35 -04:00
Emily Kager
d42e72fd8b Closes #4462 - Adjust layout params of select bookmark folder view 2019-08-01 13:31:13 -07:00
Thom Chiovoloni
a1adb2e57f Update fenix for new megazord setup 2019-08-01 13:10:20 -07:00
Tiger Oakes
ccae66c08a Issue #2379 - Use LibraryPageView in history 2019-08-01 15:59:55 -04:00
Jeff Boek
2813a3cff7 For #4441 - Keeps the ID 0 based for the recyclerview 2019-08-01 10:45:23 -07:00
Christian Sadilek
9887945296 For #4412: Only consume state change when UI initialized 2019-08-01 11:51:32 -04:00
isabelrios
f815ef1dd0 Fixes #4324 - Add more l10n screenshots tests (#4350) 
* Fixes #4324 - l10n Add more screenshots tests

* change test name

* final changes

* fixing reviewer comments
 2019-08-01 08:35:47 -07:00
Christian Sadilek
b646e87d9e No issue: Add engine warmup call 2019-08-01 10:53:55 -04:00
Jeff Boek
e4700f76c6 For #3886 - Uses defaultDeviceName for the DeviceConfig device name 2019-07-31 21:34:21 -07:00
Jeff Boek
a75c2f7cfb No Issue - Fixes the offset key to prevent endless history bug 2019-07-31 17:58:56 -07:00
Sawyer Blatz
97f7d5ba87 For #2267: Fixes telemetry for reader view (#4328) 2019-07-31 17:58:37 -07:00
Sawyer Blatz
2e7a61860a For #969: Adds more telemetry for collections (#4358) 2019-07-31 17:07:41 -07:00
Jonathan Almeida
4922e5d09d No issue: Move PublicSuffixList to root component 
With the PublicSuffixList class in Utilities, the first instantiation
of it (prefetching in onCreate), causes the Utilities to instantiate
and thus slowing down startup by needing the SearchEngineManager from
instantiating as well.

Moving this back to the root component fixes the immediate perf issue.

Co-authored-by: Will Hawkins <whh8b@obs.cr>
 2019-07-31 17:01:14 -07:00
Christian Sadilek
59c0005979 For #4412: SiteSecurityClickedListener set incorrectly 2019-07-31 19:52:53 -04:00
Will Hawkins
ed31d990a4 No Issue: Move notification manager to member of background services 
Instead of taking notification manager as a parameter
(from the utils class), create one private to the
BackgroundServices class. This means that we do not need
to create the entirety of utilities just to use
the notification manager.
 2019-07-31 16:11:46 -07:00
mihai-adrian
fa8199f429 fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small 
changed size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
 2019-07-31 14:42:43 -07:00
mihai-adrian
30ecbc6000 fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small 
changes size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
 2019-07-31 14:42:43 -07:00
Jeff Boek
e7ec6246fd For #4137 - Fixes HistoryStoreTest 2019-07-31 14:35:33 -07:00
Jeff Boek
af449c84d5 For #4137 - Fixes HistoryInteractorTest 2019-07-31 14:35:33 -07:00
ekager
4494e40dbc For #4137 - Adds pagination to the history view 2019-07-31 14:35:33 -07:00
Emily Kager
0773069dad For #3829 - Ignore Intents Launched From History 2019-07-31 17:07:54 -04:00
Nikit Bhandari
46de06d132 For #4339 reduce build warnings (#4340) 2019-07-31 11:43:49 -07:00
Emily Kager
95208c84a9 Closes #4265 - Do not pop after all exceptions are removed (#4392) 2019-07-31 11:43:15 -07:00