2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-17 15:26:23 +00:00
Commit Graph

5164 Commits

Author SHA1 Message Date
Michael Comella
af732f0748 [fenix] No issue: elaborate on Components class doc.
This is to clarify a misunderstanding I found in PR review.
2020-09-29 15:39:10 -07:00
Sebastian Kaspari
70dbf0d765 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565: Pass metrics to share controller" for debug test failures.
This reverts commit 5de145914e9fc10d3d647e6f2856c2df19dd9156.
2020-09-29 10:59:31 +02:00
Sebastian Kaspari
9b598b33d8 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565: Pass bookmark storage to controller" for debug test failures.
This reverts commit 9825a5d2dfb0f6d3c0235fdf0032e510c34bf20a.
2020-09-29 10:59:17 +02:00
Andrew Gaul
43778cf3cb [fenix] Show undo snackbars with padding with static bottom toolbar
This specifically fixes the close tab snackbar.  This commit mirrors
the logic when not using Undo from
e14bf8e791aa56ded47812018f32ee9801a5b4f9.  References https://github.com/mozilla-mobile/fenix/issues/14982.
2020-09-29 10:15:30 +02:00
ekager
1429c5ddaf [fenix] For https://github.com/mozilla-mobile/fenix/issues/15324 - Show tab settings and recently closed items in menu when no tabs 2020-09-28 21:09:30 -07:00
ekager
8caf149ab7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15503 - Change recently closed max to 10 2020-09-29 00:03:49 -04:00
TrianguloY
98f8f3b2ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/13856 - Prevent overscroll in swipe to switch tabs gesture 2020-09-28 20:43:44 -07:00
Tiger Oakes
5a3b5af7d9 [fenix] Extract locale settings initial state 2020-09-28 20:39:49 -07:00
Tiger Oakes
be11bfd5b4 [fenix] Add test for initial logins list state 2020-09-28 20:39:49 -07:00
Tiger Oakes
e4bdd355d3 [fenix] Add tests for initial collection creation state 2020-09-28 20:39:49 -07:00
Sören Hentzschel
ac1a2a708a [fenix] For https://github.com/mozilla-mobile/fenix/issues/11561 - changed inactive heading and menu icon color in dark mode 2020-09-28 20:24:12 -07:00
Mozilla L10n Automation Bot
87ecdf8bfb [fenix] Import l10n. 2020-09-28 20:18:50 -07:00
Tiger Oakes
b55c4af6fb [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Pass bookmark storage to controller 2020-09-28 20:05:50 -07:00
Tiger Oakes
966e13c9aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Pass metrics to share controller 2020-09-28 20:05:50 -07:00
Michael Comella
a50cf27648 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: fix startup crash by using arg Context.
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
2020-09-28 18:01:19 -07:00
Michael Comella
53bd004f55 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: remove resetAfter & port tests to StrictModeManager. 2020-09-28 18:01:19 -07:00
Michael Comella
d0fbe70f10 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: clean up existing StrictMode test names. 2020-09-28 18:01:19 -07:00
Michael Comella
8a9472e540 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: move resetAfter into StrictModeManager.
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.

Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```

We're going to have to add a lint check to prevent them from doing that.
2020-09-28 18:01:19 -07:00
Michael Comella
5f8943f76c [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: change StrictModeManager to class from object.
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
2020-09-28 18:01:19 -07:00
Christian Sadilek
76018e2fe0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14034: Add debug preference to override AMO collection in Nightly 2020-09-28 17:25:52 -04:00
Michael Comella
9e86e369b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: comment about duplication in logic in StrictMode.
I had to drop a commit that addressed the issue because it was too hard
to fix.
2020-09-28 13:52:40 -07:00
Michael Comella
394465e33e [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add comment to explain why we only resetAfter in certain build modes. 2020-09-28 13:52:40 -07:00
Michael Comella
c1aa8d396a [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: use ac StrictMode.resetAfter rather than duplicating functionality. 2020-09-28 13:52:40 -07:00
Michael Comella
b2c01e442f [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: rename to attachListenerToDisablePenaltyDeath for clarity. 2020-09-28 13:52:40 -07:00
Michael Comella
1ec45f33a2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: remove unused penaltyDialog parameter.
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
2020-09-28 13:52:40 -07:00
Michael Comella
3b76f2b3fc [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: always enable detectNonSdkApiUsage.
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
2020-09-28 13:52:40 -07:00
Sebastian Kaspari
eca2b8ecf4 [fenix] Use "undo" implementation from Android Components.
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.

Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
2020-09-28 10:04:46 -07:00
Mozilla L10n Automation Bot
788b5bb21e [fenix] Import l10n. 2020-09-28 17:16:11 +02:00
mcarare
3ede6cf544 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15310: Add test for ActivityNotFoundException when sharing to app. 2020-09-28 13:29:17 +03:00
mcarare
9d9d283dc7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15310: Also catch ActivityNotFoundException when sharing to app. 2020-09-28 13:29:17 +03:00
Johan Lorenzo
98aa5bafd0 [fenix] Bug 1667367 - Change nightly schedule to align with GV and AC nightlies
Fixes https://github.com/mozilla-mobile/android-components/pull/8508
2020-09-28 10:48:26 +02:00
ekager
b276e9daca [fenix] No issue: Update AC to 61.0.20200925190057 2020-09-26 12:21:10 +02:00
ekager
cf0af49d3b [fenix] For https://github.com/mozilla-mobile/fenix/issues/12383 https://github.com/mozilla-mobile/fenix/issues/15407 https://github.com/mozilla-mobile/fenix/issues/12860 - Switch to using shared view model for session to delete on home 2020-09-25 16:54:54 -07:00
Grisha Kruglov
c348e03d0e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15434: Don't try to display a 'signed in' snackbar in a 'headless' mode 2020-09-25 15:31:07 -07:00
Grisha Kruglov
a0189c8080 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15432: Invoke UI updates on main thread in response to account events 2020-09-25 15:30:48 -07:00
Grisha Kruglov
5bb231cc70 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15436: Auto-close tabs during startup on the main thread 2020-09-25 15:11:21 -07:00
Aaron Train
a2030dde22 [fenix] No issue: Update Flank to v20.09.3 (https://github.com/mozilla-mobile/fenix/pull/15399) 2020-09-25 13:29:14 -04:00
MickeyMoz
96b7e49f80 [fenix] Update Android Components version to 61.0.20200925130131. 2020-09-25 08:40:01 -07:00
Christian Sadilek
146aa075dd [fenix] Configure M5 AMO collection for Nightly/Debug 2020-09-25 11:18:07 -04:00
mcarare
c5c3b6549d [fenix] For https://github.com/mozilla-mobile/fenix/issues/15130: Remove "what's new card" check in UI test. 2020-09-25 18:04:48 +03:00
mcarare
1d7b1df0e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15130: Remove "what's new card" from onboarding screen. 2020-09-25 18:04:48 +03:00
Mozilla L10n Automation Bot
8774b36f49 [fenix] Import l10n. 2020-09-24 18:03:47 -07:00
Kate Glazko
739a3520e1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15320: Ensure Mimetype Other PDF Shows PDF Icon 2020-09-24 13:49:51 -07:00
Elise Richards
609857c5f1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14280, https://github.com/mozilla-mobile/fenix/issues/14743: Remove old search fragment (https://github.com/mozilla-mobile/fenix/pull/15169)
* Remove search fragment

* Use new folder to search dialog

* Rebase and lint

* Update tests with search dialog nav directions

* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
2020-09-24 15:46:42 -05:00
Jonathan Almeida
2ab099b37b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15349: Fixes SyncedTabs suggestion not clicking 2020-09-24 15:35:06 -04:00
MickeyMoz
fbe9ec094c [fenix] Update Android Components version to 61.0.20200923190103. 2020-09-24 11:48:17 -04:00
Michael Comella
4ac309f013 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15273: add warnings about codeowners; add perf team as CODEOWNERS owner. 2020-09-24 08:33:18 -07:00
Michael Comella
e78c0aad23 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15273: fix suspected syntax errors in code owners.
I validated the paths used using a technique in this blog post:
http://www.benjaminoakes.com/git/2018/08/10/Testing-changes-to-GitHub-CODEOWNERS/

So the syntax error(s) are likely within the names, such as this
example.
2020-09-24 08:33:18 -07:00
Grisha Kruglov
bc90bd2f31 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15296: Allow excluding bookmark subtrees when editing parent folder
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
2020-09-23 23:22:44 -07:00
Mozilla L10n Automation Bot
fdb3d6c013 [fenix] Import l10n. 2020-09-23 21:16:24 -07:00