ekager
9d876a7076
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15347 - Adds telemetry for tabs settings
2020-10-14 22:53:31 -04:00
Gabriel Luong
de0419f182
[fenix] No issue - Commit auto-generated glean changes for metrics.md
2020-10-12 10:26:03 -07:00
Michael Comella
6c86641cbc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: change extra name to firstFramePreDrawNanos.
2020-10-09 15:47:55 -07:00
sraturi
e97a48b48f
[fenix] for https://github.com/mozilla-mobile/fenix/issues/10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types.
2020-10-09 15:47:55 -07:00
Chenxia Liu
20f0e9eaf1
[fenix] Update docs
2020-10-07 11:02:42 -07:00
Grisha Kruglov
cc9268d292
[fenix] Glean docs update
2020-09-23 14:51:04 -07:00
Sawyer Blatz
1a5a88be4b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14565 : Add telemetry for top sites
2020-09-17 10:06:39 -07:00
ekager
793b27980d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13926 - MP migration
2020-09-01 16:27:51 -07:00
Sachin
8025efc0d7
[fenix] for https://github.com/mozilla-mobile/fenix/issues/12573 , added startup type and hasSavedInstance keys to app_startup_type telemetry ( https://github.com/mozilla-mobile/fenix/pull/13494 )
2020-08-26 23:14:13 -07:00
liuche
56821f7270
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12046 - Renew telemetry probes before migration completion ( https://github.com/mozilla-mobile/fenix/pull/13958 )
...
* For https://github.com/mozilla-mobile/fenix/issues/12046 - Renew telemetry probes before migration completion
* Delay remaining probes renewal for one more month.
2020-08-25 10:45:02 -07:00
Michael Comella
e2cd23ab93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14133 : warn opened_link telemetry may be wrong.
2020-08-25 08:39:42 -07:00
MarcLeclair
594483f535
[fenix] 13899 fix formatting issue ( https://github.com/mozilla-mobile/fenix/pull/13900 )
...
13899 re worded the performance readme and removed the reference to debuggable builds
13899 fixed some nits
2020-08-19 12:04:49 -04:00
Elise Richards
1e7d4c3e80
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10261 : PWA Telemetry ( https://github.com/mozilla-mobile/fenix/pull/11859 )
...
* Add PWA events to metrics.
Track events for add to homescreen and install.
Map PWA facts to events
* Map component facts to local metrics
Add events pings to fragments
Supress long method for events
Move install event to AC and collect facts
Retrieve fg and bg events from Facts. Do not track intent fg/bg events, only views
* Allow onPause in base fragment to send telemetry for PWA in the external app fragment. Track foreground and bg locally in fenix, and route install and home screen taps from AC facts
* Rebase
2020-08-03 13:59:31 -05:00
Michael Comella
56b2adf7e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12802 - review: update metrics for data review.
2020-07-31 16:05:06 -07:00
Michael Comella
19abae1155
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12802 : add StorageStats glean metrics.
2020-07-31 16:05:06 -07:00
Jeff Boek
d2d7fceb94
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11579 - Adds telemetry for autoplay settings in Site Permissions
2020-07-29 15:10:25 -07:00
Sawyer Blatz
2a5fdd6054
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9730 : Add Login Dialog Prompt telemetry
2020-07-29 12:59:35 -07:00
sraturi
adfcf08a49
[fenix] for https://github.com/mozilla-mobile/fenix/issues/11830 created class containing the logic for sending AllStartup telemetry logic
...
lint check
renamed the intentReceived telemetry to appOpenedAllSource
added comments
removed unused code
moved lifecycle process to AppAllSourceStartTelemetry
moved tracking event out of init function
lint fix
moved appAllStartTelemetry to components
added bit more info about the metrics
added the onReceivedIntent metric back
minor fix
change discriptions based on the comments frm MR
wrote test cases for AppAllSourceStartTelemetry.kt
lint fix
test case to mock application going background
post rebase:
post rebase:
fixed nit from comments
fixed nit from comments
fixed nit from comments
lint fix
lint fix
2020-07-28 17:09:42 -07:00
Tiger Oakes
5de89421d7
[fenix] Suppress YamlConfig deprecation
2020-07-27 13:56:03 -04:00
Sawyer Blatz
d63bd0b2e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12430 : Hide the mic when not using Google
2020-07-23 19:29:26 -04:00
Elise Richards
5b46f572df
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10173 : login duplicates and save ( https://github.com/mozilla-mobile/fenix/pull/11208 )
...
* Extract controller into it's own class. Implement find dupes and filter based on username.
Create edit login controller. Add text watchers and check for duplicates.
Edit controller test
* Find duplicates and save to store
* Retrieve duplicates from AC and check list on username text changed
Move duplicates logic into the controller
* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.
* Use correct threads in controller. Enable save button when applicable.
Save enabled in datastore.
Move login data to datastore
Rebase with password error states
Update metrics to be more specific for edit
* Create logins controller for AC calls
* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.
Inflate view in edit fragment. Double layout showing up.
Edit view
Controller tests
Controller tests passing
Interactor tests
Lint and detekt cleanup
* Remove datastore and use storage controller for all logins calls to password storage.
Addressed comments
Lint
:
Rebase - 1
2020-07-16 17:08:04 -05:00
Chenxia Liu
a564b2a2fc
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/12044 - Bump expiry by 1mo for release
2020-06-26 18:28:46 -07:00
Sachin
10a018b0b2
[fenix] for https://github.com/mozilla-mobile/fenix/issues/11830 added new metric for collecting startup method from all startup phases ( https://github.com/mozilla-mobile/fenix/pull/11940 )
...
* for https://github.com/mozilla-mobile/fenix/issues/11830 added new metric for collecting startup method
move all source startup telemetry into its own logic and added an UNKOWN state
* switched back to onNewIntent solution
* renamed the metric
2020-06-26 17:38:08 -07:00
Sawyer Blatz
44ef22425b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11479 : Record open tabs count in metrics ping ( https://github.com/mozilla-mobile/fenix/pull/12024 )
2020-06-26 17:15:43 -07:00
Sawyer Blatz
f3b4354e76
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11273 : Add tabs tray telemetry ( https://github.com/mozilla-mobile/fenix/pull/12036 )
2020-06-26 16:37:07 -07:00
Grisha Kruglov
f18c517551
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11909 : Metrics for recording number of recently used PWAs
2020-06-26 14:13:41 -07:00
Elise Richards
71cc2e1612
[fenix] Fix illegal arguments for onboarding keys ( https://github.com/mozilla-mobile/fenix/pull/12033 )
2020-06-26 16:12:18 -05:00
Sawyer Blatz
9834983edc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9625 : Add telemetry for Tracking Protection CFR ( https://github.com/mozilla-mobile/fenix/pull/11923 )
2020-06-25 11:24:55 -07:00
Elise Richards
ad9fa8a2ba
[fenix] https://github.com/mozilla-mobile/fenix/issues/10824 : Onboarding telemetry ( https://github.com/mozilla-mobile/fenix/pull/11867 )
...
* Onboarding events and tracking
* Rename metrics for consistency
* Add reference to PR for the data review
* Add default values to onboarding events
2020-06-25 13:21:31 -05:00
Sawyer Blatz
13e2e1f90b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11392 : Rename Installation ping to FirstSession ( https://github.com/mozilla-mobile/fenix/pull/11869 )
2020-06-25 10:06:26 -07:00
person808
0c7be5c84c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11442 - Telemetry for tab counter menu.
2020-06-15 11:48:12 -07:00
Sawyer Blatz
82766c2043
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11118 : Add missing telemetry
2020-06-12 10:29:05 -07:00
Sawyer Blatz
c75f07a97f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11063 : Update telemetry for etp settings
2020-06-10 22:51:21 -04:00
Chenxia Liu
4e4a09c240
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/10616 - Update docs for app_opened to reflect cold-start
2020-06-04 14:39:43 -07:00
Sawyer Blatz
469c553398
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11118 : Add toggle states to metrics ping
2020-06-04 10:08:23 -07:00
Gabriel Luong
f114509a37
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8920 - [Telemetry] Send add-on ids in a metrics ping
2020-06-04 08:15:39 -07:00
mcarare
b4d01b50ec
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10434 : Handle cases when proc/$pid/stat is not accessible.
2020-06-02 17:57:39 -07:00
Sawyer Blatz
14dca9ab2a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9488 Add telemetry for search widget CFR
2020-05-28 15:15:25 -07:00
Sawyer Blatz
8379ab29eb
[fenix] No issue: Update installation docs timestamp for clarity ( https://github.com/mozilla-mobile/fenix/pull/10866 )
2020-05-22 14:17:47 -07:00
Sawyer Blatz
6d3ff138cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8125 : Add default top site telemetry ( https://github.com/mozilla-mobile/fenix/pull/10752 )
2020-05-22 13:10:09 -07:00
Sawyer Blatz
ce07ba1b8c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10465 : Add telemetry for voice search ( https://github.com/mozilla-mobile/fenix/pull/10785 )
2020-05-20 14:35:57 -07:00
Grisha Kruglov
3e14d2215b
[fenix] Perf telemetry for awesomebar suggestion provider durations
...
See https://github.com/mozilla-mobile/android-components/pull/6802 for details; requires that PR.
2020-05-14 14:13:53 -07:00
Mihai Branescu
990833cafd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10599 - Removed baseline pings form metrics.yaml
...
As per documentation, this ping is intended to provide metrics that are managed by the library itself, and not explicitly set by the application or included in the application's metrics.yaml file.
2020-05-13 14:34:03 -07:00
Simon Chae
8461e941e5
[fenix] Update Android Components version to 41.0.20200512130104 🎲 🎲 ( https://github.com/mozilla-mobile/fenix/pull/10600 )
...
* Update GLEAN metrics and ping formatting
* Update Android Components version to 41.0.20200512130104.
2020-05-12 14:52:58 -04:00
ValentinTimisica
bdc8299a36
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10343 : Updates metrics accordingly to 'Library' removal
2020-05-11 10:22:19 -07:00
Sawyer Blatz
a324d122e9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10426 : Removes installation ping GAID ( https://github.com/mozilla-mobile/fenix/pull/10532 )
2020-05-09 10:35:57 -07:00
Sawyer Blatz
faf0e35a96
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10426 : Adds identifier to Glean for 24 hours ( https://github.com/mozilla-mobile/fenix/pull/10446 )
2020-05-07 08:57:20 -07:00
Mugurell
b3f769b407
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10322 - Update Glean - total_uri_count documentation
...
total_uri_count continues to accurately track the URLs visited by the user in
the current session.
Websites can though programmatically redirect users to a new URL using simple
javascript even without user interaction.
This needs to be documented for future references.
2020-05-01 18:34:39 -07:00
Michael Droettboom
bf0ecbc19d
[fenix] Update generated docs
2020-04-30 08:37:22 -07:00
Mihai Branescu
c1e736fdb2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6557 - added metric for in_content
2020-04-24 15:47:48 -07:00
Mihai Branescu
30273fe6de
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6558 - cleanup + added unit tests
2020-04-24 09:28:40 -07:00
Mihai Branescu
09fae4d74f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6558 - added handling of web extension + sending metric for has_ads
2020-04-24 09:28:40 -07:00
Vlad Filippov
81122da15a
[fenix] Add 'useEmail' and 'useEmailProblem' metrics event
...
Fixes https://github.com/mozilla-mobile/fenix/issues/9834
2020-04-23 10:33:36 -07:00
Sawyer Blatz
8ed532ebdf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9208 : Adds in-product prompt to homescreen ( https://github.com/mozilla-mobile/fenix/pull/9836 )
2020-04-22 14:29:43 -07:00
Jeff Boek
1ba6fea116
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9816 - Adds SessionObserver to session on selection
2020-04-21 14:08:58 -07:00
Michael Comella
91ce22f753
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 - post: update metrics & pings data review URL.
2020-04-17 09:11:58 -07:00
Michael Comella
12e7ad43c8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 - review: move forward metric expiration date.
...
We primarily want to determine if this is a problem area for us to
investigate rather than a long term measurement to keep so we should set
the expiration date accordingly. Furthermore, this code executes before
crash reporting is init so it's ideal to remove it sooner rather than
later.
2020-04-17 09:11:58 -07:00
Michael Comella
3556b5a10f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 : add StartupTimeline ping type and framework_start metrics.
2020-04-17 09:11:58 -07:00
Sawyer Blatz
92ea1cc5b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9892 : Set dynamicToolbarMaxHeigtht to 0 for PWAs ( https://github.com/mozilla-mobile/fenix/pull/9893 )
2020-04-13 13:08:08 -07:00
Gabriel Luong
e754578cef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6174 - Add telemetry for WebExtensions ( https://github.com/mozilla-mobile/fenix/pull/8318 )
2020-04-02 10:12:31 -07:00
ekager
ea9add8d2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8125 - Send top sites count with metrics ping
2020-04-01 15:27:39 -07:00
Mihai Branescu
7c4db6a8af
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9352 - changed capitalisation of 'Open in app'
2020-03-27 14:43:32 -07:00
Sawyer Blatz
3c3db7d3ba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9136 : Send all adjust properties to glean ( https://github.com/mozilla-mobile/fenix/pull/9253 )
2020-03-20 10:06:55 -07:00
Jeff Boek
ea819f9a9d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4807 - Always navigate to settings after deleting data
2020-02-18 13:30:32 -08:00
Jeff Boek
ef35bc2c24
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7295 - Adds more documentation for the installation metrics
2020-02-14 20:56:49 -08:00
codrut.topliceanu
30c7a2dee8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7295 - Updates auto-generated metrics.md
2020-02-14 20:56:49 -08:00
codrut.topliceanu
0c9efef83c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7295 - Adds new custom ping: 'installation'
2020-02-14 20:56:49 -08:00
ekager
fecc5376cf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8126 - Adds default top sites
2020-02-14 14:39:58 -08:00
Mugurell
e7a936910f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6577 - Add total_uri_count
to the Glean metrics ping
...
Re-apply the change for https://github.com/mozilla-mobile/fenix/issues/4456 .
Keep `total_uri_count` as a CounterMetricType and let Glean manage it's
persistence and reset time (resets with each metrics ping sent).
2020-02-13 15:54:55 -08:00
Mugurell
0929ce5872
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6577 - Remove the total_uri_count
Glean StringMetricType
...
This was added as a duplicate to an already existing `total_uri_count`
CounterMetricType in https://github.com/mozilla-mobile/fenix/issues/4456 .
2020-02-13 15:54:55 -08:00
Emily Kager
100d019a67
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/8176 - Adds new string for add to top sites ( https://github.com/mozilla-mobile/fenix/pull/8209 )
2020-02-07 22:05:35 -05:00
Gabriel Luong
aaf9c65f5d
[fenix] Provide add-on support ( https://github.com/mozilla-mobile/fenix/pull/8064 )
...
Closes https://github.com/mozilla-mobile/fenix/issues/5630 , https://github.com/mozilla-mobile/fenix/issues/6069 , https://github.com/mozilla-mobile/fenix/issues/6092 , https://github.com/mozilla-mobile/fenix/issues/6091 , https://github.com/mozilla-mobile/fenix/issues/6124 , and https://github.com/mozilla-mobile/fenix/issues/6147 .
Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-02-04 01:41:51 -05:00
ValentinTimisica
bcc027e1f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7289 : Adds telemetry for selecting dark theme
2020-02-03 23:20:42 +01:00
ValentinTimisica
128ef37d5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6834 : Adds telemetry for About page items
...
Didn't change the existing probe for 'whats new' item because we're already
collecting that info.
2020-02-03 19:28:56 +01:00
Gabriel Luong
1742d10b7e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7525 - Add telemetry for opening a top site in normal and private mode and removing a top site
2020-01-24 15:18:25 -08:00
ekager
6377a946f8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5586 - Add telemetry for save logins setting
2020-01-22 14:19:12 -08:00
Kaaira Gupta
8547ba1a74
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3813 - Create a save button for bookmark editing
2020-01-21 16:03:33 -08:00
Sawyer Blatz
1b6e2b2f2d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6308 : Remove unecessary telemetry & bump expiry date ( https://github.com/mozilla-mobile/fenix/pull/7793 )
...
* For https://github.com/mozilla-mobile/fenix/issues/6308 : Remove unecessary telemetry
* For https://github.com/mozilla-mobile/fenix/issues/6308 : Bump expiry date on telemetry
2020-01-17 15:13:20 -08:00
ValentinTimisica
d4fa64f541
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7751 : Remove 'SearchWithCustomEngine' telemetry event
2020-01-16 10:14:07 -08:00
ValentinTimisica
a5e27570cb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6556 : Adds Telemetry counts for Search Access Points
...
Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and
'suggestion'. Also modified/fixed some tests.
2020-01-16 10:23:48 +02:00
ValentinTimisica
8560ea17c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5884 : Adds user-specified search engines telemetry
...
Created events for adding and deleting a custom search engine and for searches
performed with a custom search engine.
2020-01-13 12:31:23 -08:00
Emma Malysz
eb02fcfcd7
[fenix] For issue 7192: move unsetOpenLinksInAPrivateTabIfNecessary off main thread. ( https://github.com/mozilla-mobile/fenix/pull/7246 )
...
Move method to Settings. There are two instances when we want to call this method: either
processing an intent, or within DefaultBrowserPreference
2019-12-30 14:42:13 -08:00
Ryan Kelly
b806b4c5fa
[fenix] Use feature-accounts-push, which replaces feature-sendtab.
2019-12-13 16:42:28 -08:00
mcarare
7a289d1eb1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6070 Adds telemetry for enabling search suggestions in private
2019-12-04 16:44:01 -08:00
Mihai Branescu
6d8117f1ba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6396 - Added metrics for tracking history/bookmarks account sync toggles ( https://github.com/mozilla-mobile/fenix/pull/6601 )
2019-11-27 11:16:23 +02:00
Sawyer Blatz
723d99864f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5694 & https://github.com/mozilla-mobile/fenix/issues/6054 : Allows users to change toolbar position ( https://github.com/mozilla-mobile/fenix/pull/6608 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5694 & https://github.com/mozilla-mobile/fenix/issues/6054 : Adds preference screen for toolbar
* For https://github.com/mozilla-mobile/fenix/issues/5694 : Adds changing toolbar position functionality
* No issue: Updates telemetry links to actually work lol 😬
* For https://github.com/mozilla-mobile/fenix/issues/6054 : Adds toolbar position to core ping
2019-11-25 16:43:32 -08:00
Gabriel Luong
23069b57af
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5583 - Adds telemetry for download notification ( https://github.com/mozilla-mobile/fenix/pull/6554 )
2019-11-15 16:50:11 -05:00
Gabriel
6314944213
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5705 - Adds telemetry for media state ( https://github.com/mozilla-mobile/fenix/pull/6463 )
2019-11-12 17:24:30 -08:00
Emily Kager
65fb429f90
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5586 - Adds Logins Telemetry ( https://github.com/mozilla-mobile/fenix/pull/6352 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5586 - Adds Logins Telemetry
* Adds Logins Sync Telemetry to PreferenceToggled event
2019-11-12 15:55:36 -08:00
Severin Rudie
153923588f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4281 : fixed metrics.yaml for QAB removal ( https://github.com/mozilla-mobile/fenix/pull/6555 )
2019-11-11 18:01:22 -08:00
Severin Rudie
2e76d82c9a
[fenix] 4281 remove qab ( https://github.com/mozilla-mobile/fenix/pull/6310 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4281 : small ToolbarMenu refactor
This makes it easier to see how items are ordered in the menuItems list
* For 4281: add QAB buttons to menu
* For 4281: removed menu back button per mocks
I double checked with UX, and we'll be relying on the hardware back button for its functionality
* For 4281: add content descriptions for bookmarking
* For 4281: updated BrowserToolbarController for new functionality
* For 4281: provided simple dependencies to browser controller
More complex changes will be in a following commit, for review readability
* For 4281: move toolbar controller dependencies up to BaseBrowserFragment
The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones
* For 4281: removed (now unused) code related to QAB
* For 4281: fix test compilation after QAB removal
Tests still need to be expanded to include added functionality
* For 4281: updated menu to show if url is bookmarked
This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests). After days of work and many attempted solutions, this was the least abhorrent among them.
https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.
* For 4281: update reader mode switch
* For 4281: selectively show/hide menu items
* For 4281: add reader mode appearance
* For 4281: update bookmark button when it is clicked
* For 4281: removed unused QAB code
* For 4281: removed QAB robot, updated UI tests
* For 4281: removed QuickActionSheet metrics
Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped
* For 4281: fixed lint errors
* For 4281: add new strings for buttons added to menu
This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages
* For 4281: remove outdated TODOs
* For 4281: removed QAB container
* For 4281: removed back button reference from UI test
This button no longer exists
* For 4821: Fixes a visual defect (extra padding on top of toolbar)
* For 4281: update copy on reader mode
* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
Sawyer Blatz
c6e952238d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4456 : Updates total_uri_count upload ( https://github.com/mozilla-mobile/fenix/pull/6482 )
2019-11-06 19:10:56 -08:00
ekager
e709201056
[fenix] Use new API for ETP Exceptions
2019-11-05 12:45:58 -08:00
liuche
0eb5656020
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6097 - Bump activation ping expiry date. ( https://github.com/mozilla-mobile/fenix/pull/6309 )
2019-11-01 14:06:44 -07:00
Sawyer Blatz
65fa1e255d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5959 & https://github.com/mozilla-mobile/fenix/issues/5958 : Integrates download feature into Fenix ( https://github.com/mozilla-mobile/fenix/pull/6368 )
2019-10-31 14:37:05 -07:00
Sawyer Blatz
506fdc79a8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4456 : Adds total_uri_count to metrics core ping ( https://github.com/mozilla-mobile/fenix/pull/6003 )
2019-10-30 11:02:33 -07:00
Sawyer Blatz
ed0d2c0c0c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1298 : Fixes issue with Adjust campaign not sending through Glean ( https://github.com/mozilla-mobile/fenix/pull/5896 )
2019-10-29 10:09:07 -07:00
Sawyer Blatz
8314b378d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5737 : Adds telemetry for open links in a private tab ( https://github.com/mozilla-mobile/fenix/pull/5975 )
2019-10-24 17:16:49 -07:00
Jeff Boek
05b2e94dcf
[fenix] No Issue - Updates telemetry docs
2019-10-10 23:00:27 -07:00
Sawyer Blatz
5581b61e60
[fenix] No issue: fixes master ( https://github.com/mozilla-mobile/fenix/pull/5777 )
2019-10-03 14:42:56 -07:00