Severin Rudie
153923588f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4281 : fixed metrics.yaml for QAB removal ( https://github.com/mozilla-mobile/fenix/pull/6555 )
2019-11-11 18:01:22 -08:00
Severin Rudie
2e76d82c9a
[fenix] 4281 remove qab ( https://github.com/mozilla-mobile/fenix/pull/6310 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4281 : small ToolbarMenu refactor
This makes it easier to see how items are ordered in the menuItems list
* For 4281: add QAB buttons to menu
* For 4281: removed menu back button per mocks
I double checked with UX, and we'll be relying on the hardware back button for its functionality
* For 4281: add content descriptions for bookmarking
* For 4281: updated BrowserToolbarController for new functionality
* For 4281: provided simple dependencies to browser controller
More complex changes will be in a following commit, for review readability
* For 4281: move toolbar controller dependencies up to BaseBrowserFragment
The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones
* For 4281: removed (now unused) code related to QAB
* For 4281: fix test compilation after QAB removal
Tests still need to be expanded to include added functionality
* For 4281: updated menu to show if url is bookmarked
This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests). After days of work and many attempted solutions, this was the least abhorrent among them.
https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.
* For 4281: update reader mode switch
* For 4281: selectively show/hide menu items
* For 4281: add reader mode appearance
* For 4281: update bookmark button when it is clicked
* For 4281: removed unused QAB code
* For 4281: removed QAB robot, updated UI tests
* For 4281: removed QuickActionSheet metrics
Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped
* For 4281: fixed lint errors
* For 4281: add new strings for buttons added to menu
This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages
* For 4281: remove outdated TODOs
* For 4281: removed QAB container
* For 4281: removed back button reference from UI test
This button no longer exists
* For 4821: Fixes a visual defect (extra padding on top of toolbar)
* For 4281: update copy on reader mode
* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
Sawyer Blatz
c6e952238d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4456 : Updates total_uri_count upload ( https://github.com/mozilla-mobile/fenix/pull/6482 )
2019-11-06 19:10:56 -08:00
ekager
e709201056
[fenix] Use new API for ETP Exceptions
2019-11-05 12:45:58 -08:00
liuche
0eb5656020
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6097 - Bump activation ping expiry date. ( https://github.com/mozilla-mobile/fenix/pull/6309 )
2019-11-01 14:06:44 -07:00
Sawyer Blatz
506fdc79a8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4456 : Adds total_uri_count to metrics core ping ( https://github.com/mozilla-mobile/fenix/pull/6003 )
2019-10-30 11:02:33 -07:00
Sawyer Blatz
ed0d2c0c0c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1298 : Fixes issue with Adjust campaign not sending through Glean ( https://github.com/mozilla-mobile/fenix/pull/5896 )
2019-10-29 10:09:07 -07:00
Sawyer Blatz
8314b378d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5737 : Adds telemetry for open links in a private tab ( https://github.com/mozilla-mobile/fenix/pull/5975 )
2019-10-24 17:16:49 -07:00
Sawyer Blatz
3cd8b5cf30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5094 : Adds telemetry for show search shortcuts
2019-10-10 22:52:41 -07:00
Michael Droettboom
eefa0e927f
[fenix] Add glinter overrides
2019-10-08 21:40:20 -07:00
Michael Droettboom
1687b09ba0
[fenix] Update bug numbers to URLs
2019-10-07 10:44:11 -07:00
Sawyer Blatz
d9881d8211
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5094 : Adds telemetry for suggestion toggles ( https://github.com/mozilla-mobile/fenix/pull/5704 )
2019-10-03 10:03:14 -07:00
Sawyer Blatz
e3d58b1676
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5567 : Removes search shortcuts button ( https://github.com/mozilla-mobile/fenix/pull/5739 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5567 : Removes search shortcut button
* No issue: Simplifies logic for displaying shortcuts
2019-10-03 08:53:16 -07:00
Sawyer Blatz
a95d6d58d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1298 : Adds adjustCampaignId to core ping ( https://github.com/mozilla-mobile/fenix/pull/5579 )
2019-09-27 08:56:33 -07:00
Sawyer Blatz
1519dbf668
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5197 : Adds telemetry for media notification ( https://github.com/mozilla-mobile/fenix/pull/5520 )
2019-09-27 08:02:29 -07:00
Emily Kager
937b18c4ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5312 - Add Telemetry for Tracking Protection
2019-09-23 08:29:45 -07:00
Sawyer Blatz
746016e560
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5197 : Adds telemetry for media controls ( https://github.com/mozilla-mobile/fenix/pull/5266 )
2019-09-20 14:49:27 -07:00
Grisha Kruglov
6411072f0d
[fenix] FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes https://github.com/mozilla-mobile/fenix/issues/4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-16 19:44:13 -07:00
Emily Kager
e647d7e8c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3700 - Add Setting to Delete Data on "Quit" menu action
2019-09-11 16:06:18 -07:00
Yeon Taek Jeong
88ecaf12b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4658 : Add private browsing mode shortcut telemetry
2019-09-11 16:03:22 -07:00
Jeff Boek
2102e39e4b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5214 - Bumps expiration dates for telemetry
2019-09-11 14:44:13 -07:00
Sawyer Blatz
88996e7f0c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/964 : Adds ability to disable each suggestion provider ( https://github.com/mozilla-mobile/fenix/pull/5096 )
...
* For https://github.com/mozilla-mobile/fenix/issues/964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
Sawyer Blatz
5a5f46cb76
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5021 : Adds metric for what's new button
2019-09-04 09:17:14 -07:00
Sawyer Blatz
da34c36d24
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4908 : Adds metrics for send tab telemetry
2019-09-04 09:15:50 -07:00
Yeon Taek Jeong
b4fa37b231
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4658 : Add some private browsing mode telemetry ( https://github.com/mozilla-mobile/fenix/pull/4968 )
2019-08-28 14:41:37 -07:00
Sawyer Blatz
0356d7c3ec
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4969 : Removes erroneous FxA sign up ping ( https://github.com/mozilla-mobile/fenix/pull/4970 )
2019-08-28 14:32:43 -07:00
Sawyer Blatz
1c995d36e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2706 : Refactor Glean to reduce errors ( https://github.com/mozilla-mobile/fenix/pull/4753 )
...
* For https://github.com/mozilla-mobile/fenix/issues/2706 : Adds recording for untracked events
* For https://github.com/mozilla-mobile/fenix/issues/2706 : Adds key alignment to Metrics
2019-08-19 15:25:48 -07:00
Sawyer Blatz
46eaca2871
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Fixes issues with new glean events ( https://github.com/mozilla-mobile/fenix/pull/4816 )
2019-08-19 14:49:48 -07:00
Sawyer Blatz
6cfbb2c02b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum events and attributes ( https://github.com/mozilla-mobile/fenix/pull/4626 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum events and attributes
* For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
Yeon Taek Jeong
468c400ff5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4457 : Adds telemetry for search widget actions ( https://github.com/mozilla-mobile/fenix/pull/4714 )
2019-08-14 11:39:54 -07:00
Michael Cooper
9646181343
[fenix] Add no-op experiment to test service-experiments integration ( https://github.com/mozilla-mobile/fenix/pull/4551 )
...
* Add no-op experiment to test service-experiments integration
* Shorten metric name to meet schema
* Add active_experiment metric to docs
* Add approved data review
2019-08-14 12:07:41 -05:00
Sawyer Blatz
20b0c30640
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4123 : Adds telemetry for quick action open in app ( https://github.com/mozilla-mobile/fenix/pull/4629 )
2019-08-09 13:51:12 -07:00
Sawyer Blatz
e904bd867e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/969 : Adds more telemetry for collections ( https://github.com/mozilla-mobile/fenix/pull/4539 )
2019-08-07 16:05:20 -07:00
Sawyer Blatz
464a5f92cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2267 : Fixes telemetry for reader view ( https://github.com/mozilla-mobile/fenix/pull/4328 )
2019-07-31 17:58:37 -07:00
Sawyer Blatz
1b027a36e4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/969 : Adds more telemetry for collections ( https://github.com/mozilla-mobile/fenix/pull/4358 )
2019-07-31 17:07:41 -07:00
Sawyer Blatz
9d4312204f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/969 : Adds telemetry for collections ( https://github.com/mozilla-mobile/fenix/pull/3935 )
2019-07-18 16:05:42 -07:00
Sawyer Blatz
6dd34ece58
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2267 : Adds telemetry for reader mode ( https://github.com/mozilla-mobile/fenix/pull/3941 )
2019-07-18 15:17:15 -07:00
Jeff Boek
c6c5f6918c
[fenix] Fix search metrics ( https://github.com/mozilla-mobile/fenix/pull/4150 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4082 - Changes lifecycles for metrics
* For https://github.com/mozilla-mobile/fenix/issues/4082 - Replaces the SearchEngine name with the identifier for
countLabel
2019-07-18 14:35:34 -07:00
Sawyer Blatz
8ab0e5a405
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2362 : Adds telemetry for history ( https://github.com/mozilla-mobile/fenix/pull/3940 )
2019-07-16 12:21:03 -07:00
Sawyer Blatz
a8b04c98b9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3174 : Adds telemetry for bookmarks ( https://github.com/mozilla-mobile/fenix/pull/3724 )
2019-07-02 08:41:20 -07:00
Jeff Boek
9928cc3c1e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds docs for search_default_engine telemetry
2019-06-11 10:55:54 -07:00
Sawyer Blatz
83134baf48
[fenix] For https://github.com/mozilla-mobile/fenix/issues/975 : Removes leakcanary and default browser telemetry ( https://github.com/mozilla-mobile/fenix/pull/3350 )
2019-06-11 12:30:25 -05:00
Sawyer Blatz
11baba71dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/975 : Adds preferenceToggled event ( https://github.com/mozilla-mobile/fenix/pull/3316 )
...
🤦🏼♂️
2019-06-10 13:56:12 -07:00
Colin Lee
858f7a8504
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1301 : Change ping for total_uri_count
2019-06-06 12:58:55 -07:00
Sawyer Blatz
0680bc4e69
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1190 : Removes syncing items from FxA telemetry
2019-06-05 13:57:18 -07:00
Jeff Boek
3c91c152fb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1158 - Add the search count to the baseline ping
2019-06-05 12:09:02 -07:00
Sawyer Blatz
4ded533432
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1192 : Updates detection for Lockwise
2019-06-04 11:23:18 -07:00
Jeff Boek
0d227b360f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1158 - Use a dot instead of an underscore to seperate values
2019-05-31 18:15:07 -07:00
Jeff Boek
3e36b2ec4a
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/2920 - Adds missing data review links
2019-05-29 09:21:32 -07:00
Sawyer Blatz
e73188f04c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1190 : Adds additional telemetry for FxA login
2019-05-24 17:39:19 -07:00
Sawyer Blatz
b479cc4320
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1190 : Adds telemetry for FxA login
2019-05-24 17:39:19 -07:00
Sawyer Blatz
6539a5aad2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1242 : Adds telemetry for error pages
2019-05-21 10:12:52 -07:00
Sawyer Blatz
2dc63e54e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/976 : Adds telemetry for library
2019-05-20 19:30:29 -07:00
Sawyer Blatz
b13095adb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1857 : Adds telemetry for QR scanner
2019-05-17 10:46:53 -07:00
Jeff Boek
abaec0708d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2260 - Sends valid keys to the labeled counter ( https://github.com/mozilla-mobile/fenix/pull/2330 )
2019-05-08 12:15:19 -05:00
Alessio Placitelli
d353bf344f
[fenix] Generate the activation
ping and send it with Glean ( https://github.com/mozilla-mobile/fenix/pull/1707 )
...
This fetches the Google Advertising ID, salts it and
then applies hashing before sending a ping with it,
at startup. Hashing and salting are used in order
to prevent ourselves to correlate advertising IDs
from the same user running different products we
own off a single device. We will never send the
client_id and the Google Advertising ID in the same
ping.
2019-05-03 09:40:21 -05:00
Sawyer Blatz
fb12b695e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/975 : Adds telemetry for settings toggles ( https://github.com/mozilla-mobile/fenix/pull/1896 )
...
* For https://github.com/mozilla-mobile/fenix/issues/975 : Adds telemetry for settings toggles
* For https://github.com/mozilla-mobile/fenix/issues/975 : Uses failable constructor
2019-04-26 08:42:20 -07:00
Colin Lee
f91ab0b460
[fenix] Merge pull request https://github.com/mozilla-mobile/fenix/pull/1785 from colintheshots/fix1301
...
For https://github.com/mozilla-mobile/fenix/issues/1301 : Add uri_count to metrics ping
2019-04-26 00:43:02 -07:00
Sawyer Blatz
5ee04c708c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1192 : Adds telemetry for Mozilla products ( https://github.com/mozilla-mobile/fenix/pull/1953 )
2019-04-25 12:33:15 -07:00
Colin Lee
d3d178240e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/974 : Telemetry for Bookmarks
2019-04-17 15:58:58 -07:00
Sawyer Blatz
facdaee5e8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/977 : Adds telemetry for custom tabs ( https://github.com/mozilla-mobile/fenix/pull/1697 )
2019-04-17 11:13:48 -07:00
Jeff Boek
cb2f2cf080
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1158 - Add search counts
2019-04-17 10:04:49 -07:00
Jeff Boek
09f47c82be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/800 - Adds metrics for the default search engine
2019-04-15 09:14:40 -07:00
Jeff Boek
62a755f0d3
[fenix] No Issue - Remove data team from notifications emails list
2019-04-12 16:46:01 -05:00
Jeff Boek
aff85189d2
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1157 - Addes Fenix Core to the telemetry notification list
2019-04-08 15:03:59 -05:00
Sören Hentzschel
fa453a9587
[fenix] For https://github.com/mozilla-mobile/fenix/issues/469 : remove "Your" from "Your library" string
...
(see https://github.com/mozilla-mobile/fenix/issues/469#issuecomment-480400794 )
2019-04-06 10:11:01 -07:00
Sawyer Blatz
0b99b7fc12
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1195 : Adds telemetry for quick action sheet ( https://github.com/mozilla-mobile/fenix/pull/1362 )
2019-04-05 15:08:55 -07:00
Jeff Boek
84b638f6ba
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1024 - Adds metrics for browser menu items
2019-04-03 15:37:52 -07:00
Jeff Boek
236c5ef455
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1191 - Crash reporter metrics
2019-04-03 15:37:52 -07:00
Jeff Boek
8c98ed5f1e
[fenix] Adds data review link and an entry to the changelog
2019-04-03 12:17:20 -05:00
Jeff Boek
1e5cb40479
[fenix] For https://github.com/mozilla-mobile/fenix/issues/957 - Adds telemetry for context menu items
2019-04-03 12:17:20 -05:00
Jeff Boek
e093dad678
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1036 - Adds Glean metrics for find in page
2019-04-03 12:17:20 -05:00
Sawyer Blatz
d56e5d1933
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1194 : Adds shortcut telemetry
2019-04-03 11:12:17 -05:00
Jeff Boek
2f4edbc2fa
[fenix] Addresses metrics nits
2019-03-22 17:14:35 -07:00
Jeff Boek
b5d6497a10
[fenix] Documents new telemetry events
2019-03-22 17:14:35 -07:00
Jeff Boek
a637e8f678
[fenix] For https://github.com/mozilla-mobile/fenix/issues/959 - Adds search related telemetry
2019-03-22 17:14:35 -07:00
Jeff Boek
83c7697a84
[fenix] For https://github.com/mozilla-mobile/fenix/issues/959 - Adds telemetry for when the search bar is tapped
2019-03-22 17:14:35 -07:00
Jeff Boek
e787da2218
[fenix] For https://github.com/mozilla-mobile/fenix/issues/968 - Adds telemetry for app entry point
2019-03-22 17:14:35 -07:00
Jeff Boek
2bb460608d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/960 - Adds metrics to measure if Fenix is the default browser
2019-03-22 17:14:35 -07:00