2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Commit Graph

2639 Commits

Author SHA1 Message Date
David Walsh
248237290e
For #10865 - Implement 3 dot menu for tab tray (#10869) 2020-05-27 13:07:03 -05:00
David Walsh
54cb8f0194 Remove unused import 2020-05-27 08:45:15 -07:00
David Walsh
5e4fd460f8 Remove onTabClosed from interactor 2020-05-27 08:45:15 -07:00
David Walsh
8b843ac9e5 Fix elevation for snackbar and fab 2020-05-27 08:45:15 -07:00
David Walsh
e9bcc9bb1e Move snackbar to TabTrayDialogFragment 2020-05-27 08:45:15 -07:00
David Walsh
f653964ee1 For #10864 - Display snack bar to undo closing tabs 2020-05-27 08:45:15 -07:00
mcarare
a59917cdc0 For #9626: Swap margin for padding and remove use of touch delegate.
Also remove text margin to maintain visual appearance.
2020-05-27 08:43:43 -07:00
mcarare
d706b085a9 For #9626: Delay cloning ConstraintSet to only when needed for updating. 2020-05-27 08:43:43 -07:00
Mugurell
d0e2d02b34 For #10948 - Avoid PWA onboarding if user already has them on screen
It is possible that after migration users would already have Firefox PWAs on
their screen.
Since they already know about this functionality, we should not promote it to
them with the one-off `FirstTimePwaFragment`.

To query installed PWAs we'll use an API available only on Android >= 26 which
means that we will probably have half of users with PWAs still see the
onboarding but half which will not.
2020-05-27 08:42:56 -07:00
Sebastian Kaspari
21bd379438 Issue #9815: Allow Intents to set HomeActivity.OPEN_TO_BROWSER. 2020-05-27 10:55:44 +02:00
Roger Yang
538a7917e4
Closes #10906: Add Open in app option in custom tab (#10929) 2020-05-26 14:37:53 -04:00
Tiger Oakes
2397695fe5
For #10596 - Redirect moz://a URL (#10688) 2020-05-26 11:06:01 -07:00
Simon Chae
422cf74731 For #8319: Integrate nest WebExtensionBrowserMenu support 2020-05-26 14:02:22 -04:00
mcarare
6e325d6242 For #6198: Update copy and position of pair QR code scan message. 2020-05-25 17:53:20 -04:00
Sebastian Kaspari
b666fbe3fe CrashReporter: Set release channel specific sentry project URL. 2020-05-25 16:13:54 +03:00
Mugurell
2dfd833941 For #10844 - Fennec page shortcuts will open in normal tabs
This comes to resolve a small regression in which they were opened in new
custom tab.
2020-05-25 14:37:00 +03:00
Grisha Kruglov
b26ac51e90 For #10494: Process HomeMenu builder changes on the main thread
Problem was that we were trying to process menu changes (in response to account manager events) on some background thread as that's what account manager emits them on, so some code internally in PopupWindow's dismiss handling (i think, didn't dig very deeply here) was silently giving up and we'd get into a bad state.

The reason this seemingly only happened if you quickly opened a menu on startup is because account manager isn't initialized until sometime after the startup finished. So the trick was to open the menu (and register account manager state callbacks) before it got initialized, so that the callbacks are invoked.

This should also reproduce in other, much more obscure ways, e.g. if you open the menu right before sync is scheduled to run in the background, change FxA password on another connected client, and then eventually receive a onAuthenticationProblem callback.
2020-05-22 13:50:57 -07:00
Sawyer Blatz
7067e5c000
For #8125: Add default top site telemetry (#10752) 2020-05-22 13:10:09 -07:00
sraturi
29d1893430 for #7032 add scroll listener to make the keyboard disappear on scroll.
touch listener was blocking the scroll
2020-05-21 18:54:50 -07:00
sraturi
4ee65755dc for #7032 fixed issue where pressing back button exited the application 2020-05-21 18:54:50 -07:00
sraturi
2c85a62a5e for #7032 removed recyclerview scroll listener from Awesomebarview 2020-05-21 18:54:50 -07:00
sraturi
c8ec25fde9 fixed lint issues 2020-05-21 18:54:50 -07:00
sraturi
703a8ed565 added a onTouch listener to scrollview in search fragment to make it disappear on scroll 2020-05-21 18:54:50 -07:00
Jeff Boek
601aedda46 For #10504 - Removes "old" TabTrayFragment 2020-05-21 15:17:20 -07:00
Jeff Boek
c32904a1d0 For #10504 - opens the tab tray and filters the tab based on the browser mode 2020-05-21 15:17:20 -07:00
Jeff Boek
a674c5dfe7 For #10504 - cleans up tabLayout colors 2020-05-21 15:17:20 -07:00
Jeff Boek
4e499e7a48 For #10504 - Adds tabTrayDialogInteractor to browserfragment 2020-05-21 15:17:20 -07:00
Jeff Boek
cc6a380d45 For #10504 - Show tab dialog on browserfragment 2020-05-21 15:17:20 -07:00
Jeff Boek
90cef752b0 For #10504 - Fixes up tab tray dialog styles 2020-05-21 15:17:20 -07:00
Jeff Boek
0b9484a172 For #10504 - Adds padding fto account for navigation bar in landscape 2020-05-21 15:17:20 -07:00
Jeff Boek
dd2a26fc7c For #10504 - Added the tab tray to the TabTrayDialogFragment and wired up dismiss actions 2020-05-21 15:17:20 -07:00
Jeff Boek
34ac9df481 For 10504 - Adds dialog style and fab 2020-05-21 15:17:20 -07:00
Jeff Boek
97d66cce56 For #10504 - Creates the TabTrayDialogFragment 2020-05-21 15:17:20 -07:00
ekager
516a6fe9f7 For #6832 - Only emit session changes if fragment is attached 2020-05-21 10:11:50 -07:00
ekager
83ab7646c1 For #7602 - Integrate media fullscreen orientation feature 2020-05-21 10:11:39 -07:00
Christian Sadilek
4e25f41a41 For #1824: Prevent extremely long URLs from locking up HomeFragment 2020-05-21 13:11:07 -04:00
codrut.topliceanu
7feae98944 For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtrusive view
- Renamed DownloadNotification and removed DownloadState.dismissed dependency
- Improved DynamicDownloadDialog behaviour when scrolling
- DynamicDownloadDialog remains attached to tab until dismissed
- Fixed onTryAgain not working for resumed DownloadDialogs
2020-05-21 10:02:51 -04:00
David Walsh
346b4aa3fd
For #10321: Wire up play and pause buttons in tab tray (#10422) 2020-05-20 16:50:58 -05:00
Sawyer Blatz
477493e197
For #10465: Add telemetry for voice search (#10785) 2020-05-20 14:35:57 -07:00
David Walsh
2795a34b0b For 10731 - Don't show tab tray menu if there are no tabs 2020-05-19 13:30:18 -07:00
Sawyer Blatz
535e020683 For #1216: Put voice search behind a nightly & debug flag 2020-05-19 13:04:11 -07:00
Sawyer Blatz
d33edd8841 No issue: Clean up SearchFragment a bit 2020-05-19 13:04:11 -07:00
Sawyer Blatz
011a9e7d96 For #1216: Add voice search 2020-05-19 13:04:11 -07:00
ekager
d46369696f For #10718 - Finish activity after removing external session 2020-05-18 15:32:29 -07:00
Tiger Oakes
cd64647a4d For #9286 - Add isDefault to topsites 2020-05-18 14:04:10 -07:00
Juan Goncalves
ee62297b4c For #7854 - Update the views only if the bookmark node has changed
As the bookmark node data is loaded from storage every time the fragment's view is created, when the user navigates to the SelectFolderFragment and returns, the bookmark is loaded once again from storage, replacing the EditText's content (title and URL) which causes the loss of user input.

Validating that the loaded bookmark is different from the one that is already referenced in the fragment avoids unnecessarily replacing the `EditText`s values.
2020-05-18 13:05:12 -07:00
Emily Kager
32e74aae61 Revert "For #6313 - On first load, hides engineView until firstContentfulPaint"
This reverts commit d66762910f.
2020-05-18 10:33:11 -07:00
Emily Kager
9b16017d1d Revert "For #7032: Add scroll to dismiss keyboard in search fragment"
This reverts commit 536921bcea.
2020-05-15 21:14:55 -07:00
ekager
d66762910f For #6313 - On first load, hides engineView until firstContentfulPaint 2020-05-15 10:55:38 -07:00
Sachin
536921bcea
For #7032: Add scroll to dismiss keyboard in search fragment
* added a onTouch listener to scrollview in search fragment to make it disappear on scroll

* fixed lint issues
2020-05-15 10:30:00 -07:00
Grisha Kruglov
d37529e416 Perf telemetry for awesomebar suggestion provider durations
See mozilla-mobile/android-components#6802 for details; requires that PR.
2020-05-14 14:13:53 -07:00
Mihai Branescu
750ae4a340 For #10393 and #10469 - browser fragment now observes collection changes
Useful for links from other apps + adding a page to multiple collections
2020-05-14 10:14:06 +03:00
Christian Sadilek
7993f1017d Migrate feature-accounts to browser-state 2020-05-13 14:24:56 -04:00
sraturi
372bb421cc created kotlin doc for FenixApplication 2020-05-13 11:01:12 -07:00
Simon Chae
7cc4816618
For #10398: Add AddonInstallationDialogFragment support (#10608) 2020-05-13 12:25:34 -04:00
Elise Richards
edc75c3ad0
Fixes #9504: Edit logins (#9693)
* Create editable view and fragment. Update login info page to display options menu with edit and delete.

* Create feature flag for edit. Check flag in the login detail fragment and default to just delete.

* Add three-dot kebab options menu in login detail fragment. Add title to the login item.

* Nav to and from edit view on save and back pressed.

* Save login through AC login manager. Clear text in editable field on button click.

* Match colors, fonts, dimens to UX specs for edit logins. Enable password reveal/hide and clearing text fields.

* Refactoring logins fragments. Using component Login object for consistency.

Fetch login list when saved logins are opened. Fetch login details when detail view is opened.

Revert "Fetch login list when saved logins are opened. Fetch login details when detail view is opened."

This reverts commit 44fe17166c3332b330229258b2e8982832672e3b.

* Using parcelable login and Login component class to pass ids and items between fragments

* Retrieve login from storage when viewing login details.

Rename login logic for consistency.

Ktlint cleanup

Fix nits and naming consistency.

* UX consistency for login detail and edit login pages

* Rebasing with logins sort - updating logins store.

* Rebasing with logins sort - merging fragments and controllers.

* Lint and removing unused files.

* UX cleanup.

* Update string description
2020-05-12 17:32:01 -05:00
Tiger Oakes
f7b4f1c959
Cache findViewById calls in session control (#10575) 2020-05-12 14:05:08 -07:00
David Walsh
86dabe09c8
For 10503 - Update save to collection flow in tab tray (#10523) 2020-05-12 10:02:29 -05:00
mcarare
58df38105b For #10453: Use TabsTray API to set divider, avoiding related crashes. 2020-05-12 17:21:26 +03:00
Sebastian Kaspari
d58c022619 Integrate activity for showing past crashes. 2020-05-12 09:14:20 +02:00
Jeff Boek
a249334976
🎲 For #10332 - Adds undo snackbar when closing tabs in the tab tray (#10456) 2020-05-11 17:18:09 -05:00
Simon Chae
5ba9cc6ec9
For #10253: Add disableFirstTimePWAPopup for performance testing (#10442) 2020-05-11 16:31:31 -04:00
ValentinTimisica
15dfe0811d For #10343: Updates metrics accordingly to 'Library' removal 2020-05-11 10:22:19 -07:00
ValentinTimisica
b2e5820364 For #10343: Remove 'Library' functionality from the app
Also adds Bookmarks and History items to browser menu.
2020-05-11 10:22:19 -07:00
Simon Chae
ca7695854a
For #10552: Set initial add-on details fragment visibility to false (#10565) 2020-05-11 12:44:18 -04:00
Sawyer Blatz
17fb7c1df7
For #10426: Removes installation ping GAID (#10532) 2020-05-09 10:35:57 -07:00
Simon Chae
d58e7d3138 For #10473: Fetch the addon from addon manager instead of the store 2020-05-08 16:03:22 -07:00
Sawyer Blatz
b87c40d42f
For #10426: Sends GAID to Installation instead of Activation ping. (#10529) 2020-05-08 12:04:15 -07:00
codrut.topliceanu
d1005dd236 For #8589 - Fix for accessibility navigation in ETP panel 2020-05-08 09:57:59 -07:00
Arturo Mejia
ca01965f90 Fix PictureInPictureFeature breaking change 2020-05-08 11:42:06 -04:00
ekager
7fe6f68e00 For #10485 - Restore block video/audio on cellular data radio button 2020-05-08 14:00:09 +03:00
ValentinTimisica
f63cb4e09f For #10244: Creates drawable for add-ons private browsing label.
The drawable is sent to AddonsManagerAdapter.Style constructor and is displayed
near the add-on name if it is allowed to run in private browsing
2020-05-07 17:27:46 -07:00
Jeff Boek
58ca5d0e3a For #10341 - Always show collections placeholder with new tab tray enabled 2020-05-07 15:38:17 -07:00
Mihai Branescu
eef5cf3469 For #10482 - made SVG gradient compatible with API < 22 2020-05-07 10:39:58 -07:00
ekager
138d8e647d No issue - Use ViewLifecycleOwner lifecycleScope for Bookmark deletion scope 2020-05-07 10:17:42 -07:00
Sawyer Blatz
02f6e6868e
For #10426: Adds identifier to Glean for 24 hours (#10446) 2020-05-07 08:57:20 -07:00
Jonathan Almeida
57eb2b9549 For #10453: Do not set item decoration when creating ViewHolder 2020-05-07 11:44:19 -04:00
ValentinTimisica
24ba9f2fc8 For #9505: Adds possibility to sort saved logins
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
2020-05-07 08:43:59 -07:00
mcarare
9177871edc For #10408: Check current destination before navigating. 2020-05-07 09:35:10 +03:00
ekager
9fd835de0f For #10433 - Pass in viewLifecycleScope to BrowserAnimator 2020-05-06 23:24:46 -07:00
ekager
9ec1f8e2d8 For #8981 - Sort devices in share list by last access time 2020-05-07 09:20:49 +03:00
Michael Comella
4cf7280916 No issue: add clarifying kdoc for BookmarkFragment. 2020-05-06 17:27:58 -07:00
David Walsh
8b27a48635 For #10329 - Implement tab tray divider 2020-05-06 14:13:39 -07:00
Simon Chae
609936d632
For #10196: Remove clickable locks for enable and private-browsing UI (#10445) 2020-05-06 13:58:42 -04:00
Simon Chae
a851b76ea3
Update Android Components version to 41.0.20200506130132 (#10443) 2020-05-06 13:17:17 -04:00
Mihai Branescu
6f97e75579 For #8643 and #7606 - illustrations are now connected to their radio buttons 2020-05-06 09:18:27 +03:00
Mihai Branescu
cde31cf785 For #8643 and #7606 - Changed toolbar picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu
16b7a9399b For #8643 and #7606 - Changed theme picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu
4c0af91b7b For #8643 and #7606 - Changed tint for onboarding icons 2020-05-06 09:18:27 +03:00
Arturo Mejia
398b516fb7 No issue: Add Fingerprinters to the standard trancking protection policy 2020-05-05 17:33:42 -07:00
Christian Sadilek
fee09c3092 No issue: Show article/page url instead of reader extension url 2020-05-05 17:52:27 -04:00
Jeff Boek
d72e455c0d No Issue - Update to AC 41.0.20200505190119 2020-05-05 17:52:27 -04:00
Mihai Adrian
43d30793f5
For #9794: Announce installing state for screen readers (#10111) 2020-05-05 11:22:15 -07:00
Mihai Adrian
5106134786
For #10408: Dismiss menu when navigating away. (#10415)
The menu is dismissed when toolbar view is detached from window.
2020-05-05 11:15:30 -07:00
David Walsh
542f31f970
For #10392 - Don't provide a "Save to collection" button in private mode for the tabs tray (#10399) 2020-05-04 22:51:07 -04:00
Sören Hentzschel
10d07912da no issue - removed unused feature flag 2020-05-01 15:14:46 -07:00
Jeff Boek
94cd195dc7
Adds swipe to delete tab (#10355)
* No Issue - Increases tap area of close button

* For #10331 - Adds swipe to delete to the tab tray
2020-05-01 15:45:51 -05:00
Simon Chae
3dcd52ef7a For #10195, #10196: Allow private browsing mode switch to sync with enable state 2020-05-01 15:14:08 -04:00
Jeff Boek
5c7e9b98cd
Fix home navigation (#10350) 2020-05-01 12:46:02 -05:00
Jeff Boek
a8a90bd4d6
For #1063: Put tab tray behind a feature flag and hidden pref (#10313)
* For #1063 - Adds feature flag and pref for new tab tray

* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For #1063 - Creates hidden preference to use new tab tray

* For #1063 - Hides tabs on home screen when setting is enabled

* For #1063 - Navigate to new tab tray from browser with setting enabled

* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For #1063 - Fixes crash when toggling to private mode on the home screen

* For #1063 - combines both settings. Cleans up lint errors
2020-04-30 15:53:10 -05:00
Chenxia Liu
390c5a0189 Issue #7996: fix lint issues 2020-04-30 13:38:52 +03:00
Jovan Gerodetti
4a12f1b6aa For #7996: Private mode doesn't play nicely with sites added to home screen
Site Controls Notification should reflect the browsing mode of the
currernt web app session.
2020-04-30 13:38:52 +03:00
Arturo Mejia
56bb3e38ec For issue #10142 Update sitePermissions state when toggling its value 2020-04-29 18:33:34 -07:00
ekager
2e27bbd15d No issue - Remove unused data class TopSiteItem 2020-04-29 18:06:02 -07:00
Sawyer Blatz
38e9b34659
For #10071: Fixes PWA showing toolbar onPause (#10306) 2020-04-29 14:03:59 -07:00
mcarare
4006501d41 For #9728: Add actionbar search for language list. 2020-04-29 11:20:18 -07:00
ekager
52d09930a6 No issue - Update new strings for quarantine 2020-04-29 11:15:21 -07:00
Mihai Eduard Badea
02bd0cc203 For issue #8648 2020-04-29 09:48:42 -07:00
Jonathan Almeida
76002c5987 Fix breaking API changes in CrashReporter 2020-04-28 15:20:12 -04:00
Falaye Iyanuoluwa
c86209ff98 Closes #9694 Bug when user denies permission 2020-04-27 22:42:02 -07:00
mcarare
3c5d8d31ea For #10083: Adjust thumb offset to thumb circumference to avoid cutoff 2020-04-27 21:19:44 -07:00
David Walsh
6afcd2cee6 For #10201 - Provide proper button padding and no tabs message visibility in tabs tray 2020-04-27 20:36:08 -07:00
Arturo Mejia
e55a4fd274 No issue: Partially update the add-on manager list 2020-04-27 16:43:05 -04:00
mcarare
1aa473b112 For #9913, For #9914: Remove touch delegate when button is disabled. 2020-04-27 11:57:51 -07:00
ekager
a9692d9bce For #10204 - Address viewLifecycleOwner IllegalStateException crashes 2020-04-24 17:12:08 -07:00
Mihai Branescu
a16bfb27ef For #6557 - added unit tests 2020-04-24 15:47:48 -07:00
Mihai Branescu
0c2d22f595 For #6557 - add in_content telemetry class 2020-04-24 15:47:48 -07:00
Mihai Branescu
28496fecc0 For #6557 - split base extension functionality from ads 2020-04-24 15:47:48 -07:00
Mihai Branescu
f09bc4566c For #6557 - added metric for in_content 2020-04-24 15:47:48 -07:00
mcarare
e830da59b7 For #10180: Remove touch delegate when button is disabled.
Also refactored multiple if's into a when.
2020-04-24 13:28:29 -07:00
mcarare
3e13927c25 For #10180: Add extension to remove touch delegate from parent. 2020-04-24 13:28:29 -07:00
Mihai Branescu
c4d76dce5a For #6558 - cleanup + added unit tests 2020-04-24 09:28:40 -07:00
Mihai Branescu
f03d65b13d For #6558 - added logic for ad_clicked metric 2020-04-24 09:28:40 -07:00
Mihai Branescu
93ca1f6d9f For #6558 - added handling of web extension + sending metric for has_ads 2020-04-24 09:28:40 -07:00
Simon Chae
f1559ed2da
For #10162: Set switch back to prev state when failed to enable/disable addon (#10164) 2020-04-24 11:54:16 -04:00
mcarare
2edd4b39a4 For #9913, For #9914: Remove button when disabling it.
Setting visibility to GONE allows clicks to parent view in that space.
2020-04-24 16:42:47 +03:00
Arturo Mejia
956bf01cd5 For issue #9493: Reload after cleaning individual site permissions exceptions 2020-04-24 06:16:32 -04:00
David Walsh
6f5f48c30e
For #10148 - Add basic tab tray implementation without exposing to rest of app (#9934) 2020-04-23 15:38:35 -05:00
Vlad Filippov
e51e1c878b Add 'useEmail' and 'useEmailProblem' metrics event
Fixes #9834
2020-04-23 10:33:36 -07:00
Simon Chae
b3248ec769 For #6123: Expose WebExtensions in private browsing control 2020-04-23 12:28:57 -04:00
mcarare
cc67de29bf For #10091 Also disable play/pause button when hiding it. 2020-04-23 09:22:01 -07:00
mcarare
9dd8314d14 For #10091 Add extension to remove and disable button 2020-04-23 09:22:01 -07:00
mcarare
932fd44823 For #7387: Change ETP onboarding from popup to a dialog.
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
2020-04-23 08:17:42 -07:00
mcarare
72fe52fcb8 For #9987: Set FLAG_SECURE to dialog when flag set in activity. 2020-04-23 08:16:25 -07:00
ValentinTimisica
da3fca0f29 Fixes #10109: Adds content description for browse privately card content 2020-04-23 16:59:42 +03:00
mcarare
e11f1b62dc For #10027: Make toolbar context menu popup dismissible on SDK<23 2020-04-22 22:47:46 -07:00
ekager
c4e83367f6 For #6832 - Fix various fragment not attached to a context crashes 2020-04-22 20:56:35 -07:00
ekager
6457a02a82 For #2818 - Enable PiP for all builds 2020-04-22 20:55:00 -07:00
Roger Yang
0227e953ae Close #9760: Add external app links context menu candidate 2020-04-22 14:45:49 -07:00
Sawyer Blatz
dce16964c0
For #9208: Adds in-product prompt to homescreen (#9836) 2020-04-22 14:29:43 -07:00
Arturo Mejia
0a23d66756 For issue #7566 Handle deny & don't ask again for site permissions 2020-04-22 11:33:32 -04:00
Arturo Mejia
995da59fa8 For issue #9493: Reload after cleaning all site permissions exceptions 2020-04-22 08:53:07 -04:00
ekager
70755adf6e For #10036 - Workaround for System Theme changes with config change 2020-04-22 00:01:54 -07:00
Michael
1f8b7ff962 Closes #8541: Hide find bar when entering fullscreen 2020-04-22 00:01:35 -07:00
Jeff Boek
164e6cd079 For #9816 - Adds SessionObserver to session on selection 2020-04-21 14:08:58 -07:00
Jonathan Almeida
6ad046714d Close #9338: Enable WebPush engine integration in all builds 2020-04-21 09:38:13 -04:00
ekager
f3847d0d7c For #8735 - Adjust fontInflation engine setting when toggling useAutoSize 2020-04-21 09:05:25 +03:00
ekager
66d9a24b28 Closes #9928 - Updates private browsing text description 2020-04-21 09:00:06 +03:00
ekager
5d51c4f059 Don't use ProcessLifecycleOwner for view-tied consume 2020-04-20 12:07:37 -07:00
ekager
f801f32027 No issue: Fix leaks in BookmarkFragment 2020-04-20 12:07:37 -07:00
ekager
5014cd78ec No issue: Fix leaking sessionControlInteractor 2020-04-20 12:07:37 -07:00
Grisha Kruglov
853a0acab4 Closes #4046: Always display 'Desktop' bookmarks folder
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.

In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
2020-04-17 23:57:43 -07:00
Jonathan Almeida
c16283a923 For #9932: Fix navigation icon theme missing from migration UI
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
2020-04-17 22:45:30 -07:00
Sawyer Blatz
a8e624959e
For #6940: Fixes top dynamic toolbar behavior (#9900) 2020-04-17 13:32:20 -07:00
Roger Yang
40550e88de
Close #9960: Launch URI in Fenix if failed to launch in custom tab (#9964) 2020-04-17 16:24:20 -04:00
Christian Sadilek
ec1d4e8fca For #8399: Hide keyboard to prevent content resizes
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
2020-04-17 12:07:44 -07:00
Michael Comella
f3ed207bdb For #8803 - review: Add clarifying comments to onAppInit capture methods. 2020-04-17 09:11:58 -07:00
Michael Comella
f49fc6dad2 For #8803: hook up frameworkStart metric. 2020-04-17 09:11:58 -07:00
Michael Comella
dbf733d70a For #8803: add StartupFrameworkStartMeasurement.
This class controls the central logic around the metrics we want to
record.
2020-04-17 09:11:58 -07:00
Michael Comella
7f618a6a7c For #8803: add Stat and test.
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
2020-04-17 09:11:58 -07:00
Emily Kager
39107b4036
For #9703 - Exit fullscreen in onPause and onSessionSelected (#10016)
* For #9703 - Call fullScreenChanged in onPause

* For #10015 - Exit full screen if new session selected
2020-04-17 08:57:36 -07:00
ekager
6f77ec5951 Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver 2020-04-16 21:00:27 -07:00
Grisha Kruglov
0ec6d266e8 Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
2020-04-16 21:00:27 -07:00
Mihai Adrian
72fe9fad0c
For #9987: Set FLAG_SECURE to dialog when flag set in activity. (#9998)
* For #9987: Add extension to secures dialog if parent activity is secured

* For #9987: Set FLAG_SECURE to dialog when flag set in activity
2020-04-16 20:33:57 -07:00
Mihai Eduard Badea
725ba1e856 For #9951 - Removed the extra empty spaces that were causing the spacing issue 2020-04-16 20:12:18 -07:00
mcarare
83d2208c6b For #9536: Open report issue tab depending on current browsing mode.
Checking if session is private uses the new browser state API.
2020-04-16 19:50:25 -07:00
Sawyer Blatz
1f8f69548a For #7158: Fixes browser to search animation fade 2020-04-16 14:03:26 -07:00
Jonathan Almeida
25d5b0d31c For #8422: Add spacing between migration items 2020-04-16 12:02:02 -07:00
ekager
4a06a228f3 For #9981 - Make Bookmark Menu UI respond to session selection 2020-04-16 10:49:16 -07:00
mcarare
25e12e2f77 For #9984: Update addon before settings visibility check 2020-04-16 10:25:37 -04:00
Sawyer Blatz
8185ba793e
For #9857: Create button style (#9858)
* For #9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
2020-04-15 15:49:02 -07:00
Jonathan Almeida
997f6c72d6 For #9409: Add app icon to Leanplum push notifications 2020-04-15 17:55:12 -04:00
Jonathan Almeida
e97904662c Remove duplicate FirebasePushService
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
2020-04-15 17:55:12 -04:00
Mihai Branescu
bded28a017
For #9420 - relaxed custom engine rules (#9967)
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
2020-04-15 13:20:06 -07:00
ekager
aef827e607 For #9887 - Respect screenshot setting when resetting window flags in logins 2020-04-15 09:03:26 -07:00
Arturo Mejia
37a277febb For issue #9930 Do not assume all add-ons have a settings page 2020-04-15 06:20:34 -04:00
Arturo Mejia
8872baef39 Update Android Components version 2020-04-14 11:34:55 -07:00
Arturo Mejia
7c279b6e1f No issue: Fix add-on translate() breaking change 2020-04-14 11:34:55 -07:00
ekager
5b1cdbd8bf For #3194 - Pause media while undo snackbar appears 2020-04-14 09:55:39 +03:00
ekager
9c56a8b387 For #204 - Remove PWA Feature Flag 2020-04-14 09:55:14 +03:00
Jeff Boek
4cbb9aebaf
Cleans up nav_graph.xml (#9829)
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
2020-04-13 21:43:45 -07:00
Arturo Mejia
eace991859 For issue #8520: Improve add-ons UI 2020-04-13 19:01:58 -04:00
ekager
b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 2020-04-13 14:56:51 -07:00
ekager
ac3a557ddf For #9703 - Exit full screen on pause if pip not entered 2020-04-13 14:31:57 -07:00
Sawyer Blatz
7c3394ea7c
For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs (#9893) 2020-04-13 13:08:08 -07:00
ekager
8c238402e2 For #9692 - Fix "Install" PWA menu item labeling 2020-04-13 10:09:37 -07:00
ekager
5039546dc5 For #7208 For #7212 - Update parameterized strings 2020-04-13 09:40:47 -07:00
mcarare
a214f04b4a For #9698: Use extension to ensure fallback to English and avoid crash 2020-04-13 09:40:00 +03:00
mcarare
4a1a875233 For #9698: Add Context extension to avoid format IllegalArgumentException 2020-04-13 09:40:00 +03:00
mcarare
177baf58a8 For #9798: Disable buttons on hiding and enable on showing.
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
2020-04-09 16:06:11 -07:00
Simon Chae
de311aef85
Update not yet unavailable add-on string (#9677) 2020-04-09 15:25:08 -04:00
Roger Yang
c9141c9ae5 Close #9827: Support display cutouts 2020-04-09 10:13:37 -07:00
Christian Sadilek
7f1ef17d8b No issue: Re-use existing usecases for addons 2020-04-09 12:53:47 -04:00
ekager
56eb2ec1d7 For #2818 - Adds Picture-in-Picture feature 2020-04-09 08:56:48 -07:00
Michael Comella
4437ddd536 No issue: Move Do and OpenClass to utils pkg.
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
2020-04-08 12:39:22 -07:00
mcarare
413af92bc5 For #9797: Set min height of dialog edit text to 48dp. 2020-04-08 10:12:20 -04:00
Abhay Agarwal
1c65bb8255 Closes #9495: Dismiss the ShareFragment in onPause() 2020-04-08 13:10:37 +03:00
Christian Sadilek
0f1bff7402 No issue: Refactor readerview to use browser-state 2020-04-07 16:31:03 -04:00
Sawyer Blatz
e94af334fc
No issue: Add more settings animations (#9750) 2020-04-07 10:44:23 -07:00
Mihai Eduard Badea
d66da53c9a For #2768 - Prevent screenshots in private mode
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
2020-04-07 17:23:06 +03:00
Mugurell
29539c458e For #9770 - Disable pull to refresh pending changes 2020-04-07 17:06:43 +03:00
Jeff Boek
c632b93ee7
For #220 - Removes feature flag for language picker (#9191)
* For #220 - Removes feature flag for language picker

* For #220 - Updates Android Components
2020-04-06 14:29:52 -07:00
Mihai Adrian
dfded8e69c
For #9687: Refactor onboarding cards to follow app architecture (#9743)
* For #9687: Refactor onboarding cards to follow app architecture

* For #9687: Update unit test to new controller parameters
2020-04-06 11:00:47 -07:00
Arturo Mejia
025656d8fd For issue #9647 Crash when tapping settings after quickly
enabling/disabling add-on
2020-04-06 13:47:21 -04:00
Michael Droettboom
3789f50423 Fix errors in top_sites_count metric
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.

[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
2020-04-06 10:34:52 -07:00
Mugurell
904bfc9ebe For #3262 - Enable pull down to refresh in Nightly 2020-04-03 19:40:08 +03:00
MickeyMoz
f46cfc2ad2 Update Android Components version to 38.0.20200403130109. 2020-04-03 16:15:31 +02:00
Michael Comella
4a8dc5b54f No issue: add kdoc to HomeActivity.
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
2020-04-02 16:27:00 -07:00
Sawyer Blatz
e3ed7ed268
Issue #9128 & #9222 & #9499: Refactors snackbar creation and fixes placement (#9628) 2020-04-02 12:30:13 -07:00
Gabriel Luong
dc6d479da3
For #6174 - Add telemetry for WebExtensions (#8318) 2020-04-02 10:12:31 -07:00
Emily Kager
327009efc4
For #768: Add first time PWA dialog (#9308)
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
2020-04-01 22:56:12 -04:00
David Walsh
26137f63a2
Prevent favicons from flashing when items are selected in History (#9233) 2020-04-01 15:43:21 -07:00
Mihai Adrian
8cd6d7460c
For #9336 Check current destination before navigating (#9353)
* For #9336 Check current destination before navigating

* For #9336 Update unit test to check for navigateSafe
2020-04-01 15:36:56 -07:00
ekager
fd60270da8 For #9533 - Switch to using enum for Library Item Selected Telemetry 2020-04-01 15:29:08 -07:00
Grisha Kruglov
8d3d030feb Closes #9553: Only update account UI state once when creating SettingsFragment 2020-04-01 15:28:39 -07:00
ekager
96c6401457 For #8125 - Send top sites count with metrics ping 2020-04-01 15:27:39 -07:00
mcarare
8c398c86ef For #9365: Partially reverse menu items order when using top toolbar 2020-04-01 15:21:22 -07:00
mcarare
b119700820 For #9365: Update naming to reflect history item 2020-04-01 15:21:22 -07:00
Sawyer Blatz
208a58bc58
Issue #9598 & #8697: Fixes force expand crash (#9599) 2020-04-01 12:32:00 -07:00
codrut.topliceanu
3d1d146c94 For #9549 - Scrolling to top sites now includes header. 2020-04-01 10:28:04 -07:00
Mihai Branescu
24596fd3cd For #9109 - remove the sync error highlight from three-dot menu 2020-04-01 10:42:00 +03:00
Grisha Kruglov
54b7fd8834 Make sure reconnect item is displayed in HomeMenu in case of account problems
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
2020-03-31 16:07:35 -07:00
Grisha Kruglov
60943df6d9 Closes #9561: Fix initialization order in HomeMenu
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.

Simply re-ordering initialization fixes the problem.
2020-03-31 16:07:35 -07:00
Arturo Mejia
804eb0f5ba For issue #8520: Polish Add-on manager UIs 2020-03-31 17:20:20 -04:00
Sawyer Blatz
1a2b65d854
Issue #9472: ForceExpand browser toolbar when navigating (#9552) 2020-03-31 11:16:40 -07:00
ValentinTimisica
cee34893ed
For #8412: Passes error handling function to 'CustomTabWindowFeature' (#8903)
* For #8412: Passes error handling function to 'CustomTabWindowFeature'

Change required for showing error message when the app can't handle a specific
scheme. Implemented in AC:
https://github.com/mozilla-mobile/android-components/pull/6122

* Upgrade AC version

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2020-03-31 10:17:29 -07:00
Grisha Kruglov
f76acc5db1 Closes #9530: Don't crash on failed avatar fetches 2020-03-31 09:17:17 -07:00
Grisha Kruglov
6c38b77315 Part 6: Kick-off account manager initialization after visual completeness
In order to hide the time it takes for the account manager to be initialized
(which always involves disk IO, and often network IO), let's kick it off
after "visual completeness".
This makes sure that for most users, by the time they interact with the account
manager-related functionality (e.g. in Settings), it's ready to go.

Also, for signed-in users, this will establish background sync workers.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
057e28d4e4 Part 5: Refactor HomeMenu<->HomeFragment interaction
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.

Once that's in place, we start observing account manager changes (once its ready)
for account problems.

This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
2020-03-30 21:43:38 -07:00
Grisha Kruglov
029fae4559 Part 4: Make sure 'sync is on' snackbar does not initialize account manager 2020-03-30 21:43:38 -07:00
Grisha Kruglov
eb98df4edd Part 3: Mark accountManager as 'lazy' in Mode.kt
This is enough to cause it to be initialized only if we're going through onboarding.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
3efaa516ca Part 2: Do not eagerly initilize account manager within HomeActivity
Instead of always kicking off accountManager's init and telling it to sync right away in
'onResume', we move these tasks to some abstract point later on, whenever account manager
is available.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
0677fc35de Part 1: Add 'accountManagerReady' queue to BackgroundServices
This gives us an ability to perform tasks against 'accountManager' without
causing its immediate initialization.
2020-03-30 21:43:38 -07:00
Grisha Kruglov
be1fa8df7d Pre: introduce a RunWhenReadyQueue
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.

This ability to either execute or queue a task will be useful later on in the
commit series.
2020-03-30 21:43:38 -07:00
Sawyer Blatz
4ac29530cd
Issue #9132: Update to search animation for top toolbar (#9524)
* let animation in top toolbar mode play nicely.

* remove duplicate methods, make code readable.

* migrate getToolbarNavOptions method to BrowserAnimator, one method to rule them all.

* Update linting

Co-authored-by: ahmedmamdouh13 <ahmedmamdouh13196@gmail.com>
2020-03-30 12:07:00 -07:00
David Walsh
e1187ebf31 For #7059 - Allow search engines to scroll 2020-03-30 10:31:39 -07:00
David Walsh
d989616f62 Add top sites heading to home screen 2020-03-30 10:29:40 -07:00
mcarare
f52fa44207 For #9498: Replace navargs with viewModel to remember if scroll to tab 2020-03-30 09:56:51 -07:00
mcarare
ab78951146 For #9496: Vertically align collection name and icons to collection icon 2020-03-30 08:30:06 -07:00
codrut.topliceanu
1e63d6ce76 For #9500 - Revert patch for 8568
The patch for 8568 introduced this regression.
Let's just revert it until we can come up with a better solution.
2020-03-30 07:20:13 -07:00
Sebastian Kaspari
02aabea14a Update to new feature-media API. 2020-03-29 23:13:13 -07:00
Edouard Oger
394f386ac3 Add secret debug menu to override FxA servers 2020-03-27 22:59:14 -07:00
mcarare
18533d3434 For #8764: Use list component for items in collections 2020-03-27 22:14:59 -07:00
mcarare
62bbbd9e37 For #8764: Update collection design, including list elements 2020-03-27 22:14:59 -07:00
mcarare
38a97cd1e0 For #9252: Add progress bar to saved logins view 2020-03-27 22:13:58 -07:00
mcarare
f3bbcc4e17 For #9252: Update views visibility ony when list has finished loading 2020-03-27 22:13:58 -07:00
Arturo Mejia
f9cc2ccfe2 For issue #8017 enable SitePermissionsWifiIntegration 2020-03-27 20:44:16 -04:00
codrut.topliceanu
ba39a46b88 For #8568 - Refocus URL editText in SearchFragment onResume 2020-03-27 17:24:14 -07:00
Amaan Marfatia
3dcfed3761 AboutPageAdapter doesn't use notifyDataSetChanged()
We make the AboutPageAdapter inherit from a ListAdapter so that we don't use notifyDataSetChanged().
2020-03-27 17:23:27 -07:00
mcarare
012e318724 For #8968: Hide keyboard when navigating away from browser 2020-03-27 16:44:11 -07:00
ValentinTimisica
3647606aae Fixes #9280: Remove tabs fade in animation when pressing on Add new collection 2020-03-27 15:54:24 -07:00
Mugurell
a1cdd31f0c Fix #8651 - Add new menu actions for a history item
We'll now also support:
- Copy url
- Share to another FXA device
- Open in new tab
- Open in private tab
2020-03-27 15:53:31 -07:00
mcarare
e8ad2389ac For #7356: Scroll to selected tab when pressing tab overview 2020-03-27 14:13:26 -07:00
Mihai Eduard Badea
91690d7b48 Replaced name field with search string field 2020-03-27 16:38:59 +02:00
ValentinTimisica
69e8a2f357 Fixes #4987: Remove close tabs functionality when they are added to a collection 2020-03-27 15:42:17 +02:00
ValentinTimisica
a72d50d78f Fixes #7734: Remove animation for back button 2020-03-27 15:37:33 +02:00
Christian Sadilek
5e9d5dd545 Closes #9414: Make AMO collection configurable 2020-03-26 17:26:20 -04:00
Grisha Kruglov
9e324fa02a Perform storage warm-up after visual completeness 2020-03-26 14:12:35 -07:00
Sebastian Kaspari
0f0d56e60a Issue #5208: Use new tab/collection restore API. 2020-03-26 10:55:12 -07:00
Mihai Branescu
73a7330b2b For #9395 - Trimmed name for custom search engines 2020-03-26 09:35:23 +02:00
Arturo Mejia
f785a07ef9 No issue: Add add-on updater information dialog 2020-03-25 13:57:51 -04:00
Mihai Branescu
a23bcebb5d For #8972 Replaced purple colors to match the rest of the app 2020-03-25 00:13:59 +02:00
Mihai Branescu
494db56ea5 For #9207 - changed status bar color in home fragment to match gradient background 2020-03-24 23:44:46 +02:00
Arturo Mejia
fa9dae0d72 For issue #9364 Crash when blocking app permissions and returning to
the app
2020-03-24 13:44:54 -07:00
ekager
eea6eb0c4c Add toolbar padding for bookmark snackbar 2020-03-24 13:33:50 -07:00
ekager
16b40992d2 For #9351 - Show snackbars with toolbar padding to work with dynamic toolbar 2020-03-24 13:33:50 -07:00
Arturo Mejia
5e75140b3d For issue #8809 Notification permissions can't be disabled/re-enabled
unless you restart the browser
2020-03-24 15:25:33 -04:00
Arturo Mejia
b484ad38cc No issue: Remove feature flag for removing one TP exception 2020-03-24 11:14:07 -04:00
mcarare
7fbb1640b6 For #8759 Use activityName instead of packageName as app identification 2020-03-24 17:10:19 +02:00
Arturo Mejia
301f56d144 For issue #9334 Fix Remove of one exception is deleting all 2020-03-23 20:04:04 -04:00
Sawyer Blatz
9feb44852b
For #9256: Attempts to fix installation ping not being sent (#9331) 2020-03-23 14:27:28 -07:00
Kate Glazko
47b2f6a070 For 7077 Simplify Display Url 2020-03-23 12:36:48 -07:00
Mihai Branescu
ab04155222 For #8653 - changed menu strings 2020-03-22 00:03:26 +02:00
mcarare
14338a3b13 For #8899: Set viable anchor for snackbars in both custom and normal tab 2020-03-20 22:46:59 -07:00
ValentinTimisica
8871c05c9d Fixes #9243: Remove tabs fade in animation when pressing on Save to Collection 2020-03-20 22:44:31 -07:00
David Walsh
681d6cf8a1 For #8652 - Allow sharing multiple bookmarks 2020-03-20 20:28:36 -07:00
David Walsh
27502bdd34 For #9177, #8248 - Hide empty verified by block when no cert 2020-03-20 19:40:51 -07:00
Severin Rudie
35a132d7ff
8017 advanced autoplay controls. (#8978)
* For #8017: add advanced autoplay controls
2020-03-20 12:10:42 -07:00
Elise Richards
5d8a9bb4be
For #8592: Relocate device name in account preferences. Deactivate device name field while syncing. (#9255) 2020-03-20 12:32:04 -05:00
Sawyer Blatz
a356b4b2c4
For #9136: Send all adjust properties to glean (#9253) 2020-03-20 10:06:55 -07:00
Sawyer Blatz
b9059c8208
For #9256: Attempts to fix installation ping not being sent (#9254) 2020-03-19 16:22:28 -07:00
Grisha Kruglov
e541e10427 Initialize storage after visual completeness
In order to eat the perceived performance costs, we initialize storage
once we're visually complete. This way, we're reducing chances of user performing
a UI action which will trigger storage init and delay said action.
2020-03-19 15:46:50 -07:00
Grisha Kruglov
eb14532c3c Closes #7450: Lazy storage initialization
Make sure that we actually lazily initialize our storage layers.

With this patch applied, storage layers (history, logins, bookmarks) will be initialized when first
accessed. We will no longer block GeckoEngine init, for example, on waiting for the logins storage
to initialize (which needs to access the costly securePrefStorage).
Similarly, BackgroundServices init will no longer require initialized instances of the storage
components - references to their "lazy wrappers" will suffice.

In practice, this change changes when our storage layers are initialized in the following ways.
Currently, we will initialize everything on startup. This includes loading our megazord, as well.

With this change, init path depends on if the user is signed-into FxA or not.

If user is not an FxA user:
- on startup, none of the storage layers are initialized
- history storage will be initialized once, whenever:
  - first non-customTab page is loaded (access to the HistoryDelegate)
  - first interaction with the awesomebar
  - history UI is accessed
- bookmarks storage will be initialized once, whenever:
  - something is bookmarked, or we need to figure out if something's bookmarked
  - bookmarks UI is accessed
- logins storage will be initialized once, whenever:
  - first page is loaded with a login/password fields that can be autofilled
  - (or some other interaction by GV with the autofill/loginStorage delegates)
  - logins UI is accessed
- all of these storages will be initialized if the user logs into FxA and starts syncing data
  - except, if a storage is not chosen to be synced, it will not be initialized

If user is an FxA user:
- on startup, none of the storage layers are initialized
- sometime shortly after startup is complete, when a sync worker runs in the background, all storage
layers that are enabled to sync will be initialized.

This change also means that we delay loading the megazord until first access (as described above).
2020-03-19 15:46:50 -07:00
mcarare
756b1fbadd For #9140: Remove drawable from title in empty state panes 2020-03-19 14:32:40 +02:00
Arturo Mejia
823eea44ed No issue: Add serverConfig param to FxaWebChannelFeature 2020-03-18 17:25:51 -07:00
Arturo Mejia
e977486809 Remove @UseExperimental for usages of the flow api 2020-03-18 17:25:51 -07:00
mcarare
4425e7139e For #9200: Remove star icon from empty state icon in toolbar 2020-03-18 10:23:50 -07:00
mcarare
772c7062fd For #8814: Change icon asset for top sites menu option 2020-03-18 08:30:33 -07:00
Jonathan Almeida
ffd4cdd970 For #7661: Add variant-specific schemas for deep links
In order to target specific variants of Fenix, we're adding schemas that
are specific that app in order to avoid collisions with the other
variants and with other forks of fenix that may have the same schemas.

The current schema for variants:
 - Fenix Nightly: `fenix-nightly://`
 - Fenix Beta: `fenix-beta://`
 - Everything else: `fenix://`
2020-03-17 17:21:09 -04:00
Sawyer Blatz
b4e1360f59
For #3086: Adds settings animations (#9187) 2020-03-17 12:35:00 -07:00
Christian Sadilek
0d974fe262 For #8808 #9139: Add-on should be able to configure how to open options page 2020-03-17 12:34:07 -04:00
Edouard Oger
a1ea94fe76 Prepare for a-c a-s upgrade 2020-03-17 11:49:54 -04:00
Sebastian Kaspari
34144fd254 Use pinned Android Components Nightly version instead of snapshots. 2020-03-17 12:09:36 +01:00
Christian Sadilek
63517a52e4 No issue: Remove unneeded logic to adjust TP 2020-03-13 14:08:49 -04:00
Jonathan Almeida
3d387e2dde Add nightly-only feature flag for WebPush integration 2020-03-12 18:39:32 -07:00
codrut.topliceanu
030bd38631 For #8561 - Scroll to topSites on app cold start 2020-03-12 10:54:58 -07:00
Sawyer Blatz
cc8f34b68b
For #8773: Fixes issue with snackbar placement on ContextMenu (#8942) 2020-03-12 09:54:13 -07:00
Roger Yang
9a582a6983
Closes #9104: Pass release channel information to Socorro service (#9130) 2020-03-12 12:00:14 -04:00
Jeff Boek
c862ca93ba No issue - Fixes shadow on top layout 2020-03-11 22:59:42 -07:00
Jeff Boek
74ce62b5c3 For #8949 - Removes old motionlayout code, fixes how shadow is drawn 2020-03-11 17:10:40 -07:00
David Walsh
fc67747409 Show the collections header when there are no collections 2020-03-11 16:26:39 -07:00
ekager
31cc7d9166 For #8897 - Don't remove all external sessions on back press 2020-03-11 14:04:27 -07:00
Michael Comella
5bd0369aed No issue: remove unused HotStartPerformanceMonitor.
This monitor for hot start was intended to be used by FNPRMS to measure
hot start. However, hot start was deprioritized so it's now essentially
unused.
2020-03-11 11:28:38 -07:00
Mihai Branescu
485efacd33 For #8800 - dismiss all highlights when menu is closed 2020-03-11 19:05:55 +02:00
Severin Rudie
1381444a52 For #8800: clear menu highlights on use 2020-03-11 19:05:55 +02:00
mcarare
2ffbecaefa For #8474 Reorganize browser menu items 2020-03-11 09:52:28 -07:00
Arturo Mejia
ce4293c8c8 For issue #8908 Notify users when previously unsupported add-ons
become available
2020-03-11 11:24:01 -04:00
ekager
709bf6f627 For #7087 - Add SearchView to Logins Fragment 2020-03-10 23:01:51 -07:00
ekager
feb6215fae For #8296 - Adds user account avatar to Account Preference 2020-03-10 11:19:22 -07:00
Jonathan Almeida
ef42becbf9 For #9059: Add WebPush engine integration 2020-03-09 16:50:29 -04:00
ekager
667ebe3142 For #8967 - Remove ability to pref login autofilling by itself 2020-03-09 13:19:47 -07:00
mcarare
320fc4e4ae For #8788 Use Flexbox instead of Grid manager for top sites 2020-03-09 11:01:14 -07:00
Emily Kager
93cb3c2053
For #8423 - Adds delete login confirmation dialog (#9014) 2020-03-09 15:51:18 +02:00
mcarare
16e2f20471 For #8975: Separate title from url with line break when sharing links 2020-03-05 21:17:36 -08:00
Sawyer Blatz
28f58eb025
For #7158: Improves home to search animation (#9008) 2020-03-05 13:54:54 -08:00
Christian Sadilek
84afb5d156 Issue #8291: Speculatively create content process in search fragment 2020-03-05 16:02:23 -05:00
Sawyer Blatz
3548e58c00
For #7158: Improves browser to search animation (#8961) 2020-03-05 12:29:23 -08:00
Sebastian
89a260ecd9 Use new MemoryConsumer.onTrimMemory() API. 2020-03-05 20:02:22 +01:00
Jim Porter
ec98fd948b For #7847: Improve startup performance of the Fenix wrapper around Glean 2020-03-04 16:21:45 -08:00
Sebastian
7b170c4428 Update IntentProcessor implementation to comply with new interface. 2020-03-04 09:40:00 -08:00
Josh Vocal
c15469595d For #7554: Add App Services Version to About Page 2020-03-03 14:44:38 -08:00
Gabriel Luong
c1a7bddcd3
For #8593 - Style the add-ons permission dialog to match the Fenix theme 2020-03-03 17:09:09 -05:00
Jonathan Almeida
0d48b65a25 For #8950: Unregister observers in the main scope coroutine 2020-03-03 16:20:20 -05:00
mcarare
f9e85e78af For #6607 Update button theming in no tab pane 2020-03-03 12:51:58 -08:00
mcarare
cfe4f11864 For #6607 Update button theming in no tab pane 2020-03-03 12:51:58 -08:00
Sawyer Blatz
edd1f013ba For #5308: Show search shortcuts for search term queries 2020-03-03 10:01:52 -08:00
Jonathan Almeida
4ccda4d495 Log push crashes to CrashReporter 2020-03-03 12:46:37 -05:00
Jonathan Almeida
4bbf87d272 Closes #6730: Lazily initialize account manager on new push message 2020-03-03 11:38:58 -05:00
Grisha Kruglov
e6e2dd94c7 Closes #7344: Login storage refactor
The a-c side of this work is in https://github.com/mozilla-mobile/android-components/pull/6128

This switches Fenix to use `SyncableLoginsStorage`, which caches a connection internally
on first access, and doesn't expose any lock/unlock APIs at the public boundary.
2020-03-03 16:58:58 +01:00
Sebastian Kaspari
a890bd4c0c AwesomeBarView: Pass BrowserStore to SessionSuggestionProvider instead of SessionManager. 2020-03-03 14:19:18 +01:00
Christian Sadilek
20387401b1 Issue #7863: Ensure parent process triggers speculative connect 2020-03-03 14:19:18 +01:00
Sawyer Blatz
f20fb50481 For #5346 & For #8859: Fixes textSize & animation on TabCounter 2020-03-02 18:54:20 -08:00
Sawyer Blatz
e38bff8597 For #5308: Display search shortcuts when going from browser to search 2020-03-02 17:54:05 -08:00
Andrew Gaul
4ab4733f34 Do not scroll menu when toolbar is on top
Fixes #8838.
2020-03-02 14:56:52 -08:00
Harshal Lele
e318cd7d15 fix #8135 - remove getColorFromAttr 2020-03-02 15:48:33 -07:00
Sawyer Blatz
8e06933e8d For #167: Adds browser -> home animation 2020-03-02 14:45:44 -08:00
Emily Kager
a61502215b Revert "For #7603 - Temporarily do not show biometric prompt for OnePlus devices"
This reverts commit 17d7928cc9.
2020-03-02 14:31:08 -08:00
Michael Comella
db57e123b9 For #8797: Do not allow nested scrolling on top sites. 2020-03-02 15:24:43 -07:00
mcarare
2bb2061931 For #8766: Show collections only when tabs are open or collection exists 2020-03-02 14:27:04 -07:00
Mihai Adrian
e3d34edfc7
For #8873 - Update snackbar padding for adding top sites 2020-03-02 14:28:14 -05:00
Arturo Mejia
4cf34b47ee
Show a notification when add-on update requires new permissions 2020-03-02 13:46:37 -05:00
Sawyer Blatz
e96732604b For #167: Improves home to browser animation 2020-02-28 18:04:14 -07:00
Michael Comella
9ed43b60b6 For #7781: instrument visual completeness for top sites.
Eyeballing my output in *Debug builds on my P2, this adds approximately 115ms
or slightly less from first frame drawn to visually complete time.
2020-02-28 13:37:06 -08:00
Michael Comella
4605ba9124 No issue: make Performance methods private that can be. 2020-02-28 13:37:06 -08:00
ekager
a6b07afa95 No issue: Fix LeakCanary detected memory leaks
Co-authored-by: Emily Kager <emilykager@gmail.com>
Co-authored-by: Pierre-Yves Ricau <py@squareup.com>
2020-02-28 13:29:16 -08:00
Sebastian Kaspari
83f94cacb5 FennecWebAppIntentProcessor: Handle manifest file not existing. 2020-02-28 13:27:53 -08:00
Sebastian Kaspari
a477f14042 IntentReceiverActivity: Simplify intent handling.
This patch removes the need to process() and then match() on every intent processor.
A successful process() means that we already matched. Doing this in two steps caused
issues when the process() failed but later the simple check in match() returned true.

After this patch lands I intent to remove the match() API from the IntentProcessor
interface in AC:
https://github.com/mozilla-mobile/android-components/issues/6097
2020-02-28 13:27:53 -08:00
mcarare
5a6fc02976 For #8773: Set proper anchor and padding for Snackbars on browser screen 2020-02-28 13:23:11 -08:00
mcarare
df80a5240b For #6607 Add button to no tab content pane 2020-02-28 13:21:22 -08:00
David Walsh
5b7a800f98 Make 'Redirect to Sync' home menu item go directly to the 'Reconnect to Sync' / error screen 2020-02-28 13:19:06 -08:00
David Walsh
0187669790 Match account problem styling between HomeMenu and BrowserMenu 2020-02-28 13:18:40 -08:00
Sebastian Kaspari
d89fbd7af8 FenixSearchEngineProvider: Use dummy location service in debug builds.
Workaround for issue described in:
https://github.com/mozilla-mobile/android-components/issues/5989

For debug builds it is unnecessary to use the actual location provider since those builds
do not have an API key configured. With that patch we replace the location provider with
a dummy implementation in debug builds.
2020-02-28 13:17:45 -08:00
Arturo Mejia
30f351910a
Make sure all installed extensions are registered for updates 2020-02-28 15:37:08 -05:00
Will Hawkins
f9b716286a For #8034: Create a post-visual completeness executor
Create an object that will execute its enqued tasks
when Fenix is visually complete.
2020-02-28 09:15:06 -08:00
Simon Chae
0def456cac
For #8116: Attach add-on snackbar to activity rootView 2020-02-27 17:47:59 -05:00
David Walsh
b525f2382a
For #7504 - Update sync error display in menus (#8639) 2020-02-27 12:54:14 -08:00
ekager
63ddff533d For #8641 - Update addon text selector to use attr colors 2020-02-27 12:40:57 -08:00
Simon Chae
4854566f94
For #8824: Reset isInstallationInProgress in correct lifecycle (#8825) 2020-02-27 12:33:37 -05:00
Arturo Mejia
cfa6f0cc7a No issue: Submit exceptions while updating add-ons to the crashReporter 2020-02-27 17:44:23 +01:00
Simon Chae
41a84e85a3
For #8699: Add view.settings to setAllInteractiveViewsClickable (#8820) 2020-02-27 11:30:22 -05:00
Mihai Adrian
9612c3f16d
For #8540: Fix ETP options not being correctly applied (#8688) 2020-02-26 12:25:40 -08:00
David Walsh
e2b72a9c01 For #8505 - Update tab icon 2020-02-26 12:04:51 -08:00
Simon Chae
f99bad949e
For #8699: Add setAllInteractiveViewsClickable for add-on pending removal (#8776) 2020-02-26 14:22:42 -05:00
mcarare
314bee2abd For #8627: Add proper content description to ETP card clickable areas 2020-02-26 08:31:51 -08:00
Grisha Kruglov
7275dd5269 Public API changes related to 0.52.0 A-S bump 2020-02-26 10:15:58 +01:00
Severin Rudie
c87c837865
For #8752: fix invalid AutoplayAction crash 2020-02-26 00:37:44 -05:00
Sawyer Blatz
b8d5dc4551 For #7715: Display search suggestions when pressing allow 2020-02-25 20:14:05 -08:00
Grisha Kruglov
fddf77280c Remove direct A-S dependency; switch to using 'full' megazord
As far as I can tell, we never actually exercise the a-s libraries in Fenix tests currently (this was one of the presumed reasons for having a direct dependency).
In a different branch I've started work on adding end-to-end tests, but currently that's blocked on trying to figure out to load native libraries in tests (somehow, fenix's setup is different than what we have in A-C, not yet clear to me in what way).

Another reason for a direct dependency (i think) is that we needed it to configure a `fenix` megazord. This could be solved via a `support-megazord-fenix` a-c component that provides the correct transient dependencies,
but we can also just switch to use the `full` megazord instead, which is essentially what fenix megazord is at this point. A-S team wants to remove the fenix megazord, so this will help. This is what this patch does.
2020-02-25 17:30:57 -08:00
ekager
7f34204188 For #5843 - Ensure tabs pending deletion are removed 2020-02-25 16:53:52 -08:00
Sawyer Blatz
13c9c39658 For #4383: Add feature flag 2020-02-25 16:45:59 -08:00
Sawyer Blatz
009a7f3020 For #4383: Enable dynamic bottom toolbar 2020-02-25 16:45:59 -08:00
ekager
f569f48b33 For #5696 - Adds basic share action to text selection context menu 2020-02-25 15:39:01 -08:00
ekager
ffc2785c1e No issue: Add back updateThemeForSession in onResume 2020-02-25 15:35:16 -08:00
MarcLeclair
41f9311e20
For #7448: Move LP to IO dispatcher (#8558) 2020-02-25 17:55:43 -05:00
Sawyer Blatz
82979afb48 For #8743: Fix baseBrowserFragment crash 2020-02-25 14:43:59 -08:00
ekager
511c36e191 Removes FragmentPreDrawManager changes in BrowserFragment 2020-02-25 13:38:47 -08:00
Sawyer Blatz
dcc1e9fc65 No issue: Fixes swipeRefresh UI test crash 2020-02-25 11:08:41 -08:00
mcarare
cc47bc4e1e For #8655: Show top site context menu below top site title 2020-02-25 10:30:15 -08:00
Arturo Mejia
959e438ff3
Initializes GlobalAddonDependencyProvider 2020-02-25 12:31:05 -05:00
Mihai Adrian
beb323924b
For #8594: Show correct info in Etp settings info (#8687) 2020-02-25 09:18:27 -08:00
Sebastian Kaspari
388c7017d8 Closes #6003: MigrationProgressActivity: Always open browser. 2020-02-25 17:44:18 +01:00
Severin Rudie
69c6de7cd4
For #8411: integrate AC permissions changes (#8618) 2020-02-25 07:36:19 -08:00
Sparky93
0f609b1888 Fix for #8533 - Migration screen's buttons in the wrong place
Made a small refactor on the migration screen layout in order to correctly position the elements.
2020-02-25 13:19:09 +01:00
Simon Chae
0434e53911 For #8637: Remove setActivityTheme outside activity lifecycle scope 2020-02-24 19:48:03 -08:00
Mihai Adrian
4be693255d
For #8565: Fix updating dropdown preferences in ETP settings! (#8573)
* For #8565: Create custom SharedPreferenceUpdater for String Preferences

* For #8565: Use custom updater to correctly update DropDownPreference

* For #8565: Set default values for dropDown preferences

* For 8565: add tests for findEntriesValue

* For 8565: clarified findEntryValue

Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2020-02-24 18:07:02 -08:00
Sebastian Kaspari
fdd3d29cd4 Implement new feature-tabs API. 2020-02-24 14:35:36 +01:00
Jeff Boek
cbad832b19 For #8153 - Allow web-extensions to open tabs in correct browsing mode 2020-02-24 00:24:07 -08:00
Jeff Boek
dfde37baf5 Reverts For #7559 - allows changing locale even after setting theme with 2020-02-24 00:24:07 -08:00
Jeff Boek
541bcf072a Reverts all BrowsingModeManager changes 2020-02-24 00:24:07 -08:00
ekager
0d398f7d44 For #8580 - Don't change theme in initialize UI 2020-02-22 20:03:02 -08:00
Roger Yang
60d38057bb
Closes #8654: Fix breakage from customTabId rename (#8656) 2020-02-21 13:37:46 -08:00
Jeff Boek
26d1bd70d8 Revert "For #8460: Prevent multiple back navigation clicks."
This reverts commit b030d3ac9f.
2020-02-21 09:32:02 -08:00
Sawyer Blatz
d918cfdf38 For #1901: Screenshot engineView to remove GV flash
Co-authored-by: ekager <ekager@mozilla.com>
2020-02-21 08:35:42 -08:00
Roger Yang
0630e2482f
Closes #8544: Activity should be reused when opening intents from other apps (#8547) 2020-02-21 09:02:13 -05:00
Simon Chae
da0148b8bd For #8535 #8498: Allow for multiple browsingModeListeners dispatch 2020-02-20 19:50:35 -08:00
Dennis Schubert
be06450dd9 Bug 1613416 - Hide "Report site issue" button in Fenix Production. 2020-02-20 19:24:56 -08:00
mcarare
b030d3ac9f For #8460: Prevent multiple back navigation clicks. 2020-02-20 19:14:45 -08:00
Arturo Mejia
8b7fd3a1df
For issue #8570: Disabling uBlock and quickly opening the Settings
section cause a crash
2020-02-20 20:31:26 -05:00
Sawyer Blatz
f02e06afae
For #8454 - Removes back button from the search screen 2020-02-20 18:15:47 -05:00
Jeff Boek
f050db517c For #8552 - Fixes bug where "installing/uninstalling" was using the old pref key 2020-02-19 15:20:52 -08:00