Commit Graph

1549 Commits (9dd9503db9f81d5ec8bf18db1ef08dfa3103c3ef)

Author SHA1 Message Date
Yeon Taek Jeong f5ffe3734c
For #4457: Adds telemetry for search widget actions (#4714) 5 years ago
Yeon Taek Jeong 2f265eccbd
For #4732: Fix search engine display issue (#4735) 5 years ago
Mihai Adrian 1a4ef1535c For #4434 - made close button for collections more accessible. (#4443)
* fixes #4434 - made close button for collections more accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for #4193 - close button for tabs

* fixes #4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button

set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
5 years ago
Michael Cooper 12371ca9c1 Add no-op experiment to test service-experiments integration (#4551)
* Add no-op experiment to test service-experiments integration

* Shorten metric name to meet schema

* Add active_experiment metric to docs

* Add approved data review
5 years ago
Tiger Oakes 3acabeb6c3 Use global navigation action for browser fragment (#4691) 5 years ago
isabelrios 7729cb63a7 Fix UI Screenshot TabMenuTest (#4730) 5 years ago
Colin Lee 5b4a441bcb For #1667: Screen reader can't reach other UI items when QAB expanded (#4695) 5 years ago
Emily Kager 1328d686aa No issue - Autoformatting (#4715) 5 years ago
Sebastian Kaspari b733fcdbd5 Closes #4719: Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. (#4722) 5 years ago
Sourabh 42e3b2771e fix #4633: show toast only on first login (#4676)
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
5 years ago
(´⌣`ʃƪ) 5aac05859d Fix #4436: hide onboarding before navigating to settings (#4675)
* Fix #4436: hide onboarding before navigating to settings

* No issue: Rename emitAccountChanges to emitModeChanges
5 years ago
Sebastian Kaspari d03c15d15c Issue #4431: Integrate feature-media component (Nightly and debug builds only). (#4683) 5 years ago
Colin Lee 0c8bcd39be For #4652: HomeFragment Crash "Can not.. after onSaveInstanceState" 5 years ago
Jorge De Los Santos 337ad1e88e For #3424 - Make talkback ignore ImageButton in Collection Sele… (#3792)
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
5 years ago
Grisha Kruglov b38b94ed79 Closes #4671: Fix a potential NPE in BookmarkFragment 5 years ago
Grisha Kruglov 634ee184a6 No issue: add some BookmarkFragmentInteractor tests 5 years ago
Grisha Kruglov f323105163 No issue: reduce code duplication in BookmarkFragmentInteractor 5 years ago
Christian Sadilek 5fe05e919a For #4125: Suppress coroutine warning to fix release build 5 years ago
Sawyer Blatz 0ec92d716f
For #4123: Adds telemetry for quick action open in app (#4629) 5 years ago
Yeon Taek Jeong b24793d863 ktlint fix 5 years ago
Yeon Taek Jeong aac73a8fe2 Finish adding tests 5 years ago
Yeon Taek Jeong 6c9ce784b1 Fix, add some tests 5 years ago
Yeon Taek Jeong 2a6069bfb7 Fix rest of issues 5 years ago
Yeon Taek Jeong 69434a765f Fix most issues 5 years ago
Yeon Taek Jeong faf0ecbcc0 For #4125: Migrate Sign in to Sync to Libstate 5 years ago
Axel Hecht 65de521ccf Import strings from android-l10n (#4643)
State: mozilla-l10n/android-l10n@ab580f757c
5 years ago
Colin Lee 7f07eabbd8
For #4652: Crash "Can not perform this action after onSaveInstanceState" (#4654) 5 years ago
Jonathan Almeida 353ecab44e No issue: Disable failing ActivationPingTest 5 years ago
Tiger Oakes 52542708aa Consodilate private browsing code 5 years ago
Jonathan Almeida 23f5ac0fb9 For #4066: Create InflationAwareFeature for lazy inflation 5 years ago
Colin Lee 519c3bde5d For #4066: Provide lazy inflation of Find In Page View 5 years ago
Sawyer Blatz 167b2ef002 No issue: Removes deprecated usage of InstrumentationRegistry 5 years ago
Colin Lee c9c43260c9
For #4529: Handle crash initializing CreateCollectionViewModel late (#4628) 5 years ago
ValentinTimisica 63d50d9827 Fixes #4323: Modified UI of component_collection_creation.
To fix the overlapping issue I used Guideline and
layout_constraintWidth_default property. I also used the
layout_constraintHorizontal_bias property to make the back_button to
lean to the left and the select_all_button to lean to the right.
5 years ago
Christian Sadilek e26570054a Suppress warning in LeanplumMetricsService to fix release builds 5 years ago
Emily Kager e1f0c9f48b No issue: Update testing dependencies 5 years ago
Mathieu Leplatre 04daf21437 Fix #4612: Fetch experiments from Remote Settings CDN 5 years ago
Colin Lee ef97173cd9
For #4529, #4427: Resuming after restoring instance state breaks UI (#4571)
* For #4529, #4427: Resuming after restoring instance state breaks UI

* Clear up warnings
5 years ago
Emily Kager c21c91eac5 No issue: Update testing dependencies and deprecated method (#4608) 5 years ago
Sawyer Blatz ff6e9bccb7
For #4451: Adds tests for DefaultBrowserToolbarController (#4493)
* For #4451: Adds tests for DefaultBrowserToolbarController

* Continue working

* Large refactoring of test

* Mock analytics

* Fix merge conflicts
5 years ago
Hakkı Kaan Çalışkan 0ea595743d Fixes #4562: Add a-c git hash to about page 5 years ago
Emily Kager 0b98d43c23 Closes #4602 - Add back transitions 5 years ago
Sawyer Blatz 4566bd6fba Fixes feedback 5 years ago
Sawyer Blatz 4d14735935 For #3060: Adds Leanplum attributes for fxa syncing 5 years ago
Sawyer Blatz 9d65e665e5 No issue: Removes deprecated usage of ViewModelProviders 5 years ago
Yeon Taek Jeong ec4d62c895 Fix ktlint 5 years ago
Yeon Taek Jeong 00bd26abe3 Remove task flags 5 years ago
Yeon Taek Jeong f952234c57 Keep CLEAR_TASK 5 years ago
Yeon Taek Jeong c87468d031 Remove popBackStack 5 years ago
Yeon Taek Jeong a8526a0606 For #4438: Fix crash when opening any URL from URL bar w/ long press 5 years ago
Sawyer Blatz 969d17b4a9
For #969: Adds more telemetry for collections (#4539) 5 years ago
Tiger Oakes 8698ade699 Minify the fenix 5 years ago
Sawyer Blatz da06b0fb15
For #4508: Treats warnings as errors (#4543) 5 years ago
Grisha Kruglov f23f3b7489 Closes #4467: Use a-c version of FirefoxAccountsAuthFeature 5 years ago
ValentinTimisica 59c60ef189 Fixes #4354: Updated SearchFragment state after returning from SearchEngineFragment.
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
5 years ago
Colin Lee a514cb3f8c No issue: Add OSS licenses link to About page 5 years ago
Sawyer Blatz f9288c7fbd
For #969: Finalizes collections telemetry (#4592) 5 years ago
Richard Pappalardo 422818c917
Stub out tabs tests (#4573) 5 years ago
Emily Kager 8194e0778e For #4026 - Update BookmarkDiffUtil to update on Title or URL change 5 years ago
Jeff Boek cf169da2fc For #4557 #3860 - Add string for collection empty state 5 years ago
Emily Kager 0604e9858d Closes #3939 - Adds strings for delete browsing history 5 years ago
Emily Kager b20c381af9 For #1749 - Land ETP Strings 5 years ago
ValentinTimisica 71aedc79fe Fixes #3922: Added accessibility announcement for history empty state.
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
5 years ago
Tiger Oakes 631b7ba7cb Issue #1000 - Split out common browser functions 5 years ago
Emily Kager 23bc8f4320 Fro #4563 - Update delete button alpha when history mode changes 5 years ago
Tiger Oakes 3c1ce90f6f Fixes #2379 - Generic library selection 5 years ago
Emily Kager 4bbb291e8d No issue: Update UI tests with new engine shortcuts behavior (#4552) 5 years ago
ekager 0320efee84 No issue: Removes focusableInTouchMode from home searchbar view 5 years ago
Yeon Taek Jeong 6f962d3376
For #1744: Open search shortcuts when entering search mode (#4536) 5 years ago
Emily Kager 6f7ae227a8 Closes #4540 - Set correct tint for select bookmark folder icon (#4541) 5 years ago
Emily Kager ad448b37ae Closes #4537 - Adds description for onboarding placeholder string (#4542) 5 years ago
ekager 5edc9d0b4e For #2021 - Update custom preferences' views with email/account changes 5 years ago
Travis Long 51218bc93e Integrate service-experiments component (#4098) 5 years ago
Emily Kager a526e0fad3 For #4455 - Rename history headers by hours and days (#4478) 5 years ago
Nikit Bhandari 8aecc2b850 For #4530 Reduce build warnings (#4531) 5 years ago
ekager d0071d0177 For #4495 - Clean up homescreen toolbar focus and content descriptions 5 years ago
Emily Kager 890833d7ac No issue: Fix failing UI tests because of renamed views (#4527) 5 years ago
Sören Hentzschel bfd4849064 For #1427 - enter multi select mode with single click on favicon in library 5 years ago
Nikit Bhandari 671727c3e8 For #4341 use camelCase for views referenced from code 5 years ago
Nikit Bhandari 1cb9f88787 For #4199 make checkbox disabled when there is no data (#4200)
* For #4199 make checkbox unclickable when there is no data
5 years ago
Tiger Oakes 1e4399ee38 Use auto pause with BrowserFragment observers 5 years ago
Tiger Oakes cbd811dcfb Closes #1657 - Use Gecko for downloads (#4296) 5 years ago
Tiger Oakes 6e2ea0750e Issue #2379 - Use LibrarySiteItemView in history 5 years ago
mihai-adrian bac2e40eb2 fixes #4435 - changed title of menuitem for delete and added content description
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
5 years ago
Yeon Taek Jeong 3a262a429b For #3907: Hide 'Go back' button for bad websites from new tabs 5 years ago
ekager 015922ddd2 No issue: Fix Crash lower API by setting gradient drawables in onBind 5 years ago
ekager 79160255c8 No issue: Just use TextView, not AppCompatTextView 5 years ago
Yeon Taek Jeong 83ceec6289 For #201: Search Widget 5 years ago
Jonathan Almeida ec96d134ff No issue: Fix breaking AccountObserver API 5 years ago
Sawyer Blatz 29f089c414 For #2203: Polishes BrowserToolbarMenu 5 years ago
Colin Lee 33e881ca8a For #1539: Only allow delete when folders multi-selected (#4062) 5 years ago
ValentinTimisica da59e36c1b Fixes #4410: Modified visibility of 'Add Tab' button.
I changed the visibility of 'Add Tab' button according to the number of
opened tabs. If there is at least one tab open, the button is displayed.
5 years ago
Grisha Kruglov ae33234bbc Closes #2593: FxA automatic sign-in integration 5 years ago
Grisha Kruglov 210864186b Reflect current sync status when opening account settings 5 years ago
Sawyer Blatz f89cefe92c No issue: Fixes failing UI test on master 5 years ago
Tiger Oakes c342a680d8 Fix crash for bookmarks 5 years ago
Emily Kager d42e72fd8b Closes #4462 - Adjust layout params of select bookmark folder view 5 years ago
Thom Chiovoloni a1adb2e57f Update fenix for new megazord setup 5 years ago
Tiger Oakes ccae66c08a Issue #2379 - Use LibraryPageView in history 5 years ago
Jeff Boek 2813a3cff7 For #4441 - Keeps the ID 0 based for the recyclerview 5 years ago
Christian Sadilek 9887945296 For #4412: Only consume state change when UI initialized 5 years ago
isabelrios f815ef1dd0 Fixes #4324 - Add more l10n screenshots tests (#4350)
* Fixes #4324 - l10n Add more screenshots tests

* change test name

* final changes

* fixing reviewer comments
5 years ago
Christian Sadilek b646e87d9e No issue: Add engine warmup call 5 years ago
Jeff Boek e4700f76c6 For #3886 - Uses `defaultDeviceName` for the `DeviceConfig` device name 5 years ago
Jeff Boek a75c2f7cfb No Issue - Fixes the offset key to prevent endless history bug 5 years ago
Sawyer Blatz 97f7d5ba87 For #2267: Fixes telemetry for reader view (#4328) 5 years ago
Sawyer Blatz 2e7a61860a For #969: Adds more telemetry for collections (#4358) 5 years ago
Jonathan Almeida 4922e5d09d No issue: Move PublicSuffixList to root component
With the PublicSuffixList class in Utilities, the first instantiation
of it (prefetching in onCreate), causes the Utilities to instantiate
and thus slowing down startup by needing the SearchEngineManager from
instantiating as well.

Moving this back to the root component fixes the immediate perf issue.

Co-authored-by: Will Hawkins <whh8b@obs.cr>
5 years ago
Christian Sadilek 59c0005979 For #4412: SiteSecurityClickedListener set incorrectly 5 years ago
Will Hawkins ed31d990a4 No Issue: Move notification manager to member of background services
Instead of taking notification manager as a parameter
(from the utils class), create one private to the
BackgroundServices class. This means that we do not need
to create the entirety of utilities just to use
the notification manager.
5 years ago
mihai-adrian fa8199f429 fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small
changed size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
5 years ago
mihai-adrian 30ecbc6000 fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small
changes size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
5 years ago
Jeff Boek e7ec6246fd For #4137 - Fixes HistoryStoreTest 5 years ago
Jeff Boek af449c84d5 For #4137 - Fixes HistoryInteractorTest 5 years ago
ekager 4494e40dbc For #4137 - Adds pagination to the history view 5 years ago
Emily Kager 0773069dad For #3829 - Ignore Intents Launched From History 5 years ago
Nikit Bhandari 46de06d132 For #4339 reduce build warnings (#4340) 5 years ago
Emily Kager 95208c84a9 Closes #4265 - Do not pop after all exceptions are removed (#4392) 5 years ago
Christian Sadilek 76ed07bd5d Closes #4412: BrowserInteractor has not been initialized (#4414) 5 years ago
Afzal Najam 8946bf20c4 Closes #3341 - Remove UserAgentRewriter 5 years ago
Emily Kager ec0bd85f6d For #4198 - Include Intent.ACTION_SEND to open to browser 5 years ago
Jonathan Almeida 026dcb01f5 No issue: Enable Send Tab and Push in production 5 years ago
Jonathan Almeida 90b1e5c262 Closes #4355: unsubscribe FxA subscription on logout 5 years ago
Maurya Talisetti 093b76593d Closes #3419: Use better accessibility strings for tab collections 5 years ago
ekager 3fb20aea6a Closes #4040 - Remove NestedScrollView from Bookmark Layout 5 years ago
mihai-adrian 458632f4bf fixes #4237 - Cannot edit the default name of a collection, only replace it
changed setting of text to be done before transition, preventing transition to make textView unclickable;
 added renaming situation to showKeyboard in onResume();
 changed title text when renaming, from: "Name collection" to "Rename collection".
5 years ago
mihai-adrian ef3c813aee fixes #4237 - Cannot edit the default name of a collection, only replace it
changed setting of text to be done before transition, preventing transition to make textView unclickable;
 added renaming situation to showKeyboard in onResume();
 changed title text when renaming, from: "Name collection" to "Rename collection".
5 years ago
mihai-adrian 2e300fc8cf fixes #4237 - Cannot edit the default name of a collection, only replace it
made name_collection_edittext field clickable
5 years ago
Sawyer Blatz 385dfd2f15
For #4376: Removes usage of selectedSessionOrThrow (#4381) 5 years ago
mihai-adrian 4ee8a890a8 fixes #3843 - (L10N) regression: alignment issue when saving tabs to collection
changed height to match_constraints instead of wrap_content - this makes for a better calculation of space, avoids setting textView on two lines, with blank line below.
5 years ago
ekager 0703fdc91f Closes #4240 - Exclude custom tabs from displayed tab count 5 years ago
bloslo 8ff77b90f3 For #3886 - Change default device name to show the app name. (#3916)
* Fix default device name to show the app name.

* Add string resource with placeholders.

* Wrap line that triggers MaxLineLength lint issue.
5 years ago
bloslo 7ab4498771 For #3548 - Fix close tab button visibility. (#3801)
* For #3548 - Fix close tab button visibility.

* Switch to 'wrap_content' instead of fixed values.

* Align close tab button with settings button.

* Change margin top
5 years ago
Tiger Oakes ecc743a1f9 Minify logo path (#4276) 5 years ago
Tiger Oakes d1651ecf71 Closes #4012 - Animate quick settings (#4047) 5 years ago
Tiger Oakes 2467588c4a Create shared custom view for library items 5 years ago
Mihai Adrian ed60bdf470 fixes #3905 - "Go back" button too low on high risk error pages (#4378)
added to border-box value to box-sizing property for tablets so that the height property includes content and padding
5 years ago
Sawyer Blatz 437ecfbca8
For #1750: Adds gradient to private BrowserToolbar (#4361)
Also updates the color of quickActionSheet ot be "above" attribute
5 years ago
Mugurell bf44c50dfd Fix #4372 - Set SitePermissionsDetailsExceptionsFragment toolbar title in onResume
The flow we are currently using involves setting a new title for the containing
Activity when the user navigates to a new Fragment.
This happened for SitePermissionsDetailsExceptionsFragment in it's onCreate().
Opening a permission (SitePermissionsManageExceptionsPhoneFeatureFragment) will
set a new title in it's onCreate() but going back from this new Fragment will
not create again a new SitePermissionsDetailsExceptionsFragment.
As a workaround I moved the call to set Activity's title in onResume().
5 years ago
Nikit Bhandari 5e52fc46b8 For #3443 - convert textPercentageSeekBar to Kotlin (#4081)
* convert textPercentageSeekBar to Kotlin

* fix test

* fix test again

* fix test again

* conflicts resolved

* merge multiple kdocs into one
5 years ago
Axel Hecht be66e00303 Import strings from android-l10n
State: mozilla-l10n/android-l10n@1412258878
5 years ago
Colin Lee 9bc0122ce3
For #4359: findBookmarkedUrl blocks the main thread (#4362) 5 years ago
Amaan Marfatia 4c13f45e9e Fixes #4192: Private keyboard in private browsing (#4345)
Sets compliant keyboards to private mode when in private browsing.
5 years ago
James Hugman ac359f6970 Closes #1331 - Filter consecutive history items using simplified URL 5 years ago
Sawyer Blatz 6fa022c2f8
For #4124: Migrate BrowserToolbar to Libstate (#4279)
* For #4124: Migrate BrowserToolbar to Libstate

* Restores QuickActionSheetReducer

* Improve tests

* Make QuickActionSheetController

* Finalize tests

* Breaks out QuickActionSheetState

* Fix comments

* Adds BrowserStoreTest
5 years ago
Tiger Oakes 87d8f3b037 Remove redundant super calls 5 years ago
Tiger Oakes 88c05a5f43 Use glide-like image loading function 5 years ago
Andrey Mukamolov ccfaa3826b For #2142: Added accessibility focus 5 years ago
Andrey Mukamolov 965d99a1c1 For #2142: Added UI test assertion 5 years ago
Andrey Mukamolov d5eeadda66 Closes #2142: Enable private browsing button is focused instead of Search or address 5 years ago