Jonathan Almeida
2c6395cafe
Issue #18535 : Do not animate first scroll to position
...
This looks less that ideal with a grid layout that swings by from the
normal tabs to private tabs.
2021-04-06 09:57:33 +04:00
Jonathan Almeida
8ccc4648a9
Issue #18535 : Move list/grid viewholders to browser package
2021-04-06 09:57:33 +04:00
Kate Glazko
841dacb69e
For 17798: Sync Menu Item
2021-04-05 14:34:34 -07:00
Jonathan Almeida
92a99542e6
Close #17821 : Add TabsTrayStore with actions and reducer ( #18773 )
2021-04-05 15:12:07 -04:00
Jonathan Almeida
af3a5b0a17
No issue - Make TabLayoutMediator lifecycle aware ( #18779 )
2021-04-05 15:10:29 -04:00
Travis Long
c17594c745
[SDK-246] Change Nimbus channel
input to use the same method as Glean ( #18766 )
...
* [SDK-246] Change Nimbus `channel` input to use the same method as Glean
* Update app/src/main/java/org/mozilla/fenix/experiments/NimbusSetup.kt
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2021-04-05 12:30:25 -04:00
Gabriel Luong
1f320fd2ad
No issue - Remove generic strings for more specificity ( #18769 )
2021-04-02 15:24:28 -04:00
Mugurell
0f0c319896
For #17772 - Collapse browser menu to "Add to Home screen"
...
The menu will start as collapsed.
Users can then swipe up to expand it.
2021-04-02 18:45:27 +03:00
Gabriel Luong
1008ca2b4a
For #18265 - [Add card] Integrate the credit card storage and handle adding a new credit card ( #18719 )
2021-04-02 10:40:44 -04:00
Michael Comella
6e5b4b3ce6
For #18731 : remove anonymous classes from StrictModeManager.
...
After this change, I took 3 profiles: the new code appeared in the profiler
only once and only for one sample (i.e. possibly just got unlucky). It
seems to be improved. Profiles:
- https://share.firefox.dev/3wifiV2 (captured it)
- https://share.firefox.dev/39xgdHz
- https://share.firefox.dev/2QMdlA0
2021-04-01 13:19:49 -07:00
Gabriel Luong
3f21a63c3c
For #18729 - Use consistent string naming for generic strings ( #18730 )
2021-03-31 18:20:04 -04:00
Elise Richards
ca33aef036
For #17770 : New tab three-dot menu reorder ( #18427 )
...
* Create new menu order for new tab
* Add new tab menu navigation. Dynamically update menu when sync auth is needed. Make new tab menu and browser menu consistent.
* Lint
Lint and refactoring tests
* Tests for default toolbar menu
* Feature flag for request desktop site
Add todos for UI test issue 17979
Add todos for UI tests
2021-03-31 16:05:44 -05:00
Mugurell
304e471801
For #18617 - Use the new EngineView#getInputResultDetail()
...
All functionality should remain the same.
2021-03-31 15:36:38 +03:00
mcarare
6f17e329c4
For #17797 : Add bookmarks menu item.
2021-03-31 11:12:58 +03:00
Roger Yang
c7cb0fd5a0
Closes #18706 - Remove unneeded add-on telemetry calls ( #18707 )
2021-03-30 16:19:00 -04:00
rxumoz
51c41f84d5
Closes #18386 - Change language display name to traditional/simplified Chinese for Chinese locale ( #18387 )
2021-03-30 16:18:31 -04:00
Mihai Adrian Carare
ccfb275b03
For #17800 - Request desktop site from home screen. ( #18653 )
2021-03-30 16:12:46 -04:00
Roger Yang
caf8ac8207
Closes #18514 : Re-add tab counter in tabs tray ( #18659 )
2021-03-30 15:43:07 -04:00
Michael Comella
ac34432176
For #18426 : warn about flaw in app_opened_all_startup
probe.
2021-03-30 10:38:44 -07:00
Michael Comella
ade38246be
For #18426 : record cold start duration telemetry.
2021-03-30 10:38:44 -07:00
Michael Comella
2be9fb61d0
For #18426 : add StartupActivityStateProvider.
...
This will be used to filter conditions for the start up telemetry we're
adding.
2021-03-30 10:38:44 -07:00
Michael Comella
edd49b286d
For #18426 : add ApplicationStartReasonProvider.
...
We need to know this state to add a correct COLD MAIN probe.
2021-03-30 10:38:44 -07:00
Michael Comella
520634165e
For #18426 : add DefaultActivityLifecycleCallbacks.
...
We'll extend this in subsequent commits.
2021-03-30 10:38:44 -07:00
Jonathan Almeida
d167bc7b67
Issue #14117 : Add Synced Tabs as a page in the tabs tray
2021-03-30 19:09:50 +04:00
Gabriel Luong
ae625e60cf
For #18247 - [Add card] Populate the Credit card expiry year drop down
2021-03-29 21:37:03 -04:00
Gabriel Luong
4763d8c9e5
For #18246 - [Add card] Populate the Credit card expiry month drop down
2021-03-29 21:37:03 -04:00
Gabriel Luong
46a267a494
For #18243 - Add a credit card editor screen
2021-03-29 21:37:03 -04:00
Jonathan Almeida
cb1fb95a3a
Issue #18521 : Focus on page corresponding to selected tab
...
This first part of #18521 is to focus on the correct pager item first
before we land a patch for `scrollToPosition` of the selected tab.
2021-03-30 03:08:01 +04:00
Jonathan Almeida
e41344aa1f
Close #18668 : Add stable ID cache for TabAdapter.getItemId
2021-03-30 02:58:54 +04:00
Kershan
02d70d3837
For #18453 - Show SUMO for default browser deeplink on Android <N
...
Lower Android versions don't offer the possibility of opening system settings
at a specific preference. In this cases we already shown a sumo article
detailing the manual steps each user is expected to perform to change the
system set default browser.
2021-03-29 18:14:15 +03:00
Jonathan Almeida
26c176a75e
Issue #18443 : Move viewholders to separate files and package
2021-03-27 03:42:34 +04:00
Jonathan Almeida
917783a141
Issue #18443 : Fix changes between grid/list viewholders
2021-03-27 03:42:34 +04:00
Jonathan Almeida
9ce4adaa32
Close #18443 : Use recyclerview-selection for multi-select mode in tray
...
Add multi-select mode to the BrowserTabsAdapter. It has the
functionality to:
- Enable multi-select mode on long-press.
- Enable multi-select mode when changed by an external function.
- Only works for normal tabs (as we currently have it).
Co-authored-by: "codrut.topliceanu" <codrut.topliceanu@softvision.ro>
2021-03-27 03:42:34 +04:00
Gabriel Luong
5d0af34537
For #17291 - Display a list of all active Nimbus experiments ( #17515 )
2021-03-26 13:58:30 -04:00
yichiehc
dd09ba64c4
For #18594 : Highlight the "Default browser" system setting on Android >= N
...
Although not public APIs we can use specific extras in the Intent used to open
system settings such that the "Default browser" setting is highlighted to
provide a better UX for users looking to set Fenix as default.
2021-03-26 18:25:56 +02:00
rxumoz
46af52d254
Update top sites to add PDD for MozillaOnline builds ( #18615 )
2021-03-26 12:18:46 -04:00
Mihai Adrian Carare
a539f69cb2
For #18260 - Add pin to default sites. ( #18618 )
2021-03-26 11:36:27 -04:00
Roger Yang
c21b44e0a3
Closes #18535 : Re-add grid layout to tabs tray ( #18638 )
2021-03-26 10:33:46 -04:00
Arturo Mejia
869c99afaa
For #15372 Optimize the order and messages of onboarding cards
2021-03-24 22:16:00 -04:00
Roger Yang
34a7bc0baa
For #17644 : Record when user taps on a add-on's setting ( #18504 )
2021-03-24 14:31:39 -04:00
Jonathan Almeida
2c23941823
Issue #18538 : Add BrowserTabsAdapter for tabs tray
2021-03-24 02:37:06 +04:00
Gabriel Luong
3b11b9a700
For #18242 - Wire up "Sync cards across devices" preference with SyncPreferenceView ( #18605 )
2021-03-23 16:00:41 -04:00
mcarare
90fea8ba5e
For #17790 : Remove app from recents screen on quit.
2021-03-23 23:02:01 +04:00
Elise Richards
559cf54798
For #17190 : notifications are updated when locale is changed ( #18179 )
...
* Add intent processor for locale changes
* Recreate notification and notify in the service
* Use locale use cases to update notification
* Use notification id instead of tag
* Add locale use cases and restore locale in application
* Send locale to service instead of string
* Controller tests for locale
* Update Android Components version to 74.0.20210323143308
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2021-03-23 14:16:30 -04:00
Gabriel Luong
578d6b5205
For #18240 - Add a Credit Card preference screen ( #18410 )
...
- Removes an unused preference key "pref_key_credit_cards_addresses"
2021-03-23 11:59:32 -04:00
Roger Yang
a8c53c6bf1
Closes #17791 : Use updated URL with custom tabs when copying to clipboard ( #18590 )
2021-03-23 10:31:53 -04:00
Vitaly V. Pinchuk
43c54b7006
For #18395 : Dismiss contextual menu when entering/exiting Reader Mode
2021-03-23 11:46:10 +02:00
mcarare
d0a45bab21
For #17799 : Add extensions submenu item.
2021-03-23 09:52:45 +02:00
Arturo Mejia
54db8f3fde
Revert "For #17805 - Fix adjustResize deprecation ( #18252 )"
...
This reverts commit 38f906a6
2021-03-22 16:32:20 -04:00
Michael Comella
62e2fb1aa6
For #18426 : add measurement probes for long-running lifecycle methods.
...
In addition to the existing probes for onCreate, this should cover all
lifecycle methods that take a long time in our profiles.
2021-03-19 17:41:03 -07:00
Stefan Arentz
b12222503b
[SDK-218] Nimbus updates to provide app_name and channel ( #18559 )
...
* [SDK-218] Nimbus updates to provide app_name and channel
Provides the `app_name` and `channel` info to Nimbus.
* Update to A-C Nightly 74.0.20210319190549
Co-authored-by: Travis Long <tlong@mozilla.com>
2021-03-19 16:39:24 -04:00
Michael Comella
9024eca01e
For #18426 : add telemetry for app.onCreate subsections.
...
Hopefully this will help us understand behavior of the
`application_on_create` probe, specifically that it seems to take longer
in telemetry than in does locally compared to `home_activity_on_create`
(comparing the medians to local runs)..
2021-03-19 11:52:29 -07:00
Michael Comella
5c0f30fd5c
For #18426 : add TimingDistributionMetricType.measureNoInline.
...
This addresses an issue I found in my follow-up PR.
2021-03-19 11:52:29 -07:00
Roger Yang
d2ffaa85f9
Closes #17531 : Use shared preference to store top sites count for telemetry ( #18557 )
2021-03-19 14:13:24 -04:00
Roger Yang
27e52b7e3d
Closes #17956 : Add top site telemetry to available search engines ( #18129 )
2021-03-19 10:53:36 -04:00
Mihai Adrian Carare
79794962d0
Closes #12565 : Clean up use of Context within ReviewPromptController. ( #18537 )
2021-03-18 21:49:09 -04:00
mcarare
f9a52af98d
No issue: Update Android Components version to 74.0.20210318143143
...
Replaces deprecated method setToolbarColor(Int) in CustomTabsIntent.Builder.
2021-03-18 21:06:36 -04:00
Stefan Arentz
6f7b911c11
Enable the Nimbus experiments library on all channels ( #18526 )
2021-03-18 13:33:33 -04:00
Roger Yang
8a7c50bbef
For #17644 : Always update add-on's telemetry values before sending metric ping ( #18529 )
2021-03-18 13:18:14 -04:00
Jonathan Almeida
e1bf8c75a0
Enable new tabs tray only for debug builds
2021-03-18 17:21:09 +04:00
Codrut Topliceanu
38f906a685
For #17805 - Fix adjustResize deprecation ( #18252 )
...
* For #17805 - Fix adjustResize deprecation
To handle the deprecation of `adjustResize` I've moved it from `styles.xml` and `AndroidManifest.xml` to `Activity.kt` as a fallback for devices with Android < 11. For Android 11 and up `setDecorFitsSystemWindows(false)` and `OnApplyWindowInsetsListener` will be used to handle app insets. Normal use activities should call `enableSystemInsetsHandling` in `onCreate` as to properly display system bars and for proper keyboard handling.
2021-03-18 10:05:54 +02:00
Jonathan Almeida
05aa948dc7
Issue #17822 : Create a tabs tray layout and fragment
...
Co-authored-by: Kate Glazko <kglazko@Kates-MacBook-Pro.local>
2021-03-17 03:16:10 +04:00
Gabriel Luong
35bae17e86
For #18408 - Add a lazy getter for AutofillCreditCardsAddressStorage
2021-03-16 13:30:43 -07:00
Grisha Kruglov
ff740337be
Closes #18501 : Enable Nimbus on Beta channel
2021-03-16 11:06:47 -07:00
Mugurell
1e30744c64
For #17869 - New AndroidKeystoreExperiment telemetry
2021-03-15 13:35:49 -07:00
Mugurell
ec0176275b
For #17869 - Start the Android Keystore experiment
...
Only on API 23+ (minimum Android version needed for SecureAbove22Preferences)
and only if enabled by a Nimbus experiment.
The Nimbus experiment will have the key `fenix-android-keystore` and use the
default branches - "control" and "treatment".
2021-03-15 13:35:49 -07:00
Gabriel Luong
3a056bf850
For #18036 - Add TrackKeyInfo to Ad Click Metrics ( #18159 )
2021-03-15 12:57:53 -04:00
Arturo Mejia
8f43acc903
Closes #18367 run SupportedAddonsChecker only for users with unsupported extensions
2021-03-15 10:40:10 -04:00
Arturo Mejia
ec52c56ed9
For issue #18132 remove icons from Settings screen
2021-03-15 09:53:08 -04:00
Arturo Mejia
83b7d6f38d
For issue #18132 create feature flag for refreshing icons
2021-03-15 09:53:08 -04:00
Jan-Erik Rediger
c47f43608d
Set distributionId
right after initializing Glean
...
Previously setting it might have been arbitrarily delayed, resulting in
this metrics missing from pings that get submitted earlier.
Setting it early should prevent that.
The performance impact is negligible, Glean dispatches recording that
data off-main-thread anyway.
2021-03-15 13:38:11 +01:00
Sebastian Kaspari
8856a3c1d7
Integrate Android Autofill support into Nightly and debug builds.
2021-03-15 10:28:38 +01:00
mcarare
1f96887f96
For #12528 : Provide fallback values for locale display name.
2021-03-15 08:54:20 +02:00
Elise Richards
b15c3ff864
Add open in app to main three dot menu ( #18462 )
2021-03-12 12:13:53 -06:00
Elise Richards
f5a1a01e06
Remove sync sign in and keep it as synced tabs
2021-03-12 12:43:16 -05:00
Elise Richards
d34848a5d9
Add report site issue to new three dot menu
2021-03-12 12:43:16 -05:00
Elise Richards
4b84503813
Remove disabled color for icons
2021-03-12 12:43:16 -05:00
Gabriel Luong
a31ce9bf67
For #18241 - Refactor SyncLoginsPreferenceView to SyncPreferenceView for reusability ( #18383 )
...
This refactors SyncLoginsPreferenceView to SyncPreferenceView so that it be can be used in the
Credit cards preference for the equivalent "Sync cards across devices" preference.
2021-03-10 16:16:37 -05:00
Jonathan Almeida
fbe73cfc1d
For #17804 : Use enterToImmersiveMode from support-ktx component
2021-03-09 15:41:21 -05:00
Roger Yang
9049513017
Closes #18178 : Rework History Telemetry ( #18261 )
2021-03-08 19:15:29 -05:00
Roger Yang
56b08abe0f
Closes #18173 : Add Telemetry When User Opens a Bookmark ( #18174 )
2021-03-08 17:11:59 -05:00
Roger Yang
2322cbdd0e
Closes #18068 : Use AwesomeBarFacts for AwesomeBar Telemetry ( #18090 )
2021-03-08 16:34:52 -05:00
Roger Yang
aada459428
Closes #18163 : Use SyncedTabsFacts for Synced Tab Telemetry ( #18172 )
2021-03-08 15:21:00 -05:00
Mihai Adrian Carare
5c7a01ba6f
For #17971 : Add Reader view appearance controls in three-dot main menu. ( #18340 )
2021-03-08 11:24:27 -06:00
mcarare
8c519994f0
For #18312 : Do not update secure flag on pausing logins fragments.
...
The flags are already properly set for activity and thus for other fragments.
2021-03-08 16:57:12 +02:00
Elise Richards
42cc4cb452
For #17802 : Match the design for three-dot menu navigation ( #17875 )
...
* Feature flag for toolbar menu redesign. Add new items to menu and reorder.
* Handle toolbar items in menu controller
* Remove bookmark from toolbar nav
* Respect toolbar position
* Inline toolbar orientation checks
* Add Todos for bookmark UI tests
* Make variable names consistent
2021-03-04 17:22:13 -06:00
Jan-Erik Rediger
8b7279ebe4
Pass auto-generated build info (version code and name) to Glean ( #18230 )
...
This also re-generated the Glean docs due to an update of the bundled
glean-parser.
2021-03-04 10:22:56 -06:00
Mugurell
cf483ef580
For #18034 - Don't animate the toolbar while the tab is loading
...
Use the new controller offered by AC to resolve some browser layout issues and
also offer an experience consistent with that of other browsers.
2021-03-04 14:41:34 +02:00
mcarare
62bd3b4f95
For #18009 : Correctly report items in adapter for a11y services.
2021-03-03 18:19:42 +02:00
mcarare
05a14efda7
For #18228 : Populate menu options in onResume along with toolbar init.
2021-03-03 15:01:54 +02:00
Vitaly V. Pinchuk
8f5244d528
Closes #18150 : select tabs button not displayed ( #18216 )
...
For #18150 : Improve showing/hiding of "Select tabs" button in tabs tray
Payload argument is unavailable after first call of notifyItemChanged() as the
whole View need to be updated.
Inject a "isPrivate" lambda in the adapter so it will always know what tabs are
currently showing and so always ensure the expected behavior.
2021-03-03 14:34:48 +02:00
mcarare
f83ed13089
For #18227 : Also update icon on search engine edit.
2021-03-02 10:22:31 +02:00
Sebastian Kaspari
d8dd809ed4
Fix metric types of engine telemetry.
2021-03-01 13:10:05 +01:00
Gabriel Luong
ccbca2cf78
For #18202 - Refactor BiometricPromptFeature out of logins into settings
2021-02-27 12:56:07 +04:00
Michael Comella
f44611f632
For #18157 : convert clock_ticks_per_second to quantity type.
...
While we could easily move this into the metrics ping, it's better to
leave it in the other ping because it's less work and because (I think)
we'll be better able to match `framework_secondary` values to the clock
ticks if we combine them in the same ping.
2021-02-26 16:12:59 -08:00
Gabriel Luong
968b7bfc78
For #18198 - Add a feature flag for Credit Cards and Addresses autofill feature ( #18200 )
2021-02-26 17:12:47 -05:00
Jonathan Almeida
607d6382f8
Close #17928 : Add feature flag for tabs tray refactor
2021-02-27 01:10:14 +04:00
Gabriel Luong
9cca1b93b5
Replace TopSitesUseCases.renameTopSites with TopSitesUseCases.updateTopSites
2021-02-25 17:46:23 -05:00
Christian Sadilek
dc002f0508
Remove Session[Manager] references from Fennec intent processors
2021-02-25 11:54:21 -05:00
Arturo Mejia
0e8dc6164d
Target Android 11
2021-02-24 14:26:08 -05:00