Grisha Kruglov
51dab196c4
Closes #15443 : Use fragment's lifecycleScope for AlertDialog actions
2020-09-30 17:42:40 -07:00
Stefan Arentz
ff930175de
For #15537 - Be more verbose about leanplum identifiers ( #15538 )
2020-09-30 13:05:28 -04:00
mcarare
19b377c021
For #15535 : hasOpenTabs now considers the selected tab mode in tray tab.
2020-09-30 08:33:38 -07:00
Michael Comella
56f78cb30c
No issue: elaborate on Components class doc.
...
This is to clarify a misunderstanding I found in PR review.
2020-09-29 15:39:10 -07:00
Sebastian Kaspari
2fda22e857
Revert "For #12565 : Pass metrics to share controller" for debug test failures.
...
This reverts commit bbaca06274
2020-09-29 10:59:31 +02:00
Sebastian Kaspari
4de466883b
Revert "For #12565 : Pass bookmark storage to controller" for debug test failures.
...
This reverts commit 3c22100b84
2020-09-29 10:59:17 +02:00
Andrew Gaul
cfbad1dae9
Show undo snackbars with padding with static bottom toolbar
...
This specifically fixes the close tab snackbar. This commit mirrors
the logic when not using Undo from
9e876ebc44#14982 .
2020-09-29 10:15:30 +02:00
ekager
01e802fef0
For #15324 - Show tab settings and recently closed items in menu when no tabs
2020-09-28 21:09:30 -07:00
ekager
e49cd9c558
For #15503 - Change recently closed max to 10
2020-09-29 00:03:49 -04:00
TrianguloY
b07af9ccd3
For #13856 - Prevent overscroll in swipe to switch tabs gesture
2020-09-28 20:43:44 -07:00
Tiger Oakes
25f62f1c76
Extract locale settings initial state
2020-09-28 20:39:49 -07:00
Tiger Oakes
acbad66f45
Add test for initial logins list state
2020-09-28 20:39:49 -07:00
Tiger Oakes
f2a6aa4f25
Add tests for initial collection creation state
2020-09-28 20:39:49 -07:00
Tiger Oakes
3c22100b84
For #12565 : Pass bookmark storage to controller
2020-09-28 20:05:50 -07:00
Tiger Oakes
bbaca06274
For #12565 : Pass metrics to share controller
2020-09-28 20:05:50 -07:00
Michael Comella
d767cd199e
For #13959 : fix startup crash by using arg Context.
...
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
2020-09-28 18:01:19 -07:00
Michael Comella
42cca072e2
For #13959 : remove resetAfter & port tests to StrictModeManager.
2020-09-28 18:01:19 -07:00
Michael Comella
f19c9920f9
For #13959 : move resetAfter into StrictModeManager.
...
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
2020-09-28 18:01:19 -07:00
Michael Comella
6abeb2d9e7
For #13959 : change StrictModeManager to class from object.
...
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
2020-09-28 18:01:19 -07:00
Christian Sadilek
d4ab728cff
For #14034 : Add debug preference to override AMO collection in Nightly
2020-09-28 17:25:52 -04:00
Michael Comella
a92356fe00
For #13959 : comment about duplication in logic in StrictMode.
...
I had to drop a commit that addressed the issue because it was too hard
to fix.
2020-09-28 13:52:40 -07:00
Michael Comella
e1bd6191c7
For #13959 : add comment to explain why we only resetAfter in certain build modes.
2020-09-28 13:52:40 -07:00
Michael Comella
3bf71ef655
For #13959 : use ac StrictMode.resetAfter rather than duplicating functionality.
2020-09-28 13:52:40 -07:00
Michael Comella
2c1befaa25
For #13959 : rename to attachListenerToDisablePenaltyDeath for clarity.
2020-09-28 13:52:40 -07:00
Michael Comella
c03c7ef793
For #13959 : remove unused penaltyDialog parameter.
...
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
2020-09-28 13:52:40 -07:00
Michael Comella
f05a542060
For #13959 : always enable detectNonSdkApiUsage.
...
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
2020-09-28 13:52:40 -07:00
Sebastian Kaspari
3983c509dc
Use "undo" implementation from Android Components.
...
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
2020-09-28 10:04:46 -07:00
mcarare
6289da892c
For #15310 : Also catch ActivityNotFoundException when sharing to app.
2020-09-28 13:29:17 +03:00
ekager
0d0a28d551
No issue: Update AC to 61.0.20200925190057
2020-09-26 12:21:10 +02:00
ekager
7d5c199e51
For #12383 #15407 #12860 - Switch to using shared view model for session to delete on home
2020-09-25 16:54:54 -07:00
Grisha Kruglov
2999f64d0a
Closes #15434 : Don't try to display a 'signed in' snackbar in a 'headless' mode
2020-09-25 15:31:07 -07:00
Grisha Kruglov
d98eba1d64
Closes #15432 : Invoke UI updates on main thread in response to account events
2020-09-25 15:30:48 -07:00
Grisha Kruglov
24985d54fa
Closes #15436 : Auto-close tabs during startup on the main thread
2020-09-25 15:11:21 -07:00
mcarare
04e59e0ac5
For #15130 : Remove "what's new card" from onboarding screen.
2020-09-25 18:04:48 +03:00
Kate Glazko
e8855c09e6
For #15320 : Ensure Mimetype Other PDF Shows PDF Icon
2020-09-24 13:49:51 -07:00
Elise Richards
1adf467248
For #14280 , #14743 : Remove old search fragment ( #15169 )
...
* Remove search fragment
* Use new folder to search dialog
* Rebase and lint
* Update tests with search dialog nav directions
* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
2020-09-24 15:46:42 -05:00
Jonathan Almeida
add60611b4
For #15349 : Fixes SyncedTabs suggestion not clicking
2020-09-24 15:35:06 -04:00
Grisha Kruglov
f1b0827a0b
For #15296 : Allow excluding bookmark subtrees when editing parent folder
...
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
2020-09-23 23:22:44 -07:00
Sawyer Blatz
0fa2509bef
For #14243 : Pre-land visuals for Close Tabs CFR ( #15171 )
2020-09-23 14:57:52 -07:00
Grisha Kruglov
71b51146cb
Update breaking changes in the FxA/Sync integration
2020-09-23 14:51:04 -07:00
Jocelyne
d45e482373
For #11800 : Hide reveal and clear password icons if the password is empty when editing a saved login ( #15244 )
...
Co-authored-by: Jocelyne Abi Haidar <jocelyne.abihaidar@gotocme.com>
2020-09-23 12:10:49 -07:00
mcarare
c1bf66618e
#274-android-l10n: Update create account string to avoid partial translations.
2020-09-23 08:49:23 -07:00
person808
baccb153b7
For #15219 - Fix tab tray handle size.
...
Also use dimens for the tab history handle.
2020-09-22 15:24:22 -07:00
ekager
24983af94e
For #15291 - Limit current CFRs to show max one every 3 days
2020-09-22 10:43:14 -07:00
mcarare
94d9a2a1ed
For #15263 : Properly update open links in app preference.
2020-09-22 09:44:32 -07:00
ekager
a9075ff87b
For #15272 - Remove bottom margin for toolbar on enter fullscreen
2020-09-22 08:34:29 -07:00
ekager
030d6a5b36
For #15121 - Ensure tabs removed while on browser select an available parent session
2020-09-22 08:33:39 -07:00
mcarare
896c1b7875
For #15268 : Use safe navigation to addon details fragments.
2020-09-22 18:23:17 +03:00
Grisha Kruglov
f51b570654
For #15284 : Process root titles when creating new folders
...
This also simplifies how we do this. We're no longer creating instances of `DesktopFolder` class
nor creating copies of BookmarkNodes just to display root titles correctly for the 'edit folder' UI.
2020-09-21 20:03:04 -07:00
ekager
f16ade33df
For #15089 - Disable recently closed in multiselect
2020-09-21 18:35:08 -07:00
