Tiger Oakes
94c4013810
Closes #3091 - Hide Pull to Refresh under flag ( #3092 )
...
This was merged in after feature freeze so we're pulling it out for
now. Pull to refresh will continue to work in debug mode so that the
design can be iterated on easily.
2019-06-03 14:10:53 -05:00
Colin Lee
04bbeb5ae6
For #3073 'Open in Firefox Preview' no longer opens in app
...
Saving and restoring the custom tab session ID fixed one problem while causing another. I added code to only restore the ID if the session has a customTabConfig associated.
2019-06-03 10:04:17 -07:00
Mitchell Hentges
62473e5e86
Migrates "raptor" build type to work for chrome-perf-testing, too ( #2926 )
2019-06-03 16:32:38 +02:00
ekager
d285e799b9
Clean up logic to return margin pairs for readability
2019-06-03 10:00:00 -04:00
ekager
14fe356d62
For #2794 - Adjust engine margins when enter/exit fullscreen
2019-06-03 10:00:00 -04:00
ekager
98a40aabd7
For #2223 , For #371 - Replace Toolbar with FIP when opened
2019-06-01 10:24:55 -07:00
ekager
388581f76f
For #3056 - Filter sessions on invoke for pending delete all job
2019-05-31 18:52:02 -07:00
Jeff Boek
e15ab3f958
For #1158 - Use a dot instead of an underscore to seperate values
2019-05-31 18:15:07 -07:00
Colin Lee
532483498a
No issue: Store the Custom Tab Session ID to avoid a crash ( #3062 )
2019-05-31 17:03:58 -05:00
Arturo Mejia
038aecc0ee
For #1919- Websites' icons are not displayed on Site permissions ( #3050 )
...
Exceptions.
2019-05-31 16:27:12 -05:00
Emily Kager
d5a9627273
For #2941 - Remove Delete Dialog, Theme Dialogs ( #3052 )
2019-05-31 16:26:34 -05:00
Emily Kager
0327b1146b
For #2977 - Update add new collections flow ( #2991 )
...
* For #2977 - Update add new collections flow
* Rename shared elements to be more general
* Make tab list not clickable in other modes
* For #2577 - Stop Flickering in List
* Add extensions function for next step with collections list size
2019-05-31 12:59:51 -05:00
Emily Kager
f48db90716
No issue: Always try to pop to browser when navigating to browser ( #3043 )
2019-05-31 12:57:34 -05:00
Jeff Boek
14f1d40e10
Fixes #3041 - Fixes the string that gets displayed in the FxA Onboarding card
2019-05-31 10:44:14 -07:00
James Hugman
060cd646c8
Fixes #1570 - Enable app-links feature
2019-05-31 10:39:47 -07:00
Sawyer Blatz
35a745d67d
For #2836 : Fixes custom tab close button color
2019-05-31 09:50:46 -07:00
Jeff Boek
301984733a
For #225 - Adds completion snackbar
2019-05-31 09:42:44 -07:00
Jeff Boek
eda70ab74c
Fixes #3037 - Unchecks boxes after deletion
2019-05-31 09:42:44 -07:00
Jeff Boek
0036938312
For #225 - Fixes crash by moving GeckoView calls t othe main thread
2019-05-31 09:42:44 -07:00
Emily Kager
1bb4d72fd1
For #3027 , For #2858 Pass in Fenix Snackbar for Context Menu Candidate ( #3028 )
2019-05-31 10:16:08 -05:00
Jonathan Almeida
ab39a5088a
For #2052 : Fix BrowserToolbar overlapping web content
2019-05-30 20:40:56 -04:00
Jeff Boek
209b50016e
For #2723 - Cleans up code formatting
2019-05-30 16:38:31 -07:00
Jeff Boek
f9d70dbc92
For #2723 - Creates callbacks to wire up the mode and theme manager together
2019-05-30 16:38:31 -07:00
Jeff Boek
a7d5cdcb9d
For #2723 - Fixes theme manager
2019-05-30 16:38:31 -07:00
Emily Kager
18cd9e58f9
Fixes Crash: Pop up to Browser Fragment if exists when coming from Search
2019-05-30 16:30:06 -07:00
Emily Kager
8dbed67f7f
No issue: Simplify and speed up shared element transitions
2019-05-30 16:30:06 -07:00
Emily Kager
43a961fe73
For #1973 - Toggle QR button on deny permissions, fix engineView crashes
2019-05-30 16:06:37 -07:00
Colin Lee
72c5cb304c
For #2893 , #2673 , #2916 , #2314 : Fix race condition navigating to browser ( #3023 )
...
Since the Navigation library restores the fragment after memory eviction, if we're already on the BrowserFragment and we deep link navigate to the BrowserFragment, we briefly get two of them. This crashes GeckoView.
2019-05-30 17:43:32 -05:00
Emily Kager
4c970a545d
For #2230 - Fix theme selection radio button for Android 6 ( #3019 )
2019-05-30 17:06:46 -05:00
Tiger Oakes
74dd2a5f23
Issue #103 - Pull to refresh ( #3020 )
2019-05-30 17:05:49 -05:00
Sawyer Blatz
cd19f36b96
For #2227 : Fixes issue with bookmark selection ( #3021 )
2019-05-30 17:01:51 -05:00
Sawyer Blatz
9e0e5d95d9
For #2931 : Show browser snackbar above quick action sheet
2019-05-30 14:52:09 -07:00
Sawyer Blatz
5e0771a6f0
For #2327 : Fix early return from displayAccountError
2019-05-30 13:45:56 -07:00
Sawyer Blatz
7fff475fd8
For #1679 : Pause media playback when backgrounded
2019-05-30 13:06:37 -07:00
Jeff Boek
0054e017ea
For #255 - Moves all deletion operations to the same coroutine
2019-05-30 13:05:51 -07:00
Christian Sadilek
0b00c0ce9b
No issue: ClipboardProvider no longer needs to be added/removed based on input
2019-05-30 13:03:50 -07:00
Emily Kager
3685b05586
For #3011 - Size EngineView for Custom Tab Fixed Toolbar
2019-05-30 12:40:54 -07:00
Emily Kager
c027feecd0
For #3011 - Size EngineView for Custom Tab Fixed Toolbar
2019-05-30 12:40:54 -07:00
Sawyer Blatz
b8c04e02e9
For #2327 : Fixes nits
2019-05-30 11:45:39 -07:00
Sawyer Blatz
fe50e88fc8
For #2327 : Adds error state syncing
2019-05-30 11:45:39 -07:00
Emily Kager
caa36c31cd
For #2979 - Prevent double navigation to Create Collection Fragment
2019-05-30 10:58:56 -07:00
Grisha Kruglov
5f42a65c2a
No issue: improve allowUndo
...
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on
New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
2019-05-30 10:48:59 -07:00
Emily Kager
3560e1793c
For #2980 - Pop to home if no session exists in Browser Fragment
2019-05-30 09:05:10 -07:00
Emily Kager
c589e4d4c3
For #2938 - Remove save to collection from PB browsing menu
2019-05-30 08:42:20 -07:00
Emily Kager
e61cebf38d
No issue: Check search engine icon exists before setting drawable
2019-05-30 08:33:30 -07:00
Denys M
8bed44819d
Fixes #2254/#2709. Observe browser sessions changes on HomeFragment
.
2019-05-29 15:13:15 -07:00
Jeff Boek
6527e05405
For #2738 - Re-throws exceptions to send better data into the crash reporters
2019-05-29 13:33:36 -07:00
Emily Kager
f142be8c92
Refactor new param to startInEditMode
2019-05-29 12:27:48 -07:00
Emily Kager
d6c1f65d72
Start MotionLayout animation to end while navigating to search fragment
2019-05-29 12:27:48 -07:00
Emily Kager
8181705b58
Init Toolbar in edit mode so we don't see the flash
2019-05-29 12:27:48 -07:00
ekager
dee3c059dc
Adds Shared Transition between Home and Search
2019-05-29 12:27:48 -07:00
Jeff Boek
3920cda693
For #2419 - Adds a deletion state to the history component
2019-05-29 12:20:19 -07:00
Denys M
39df4c8522
For #747 . Improve HistoryFragment
readability.
2019-05-29 10:21:48 -07:00
Denys M
13f144f212
For #747 . Fix coroutines leaks in HistoryFragment
.
2019-05-29 10:21:48 -07:00
Jonathan Almeida
b05e9ab14b
Closes #2968 : Specify the activity name in the share item
2019-05-29 13:12:46 -04:00
Grisha Kruglov
70453ef2d5
No issue: increase likelyhood of notification showing up as 'heads-up'
2019-05-29 09:52:35 -07:00
Grisha Kruglov
fda0f1de97
No issue: sync and refresh device state on foreground
2019-05-29 09:52:35 -07:00
Emily Kager
039990f608
For #2972 - Call session feature back press before custom tab back press
2019-05-29 09:40:52 -07:00
Grisha Kruglov
9e7269214c
Closes #2835 : Do not assume bookmarks fragment is attached while processing operations
...
This is mostly necessary when we're running stuff in a coroutine, so the patch likely goes
overboard a bit with the nullability checks... but it shouldn't hurt.
2019-05-29 09:19:03 -07:00
Sawyer Blatz
6a53127ef9
For #2948 : Adds menu button add tab to collection
2019-05-29 09:08:11 -07:00
Sawyer Blatz
3fd831cc4d
Fixes #2942 : Updates strings for l10n ( #2950 )
2019-05-29 10:47:19 -05:00
Emily Kager
1ef85433b4
For #2891 - Make checkbox invisible so text isn't cut off
2019-05-28 20:57:02 -07:00
Emily Kager
6290d7b890
For #2110 - Pressing back on external link should close the tab
2019-05-28 17:55:17 -07:00
Emily Kager
cae95c0ee1
For #2952 - Delete All Tabs should run on Main Thread
2019-05-28 16:25:39 -07:00
Arturo Mejia
b2e27d26dc
Closes #2903 : Fixed crash when trying to rate the app on a devices without
...
the play store app.
2019-05-28 15:14:56 -07:00
Jonathan Almeida
540b0939d2
Closes #2878 : Cleanup with card-like styling
2019-05-28 15:11:41 -07:00
Arturo Mejia
b5d1d04d88
Closes #2900 : Fix crash when trying to show site info panel with
...
a null session.
2019-05-28 15:05:49 -07:00
Jonathan Almeida
3da6cfd98a
For #2886 : Fix sending multiple tabs to another device ( #2923 )
...
* For #2886 : Fix sending multiple tabs to another device
* Update share methods to use new API
2019-05-28 15:05:16 -07:00
Arturo Mejia
ba6bb916e4
Closes #2789 : Custom tabs is not covering the full screen size.
2019-05-28 15:01:18 -07:00
Emily Kager
bfc0fa36b1
For #2133 - Add destructive text color to delete history button
2019-05-28 14:59:21 -07:00
Emily Kager
506f332b85
For #2919 - Invoke Pending Delete Jobs in onPause
2019-05-28 14:59:05 -07:00
Emily Kager
a6a72885d2
For #2898 - Adds Deselect All in Collection Creation Select Tabs Step
2019-05-28 14:58:16 -07:00
Emily Kager
e0ceb195ff
For #2337 - Open Report Site in Browser from Custom Tab
2019-05-28 14:56:01 -07:00
Emily Kager
7d65e21b83
For #2941 - Creates delete dialog style
2019-05-28 13:41:38 -07:00
Emily Kager
250548a72f
For #2823 - Invoke pending jobs with context on switch to private mode
2019-05-28 12:48:02 -07:00
Jonathan Almeida
06bf7a4da7
For #2890 : Sending tab from another device shows empty title
2019-05-27 16:39:56 -04:00
Jonathan Almeida
d825011fc0
Fixes #2872 : Send tab notification never dismisses ( #2889 )
2019-05-27 19:31:59 +02:00
Harsh Shandilya
7d9c8726c5
treewide: Resolve compilation warnings ( #2859 )
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-05-27 19:04:17 +02:00
Jonathan Almeida
db2eba9762
For #2876 : Fix crash on sync now button clicked
2019-05-27 12:38:11 -04:00
Jeff Boek
d24aa8a772
For #927 - Adds build type to glean to report the channel
2019-05-24 17:43:24 -07:00
Sawyer Blatz
9aa4f48e77
For #1190 : Adds additional telemetry for FxA login
2019-05-24 17:39:19 -07:00
Sawyer Blatz
62bed0cd06
For #1190 : Adds telemetry for FxA login
2019-05-24 17:39:19 -07:00
Emily Kager
2ad6875f09
No issue: Correct material dependency and anchor snackbar above toolbar
2019-05-24 17:38:20 -07:00
Jeff Boek
e3031378bc
For #225 - Address small nits, changes default color of ic_delete
2019-05-24 17:16:03 -07:00
Jeff Boek
0cbaeaffdc
For #225 - Properly delete collections
2019-05-24 17:16:03 -07:00
Jeff Boek
51451ff002
For #225 - Deletes data on button press
2019-05-24 17:16:03 -07:00
Jeff Boek
3cf91fc303
For #225 - Adds button to delete browsing data
2019-05-24 17:16:03 -07:00
Jeff Boek
072ef5785d
For #225 -Adds checkbox listener to data items
2019-05-24 17:16:03 -07:00
Jeff Boek
e9c7943fe8
For #225 - Adds icons for list items
2019-05-24 17:16:03 -07:00
Jeff Boek
3006b21508
For #225 - Adds list items for delete browsing data
2019-05-24 17:16:03 -07:00
Jeff Boek
182bbdf359
For #225 - Adds delete browsing data fragment
2019-05-24 17:16:03 -07:00
Emily Kager
01c9317be0
For #2843 - Improve Collections UI and UX ( #2851 )
2019-05-24 17:06:17 -07:00
Jonathan Almeida
1de2e58644
No issue: Add device name to account page
2019-05-24 15:29:34 -07:00
Tiger Oakes
207a8d6772
Use a ListAdapter for SessionControl
2019-05-24 13:13:52 -07:00
Jonathan Almeida
2fd91daa5b
No issue: Fix NotificationManager icon color
2019-05-24 11:32:55 -07:00
Sawyer Blatz
36f4b97712
For #658 : Adds your rights page link
2019-05-24 11:32:27 -07:00
Emily Kager
09588dfda6
For #2529 - Remove "Delete Collection" button from private browsing
2019-05-24 10:53:15 -07:00
Emily Kager
4e13de3ffd
No issue: Register observers with owner view
2019-05-24 10:53:05 -07:00
Emily Kager
a676e964b5
For #966 - Preserve CustomTab history when opening in browser
2019-05-24 10:50:20 -07:00
Sawyer Blatz
549292d06e
For #2732 : Removes view model usage from collection creation
2019-05-24 10:40:32 -07:00