Jonathan Almeida
591d6744df
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796 : Additional fixes for intermittent failing test
...
Fixes for TrackingProtectionExceptionsInteractorTest to remove the lamba
mocking and test actual BrowserState changes instead (where possible).
3 years ago
MickeyMoz
d643af098a
[fenix] Update Android Components version to 93.0.20210816143131.
3 years ago
Arturo Mejia
93f23aa750
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 integrate view binding.
3 years ago
Arturo Mejia
2e60b8d80a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 fix ui tests
3 years ago
Gabriel Luong
2d6dcb814c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add a back navigation to the Global Quick Settings from the Tracking Protection dialog
3 years ago
Arturo Mejia
39dc0701a8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Improve quick setting dialogs navigation
3 years ago
Gabriel Luong
c9575d0d62
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove tracking protection overlay CFR
3 years ago
Gabriel Luong
609acda69c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Use the new "Details" text for navigating to ETP details
3 years ago
Arturo Mejia
ab1e4228c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add connection sub-menu.
3 years ago
Gabriel Luong
7d8ca1ec98
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add favicon to website info view
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Gabriel Luong
66192cc136
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add right arrowheader to tracking protection navigators
3 years ago
Gabriel Luong
9bb39fe7b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Handle toggling tracking protection in quick settings
3 years ago
Gabriel Luong
23d57b151f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add navigation from quick settings to tracking protection panel
3 years ago
Gabriel Luong
70d55f4746
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove the tracking protection indicator
3 years ago
Mozilla L10n Automation Bot
0196a85e19
[fenix] Import l10n.
3 years ago
Jonathan Almeida
8c5bccf445
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20853 : Fix intermittent failing test in HomeFragmentStoreTest
3 years ago
Jonathan Almeida
b9c243c0ec
[fenix] Update TabSessionState.createdAt for inactive tabs debugging
3 years ago
Arturo Mejia
d735df1dd6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 separate learn more string
3 years ago
Sebastian Kaspari
7e548348e3
[fenix] Android Autofill: Use AppCompat theme for UnlockActivity.
3 years ago
Arturo Mejia
3dc3db856c
[fenix] Remove duplicated line in TabsSettingsFragment
3 years ago
Sebastian Kaspari
eb35f06802
[fenix] Use theming in debug screen.
3 years ago
Mickey Moz
3a8940d933
[fenix] Update Android Components version to 93.0.20210815143147. ( https://github.com/mozilla-mobile/fenix/pull/20859 )
3 years ago
MickeyMoz
094c8b5da8
[fenix] Update Android Components version to 93.0.20210814143348.
3 years ago
Jonathan Almeida
632311b1ea
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/15168 : Remove intermittent failing test in ToolbarViewTest
...
This test seems to be hacking at the binding between Fenix and the
BrowserToolbar to simulate toolbar events passing to the Fenix
interactor.
This is rather clumsy test that relies on the magic working of mockk
instead of following a general unit testing strategy that would commonly
require the class to be re-written to allow for better testing instead.
It is far safer to remove this test since we are not guaranteeing
anything in it and instead we see intermittent failures that make us
lose more time.
So therefore.. 🔥
3 years ago
Jonathan Almeida
d32727eff9
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796 : Fix intermittent test failure in TrackingProtectionExceptionsInteractorTest
3 years ago
Jonathan Almeida
14735a61ae
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20795 : Speculative fix for intermittent test failures in HomeFragmentTest
...
The expectation is that replacing `return` with `answers` will compute
the return value for the extension function again in order to avoid the
error, "no answer found for: Settings".
3 years ago
Jonathan Almeida
a590fd2b74
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20797 : Fix intermittent test failures in ShortcutsSuggestionProviderTest
3 years ago
Jonathan Almeida
9b20f9c1c0
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20792 : Fix intermittent test failures in QuickSettingsFragmentReducerTest
3 years ago
Mickey Moz
2722a662de
[fenix] Update Android Components version to 93.0.20210813143343. ( https://github.com/mozilla-mobile/fenix/pull/20839 )
...
Co-authored-by: Ryan VanderMeulen <ryanvm@gmail.com>
3 years ago
Aaron Train
f2fe9ae61d
[fenix] Filter out test target packages in Flank-x86 ( https://github.com/mozilla-mobile/fenix/pull/20841 )
...
* Filter out test target packages in Flank-x86
* Ignore verifyRunBlockingAndStrictModeSuppresionCount
3 years ago
Ben Hearsum
b498187399
[fenix] Ship nightlies to Google Play twice a day
...
This was moved to once per day in https://bugzilla.mozilla.org/show_bug.cgi?id=1628413 when Google Play reviews were very slow. That hasn't been a problem for awhile, and the less frequent nightlies are causing delays getting new Android Components bumps shipped out.
3 years ago
Michael Comella
fce543516e
[fenix] No issue: move kotlin-allopen outside appVariants loop.
...
The kotlin-allopen plugin could be getting applied for each variant we
have in the app. With the changed code, it will only get applied once.
3 years ago
Elise Richards
cc2f37b040
[fenix] Use header20 style on collections to match other home items. Add margin above collections. ( https://github.com/mozilla-mobile/fenix/pull/20633 )
3 years ago
Jonathan Almeida
00cb0c74f3
[fenix] Update the description for an inactive tabs string
3 years ago
MickeyMoz
043cf59211
[fenix] Update Android Components version to 93.0.20210812143121.
3 years ago
Steven Knipe
982dc4410f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4134 Add Forward Back Reload to Toolbar on Tablets
3 years ago
codrut.topliceanu
4082b5eb90
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20098 : Allow PB PiP video screenshots
...
...when `Allow screenshots in private browsing` is enabled
3 years ago
Rohan Maity
620d034134
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20596 remove perf.startup probes
3 years ago
MickeyMoz
a174504f33
[fenix] Update Android Components version to 93.0.20210811143137.
3 years ago
Arturo Mejia
d4a2d1ac83
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 add screen for opting out of experiments
3 years ago
Arturo Mejia
be0f7d9dcc
[fenix] Disable intermittent tests.
3 years ago
Arturo Mejia
8ff9adb54e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20672 crash when attempting to disconnect from Mozilla account
3 years ago
codrut.topliceanu
f4f6b18cbe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in history screens
3 years ago
MickeyMoz
c0e20cf63d
[fenix] Update Android Components version to 92.0.20210809190134.
3 years ago
codrut.topliceanu
c441adb0d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in collections
3 years ago
Arturo Mejia
12541dfb2a
[fenix] Set version to 93.0.0
3 years ago
Ben Hearsum
dea42546cf
[fenix] Backout mergify changes for bustage
3 years ago
Ben Hearsum
366a3da875
[fenix] Add a default to task-priority to fix issues when forks are named differently
3 years ago
Vitaly V. Pinchuk
21fedbf45f
[fenix] Dismisses search dialog if active in (RecentTabsHeaderViewHolder, RecentBookmarksViewHolderTest) and adapts test for the changes.
3 years ago
Michael Comella
b8f673380f
[fenix] No issue: remove unnecessary robolectric annotations.
...
Theoretically, this should marginally decrease the duration of our unit
test suite. In my testing, for 1 iteration each (i.e. noise is very
possible), the duration changed from 9m 32s to 8m 21s – a 71s
improvement.
---
To identify tests that were running with robolectric that didn't need to
be, I removed the @RunWith(FenixRobo... from all relevant files:
sed -i '' "/@RunWith(FenixRobolectric/d" app/src/test/**/*.kt
I ran the tests and discovered which ones failed from the Classes tab of
the index.html test result file. Something like:
tests = document.querySelectorAll('table')[3].querySelectorAll('tr');
failureElements = tests.querySelectorAll('.failures');
// TODO: extract the test names
Then I copied these results to a text file and compared them to all the
files that had robolectric test runners to figure out which ones still
pass:
comm -1 -2 failures.txt changed_files.txt > robolectric_not_needed.txt
And undid the changes to the failing files:
for i in $(cat robolectric_not_needed.txt); do git checkout $i; done
Then I removed the import statements on those files:
for i in $(cut changed_files.txt); do sed -i '' "/import.*RunWith/d" $i; done
for i in $(cat changed_files.txt); do sed -i '' "/import.*RobolectricTestRunner/d" $i; done
3 years ago