04a35c81b8
Closes #22083 - Match history groups to history pages by all items within the group
...
When deciding if we should include a history group within the "page of
history" results on the History View UI, we used to look at the most
recent timestamp of the metadata items within the group, and see if that
falls within the range of the timestamps of the history page, +/- some
buffer.
This assumes that each metadata entry will have a corresponding history
item. However, that's not true - when restarting the app, the selected
tab will be restored, and when opening History View right after we'll
record some metadata for it. However, we won't record a history visit
during the app restore for the selected tab.
That's all correct, but the assumption around group matching to history is now incorrect.
This patch changes the logic to instead look at every item within the
group, and see if any of them match the time window of the current
history page. This has a side-effect of also displaying search groups
multiple times on diffenent pages of history, if it makes sense to do so chronologically.
I think that's fine, it reflects reality at least (e.g. items within the
group may have been visited at very different points in time).
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
347f82f2f5
For #21313 : Renew metrics for December - never expire updates ( #21788 )
...
* For #21313 : Renew metrics for December - never expire updates
* For #21313 : data review
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
d943be0e53
For #22034 : Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
a4bcecf8c5
Update Android Components version to 95.0.20211026143215.
...
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
44666ca2ca
For #21776 - Call chain on collection type may be simplified
3 years ago
100547130e
For #21776 - Add package path to TabGroupViewHolder
3 years ago
b04bf99b7d
For #21776 - Remove unused symbols
3 years ago
b54698a3f2
For #21776 - Class member can have 'private' visibility
3 years ago
3115f1343f
For #21776 - Replace Java static method with Kotlin analog
3 years ago
660300f770
For #21776 - Replace 'isEmpty' with 'ifEmpty'
3 years ago
603ba63962
For #21776 - 'protected' visibility is effectively 'private' in a final class
3 years ago
da395d1038
For #21776 - Local 'var' is never modified and can be declared as 'val'
3 years ago
5afe393b8f
For #21776 - Remove unused imports
3 years ago
76c746b982
For #21776 - Remove unnecessary type argument
3 years ago
272d31b2b4
For #21776 - Remove unnecessary parentheses from function call with lambda
3 years ago
6d1d4bea93
For #21776 - Remove redundant qualifier name
3 years ago
1039a92281
For #21776 - Remove reductant SAM constructor
3 years ago
ed48dc934a
For #21776 - Remove reductant 'suspend' modifier from SecurePrefsTelemetry
3 years ago
d854c282da
For #21776 - Remove val from constructor parameter that are never used as a property
3 years ago
bba787e87e
For #21732 - Adds inactive tabs survey on disable + telemetry
3 years ago
6d62aed35f
For #21933 - Refresh history items everytime the fragment is opened
3 years ago
c9e769544f
Import l10n.
3 years ago
d67c23511d
Update Android Components version to 95.0.20211025134949.
3 years ago
7666f0e4c2
No issue: Replace TabsTray.Tab with TabSessionState
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
b2a7877c83
No issue: Disable FenixSnackbarDelegateTest intermittents
3 years ago
c1780cf332
For #21025 : Set long term business-critical metrics as non-expiring ( #21038 )
...
* Set long term business-critical metrics as non-expiring.
* Remove quotes around "never"
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
ffddd53607
Update Jetpack Compose to 1.0.4 and Kotlin to 1.5.31
3 years ago
bfee2ef0a6
No issue: Update ui-test slackBlocks
...
Stage a failed test
fix: commit href
fix: test source href
fix: obj ref fix
fix: remove staged test
3 years ago
6149f9faf8
Use identifiers instead of hard coded strings
3 years ago
d3651eb0fc
For #21747 re-enable start on homepage UI test and refactoring work
3 years ago
b10835992d
For #21754 re-enable general settings UI test and refactoring work
3 years ago
4c343b8b3a
For #21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test
3 years ago
367c5f42d8
No issue: Add external load flag
3 years ago
170fa9705e
Update Kotlin and Jetpack Compose versions.
3 years ago
52facc9723
For #21628 : catch ComposeNotIdleException
3 years ago
8ed9944921
Ignore github-release events in Taskcluster
...
There are no more known use cases for watching them now that we use Ship It for releases, and they sometimes cause issues such as https://github.com/mozilla-mobile/fenix/issues/20815 .
3 years ago
ee8c4de62d
For #21986 Confirmation when people set tabs to auto-close
...
For #22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
1a7b486808
Issue #21714 : Login button visibility fix on saved logins page
3 years ago
e0bf4f31fa
For #21771 - Show url when recent tab's title is not available
...
This is the same previously used approach and the same used for tabs tray.
3 years ago
df2652f9b5
Import l10n.
3 years ago
19594def90
Update Android Components version to 95.0.20211024143057.
3 years ago
a8f42cd363
Import l10n.
3 years ago
10e1718180
Update Android Components version to 95.0.20211022190114.
3 years ago
9e1f596c1e
Import l10n.
3 years ago
ec1a25dfcf
For #21921 - post: switch generic marker skip to BaseBrowserFragment.
...
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
3 years ago
788eb2c5de
For #21921 : add duration for some BrowserFragment lifecycle markers.
...
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
3 years ago
3a3c39406a
For #21921 : add durations for some HomeFragment lifecycle markers.
3 years ago
f65ea1e972
For #21921 : add and register MarkersFragmentLifecycleCallbacks.
3 years ago
99533626f1
For #21921 : rename MarkersLifecycleCallbacks to ...ActivityLifecycle...
...
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
3 years ago
623914bd89
For #22054 : add marker for root view layout/measure.
...
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.
Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
3 years ago
Grisha Kruglov
Elise Richards
Arturo Mejia
MickeyMoz
Gabriel Luong
codrut.topliceanu
Mugurell
Mozilla L10n Automation Bot
Jonathan Almeida
Jonathan Almeida
Michael Droettboom
Sebastian Kaspari
Aaron Train
AndiAJ
Roger Yang
Oana Horvath
Ben Hearsum
Mayank Agarwal
Michael Comella