mcarare
85d00ac291
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16426 : Allow multiselect title to be selected by a11y services.
4 years ago
mozilla-l10n-automation-bot
c32bbcc3e8
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16447 )
4 years ago
Christian Sadilek
70852916d6
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16430 : ExternalAppBrowserActivity should not handle incoming intents
4 years ago
mozilla-l10n-automation-bot
3ab61bec1b
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16441 )
4 years ago
Mihai Adrian Carare
489e8cc970
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15764 - Update Tabs summary description. ( https://github.com/mozilla-mobile/fenix/pull/16428 )
4 years ago
Christian Sadilek
0ccff38ebc
[fenix] Update Android Components version to 66.0.20201106143126 ( https://github.com/mozilla-mobile/fenix/pull/16439 )
4 years ago
Oana Horvath
2748519959
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15847 : use Espresso's RecyclerView scrollTo action
4 years ago
Mozilla L10n Automation Bot
77cfcd82c3
[fenix] Import l10n.
4 years ago
Christian Sadilek
80e9e1fa8e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16327 : Refactor MenuPresenter to use browser store
4 years ago
Arturo Mejia
8cc09b5785
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/15934 fix ConcurrentModificationException
...
on WifiConnectionMonitor
4 years ago
Sebastian Kaspari
84770f1f64
[fenix] Fix GeckoProvider for beta and release variant.
4 years ago
rxu
3ec2a3d971
[fenix] Add mozcn safebrowsing
4 years ago
Michael Comella
c481d0504b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 - review: set LazyMonitored to private.
4 years ago
Michael Comella
17b32070dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : add component init count to StartupExcessiveResourceUseTest.
4 years ago
Michael Comella
7ac4b40fa8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : remove redundant lazy wrapper from storage APIs.
...
They're currently lazy { lazy { value } }. Accessing `lazy.value`
directly allows us to make it lazy { value }. This should be more
performant and prevents us from double-counting these components.
4 years ago
Michael Comella
9e8fd7c6f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : LazyMonitored implement Lazy + update built-in API use.
...
By having LazyMonitored implement Lazy, we can continue to pass these
values directly into the ac APIs that require Lazy references. For some
reason, implementing `Lazy.value` can replace `operator fun getValue`
required for delegates.
4 years ago
Michael Comella
3879697c06
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : replace lazy with lazyMonitored in component groups.
...
By component groups, I mean I applied this to any class with the
class kdoc, "Component group for...".
There are a few instances of lazy we had to keep using the old API to
avoid having to update constructor arguments.
4 years ago
Michael Comella
07e69195f2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : add LazyMonitored and tests.
4 years ago
mozilla-l10n-automation-bot
83cf8baedf
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16380 )
4 years ago
Kate Glazko
88375a2294
[fenix] For https://github.com/mozilla-mobile/fenix/issues/352 : Delete a download
4 years ago
ekager
5344dceead
[fenix] No issue: Update stable androidx and material versions
4 years ago
Mugurell
f3d5862668
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6521 - Remove auto sigin onboarding card ( https://github.com/mozilla-mobile/fenix/pull/16315 )
...
With the Fennec -> Fenix migration complete there is no other Mozilla
application that would serve as a custom account provider hence the automatic
signin would not be possible.
Make this more obvious by commenting out the code that would trigger an
onboarding banner for it but keep the code in the app for when https://github.com/mozilla-mobile/fenix/issues/15694 would add
to Fenix the ability to serve as a custom account provider.
4 years ago
Mugurell
0a8d8cfbf0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16323 - Use 10dp corner radius for the selected outer border of a grid item ( https://github.com/mozilla-mobile/fenix/pull/16364 )
...
This would ensure the corners of the inner and outer borders are aligned, with
no empty gap between them.
4 years ago
Mugurell
2f04b48e7c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14980 - Effectively disable tabs tray STATE_HALF_EXPANDED ( https://github.com/mozilla-mobile/fenix/pull/16052 )
...
STATE_HALF_EXPANDED cannot be disabled while also keeping fitToContents = true
based on which the tabs tray layout is currently set.
To work around this we'll set a a minuscule height for the tab tray when in
this state and then immediately advance to STATE_HIDDEN so to make it
imperceptible to the users.
Since I couldn't write unit tests because of InflateExceptions in Robolectric
I've written UI tests to protect against regressions.
4 years ago
Mihai Adrian Carare
647117ca54
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13172 - Tab swipe order follows text direction from oldest to newest ( https://github.com/mozilla-mobile/fenix/pull/16178 )
4 years ago
Rafał Opiłowski
7dab7b2d53
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12971 - Show collection saved snackbar above FAB ( https://github.com/mozilla-mobile/fenix/pull/16311 )
4 years ago
Oana Horvath
24d2b31b74
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15847 - Disables verifyAboutFirefoxPreview UI test ( https://github.com/mozilla-mobile/fenix/pull/16346 )
4 years ago
Mugurell
5311233fae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16339 - Initialize FxaAccountManager with also a CrashReporter ( https://github.com/mozilla-mobile/fenix/pull/16340 )
4 years ago
Sebastian Kaspari
03343e86ed
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16256 : Introduce build flag for "Mozilla Online" variant.
...
This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).
At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
4 years ago
Oana Horvath
4fe05cc97c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13446 UI tests: wait for historyList to exist
4 years ago
Mozilla L10n Automation Bot
9007d8d33e
[fenix] Import l10n.
4 years ago
Gabriel Luong
ba18f60d64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14636 - Update preference section headers to use correct color, spacing and rulers ( https://github.com/mozilla-mobile/fenix/pull/16332 )
4 years ago
Michael Comella
b495ffee53
[fenix] No issue - review: clarify thread safety of suppressionCount.
4 years ago
Michael Comella
6fed5f3177
[fenix] No issue: make StrictMode suppression count thread safe.
4 years ago
Christian Sadilek
ecd79c4d6e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 : Switch to consumeFlow and add tests
4 years ago
ekager
5991d0996e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 - Remove activityViewModels workarounds
4 years ago
MarcLeclair
78850c7e3d
[fenix] 15278 detekt rule runblocking ( https://github.com/mozilla-mobile/fenix/pull/15942 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added CoroutineManager to count runBlocking calls
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added actual detekt rule for runblocking and its config to the yaml
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added unit test for RunblockingCounter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test
* Lint fix
* For https://github.com/mozilla-mobile/fenix/issues/15278 : made runblocking a Long to prevent overflow
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed MozRunblocking name, description and moved RunBlockingCounter to perf package
* For https://github.com/mozilla-mobile/fenix/issues/15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added setup for unit test, since it failed without restting counter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Fixed naming for RunBlocking lint check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : removed changes made to test to use runBlockingIncrement
* For https://github.com/mozilla-mobile/fenix/issues/15728 : added test exclusion for runBlocking check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : changed null check and added Synchronized to count setter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fix for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added StartupExcessiveResourceUseTest to CODEOWNERS
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Moved increment function to extension function and fixed indentation
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added tests for Atomic Integer extension and nit fix
4 years ago
ekager
e564dda990
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Remove unneeded delay in BrowserAnimator
4 years ago
Roger Yang
f60df4a976
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16268 - Allowing multiple task while sharing ( https://github.com/mozilla-mobile/fenix/pull/16275 )
4 years ago
Jocelyne Abi Haidar
3139337d7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15931 : Sort Downloads from newest to oldest ( https://github.com/mozilla-mobile/fenix/pull/15939 )
4 years ago
mcarare
e682cb55cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15430 : Fix StrictMode death on opening app from widget voice search.
4 years ago
mcarare
c66ab231d5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15430 : Fix StrictMode death on opening app from widget text search.
4 years ago
mcarare
87ce122d03
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14552 : Do not display back button when there is no tab history.
4 years ago
Mozilla L10n Automation Bot
a94eca1063
[fenix] Import l10n.
4 years ago
Mugurell
b85522198c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15963 - Increase touch target for the close button in the tabs tray grid layout
...
We need to ensure it has at least 48dp while also not appearing too big.
4 years ago
Mugurell
58a22af103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15757 - Avoid the double spacing issues for grid items in tabs tray
...
Items should have a 16dp all around padding.
Have them have a 8dp padding that will add to 16 when placed together.
Have the parent have another 8dp that will add to 16 for when items are placed
to the edge of the available screen.
4 years ago
Mugurell
0dd114beb8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15968 - Show a border for the selected tab in the grid based tabs tray
...
The border for the grid item will now be updated in the same method that
updates the background for the list item.
4 years ago
Mugurell
f90db55a2f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15756 - Add a play/pause button in the tabs tray grid layout
...
Moved the previous layout in a new, bigger FrameLayout that would serve as a
buffer space for the play/pause button to be translated to the exterior.
Otherwise the button would be clipped.
4 years ago
Gabriel Luong
949d66da5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9548 - Ability to rename top sites ( https://github.com/mozilla-mobile/fenix/pull/16285 )
...
* Ability to rename top sites, closes https://github.com/mozilla-mobile/fenix/issues/9548
* Highlight the "Remove" top site action as destructive
With more menu items in the top site contextual menu, it makes sense to differentiate
* Added test for the top site renaming action
* Fixed lint check (wildcard imports, blank spaces)
* Applied suggestions from code review
* Apply suggestions from code review
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
* Implemented dialog click listener with manual dismiss/cancel
Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
4 years ago
ekager
c4d7e19da6
[fenix] No issue: Make sure we are cleaning up test coroutines
4 years ago