Commit Graph

12 Commits (7ac4b40fa802424cb1f2e96169fbc06eb415e255)

Author SHA1 Message Date
MarcLeclair 78850c7e3d [fenix] 15278 detekt rule runblocking (https://github.com/mozilla-mobile/fenix/pull/15942)
* For https://github.com/mozilla-mobile/fenix/issues/15278: added CoroutineManager to count runBlocking calls

* For https://github.com/mozilla-mobile/fenix/issues/15278: Added actual detekt rule for runblocking and its config to the yaml

* For https://github.com/mozilla-mobile/fenix/issues/15278: Added unit test for RunblockingCounter

* For https://github.com/mozilla-mobile/fenix/issues/15278: renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test

* Lint fix

* For https://github.com/mozilla-mobile/fenix/issues/15278: made runblocking a Long to prevent overflow

* For https://github.com/mozilla-mobile/fenix/issues/15278: fixed MozRunblocking name, description and moved RunBlockingCounter to perf package

* For https://github.com/mozilla-mobile/fenix/issues/15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck

* For https://github.com/mozilla-mobile/fenix/issues/15278: Added setup for unit test, since it failed without restting counter

* For https://github.com/mozilla-mobile/fenix/issues/15278: Fixed naming for RunBlocking lint check

* For https://github.com/mozilla-mobile/fenix/issues/15278: removed changes made to test to use runBlockingIncrement

* For https://github.com/mozilla-mobile/fenix/issues/15728: added test exclusion for runBlocking check

* For https://github.com/mozilla-mobile/fenix/issues/15278: changed null check and added Synchronized to count setter

* For https://github.com/mozilla-mobile/fenix/issues/15278: fix for nits

* For https://github.com/mozilla-mobile/fenix/issues/15278: added StartupExcessiveResourceUseTest to CODEOWNERS

* For https://github.com/mozilla-mobile/fenix/issues/15278: fixed for nits

* For https://github.com/mozilla-mobile/fenix/issues/15278: Moved increment function to extension function and fixed indentation

* For https://github.com/mozilla-mobile/fenix/issues/15278: Added tests for Atomic Integer extension and nit fix
4 years ago
Michael Comella 4e7658e479 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - post: ignore new StrictMode rule in tests. 4 years ago
Michael Comella 19904397b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add MozillaStrictModeSuppression detekt check. 4 years ago
Michael Comella e1ffe1108f [fenix] No issue: replace LintUnitTestRunner with detekt implementation.
This should be more performant and easier to maintain.
4 years ago
Kainalu Hagiwara e17c4e5f90 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13424 - Fix detekt config and warnings. 4 years ago
Tiger Oakes 233708b122 [fenix] Update LongParameterList baseline 4 years ago
liuche 8932298651 [fenix] CI for PR https://github.com/mozilla-mobile/fenix/pull/9705 (https://github.com/mozilla-mobile/fenix/pull/12748)
* https://github.com/mozilla-mobile/fenix/issues/3880. Update detekt to 1.9.1

* https://github.com/mozilla-mobile/fenix/issues/3880. Use `AbsentOrWrongFileLicense` detekt rule

* https://github.com/mozilla-mobile/fenix/issues/3880. Update detekt baseline

Co-authored-by: Denys M <dector9@gmail.com>
4 years ago
Emily Kager 522aca44f4 [fenix] Upgrade to detekt 1.6.0 (https://github.com/mozilla-mobile/fenix/pull/9306)
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes https://github.com/mozilla-mobile/fenix/issues/7360.  Also use more exact test glob.

Co-authored-by: Andrew Gaul <andrew@gaul.org>
5 years ago
Will Hawkins 78e86d8f2b [fenix] No Issue: Add custom detekt rule to blacklist certain properties
Add a custom detekt rule to blacklist certain properties. This is
immediately useful for making sure that developers do not configure
runtime behavior using the `BuildConfig.DEBUG` property but it is
useful in a wider context.
5 years ago
Jeff Boek 6ec0801d0c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of detekt 5 years ago
Tiger Oakes 43248d95e3 [fenix] No issue: Adds lint exception for when statement (https://github.com/mozilla-mobile/fenix/pull/3685) 5 years ago
Colin Lee c0a89dc3c1 [fenix] Make ktlint and detekt style changes 6 years ago