8f1876407b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9687 : Refactor onboarding cards to follow app architecture ( https://github.com/mozilla-mobile/fenix/pull/9743 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9687 : Refactor onboarding cards to follow app architecture
* For https://github.com/mozilla-mobile/fenix/issues/9687 : Update unit test to new controller parameters
4 years ago
174af614f4
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9647 Crash when tapping settings after quickly
...
enabling/disabling add-on
4 years ago
461853e252
[fenix] Fix errors in top_sites_count metric
...
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.
[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
4 years ago
ff708e4ff1
[fenix] Import l10n.
4 years ago
3647494de3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9663 : Allow more than one line for onboarding card header
4 years ago
50bb5be4db
[fenix] Import l10n.
4 years ago
4d216e26ea
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9688 : Disable ReaderViewTest for intermittent investigation in detection issues
4 years ago
47366000e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9670 : Disabled intermittent tabMediaControlButton test ( https://github.com/mozilla-mobile/fenix/pull/9679 )
...
and removed file created by mistake -e
added reason for disabled tests
4 years ago
dca4c74a30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3262 - Enable pull down to refresh in Nightly
4 years ago
09253e7566
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 - review: clarify comments in new test runner.
4 years ago
74fbc518db
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : Add LintUnitTestRunner gradle task.
...
This will prevent us from regressing on adding older versions of the
unit test runner.
4 years ago
5d2c577c64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : TestApplication -> FenixRobolectricTestApplication.
...
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
4 years ago
dff3a69dc3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : move TestApplication to the helpers package.
...
The helpers/ package is created to separate the test support code from
the code under test.
4 years ago
f11bb37121
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : replace unit test runners with FenixRobolectricTestRunner.
...
This is how we can apply the new test runner to remove duplication.
This commit was generated programmatically with the following commands:
```
// Replace test runners with new one.
find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
// Replace imports of old test runners with new one
find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
// Remove unused imports
find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```
Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
4 years ago
b401d400b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : add FenixRobolectricTestRunner.
...
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.
This class is adapted from Firefox for Fire TV:
https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
4 years ago
774a07d5f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : remove unnecessary @RunWith(Robolectric in unit tests.
...
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.
Between this change and the last one, the unit test runtime was reduced
by ~10s.
4 years ago
b9ffb3ddcc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : remove unnecessary @RunWith(AndroidJUnit4) in unit tests.
...
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
4 years ago
3489fe1e22
[fenix] No issue: re-enable libraryMenuItemsTest and backButtonTest ( https://github.com/mozilla-mobile/fenix/pull/9639 )
4 years ago
0487e0ad62
[fenix] Update Android Components version to 38.0.20200403130109.
4 years ago
caded80288
[fenix] Import l10n.
4 years ago
cb29b33e21
[fenix] No issue: add kdoc to HomeActivity.
...
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
4 years ago
9e5e780a9a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9128 & https://github.com/mozilla-mobile/fenix/issues/9222 & https://github.com/mozilla-mobile/fenix/issues/9499 : Refactors snackbar creation and fixes placement ( https://github.com/mozilla-mobile/fenix/pull/9628 )
4 years ago
b2d81076f9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7978 - Put views above button in scrollView ( https://github.com/mozilla-mobile/fenix/pull/8819 )
4 years ago
e754578cef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6174 - Add telemetry for WebExtensions ( https://github.com/mozilla-mobile/fenix/pull/8318 )
4 years ago
2f02eeb972
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9604 : Swap and adjust margin with padding to avoid text being cut ( https://github.com/mozilla-mobile/fenix/pull/9617 )
4 years ago
006e32c454
[fenix] No issue: remove unused FirefoxTestRunner.
...
It would be used for on device tests but it doesn't seem to hooked up
currently.
4 years ago
f7f452367d
[fenix] Import l10n.
4 years ago
7e54f731db
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9422 : Nit: Fix xml indenting
4 years ago
34394af021
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9422 : Align widget text to viewStart to support RTL layouts
4 years ago
2ec2ee395b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/768 : Add first time PWA dialog ( https://github.com/mozilla-mobile/fenix/pull/9308 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
548a18ba32
[fenix] Use same configuration for "forPerformanceTest" builds like we do for "fennec" flavor builds.
4 years ago
a96fa3b790
[fenix] Prevent favicons from flashing when items are selected in History ( https://github.com/mozilla-mobile/fenix/pull/9233 )
4 years ago
66d28a700c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating ( https://github.com/mozilla-mobile/fenix/pull/9353 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating
* For https://github.com/mozilla-mobile/fenix/issues/9336 Update unit test to check for navigateSafe
4 years ago
d6fe360148
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9423 : Align preference title and summary to viewStart ( https://github.com/mozilla-mobile/fenix/pull/9426 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9423 : Align preference title and summary to viewStart
* Update checkbox_left_preference_etp.xml
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
4 years ago
8224f61cb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9533 - Switch to using enum for Library Item Selected Telemetry
4 years ago
4b91238222
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9553 : Only update account UI state once when creating SettingsFragment
4 years ago
ea9add8d2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8125 - Send top sites count with metrics ping
4 years ago
ef2d26efee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9365 : Partially reverse menu items order when using top toolbar
4 years ago
011b4f7fbd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9365 : Update naming to reflect history item
4 years ago
67bf4073ad
[fenix] NoIssueFixMetropolisAccountPref
4 years ago
eb99ae1fef
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9598 & https://github.com/mozilla-mobile/fenix/issues/8697 : Fixes force expand crash ( https://github.com/mozilla-mobile/fenix/pull/9599 )
4 years ago
7b333febc0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9549 - Scrolling to top sites now includes header.
4 years ago
c0b09436d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9574 : Remove category layout from LeakCanary SwitchPreference
4 years ago
d1d0a09f21
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9564 : Fixes cut off strings in ETP panel
4 years ago
d80763ee11
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9109 - remove the sync error highlight from three-dot menu
4 years ago
1ccd93d99a
[fenix] For 3687 Use Metropolis Font for Header
4 years ago
9cb58154bb
[fenix] Import l10n.
4 years ago
12e3619a2e
[fenix] Make sure reconnect item is displayed in HomeMenu in case of account problems
...
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
4 years ago
8d1befd34c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9561 : Fix initialization order in HomeMenu
...
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.
Simply re-ordering initialization fixes the problem.
4 years ago
12237fdca1
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8520 : Polish Add-on manager UIs
4 years ago
Mihai Adrian
Arturo Mejia
Michael Droettboom
Mozilla L10n Automation Bot
mcarare
Aaron Train
Oana Horvath
Mugurell
Michael Comella
MickeyMoz
Sawyer Blatz
Codrut Topliceanu
Gabriel Luong
Emily Kager
Sebastian Kaspari
David Walsh
Grisha Kruglov
Kate Glazko
codrut.topliceanu
Mihai Branescu
Kate Glazko