Commit Graph

285 Commits (74c1cc82fb4975f63c20a718f09367149bcc3c70)

Author SHA1 Message Date
Gabriel Luong 4f76699ab7 For #10342 - Part 6: Show "Delete from history" instead of "Remove" for top frecent sites in the top site menu 4 years ago
Gabriel Luong 1f564c10ce For #10342 - Part 4: Use the TopSitesFeature in the HomeFragment for displaying top sites 4 years ago
Gabriel Luong 46aa6a003e For #10342 - Part 3: Use the TopSitesUseCase in the BrowserToolbarController and SessionControlController
Use the provided `addPinnedSites` and `removeTopSites` use cases in `BrowserToolbarController` and `SessionControlController`.
4 years ago
Gabriel Luong 04dcfa5cab
For #8312 - Show Top Sites in a ViewPager (#14116) 4 years ago
Elise Richards 433a20db50
Update string for FxA signin onboarding header (#14132) 4 years ago
ekager 655d2b8a88 For #12377 - Choice to hide no collections placeholder from homescreen 4 years ago
Elise Richards feae7fff2f
FNX-14498 ⁃ For #9487: improve fxa onboarding manual sign in card (#13317)
* Replace strings, add learn more, hook up button

* Constrain learn more and icon to the text

* View holder tests

* Lint

* Update homescreen ui test
4 years ago
Mugurell b993b94be1 For #12857 - Use Collection title when sharing tabs collection
Avoided passing the subject for sharing a collection of tabs in the ShareData
object since ShareData is part of a web standard.
4 years ago
ekager a1a839f237 For #13221 - Update global ETP to include PBM 4 years ago
Mihai Eduard Badea 58e24b81aa For issue #12400 - Refresh swiped collection tab view
Item is now refreshed by calling notifyDataSetChanged on the adapter when the last tab from the collection has been swiped away and the user cancels the deletion by pressing the cancel button from the dialog.
Also added a "wasSwiped" flag to onCollectionRemoveTab in order to check if the tab was deleted from a swipe action and not by pressing the "X" button.
4 years ago
ekager 6cdf304d10 No issue: Adds sameAs function for TopSiteList AdapterItem 4 years ago
ekager 3d3153039c For #11690 - Add contentsSameAs to avoid rebind of items in SessionControlAdapter 4 years ago
Tiger Oakes d8ff6179fe
For #7992: Use favicon style from AC (#12608) 4 years ago
Tiger Oakes 61d6b333de Update LongParameterList baseline 4 years ago
ekager e5e62fa79a For #6846: Added quick actions for nav bar in home 4 years ago
ekager 46511d6f8e For #10163 - Adds tab multiselect mode 4 years ago
Tiger Oakes 8f5a37733d
Create ToolbarPosition enum (#12747) 4 years ago
Tiger Oakes c08d375c18
Move settings in components (#12675) 4 years ago
mcarare 8826f99ef7 For #9722: Refactor onboarding buttons with text.
Add title and description to button text, remove extra Textviews.
4 years ago
Kainalu Hagiwara 02a929a926 No issue - Suppress new warnings from detekt update 4 years ago
Tiger Oakes eed20b43b9
Test session control controller (#12652) 4 years ago
Tiger Oakes d4bb432e24
Add helper for underlining text (#12520) 4 years ago
Tiger Oakes d0e9f1f165
Update Kotlin dependency (#10806) 4 years ago
Tiger Oakes e9fb1a61c7
Test viewholders in home.sessioncontrol (#12524) 4 years ago
Tiger Oakes 67ce5ad5d9
Add tests for onboarding viewholders (#11522) 4 years ago
Tiger Oakes 8e8e5aea36
Extract radio group logic into helper (#11493) 4 years ago
ValentinTimisica e39d5b6de7 For #11763: Shows confirmation dialog when deleting last tab from collection 4 years ago
mcarare 94273bc274 For #12125: Handle visibility updates for add to collection button. 4 years ago
Elise Richards 665fb8d60c
#10824: Onboarding telemetry (#11867)
* Onboarding events and tracking

* Rename metrics for consistency

* Add reference to PR for the data review

* Add default values to onboarding events
4 years ago
mcarare a056e86e4f For #8080: Dismiss menu when swiping away from its anchor. 4 years ago
Jeff Boek 2861421312 For #11112 - Adds save tabs to collection button to the no collections message 4 years ago
MarcLeclair b52091ed34
For #11660: added prefetch for topsites and update in onCreateView() (#11668)
* For #11660:added prefetch for topsites

TopSites will be prefetched with observerOnce (wrapper around observerForever).
Also, the SessionControlView.update() is called right away instead of waiting from consumeFrom
in the HomeFragment.onCreateView() which will allow the UI to render all at once on its first
perform traversal

* Removed the submitList(null) since it retriggered a drawing on lower end device
4 years ago
liuche 35fa445165
Issue #11112 - Update empty collections string + tests. (#11538) 4 years ago
mcarare 4b04a140fc For #11229: Update etp strict option title content description. 4 years ago
mcarare a0d9189321 For #11229: Update onboarding ETP copy. 4 years ago
Jeff Boek 52c2fdb310
Remove tab tray feature flag (#11176)
* For #11171 - Removes feature flag for the new tab tray

* For #11171 - Removes all tab references from homeFragment

* For #11171 - Fixes unit tests

* For #11171 - Gets UI tests to compile and HomeScreenTest to pass

* For #11171 - Fixes `deleteMultipleSelectionTest`

* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`

* For #11171 - Fixes `openHistoryInPrivateTabTest`

* For #11171 - Fixes `openHistoryInNewTabTest`

* For #11171 - Fixes `openNewPrivateTabTest`

* For #11171 - Fixes tabbedBrowsingTests

* For #11171 - Fixes SettingsPrivacyTest

* For #11171 - Fixes TopSitesTest

* For #11171 - Fixes lint errors

* Ignore
4 years ago
mcarare c4f7a32eae For #9583: Increase touch targets for onboarding elements. 4 years ago
Jeff Boek 8662164b8a
Refactors the TabTrayDialogFragment to ditch that weird interactor (#11061)
* For #11056 - Removes unused argument when navigating to the collection creation fragment

* For #11056 - Moved the collection creation navigation logic to the TabTrayDialogFragment

* For #11056 - Moves navigating to the share screen from home/browser to the TabTrayDialogFragment

* For #11056 - We moved tab selection logic from home/browser to the tab tray dialog

* For #11056 - Moved new tab tapped logic to the tab tray dialog fragment

* For #11056 - Removes all interactor logic for the TabTrayDialogFragment

* For #11056 - Migrates the presentation / navigation around the TabTrayDialog to the androidx navigation library
4 years ago
Jeff Boek 3946ec11de
Polish homescreen (#11065)
* For #10505 - Adjusts wordmark margins

* For #10505 - Removes topsite header, fixes collections header size and removes divider

* For #10505 - Restyle the top site items on the homescreen
4 years ago
David Walsh 4fdac4d608
For 10734 - Open tab tray when collection is opened from Home (#10751)
* For 10734 - Open tab tray when collection is opened from Home

* Update to work with tab tray drawer
4 years ago
Sawyer Blatz 7067e5c000
For #8125: Add default top site telemetry (#10752) 4 years ago
Christian Sadilek 4e25f41a41 For #1824: Prevent extremely long URLs from locking up HomeFragment 4 years ago
Tiger Oakes f7b4f1c959
Cache findViewById calls in session control (#10575) 4 years ago
Jeff Boek 58ca5d0e3a For #10341 - Always show collections placeholder with new tab tray enabled 4 years ago
Mihai Branescu 6f97e75579 For #8643 and #7606 - illustrations are now connected to their radio buttons 4 years ago
Mihai Branescu cde31cf785 For #8643 and #7606 - Changed toolbar picker illustrations according to theme 4 years ago
Mihai Branescu 16b7a9399b For #8643 and #7606 - Changed theme picker illustrations according to theme 4 years ago
Mihai Branescu 4c0af91b7b For #8643 and #7606 - Changed tint for onboarding icons 4 years ago
Jeff Boek a8a90bd4d6
For #1063: Put tab tray behind a feature flag and hidden pref (#10313)
* For #1063 - Adds feature flag and pref for new tab tray

* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For #1063 - Creates hidden preference to use new tab tray

* For #1063 - Hides tabs on home screen when setting is enabled

* For #1063 - Navigate to new tab tray from browser with setting enabled

* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For #1063 - Fixes crash when toggling to private mode on the home screen

* For #1063 - combines both settings. Cleans up lint errors
4 years ago
mcarare 1aa473b112 For #9913, For #9914: Remove touch delegate when button is disabled. 4 years ago
mcarare e830da59b7 For #10180: Remove touch delegate when button is disabled.
Also refactored multiple if's into a when.
4 years ago
mcarare 2edd4b39a4 For #9913, For #9914: Remove button when disabling it.
Setting visibility to GONE allows clicks to parent view in that space.
4 years ago
mcarare cc67de29bf For #10091 Also disable play/pause button when hiding it. 4 years ago
ValentinTimisica da3fca0f29 Fixes #10109: Adds content description for browse privately card content 4 years ago
ekager c4e83367f6 For #6832 - Fix various fragment not attached to a context crashes 4 years ago
Sawyer Blatz dce16964c0
For #9208: Adds in-product prompt to homescreen (#9836) 4 years ago
ekager 66d9a24b28 Closes #9928 - Updates private browsing text description 4 years ago
ekager 5d51c4f059 Don't use ProcessLifecycleOwner for view-tied consume 4 years ago
Sawyer Blatz 8185ba793e
For #9857: Create button style (#9858)
* For #9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
4 years ago
Jeff Boek 4cbb9aebaf
Cleans up nav_graph.xml (#9829)
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
4 years ago
ekager b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 4 years ago
mcarare 177baf58a8 For #9798: Disable buttons on hiding and enable on showing.
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
4 years ago
Mihai Adrian dfded8e69c
For #9687: Refactor onboarding cards to follow app architecture (#9743)
* For #9687: Refactor onboarding cards to follow app architecture

* For #9687: Update unit test to new controller parameters
4 years ago
Sawyer Blatz e3ed7ed268
Issue #9128 & #9222 & #9499: Refactors snackbar creation and fixes placement (#9628) 4 years ago
codrut.topliceanu 3d1d146c94 For #9549 - Scrolling to top sites now includes header. 4 years ago
David Walsh d989616f62 Add top sites heading to home screen 4 years ago
mcarare ab78951146 For #9496: Vertically align collection name and icons to collection icon 4 years ago
Sebastian Kaspari 02aabea14a Update to new feature-media API. 4 years ago
mcarare 18533d3434 For #8764: Use list component for items in collections 4 years ago
mcarare 62bbbd9e37 For #8764: Update collection design, including list elements 4 years ago
Sebastian Kaspari 0f0d56e60a Issue #5208: Use new tab/collection restore API. 4 years ago
mcarare 756b1fbadd For #9140: Remove drawable from title in empty state panes 4 years ago
codrut.topliceanu 030bd38631 For #8561 - Scroll to topSites on app cold start 4 years ago
David Walsh fc67747409 Show the collections header when there are no collections 4 years ago
mcarare 320fc4e4ae For #8788 Use Flexbox instead of Grid manager for top sites 4 years ago
mcarare f9e85e78af For #6607 Update button theming in no tab pane 4 years ago
mcarare cfe4f11864 For #6607 Update button theming in no tab pane 4 years ago
Harshal Lele e318cd7d15 fix #8135 - remove getColorFromAttr 4 years ago
Michael Comella db57e123b9 For #8797: Do not allow nested scrolling on top sites. 4 years ago
mcarare 2bb2061931 For #8766: Show collections only when tabs are open or collection exists 4 years ago
Sawyer Blatz e96732604b For #167: Improves home to browser animation 4 years ago
Michael Comella 9ed43b60b6 For #7781: instrument visual completeness for top sites.
Eyeballing my output in *Debug builds on my P2, this adds approximately 115ms
or slightly less from first frame drawn to visually complete time.
4 years ago
mcarare df80a5240b For #6607 Add button to no tab content pane 4 years ago
Mihai Adrian 9612c3f16d
For #8540: Fix ETP options not being correctly applied (#8688) 4 years ago
mcarare 314bee2abd For #8627: Add proper content description to ETP card clickable areas 4 years ago
mcarare cc47bc4e1e For #8655: Show top site context menu below top site title 4 years ago
mcarare a5ac7304bb For #8523: Also disable radio buttons clickable area when ETP is off 4 years ago
ekager b72550c28a For #8126 - Adds default top sites 4 years ago
mcarare 372b1e7f0e For #6980: Update Private browsing card.
Added test to description.
Added link to settings.
Updated unit tests.
4 years ago
mcarare 1168fbd638 For #8299: Select current ETP policy set on card creation 4 years ago
mcarare 3ea5b08135 For #8190: Add animation to ETP policy selection 4 years ago
mcarare 5bd5f81559 For #6980: Add onboarding Toolbar position picker card 4 years ago
Tiger Oakes 5faa22d611
Use createBlendModeColorFilterCompat (#8129) 4 years ago
mcarare 9d993cae92 For #8146: Extend radio buttons clickable area to title and description 4 years ago
Mohammaduvez 00d7f4c91c
Fixes #5711 Added tint to onboarding icons (#8093)
* Added tint to onboarding icons and udpated finish button tint

* Replaced tint parameter with onboarding_card_icon color in setOnboardingIcon
4 years ago
Marc Leclair 72007590f7 #7700 squash commit and fixing toolbar to switxh to top with coordinatorlayout 4 years ago
Grisha Kruglov 3f9ed2992c Bump to a-s 0.50.0 4 years ago
Mihai Adrian 4eb71ce235
For #6980: Update ETP onboarding card (#7958) 4 years ago
ValentinTimisica 0a76fdaa58 For #7289: Adds telemetry for selecting dark theme 4 years ago
Mihai Adrian 24396d174f
For #6980: Add What's new card (#7952) 4 years ago