Michael Comella
169071ac61
No issue: extract startMetricsIfEnabled function.
...
This refactor, done entirely by IDE, is a no-op clean-up of this file.
4 years ago
Jeff Boek
11e2137fab
For #12806 - Adds unit tests to cover `ToolbarView.update()` ( #12807 )
4 years ago
Jonathan Almeida
99354174a9
For #12797 : Use measured height/width for loading a thumbnail
...
Using `onNextLayout` has the side-effect of showing the thumbnail with
the tab.id from a recycled view.
The root cause of needing that call is to retrieve the measured
height/width from the view first before requesting. A simpler solution
to avoid the complexity is to retrieve these values from the dimen
resources.
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
4 years ago
Sawyer Blatz
b483067bd9
For #12461 : Update content description for tabs tray open tab count
4 years ago
Sebastian Kaspari
96121a79fa
Issue #7877 : Add SearchActionProvider for faster responses that mirror entered text.
4 years ago
Tiger Oakes
c08d375c18
Move settings in components ( #12675 )
4 years ago
Mihai Eduard Badea
c3041bcb64
For issue #12387 - Display tab tray using .show
...
Replaced the global navigation action used for displaying the tab tray with the .show() function.
4 years ago
mcarare
8826f99ef7
For #9722 : Refactor onboarding buttons with text.
...
Add title and description to button text, remove extra Textviews.
4 years ago
Tiger Oakes
0abb2c4f8b
Add tests for web push integration
4 years ago
Johan Lorenzo
7e7d69cb8e
Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta ( #12225 )
4 years ago
Tiger Oakes
e809df0858
Pass settings and metrics to CFR
4 years ago
Kainalu Hagiwara
02a929a926
No issue - Suppress new warnings from detekt update
4 years ago
Sawyer Blatz
284ec7b58f
For #12461 : Add tab count to tab tray
4 years ago
Tiger Oakes
f73411b924
For #5499 - Unify CFR drawables and dimens ( #12749 )
4 years ago
Kainalu Hagiwara
cd2532349d
For #12551 - Implement swipe to delete for bookmarks.
4 years ago
Kainalu Hagiwara
313e5abf6a
Rename tab_tray_background.xml
4 years ago
Michael Comella
fcb84d940a
No issue: correct position of StartupTimeline; add warning.
4 years ago
Sawyer Blatz
445593b719
For #10466 : Add search privately to top of list ( #12744 )
4 years ago
Tiger Oakes
51937e73fc
Closes #10924 - Cleanup SavedLoginsAuthFragment ( #10930 )
4 years ago
Sawyer Blatz
afbb039a08
For #11851 : Close tab tray when last tab closed ( #12615 )
4 years ago
ekager
1dc0ad39f4
For #10784 - Fixes memory leak in BrowserAnimator
4 years ago
Sawyer Blatz
f0c6bc0226
For #12735 : Fixes issue with tab deletion undo ( #12737 )
4 years ago
Hakkı Kaan Çalışkan
3f25a28cf7
For #12554 : Helper class for password reveal on logins
4 years ago
Christian Sadilek
16b6776938
Update Android Components to 51.0.20200717190031
4 years ago
Tiger Oakes
499f185fc0
Fix lint issues ( #12683 )
4 years ago
Tiger Oakes
13949d6968
Test migration classes ( #12677 )
4 years ago
Tiger Oakes
67fda80453
Add tests for login exceptions ( #12681 )
4 years ago
Mihai Adrian Carare
9c1b586e45
For #7966 : Update toolbar content description. ( #12667 )
4 years ago
Mihai-Eduard Badea
1823fdb66d
For issue #9949 - Bookmarks/History deletion inconsistencies ( #12630 )
...
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.
- Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648 .
Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
4 years ago
Tiger Oakes
eed20b43b9
Test session control controller ( #12652 )
4 years ago
Hakkı Kaan Çalışkan
aa7655f4d6
For #12509 : Set height of remove add on button to 36dp
4 years ago
ekager
455e7b8f99
Update ContextMenuUseCases to just take a store
4 years ago
ekager
e1ef5f55ec
For #12453 - Sets secure flags on private tab of tabs tray
4 years ago
ekager
e358f95eed
For #12364 - Only show PWA prompt the third time a user visits installable site
4 years ago
Tiger Oakes
ac3df6bc5e
Add tests for adapters in collections ( #12649 )
4 years ago
Elise Richards
023a4983fa
For #10173 : login duplicates and save ( #11208 )
...
* Extract controller into it's own class. Implement find dupes and filter based on username.
Create edit login controller. Add text watchers and check for duplicates.
Edit controller test
* Find duplicates and save to store
* Retrieve duplicates from AC and check list on username text changed
Move duplicates logic into the controller
* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.
* Use correct threads in controller. Enable save button when applicable.
Save enabled in datastore.
Move login data to datastore
Rebase with password error states
Update metrics to be more specific for edit
* Create logins controller for AC calls
* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.
Inflate view in edit fragment. Double layout showing up.
Edit view
Controller tests
Controller tests passing
Interactor tests
Lint and detekt cleanup
* Remove datastore and use storage controller for all logins calls to password storage.
Addressed comments
Lint
:
Rebase - 1
4 years ago
Mugurell
e1fc0cc038
Ensure logins deletion ( #12507 )
...
* For #11227 - Cleanup saved logins list when one is selected
Selecting a saved login will open a detail screen for it from where users can
change details or even delete that particular login.
After the change is made the user is brought back to the list of saved logins
where for a brief moment (< 1s) until we get a new response from
passwordsStorage.list() the user can see and even interact with the old list
of items, which may still contain the just deleted one.
To avoid users seeing obsolete logins or even interacting with them (selecting
a previosuly deleted item will result in a crash) we will clean the list of
logins just before the selected login is opened in the detailed view.
When returning for a brief moment the users may see the "loading" UX until
passwordsStorage.list() returns the up-to-date list of logins to display.
* For #11227 - Refactor SavedLoginsView to be closer to MVI
- Interactors should only get passed other Interactors or Controllers as
dependencies to which they should delegate user actions.
- Controllers should hold most of the business logic and get passed all final
dependencies they need to do their job.
4 years ago
Tiger Oakes
2d066d77ad
Add tests for sync, wifi, and push ( #12581 )
4 years ago
Tiger Oakes
2291fb07aa
For #12565 : Add Locale settings tests & use activity ( #12579 )
4 years ago
jhugman
3373f8b987
For #12600 - remove AddonInstalled event when the permission dialog is shown ( #12601 ) r=csadilek,sblatz
4 years ago
Mihai Branescu
9373e7fcf4
For #12201 - forced callbacks to be on the main thread ( #12543 )
4 years ago
Elise Richards
4fe1fb8f4a
No issue: Delete unnecessary to-dos ( #12603 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
Kainalu Hagiwara
b867e0de45
Update TabTrayViewHolder with A-C thumbnail changes.
4 years ago
Roger Yang
7923255fda
For #12118 : Add isSubframeRequest parameter for app links
4 years ago
Christian Sadilek
a0d9cdc450
For #12248 : Webcompat reporter not active in Nightly
4 years ago
jhugman
fb1d7e12e6
For #11704 Add leanplum attributes for tracking protection ( #11965 ) r=sblatz
...
* For 11657: add LP attribute for tracking protection
* For #11704 : added tracking_protection_enabled attribute
* Added docs for the new attributes, linking to data-review to the mma.md
* Rename null to none when no ETP is enabled
4 years ago
James Hugman
798c1bf743
Address review comments
4 years ago
James Hugman
22689a9ff5
Remove need to specify component names for new intents
4 years ago
James Hugman
98a33ea82b
Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is
4 years ago
James Hugman
1629878a66
Add install_search_widget
4 years ago
James Hugman
8130aaa2cc
Add deep links for settings and home screens
4 years ago
Mugurell
d449184faa
For #12544 - Prevent search engines mixup
...
Stricter synchronization by always using the same "loadedSearchEngines"
variable.
With "loadedSearchEngines" calling "refreshAsync()" we also get the fallback
engines to contain reddit and youtube (which are programatically added) and
also now we properly remember and display the engines added by user.
4 years ago
Tiger Oakes
6be39aebde
Add tests for StartupReportFullyDrawn ( #12560 )
4 years ago
Tiger Oakes
d4bb432e24
Add helper for underlining text ( #12520 )
4 years ago
Tiger Oakes
a0491b702e
Fix nav graph and theme tests ( #12567 )
4 years ago
Tiger Oakes
d0e9f1f165
Update Kotlin dependency ( #10806 )
4 years ago
mcarare
800702149b
For #12503 : Open addon permissions link in app.
4 years ago
ekager
9ed85510ae
For #7094 - Adds save login exceptions
4 years ago
Tiger Oakes
69020a1f26
For #12457 - Add MockK matcher for nav directions ( #12262 )
4 years ago
Tiger Oakes
1ff64cab67
Add tests for search ( #12437 )
4 years ago
Tiger Oakes
e9fb1a61c7
Test viewholders in home.sessioncontrol ( #12524 )
4 years ago
Hakkı Kaan Çalışkan
f424656575
For #12107 : Follow ux mock on Settings --> Account screen
4 years ago
Sawyer Blatz
98ad7ace49
For #10466 : Put call & email at top of context list
4 years ago
Mugurell
ea10d2a872
For #11875 - Prevent mixup of region / locale based search engines
...
We have two search engine types:
- one based on MLS reported region,
- one based only on Locale.
There are multiple steps involved in returning the default search engine for
example and though at each step we could verify if a certain operation is
completed we are still exposed to concurrency issues.
Simplest and most effective way to make sure the MLS engines do not mix with
Locale based engines is to use the same type of engines for the entire duration
of the app. At the next cold start we'll verify again which engines to use.
Using the Locale based engines (fallbacks) is expected to only happen once, at
the first run of the application after being installed.
4 years ago
jhugman
9df13ae121
For #11655 : add leanplum event for installing an addon ( #12136 ) r=elise
...
* For #11655 : add leanplum event for installing an addon
* Add link to data-review request in PR
* Addressed CI comments
4 years ago
Grisha Kruglov
31248b835c
Synced Tabs: make sure to stop 'loading' when we encounter an error
4 years ago
ekager
0add94e353
For #11324 - Adds trash icon to swipe to delete
4 years ago
Nazım Can Altınova
7319f77114
Add profiler markers for HomeActivity.load and DefaultTabTrayController.onNewTabTapped
4 years ago
Sawyer Blatz
5d9fdd6266
Update app/src/main/java/org/mozilla/fenix/HomeActivity.kt
...
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
4 years ago
Sawyer Blatz
bab0f9d95b
No issue: Update AC version
4 years ago
Grisha Kruglov
806f6031ae
For #12433 - Allow synced tabs pull-to-refresh for non-critical account errors
4 years ago
ekager
ad265be672
For #11303 - Change copy login origin to open in browser
4 years ago
Tiger Oakes
c99a8f5cfa
Fixes #9832 - Change targetSdkVersion to Android 10 ( #11014 )
4 years ago
Sebastian Kaspari
a2a7b11425
Issue #12311 : BrowserToolbarController: Stop SessionFeature and release session from EngineView.
4 years ago
David Walsh
85cebf8796
For 11889 - Fix snackbar for collection creation in browser fragment
4 years ago
ekager
38657bbfc6
For #11431 - Scroll to restored tab in tab tray
4 years ago
Christian Sadilek
216396d979
For #12353 : URL copied to clipboard should not be extension/reader URL
4 years ago
Tiger Oakes
9ae1aa6f16
Add tests for exceptions
4 years ago
MickeyMoz
236b981881
Update Android Components version to 50.0.20200708130551.
4 years ago
Tiger Oakes
67ce5ad5d9
Add tests for onboarding viewholders ( #11522 )
4 years ago
Tiger Oakes
720a590902
Add tests for browser helper classes ( #12370 )
4 years ago
Christian Sadilek
27c608d956
Update built-in extensions for new AC/GV API
...
New API (installBuiltIn/ensureBuiltin) requires
- Gecko IDs and new permissions
- Extension will only be re-installed if it has a new version
This includes a gradle task to automatically generate a
new version in manifest.json for every build so we don't
forget to update the version and end up with changes that
are never applied.
4 years ago
ekager
bceb07a05b
For #12312 - Disable settings that navigate while authenticating
4 years ago
Michael Comella
3e617245b5
For #12345 : catch SecurityException when calling reportFullyDrawn.
...
That's amazing! I've got the same combination on my luggage.
4 years ago
Tiger Oakes
65637e9e2b
Use A-C version of Resources.getSpanned ( #12358 )
4 years ago
Mihai Eduard Badea
eeb8719fa1
For issue #12126 - Tab counter consumeFrom update
...
Added a direct call to the updateTabCounter method to account for changes made to the BrowserState while the tabCounter view is not visible.
4 years ago
Tiger Oakes
8e8e5aea36
Extract radio group logic into helper ( #11493 )
4 years ago
ValentinTimisica
e39d5b6de7
For #11763 : Shows confirmation dialog when deleting last tab from collection
4 years ago
ValentinTimisica
c3acde438a
For #11889 : Changes collection creation confirmation snackbar strings
...
Also I changed the adding tabs to collection confirmation string from
tabtray to take into account the number of tabs.
Example: 1 tab-"Tab saved!"; multiple tabs-"Tabs saved!"
4 years ago
Tiger Oakes
1ab5fe3eb9
Add method to test fragments in roboletric ( #12261 )
4 years ago
Hakkı Kaan Çalışkan
331090d1e6
For #12007 : Fix add search engine items using wrap content for height
4 years ago
MickeyMoz
da39a7e671
Update Android Components version to 49.0.20200705130154.
4 years ago
mcarare
94273bc274
For #12125 : Handle visibility updates for add to collection button.
4 years ago
Tiger Oakes
fd18687ac9
Switch to any calls
4 years ago
Tiger Oakes
41452e945b
Move SearchProviderModel extension to class
4 years ago
Mugurell
0fb6bbc175
For #10401 - Hide Shortcuts if just one search engine is installed
...
Otherwise, the Shortcuts option which allows to choose with what search engines
to search would be redundant.
4 years ago
Sebastian Kaspari
388c144a62
SearchFragmentStore: Remove Session reference from state and read values from BrowserStore.
4 years ago
ekager
f863c341e8
Updates AC to 49.0.20200702190156 and fixes breaking changes
4 years ago
ekager
8533d96ee2
For #11320 - Expose login autofill setting to beta dimension
4 years ago
liuche
6ec0aeb843
Issue #12207 - Update "new nightly" link to point to org.mozilla.fenix ( #12209 )
4 years ago
Sawyer Blatz
8583cac8f8
Revert "For #11183 : Redirect user to homescreen after widget added"
...
This reverts commit a8ed913654
.
4 years ago
Sawyer Blatz
3cbab45566
For #12157 : Don't show two search widget dialogs
4 years ago
Mihai Adrian Carare
daecbd348b
For #11996 : Open all links from add-on details in Fenix. ( #12080 )
...
* For #11996 : Open add-on homepage link in Fenix.
* For #11996 : Open add-on details links in Fenix.
4 years ago
Sawyer Blatz
306505fee0
No issue: Remove feature flag for tips ( #12172 )
4 years ago
Johan Lorenzo
4bc1cb94c5
Bug 1649400 - part 1: ship org.mozilla.fenix as a nightly product ( #12127 )
4 years ago
Jeff Boek
fb4822498f
For #12081 - Properly installs searchengines when MLS completes
4 years ago
ekager
70f90e71e8
For #11991 - Show tab count during onboarding
4 years ago
Tiger Oakes
6bde0378a2
Add tests for StrictModeManager ( #12013 )
4 years ago
ekager
60069395eb
Update AC to 48.0.20200627130132 and fix breaking changes
4 years ago
Tiger Oakes
ed334788e8
For #11903 : Enforce private theme in custom tabs
4 years ago
Jeff Boek
b1a8c0f483
For #9935 - Use the searchengine deferred
4 years ago
Jeff Boek
40977a93a0
For #9935 - Fallback region selection on first load
4 years ago
Michael Comella
5ef6b49aa1
For #8795 : remove redundant ConstraintLayout around BrowserToolbar. ( #12014 )
...
This is functionally equivalent to the code before this patch but should
be slightly more performant in theory because ConstraintLayout is
expensive to inflate.
The elevation and layoutParams set dynamically appeared to have no effect
with the wrapping view but broke the view when used by itself so I had
to remove them. I also updated a few other unnecessary params.
Theoretically this may have some perf benefits but I didn't see anything
outside noise levels after I took the numbers (but I didn't try very
hard).
4 years ago
David Walsh
c4a4beb6b9
For 11468 - Show tab tray after opening links from history and bookmarks
4 years ago
Kate Glazko
2ac8496315
For #12025 : Set Search Shortcuts Off By Default
4 years ago
Jeff Boek
a18c1befd1
For #11044 - Sets the anchorView of the snackbar to be the new tab fab ( #11930 )
4 years ago
Sachin
4b9cc954fa
for #11830 added new metric for collecting startup method from all startup phases ( #11940 )
...
* for #11830 added new metric for collecting startup method
move all source startup telemetry into its own logic and added an UNKOWN state
* switched back to onNewIntent solution
* renamed the metric
4 years ago
Sawyer Blatz
61b1b5a895
No issue: update experiments when experiments updated ( #12032 )
4 years ago
Sawyer Blatz
8a08cb941e
For #11479 : Record open tabs count in metrics ping ( #12024 )
4 years ago
Jonathan Almeida
b7d989a588
Fix breaking API in WebNotificationFeature
4 years ago
Marc Leclair
ff5d00362b
Added A-C version 48.0.20200626213814
4 years ago
Sawyer Blatz
101ecfbf66
For #11273 : Add tabs tray telemetry ( #12036 )
4 years ago
Tiger Oakes
7287b5579f
Test settings about/advanced ( #12023 )
4 years ago
Tiger Oakes
4f6f0785c5
For #11943 : Fix intermittent coroutine failure ( #12027 )
4 years ago
ekager
df49db6adb
For #11294 - Enable Synced Tabs for all builds
4 years ago
Gabriel Luong
e6a56aec36
For #12026 - Update default top sites for new users ( #12028 )
4 years ago
Grisha Kruglov
f8cb1d6b48
Closes #11909 : Metrics for recording number of recently used PWAs
4 years ago
Elise Richards
eeabcb10ff
Fix illegal arguments for onboarding keys ( #12033 )
4 years ago
Tiger Oakes
bcb2ef10ac
Add tests for PhoneFeature ( #12021 )
4 years ago
MarcLeclair
f3b44c06e4
For #11841 : Removed topsite bug on private browsing ( #12020 )
4 years ago
Gabriel Luong
005ad6ff2a
Update Android Components version to 48.0.20200626130049. ( #12006 )
...
Co-authored-by: MickeyMoz <sebastian@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
4 years ago
Tiger Oakes
80de3851f3
Add tests for OnSharedPreferenceChangeListener ( #12019 )
4 years ago
ValentinTimisica
9f5c8819d3
For #11892 : Remove dynamic calls to setupNavigationToolbar
...
This is a speculative fix for 11892 crash.
The side effect is that the back button will be visible in bookmarks root.
4 years ago
Mihai Branescu
93247e0b2f
For #9425 - SearchFragment now reacts to undo operation for base engines
4 years ago
Mihai Branescu
e6e3166d2d
For #9425 - SearchFragment now reacts to undo operation for custom engines
...
When you remove a search engine from our list, an undo snackbar that outlives the fragment is shown. If you go back to the search fragment and press undo, now the shortcut list gets updated
4 years ago
Mihai Branescu
46c1c130da
For #9425 - Handle undo for custom search engines
...
On undo, get the template that the user entered for that engine and then
re-add it to the `CustomSearchEngineStore`
4 years ago
Sawyer Blatz
c5034fa770
No issue: Allow us to run experiments on nightly if needed
4 years ago
mcarare
216da0c64b
For #10285 : Add a custom TextView for links with a11y improvements.
4 years ago
Kainalu Hagiwara
b84f55c980
For #11677 - Adjust tab counter menu item order.
4 years ago
person808
ad90625b48
For #2165 - Add swipe to refresh gesture to bookmarks view.
4 years ago
Christian Sadilek
64440409b0
For #9100 : Follow-up to fix memory leak in NotificationSessionObserver
...
The observer was moved and is now bound to the activity and its
context. If the activity is re-created we leak the observer and
therefore the activity itself.
With this we make sure to stop the observer and also don't use
the activity context to begin with.
4 years ago
ekager
c77ddd8d26
For #11866 - Update back press logic for SearchFragment
4 years ago
Christian Sadilek
7be56ce4fa
For #11798 : Allow sharing of reader view pages
4 years ago
Sawyer Blatz
04aee11d82
For #9625 : Add telemetry for Tracking Protection CFR ( #11923 )
4 years ago
Elise Richards
665fb8d60c
#10824 : Onboarding telemetry ( #11867 )
...
* Onboarding events and tracking
* Rename metrics for consistency
* Add reference to PR for the data review
* Add default values to onboarding events
4 years ago
Sawyer Blatz
2d65faf232
For #11392 : Rename Installation ping to FirstSession ( #11869 )
4 years ago
ekager
d3de9e517e
Remove ThumbnailsUseCases
4 years ago
Tiger Oakes
c958cc048a
Update customtabs service
4 years ago
Sawyer Blatz
13c8abe3dc
For #11613 : Expand toolbar onUrlChanged
4 years ago
Mihai Branescu
be5213e944
For #11727 - added content description
4 years ago
Hakkı Kaan Çalışkan
9068c96ab3
don't animate unnecessarily
...
Fixes #11672 , #11727 : Empty default tab text and add padding to infinite character
Fixes #11739 : Fix flicker
Update TabCounter.kt
make lint happy
don't animate unnecessarily
don't animate unnecessarily
Fixes #11739 : Fix flicker
Update TabCounter.kt
squash commits
don't animate unnecessarily
Fixes #11672 , #11727 : Empty default tab text and add padding to infinite character
Fixes #11739 : Fix flicker
Update TabCounter.kt
make lint happy
don't animate unnecessarily
4 years ago
Hakkı Kaan Çalışkan
3dc6c438f4
Fixes #11739 : Fix flicker
4 years ago
Hakkı Kaan Çalışkan
b95804c33b
Fixes #11672 , #11727 : Empty default tab text and add padding to infinite character
4 years ago
Sawyer Blatz
a8ed913654
For #11183 : Redirect user to homescreen after widget added
...
Co-authored-by: hakkikaancaliskan <caliskanhkaan@gmail.com>
4 years ago
David Walsh
77ed670558
For #11860 - Conditionally show add to collection button on Home screen
4 years ago
Sawyer Blatz
872c179cf4
For #11825 : Removing the last pretty animation 😞
...
Goodbye, sweet summer child.
4 years ago
mcarare
a056e86e4f
For #8080 : Dismiss menu when swiping away from its anchor.
4 years ago
mcarare
b961fdcf02
For #11901 : Use safe call for collection item info.
4 years ago
Mihai Branescu
49b617c999
For #9100 - Private browsing notification fixes
...
Co-authored-by: Seef <Saif Dara>
4 years ago
Mihai Branescu
632b64971f
For #10467 - removed unused tests and resources related to blue dot notification
4 years ago
Mihai Branescu
3c2c7f705c
For #10467 - blue dot doesn't disappear on menu dismiss
4 years ago
Tiger Oakes
0b781ae3b7
Add tests for collection creation controller
4 years ago
Jeff Boek
177e7a400f
For #11406 - Scrolls to selected tab when switching modes
4 years ago
Tiger Oakes
4415702fa8
Add tests for share sheet
4 years ago
Tiger Oakes
183ba1bce0
For #11903 : fix custom tab private gradient
4 years ago
ekager
f39313d908
For #8374 - On external session removed, handle back press
4 years ago
person808
5f7e0e4dd6
Followup for #11442 - Add tab counter menu metrics to home fragment.
4 years ago
Tiger Oakes
9a8b800a76
For #8621 - fix intermittent test failures
4 years ago
Jeff Boek
621da0c4c1
For #9935 - Adds fallback searchengine provider for long MLS lookups ( #11863 )
4 years ago
mcarare
fe97dc9d2e
For #11542 : Update tabs positions in tab tray reported by screen readers
4 years ago
ekager
06e6cfa696
For #5636 - Unregisters wifiConnectedListener when setting changes, sets default blocked
4 years ago
Jeff Boek
8ce7cf59c8
For #11261 - Dismisses menu when rotating to landscape ( #11845 )
4 years ago
Jeff Boek
2861421312
For #11112 - Adds save tabs to collection button to the no collections message
4 years ago
Tiger Oakes
ccb532bb77
For #11534 - Don't check lastUsed mode for screenshots ( #11827 )
4 years ago
Jeff Boek
c7b1f215c8
No Issue - Fixes flash when toggling tab tray ( #11826 )
4 years ago
Tiger Oakes
18cc4c95c1
Add tests for ContextKt ( #11824 )
...
Migrated from an old branch by Kate
Co-authored-by: Kate Glazko <katglazko@gmail.com>
4 years ago
Hakkı Kaan Çalışkan
c8d36ddc36
For #8649 : No bookmarks here strings are close to the top
4 years ago
ekager
88765c348b
Update A-C version, add synced tabs empty state
4 years ago
mcarare
721e290734
For #10049 : Provide correct seek bar value to screen readers.
4 years ago
ValentinTimisica
c75ab3f720
For #10462 : Removes back button from bookmarks and history fragments ( #11721 )
4 years ago
ekager
635c30510d
No issue: refactor tabs tray to use interactor/controller, add tests
4 years ago
Mugurell
0ba1d266b3
For #9144 - Ignore previous Intent if activity is started from Recents
...
We'll now clearly differentiate between cold / hot starts of HomeActivity.kt.
This is needed because Android will resend the original Intent which initially
started the Activity whenever it is restarted from the Recents Screen if the
activity is already destroyed at that time. So in the event that the activity
was before started with an Intent to open a webpage for example whenever the
activity is restarted from Recents it will receive the same Intent to open a
webpage even though that Intent has already been consumed.
Activity's onCreate() will only use the intent processors when the activity is
cold started so that we'll only initially act upon Intents configured for
different behaviors inside the app.
If the activity is destroyed while in background and opened from Recents it
will not act upon the original Intent which is now resent by Android.
Activity's onNewIntent() will be called to act upon a new Intent if the
activity is hot started since we are declared as singleTask and it now has the
responsibility to delegate various intent processors to consume that Intent.
4 years ago
ValentinTimisica
0b57f5e71b
Fixes #10551 : Removes the increased touch target for learn more link
4 years ago
Mihai Eduard Badea
eb45b37207
For issue #10727 - Hide saved logins details
...
Removed the clearFlags call from the HomeActivity that was causing this issue and removed the now redundant call to update the flag from the redirectToReAuth method
4 years ago
ValentinTimisica
e9bb11e22d
Fixes #9205 : Changes add-ons and 'Open links in apps' icons from menus
4 years ago
Sachin
988513aa89
for #10568 moved awesomebar and toolbar into fragment_search ( #11744 )
4 years ago
Sachin
9269a53b21
for #11615 allowed strictMode disk read for violations made by the OS. ( #11658 )
4 years ago
Antti Vainikka
cb129231ae
Closes #11500 : Remove wrong activity title
4 years ago
mcarare
a0fe1a452a
For #11756 : Fix bottom toolbar preference reference.
4 years ago
mcarare
4bebc56c50
For #9229 : Remember options for delete browsing data.
4 years ago
MarcLeclair
b52091ed34
For #11660 : added prefetch for topsites and update in onCreateView() ( #11668 )
...
* For #11660:added prefetch for topsites
TopSites will be prefetched with observerOnce (wrapper around observerForever).
Also, the SessionControlView.update() is called right away instead of waiting from consumeFrom
in the HomeFragment.onCreateView() which will allow the UI to render all at once on its first
perform traversal
* Removed the submitList(null) since it retriggered a drawing on lower end device
4 years ago
Emily Kager
44ff29bdc0
Revert "For issue #9949 - Bookmarks/History deletion inconsistencies"
...
This reverts commit 3feab90b19
.
4 years ago
ekager
df63c5a4bc
For #11708 - Remove setMargins in CustomTabsIntegration
4 years ago
Jeff Boek
82cbafabaf
For #11625 - Fixes tab tray staying open when opening from another app ( #11740 )
4 years ago
mcarare
5f1c9449f3
For #8114 : Restore normal UI when a library fragment is detached.
4 years ago
Tiger Oakes
c503798cd6
Replace PhoneFeature.getPreferenceKey
4 years ago
Tiger Oakes
596c579bbb
Replace nullable findPreference
4 years ago
Tiger Oakes
45ef88f6b9
Replace requireNotNull(findPreference())
4 years ago
Tiger Oakes
3e03439259
Add requirePreference helper
4 years ago
codrut.topliceanu
0eb2f328dc
For #11371 - Fix for Dynamic Download Dialog
4 years ago
David Walsh
3feab90b19
For issue #9949 - Bookmarks/History deletion inconsistencies
...
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.
- Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648 .
4 years ago
Tiger Oakes
f6efb386d6
Add tests for addon details
4 years ago
Hakkı Kaan Çalışkan
8cbdce58e6
Update FxaServer.kt
4 years ago
Hakkı Kaan Çalışkan
670e03c3b2
Update app/src/main/java/org/mozilla/fenix/components/FxaServer.kt
...
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
4 years ago
Hakkı Kaan Çalışkan
bd85a9c399
remove suppress and unnecessary otherwise = private
4 years ago
Hakkı Kaan Çalışkan
87a65d2445
For #9782 : Clean up unused FeatureFlags
...
I've currently found out this ones unused.
webPushIntegration removed because looks like all fatal bugs solved as it said from note.
4 years ago
Sören Hentzschel
396cd61efa
For #9712 - show "AC: " before AC version on "About" screen
4 years ago
Sachin
36b1c710e7
for #11617 added a resetPoliciesAfter ext function for StrictMode, and replaced all existing calls to "resetAfter" with "resetPoliciesAfter" ( #11619 )
4 years ago
Tiger Oakes
d81aa62683
Fix PIP toolbar
4 years ago
Tiger Oakes
d3d5c8934f
Cleanup tests for toolbar controller
4 years ago
person808
9e3e95e351
For #11442 - Telemetry for tab counter menu.
4 years ago
Mihai Branescu
4f870e9251
For #6126 - moved the sessionObserver init to the onCreate
...
This helps because we will always need the observer to be initiated, not only when the `openToBrowser` method gets called. Example: Opening a tab from the tab tray had it's own method for opening the browser, causing this to not be called.
4 years ago
Jonathan Almeida
e6da2bd910
Fix breaking APIs in TabsAdapter and ViewHolder
4 years ago
Tiger Oakes
704fc6f983
Use updated webapphidetoolbarfeature
4 years ago
Tiger Oakes
fc96e188ab
Convert flow from AC to livedata
4 years ago
David Walsh
149efc1683
For 9640 - Focus on last selected tab in tab tray with a11y turned on ( #11487 )
4 years ago
David Walsh
8b24cdec42
For 11428 - Focus on home screen address bar when tab tray new tab is tapped ( #11429 )
4 years ago
David Walsh
063cf457ba
For #11291 - Provide New Tab button when accessibility enabled ( #11441 )
4 years ago
liuche
35fa445165
Issue #11112 - Update empty collections string + tests. ( #11538 )
4 years ago
Arturo Mejia
a36ec7279e
No issue: Decrease the frequency for checking for new supported add-ons
4 years ago
Tiger Oakes
294f29768d
Test logins settings
4 years ago
Sawyer Blatz
0a9afbed42
For #11380 : Update migration tip text
4 years ago
Sawyer Blatz
fffbadbfca
For #11118 : Add browsing history suggestion in metrics ( #11525 )
4 years ago
Sawyer Blatz
13d077eb66
For #11269 : Telemetry for new reader mode position ( #11385 )
4 years ago
Sawyer Blatz
d1cd877374
For #11118 : Add missing telemetry
4 years ago
mcarare
0ebfa4f947
For #11497 : Disable pull to refresh in error states.
4 years ago
Jeff Boek
1639b1d3a1
For #11342 - Fixes missing space for the FAB
4 years ago
Tiger Oakes
651b2831fe
Fix tests in toolbar controller
4 years ago
Sachin
cd26ba9a9c
for #11364 added a exception list for manufacturers violating strict mode policies on startup ( #11407 )
...
for #11364 changed blackList -> exceptionList, added one plus to the list
change magic strings into const Val
4 years ago
person808
d14b39a56e
For #2165 - Implement pull-to-refresh gesture to sync history.
4 years ago
mcarare
4b04a140fc
For #11229 : Update etp strict option title content description.
4 years ago
Sawyer Blatz
932a2f3703
For #11063 : Update telemetry for etp settings
4 years ago
Tiger Oakes
f0295048fa
Remove Mockito
4 years ago
Jeff Boek
cd3b6181b3
For #10374 - Adds quick contextual menu to tab switcher
...
Co-authored-by: person808 <kainaluh808@gmail.com>
4 years ago
Elise Richards
137d66a511
For 10172: Set edit text listeners ( #11196 )
...
* Set edit text listeners
* Set clearable icons and change with error states
* Clear text buttons show and hide
* Move error checks to afterTextChanged. Refactor. Remove unused color.
4 years ago
Tiger Oakes
31edbc924c
Fixes #9056 - Start Fenix activity on search in external app ( #10932 )
4 years ago
Tiger Oakes
4b064afb81
Add tests for ext package ( #11334 )
4 years ago
Christian Sadilek
d16c70d8be
Wire up UI to make add-on installation cancelable
4 years ago
ValentinTimisica
bc53296603
For #11365 : Reorganizes 'SettingsFragment' items
...
Moved all the functionality form 'DefaultBrowserSettingsFragment' to
'SettingsFragment'.
4 years ago
ekager
11697c1363
For #11390 - Removes redundant session observer init for ETP overlay
4 years ago
Sawyer Blatz
27c7ef5ad4
For #8775 : Removes feature flag for dynamic bottom toolbar
4 years ago
ValentinTimisica
f937c96c12
For #5148 : Switch to the correct tab on media notification clicked
...
Processing the intent in OpenSpecificTabIntentProcessor to be able to switch
to the tab where audio/video is playing
4 years ago
David Walsh
1356b3e426
For 11271 - Provide useful tab counter message for accessibility
4 years ago
Tiger Oakes
96d2307df0
Add tests for widget
4 years ago
ValentinTimisica
3a28704fa6
For #11132 : Replaces wrong icons from menus
4 years ago
ValentinTimisica
dc37baff0b
For #11132 : Rearranges home menu items
4 years ago
Jeff Boek
f41ca2f424
No Issue - Moves from being a tabstray observer to overriding tab use cases
4 years ago
Christian Sadilek
05496faa66
Clear speculative session on engine settings change
4 years ago
Sawyer Blatz
5445d34ac4
For #11357 : Use AppCompatResources for reader mode icon
4 years ago
Jeff Boek
4ee1cd6716
For #11361 - Nulls out tabsFeature in the correct spot
4 years ago
Jeff Boek
d8ef0722e3
For #11175 - Moves tab tray strings to be translated, fixes description of the fab string
4 years ago
ekager
6d4a673c6f
For #8967 - Expose autofill logins setting in nightly
4 years ago
Mozilla L10n Automation Bot
5373a75f57
For #10502 - Show snackbar after adding tabs to collection from tab tray
4 years ago
Grisha Kruglov
8769d98e71
Pass crashReporter instance to RustLog
4 years ago
Sachin
8fdc28010d
for #10839 added IO coroutine to check onboarding stat from sharedpref ( #11338 )
...
changed coroutine scope to fragments lifecycle
4 years ago
Jeff Boek
e4e7cc5108
For #11260 - Fixes lifecycle issues with the tabs tray
...
- Also check to make sure the fragment manager is still valid before trying to show the tabs tray
Co-authored-by: Emily Kager <emilykager@gmail.com>
4 years ago
Sawyer Blatz
e9189dc089
For #11045 : Add reader mode to urlView
4 years ago
Tiger Oakes
1a19b06227
Simplify `PhoneFeature` code ( #10810 )
4 years ago
Sachin
74948cb3f1
for #7225 , Changed strictMode thread penalty to dialog on startup and back to logs after startup is done. ( #10831 )
...
for #7225 , refactored and cleanup the branch.
for #7225 , change strict mode policy only on main process.
for #7225 , setting thread policy inside a seperate thread to keep it from getting overridden in activities.
for #7225 removed Handler().postAtFrontOfQueue as a solution due to unknown side effects. moved the enableStrictMode function to be static so we can reuse it.
for #7225 lint check
for #7225 created strict mode manager and moved enabledStrictMode function inside it.
for #7225 removed penalty death on network
for #7225 added allow disk access on thread for already existing violation
strict mode running in main process to see if it passes the gitlab check, will revert it if it doesnt
allowed diskread for super.onCreate for home activity
added comments for disk violation oncreate homeactivity
added fragment manager inside strictmode manager
allowed disk read for onboarding
allowed disk read for cachedTopSites
4 years ago
David Walsh
d33080571b
For #11267 - Announce "Your open tabs will be shown here ( #11272 )
4 years ago
mcarare
512aa46224
For #11229 : Update ETP cfr string and behaviour.
4 years ago
mcarare
91c27a023e
For #11229 : Update settings ETP copy.
4 years ago
mcarare
a0d9189321
For #11229 : Update onboarding ETP copy.
4 years ago
Jeff Boek
52c2fdb310
Remove tab tray feature flag ( #11176 )
...
* For #11171 - Removes feature flag for the new tab tray
* For #11171 - Removes all tab references from homeFragment
* For #11171 - Fixes unit tests
* For #11171 - Gets UI tests to compile and HomeScreenTest to pass
* For #11171 - Fixes `deleteMultipleSelectionTest`
* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`
* For #11171 - Fixes `openHistoryInPrivateTabTest`
* For #11171 - Fixes `openHistoryInNewTabTest`
* For #11171 - Fixes `openNewPrivateTabTest`
* For #11171 - Fixes tabbedBrowsingTests
* For #11171 - Fixes SettingsPrivacyTest
* For #11171 - Fixes TopSitesTest
* For #11171 - Fixes lint errors
* Ignore
4 years ago
mcarare
2d24369362
For #7725 : Increase info button touch target while keeping size.
...
Also removed unnecessary touch delegate.
4 years ago
person808
8c47b988b8
For #10525 - Remove tab tray item dividers.
4 years ago
Jeff Boek
bc53b94feb
For #10989 - Fixes memory leak caused by retaining the TabTrayView and TabsFeature
4 years ago
Sawyer Blatz
1be2ec2cbf
For #9488 : Init widgetExperiment after Experimenter init
4 years ago
mcarare
886c1882c5
For #11230 : Set default to false for allow screenshots in private setting
4 years ago
Dennis Schubert
e41fc7841a
Bug 1643132 - Add WebCompat Reporter feature.
4 years ago
Dennis Schubert
d046d908fc
Bug 1643132 - Remove native "Report site issue" functionality.
...
This will be replaced by the WebCompat team's system extension that ships as an android-component.
4 years ago
Sawyer Blatz
42f58a1984
For #9488 : Add experimentation support
4 years ago
ekager
54df729fb3
For #8374 - Don't recreate ExternalAppBrowserActivity or finishing activities
4 years ago
Sawyer Blatz
9302d07d13
For #11118 : Add toggle states to metrics ping
4 years ago
mcarare
5a23fb33f8
For #11182 : Fix back button text update according to save step.
4 years ago
mcarare
a910698007
For #11182 : Set click listener also to icon button.
4 years ago
Gabriel Luong
9520c9dd32
For #8920 - [Telemetry] Send add-on ids in a metrics ping
4 years ago
mcarare
29f1800021
For #11182 : Explicitly clone select tabs on updating SaveCollectionStep.
4 years ago
mcarare
68286d263a
For #11182 : Set click listener to full layout instead of just icon.
4 years ago
person808
9272026b7e
For #10193 - Remove page title when sharing links
4 years ago
Tiger Oakes
a7e74e308b
Migrate some SessionManager usage to BrowserStore ( #10789 )
4 years ago
mcarare
138c12696f
For #11153:Add FLAG_SECURE on pause and clear on resume for private session.
4 years ago
David Walsh
d862d58051
Scroll to the top of home when using the tab tray
4 years ago
mcarare
2090b11c97
For #10434 : Handle cases when proc/$pid/stat is not accessible.
4 years ago
ekager
ead3194d86
For #8759 - Allow recently used in share fragment to scroll
4 years ago
Jeff Boek
2dd0a3cb9e
Implement tab tray design improvements and fix close functionality.
4 years ago
Tiger Oakes
6317eea690
Add tests for some of collection creation
4 years ago
ValentinTimisica
591e2c9a6f
Fixes #9696 : Adds Add-ons menu item to the home menu
4 years ago
mcarare
c4f7a32eae
For #9583 : Increase touch targets for onboarding elements.
4 years ago
Tiger Oakes
50441e28f1
Tests and cleanup for tracking protection
4 years ago
ekager
9ef4d9bdae
For #10968 - Don't show ETP CFR if toolbar doesn't have window focus
4 years ago
Vishwa Patel
4da22c605a
For #10834 - Adding Sync Tabs Feature in Fenix
4 years ago
Gabriel Luong
0300f15df1
Fix crash from TabThumbnailView where drawable is null ( #11121 )
4 years ago
Gabriel Luong
60b68a265a
For #10921 - Integrate BrowserThumbnails feature into the tabs tray ( #11093 )
4 years ago
Sawyer Blatz
82facbfa00
For #1216 : Remove feature flag for voice search
4 years ago
David Walsh
84d9e5b1fb
For 11031 - Fix landscape mode for tab tray ( #11084 )
4 years ago
Jeff Boek
a6e77e3e8f
For #10848 - Fixes unit tests
4 years ago
Jeff Boek
c8e8566668
For #10848 - Fixes navigationbar colors on tab dialog fragment
4 years ago
Jeff Boek
f05890efec
For #10848 - Fixes bug where selected index wouldnt be properly calculated in private mode
4 years ago
Jeff Boek
d5c20bc0d0
For #10848 - Fixes menu background color
4 years ago
Jeff Boek
19a709a04d
For #10848 - Fixes tab tray colors
4 years ago
Jonathan Almeida
ce15763cc4
Use new AuotPushFeature.getSubscription API
4 years ago
Tiger Oakes
221792c074
Add tests for FenixOnboarding ( #11057 )
4 years ago
Gabriel Luong
63e529ac2b
Added BrowserThumbnails dependencies
4 years ago
Jeff Boek
8662164b8a
Refactors the TabTrayDialogFragment to ditch that weird interactor ( #11061 )
...
* For #11056 - Removes unused argument when navigating to the collection creation fragment
* For #11056 - Moved the collection creation navigation logic to the TabTrayDialogFragment
* For #11056 - Moves navigating to the share screen from home/browser to the TabTrayDialogFragment
* For #11056 - We moved tab selection logic from home/browser to the tab tray dialog
* For #11056 - Moved new tab tapped logic to the tab tray dialog fragment
* For #11056 - Removes all interactor logic for the TabTrayDialogFragment
* For #11056 - Migrates the presentation / navigation around the TabTrayDialog to the androidx navigation library
4 years ago
Jeff Boek
3946ec11de
Polish homescreen ( #11065 )
...
* For #10505 - Adjusts wordmark margins
* For #10505 - Removes topsite header, fixes collections header size and removes divider
* For #10505 - Restyle the top site items on the homescreen
4 years ago
ekager
20e358228e
For #11015 - Switch Default ETP Setting to Standard
4 years ago
Tiger Oakes
749c95e0f0
Add tests for ReaderModeController ( #11049 )
4 years ago
Mihai Eduard Badea
11df3aaca1
For issue#10727 - Logins auth redirect
...
Added an extension function that pops the backstack of the fragment so the user is redirected to the Logins and passwords screen.
This is done to force the user to re-authenticate if he wants to re-enter the saved logins flow.
Additionally, some UI elements are being hidden on each Fragment since they were remained visible on the Logins and passwords screen's UI.
4 years ago
Jeff Boek
58a42828a1
For #10496 - Fully expand bottom sheet when loaded
4 years ago
Jeff Boek
0566790257
For #10496 - Automatically scroll to the selected tab when you open the tab tray
4 years ago
ValentinTimisica
9f265fd62f
Fixes #10064 : Open help articles in normal tab instead of custom tab
4 years ago
David Walsh
267cf35edb
For 11001 - Show close all tabs above tab tray
4 years ago
David Walsh
a70ba76cc9
Provided unique no tabs message per mode
4 years ago
apoorv9990
3469eeed9e
removed auto play permissions while determining isVisible for WebsitePermissionsState
4 years ago
apoorv9990
97704bfdbd
Closes #9529 : changed styling for permissions dialog to set proper padding
...
- Changed the visibility check to check just for the permissions shown instead of all the permissions in WebsitePermissionsState
- Added bottom padding to the permissions root view so there is balanced padding on top and bottom
4 years ago
Sawyer Blatz
b06be1fcde
For #9488 Add telemetry for search widget CFR
4 years ago
Sawyer Blatz
94d741864e
For #9488 : Add search widget CFR
4 years ago
Sawyer Blatz
27a85d86dc
For #10803 : Hide voice icon in search if not available ( #11005 )
4 years ago
Christian Sadilek
7b5661ed10
Update Android Components version to 44.0.20200528190114
...
Pass store to download manager and service to address API changes.
4 years ago
Jonathan Almeida
63b4fcd4c4
For #11004 : Fix invisible text on migration UI
...
For some text and colors, we were using the default styling where
possible. These styles contain references that react to theme changes
like dark mode. Since the migration UI does not respect these changes,
we should not use them.
4 years ago
David Walsh
c0c895af33
For 10665 - Show the most recent tabs at the top of the tab tray ( #10687 )
4 years ago
ValentinTimisica
03284e2da0
Fixes #10674 : Add SignInView only once
4 years ago
David Walsh
4fdac4d608
For 10734 - Open tab tray when collection is opened from Home ( #10751 )
...
* For 10734 - Open tab tray when collection is opened from Home
* Update to work with tab tray drawer
4 years ago
David Walsh
ea4c342797
For #10877 - Show 'no tabs' message when no tabs are open ( #10960 )
4 years ago
Roger Yang
6cef0edd5e
Closes #10980 : Stop sending native crashes to Sentry ( #10982 )
4 years ago
ValentinTimisica
7974a5c77c
Fixes #10815 : Sort login items on initial load
4 years ago
mcarare
9ec6ebc92a
For #10969 : Fix and clarify logic for checking showing PWA dialog.
4 years ago
David Walsh
248237290e
For #10865 - Implement 3 dot menu for tab tray ( #10869 )
4 years ago
David Walsh
54cb8f0194
Remove unused import
4 years ago
David Walsh
5e4fd460f8
Remove onTabClosed from interactor
4 years ago
David Walsh
8b843ac9e5
Fix elevation for snackbar and fab
4 years ago
David Walsh
e9bcc9bb1e
Move snackbar to TabTrayDialogFragment
4 years ago
David Walsh
f653964ee1
For #10864 - Display snack bar to undo closing tabs
4 years ago
mcarare
a59917cdc0
For #9626 : Swap margin for padding and remove use of touch delegate.
...
Also remove text margin to maintain visual appearance.
4 years ago
mcarare
d706b085a9
For #9626 : Delay cloning ConstraintSet to only when needed for updating.
4 years ago
Mugurell
d0e2d02b34
For #10948 - Avoid PWA onboarding if user already has them on screen
...
It is possible that after migration users would already have Firefox PWAs on
their screen.
Since they already know about this functionality, we should not promote it to
them with the one-off `FirstTimePwaFragment`.
To query installed PWAs we'll use an API available only on Android >= 26 which
means that we will probably have half of users with PWAs still see the
onboarding but half which will not.
4 years ago
Sebastian Kaspari
21bd379438
Issue #9815 : Allow Intents to set HomeActivity.OPEN_TO_BROWSER.
4 years ago
Roger Yang
538a7917e4
Closes #10906 : Add Open in app option in custom tab ( #10929 )
4 years ago
Tiger Oakes
2397695fe5
For #10596 - Redirect moz://a URL ( #10688 )
4 years ago
Simon Chae
422cf74731
For #8319 : Integrate nest WebExtensionBrowserMenu support
4 years ago
mcarare
6e325d6242
For #6198 : Update copy and position of pair QR code scan message.
4 years ago
Sebastian Kaspari
b666fbe3fe
CrashReporter: Set release channel specific sentry project URL.
4 years ago
Mugurell
2dfd833941
For #10844 - Fennec page shortcuts will open in normal tabs
...
This comes to resolve a small regression in which they were opened in new
custom tab.
4 years ago
Grisha Kruglov
b26ac51e90
For #10494 : Process HomeMenu builder changes on the main thread
...
Problem was that we were trying to process menu changes (in response to account manager events) on some background thread as that's what account manager emits them on, so some code internally in PopupWindow's dismiss handling (i think, didn't dig very deeply here) was silently giving up and we'd get into a bad state.
The reason this seemingly only happened if you quickly opened a menu on startup is because account manager isn't initialized until sometime after the startup finished. So the trick was to open the menu (and register account manager state callbacks) before it got initialized, so that the callbacks are invoked.
This should also reproduce in other, much more obscure ways, e.g. if you open the menu right before sync is scheduled to run in the background, change FxA password on another connected client, and then eventually receive a onAuthenticationProblem callback.
4 years ago
Sawyer Blatz
7067e5c000
For #8125 : Add default top site telemetry ( #10752 )
4 years ago
sraturi
29d1893430
for #7032 add scroll listener to make the keyboard disappear on scroll.
...
touch listener was blocking the scroll
4 years ago
sraturi
4ee65755dc
for #7032 fixed issue where pressing back button exited the application
4 years ago
sraturi
2c85a62a5e
for #7032 removed recyclerview scroll listener from Awesomebarview
4 years ago
sraturi
c8ec25fde9
fixed lint issues
4 years ago
sraturi
703a8ed565
added a onTouch listener to scrollview in search fragment to make it disappear on scroll
4 years ago
Jeff Boek
601aedda46
For #10504 - Removes "old" TabTrayFragment
4 years ago
Jeff Boek
c32904a1d0
For #10504 - opens the tab tray and filters the tab based on the browser mode
4 years ago
Jeff Boek
a674c5dfe7
For #10504 - cleans up tabLayout colors
4 years ago
Jeff Boek
4e499e7a48
For #10504 - Adds tabTrayDialogInteractor to browserfragment
4 years ago
Jeff Boek
cc6a380d45
For #10504 - Show tab dialog on browserfragment
4 years ago
Jeff Boek
90cef752b0
For #10504 - Fixes up tab tray dialog styles
4 years ago
Jeff Boek
0b9484a172
For #10504 - Adds padding fto account for navigation bar in landscape
4 years ago
Jeff Boek
dd2a26fc7c
For #10504 - Added the tab tray to the TabTrayDialogFragment and wired up dismiss actions
4 years ago
Jeff Boek
34ac9df481
For 10504 - Adds dialog style and fab
4 years ago
Jeff Boek
97d66cce56
For #10504 - Creates the TabTrayDialogFragment
4 years ago
ekager
516a6fe9f7
For #6832 - Only emit session changes if fragment is attached
4 years ago
ekager
83ab7646c1
For #7602 - Integrate media fullscreen orientation feature
4 years ago
Christian Sadilek
4e25f41a41
For #1824 : Prevent extremely long URLs from locking up HomeFragment
4 years ago
codrut.topliceanu
7feae98944
For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtrusive view
...
- Renamed DownloadNotification and removed DownloadState.dismissed dependency
- Improved DynamicDownloadDialog behaviour when scrolling
- DynamicDownloadDialog remains attached to tab until dismissed
- Fixed onTryAgain not working for resumed DownloadDialogs
4 years ago
David Walsh
346b4aa3fd
For #10321 : Wire up play and pause buttons in tab tray ( #10422 )
4 years ago
Sawyer Blatz
477493e197
For #10465 : Add telemetry for voice search ( #10785 )
4 years ago
David Walsh
2795a34b0b
For 10731 - Don't show tab tray menu if there are no tabs
4 years ago
Sawyer Blatz
535e020683
For #1216 : Put voice search behind a nightly & debug flag
4 years ago
Sawyer Blatz
d33edd8841
No issue: Clean up SearchFragment a bit
4 years ago
Sawyer Blatz
011a9e7d96
For #1216 : Add voice search
4 years ago
ekager
d46369696f
For #10718 - Finish activity after removing external session
4 years ago
Tiger Oakes
cd64647a4d
For #9286 - Add isDefault to topsites
4 years ago
Juan Goncalves
ee62297b4c
For #7854 - Update the views only if the bookmark node has changed
...
As the bookmark node data is loaded from storage every time the fragment's view is created, when the user navigates to the SelectFolderFragment and returns, the bookmark is loaded once again from storage, replacing the EditText's content (title and URL) which causes the loss of user input.
Validating that the loaded bookmark is different from the one that is already referenced in the fragment avoids unnecessarily replacing the `EditText`s values.
4 years ago
Emily Kager
32e74aae61
Revert "For #6313 - On first load, hides engineView until firstContentfulPaint"
...
This reverts commit d66762910f
.
4 years ago
Emily Kager
9b16017d1d
Revert "For #7032 : Add scroll to dismiss keyboard in search fragment"
...
This reverts commit 536921bcea
.
4 years ago
ekager
d66762910f
For #6313 - On first load, hides engineView until firstContentfulPaint
4 years ago
Sachin
536921bcea
For #7032 : Add scroll to dismiss keyboard in search fragment
...
* added a onTouch listener to scrollview in search fragment to make it disappear on scroll
* fixed lint issues
4 years ago
Grisha Kruglov
d37529e416
Perf telemetry for awesomebar suggestion provider durations
...
See mozilla-mobile/android-components#6802 for details; requires that PR.
4 years ago
Mihai Branescu
750ae4a340
For #10393 and #10469 - browser fragment now observes collection changes
...
Useful for links from other apps + adding a page to multiple collections
4 years ago
Christian Sadilek
7993f1017d
Migrate feature-accounts to browser-state
4 years ago
sraturi
372bb421cc
created kotlin doc for FenixApplication
4 years ago
Simon Chae
7cc4816618
For #10398 : Add AddonInstallationDialogFragment support ( #10608 )
4 years ago
Elise Richards
edc75c3ad0
Fixes #9504 : Edit logins ( #9693 )
...
* Create editable view and fragment. Update login info page to display options menu with edit and delete.
* Create feature flag for edit. Check flag in the login detail fragment and default to just delete.
* Add three-dot kebab options menu in login detail fragment. Add title to the login item.
* Nav to and from edit view on save and back pressed.
* Save login through AC login manager. Clear text in editable field on button click.
* Match colors, fonts, dimens to UX specs for edit logins. Enable password reveal/hide and clearing text fields.
* Refactoring logins fragments. Using component Login object for consistency.
Fetch login list when saved logins are opened. Fetch login details when detail view is opened.
Revert "Fetch login list when saved logins are opened. Fetch login details when detail view is opened."
This reverts commit 44fe17166c3332b330229258b2e8982832672e3b.
* Using parcelable login and Login component class to pass ids and items between fragments
* Retrieve login from storage when viewing login details.
Rename login logic for consistency.
Ktlint cleanup
Fix nits and naming consistency.
* UX consistency for login detail and edit login pages
* Rebasing with logins sort - updating logins store.
* Rebasing with logins sort - merging fragments and controllers.
* Lint and removing unused files.
* UX cleanup.
* Update string description
4 years ago
Tiger Oakes
f7b4f1c959
Cache findViewById calls in session control ( #10575 )
4 years ago
David Walsh
86dabe09c8
For 10503 - Update save to collection flow in tab tray ( #10523 )
4 years ago
mcarare
58df38105b
For #10453 : Use TabsTray API to set divider, avoiding related crashes.
4 years ago
Sebastian Kaspari
d58c022619
Integrate activity for showing past crashes.
4 years ago
Jeff Boek
a249334976
🎲 For #10332 - Adds undo snackbar when closing tabs in the tab tray ( #10456 )
4 years ago
Simon Chae
5ba9cc6ec9
For #10253 : Add disableFirstTimePWAPopup for performance testing ( #10442 )
4 years ago
ValentinTimisica
15dfe0811d
For #10343 : Updates metrics accordingly to 'Library' removal
4 years ago
ValentinTimisica
b2e5820364
For #10343 : Remove 'Library' functionality from the app
...
Also adds Bookmarks and History items to browser menu.
4 years ago
Simon Chae
ca7695854a
For #10552 : Set initial add-on details fragment visibility to false ( #10565 )
4 years ago
Sawyer Blatz
17fb7c1df7
For #10426 : Removes installation ping GAID ( #10532 )
4 years ago
Simon Chae
d58e7d3138
For #10473 : Fetch the addon from addon manager instead of the store
4 years ago
Sawyer Blatz
b87c40d42f
For #10426 : Sends GAID to Installation instead of Activation ping. ( #10529 )
4 years ago
codrut.topliceanu
d1005dd236
For #8589 - Fix for accessibility navigation in ETP panel
4 years ago
Arturo Mejia
ca01965f90
Fix PictureInPictureFeature breaking change
4 years ago
ekager
7fe6f68e00
For #10485 - Restore block video/audio on cellular data radio button
4 years ago
ValentinTimisica
f63cb4e09f
For #10244 : Creates drawable for add-ons private browsing label.
...
The drawable is sent to AddonsManagerAdapter.Style constructor and is displayed
near the add-on name if it is allowed to run in private browsing
4 years ago
Jeff Boek
58ca5d0e3a
For #10341 - Always show collections placeholder with new tab tray enabled
4 years ago
Mihai Branescu
eef5cf3469
For #10482 - made SVG gradient compatible with API < 22
4 years ago
ekager
138d8e647d
No issue - Use ViewLifecycleOwner lifecycleScope for Bookmark deletion scope
4 years ago
Sawyer Blatz
02f6e6868e
For #10426 : Adds identifier to Glean for 24 hours ( #10446 )
4 years ago
Jonathan Almeida
57eb2b9549
For #10453 : Do not set item decoration when creating ViewHolder
4 years ago
ValentinTimisica
24ba9f2fc8
For #9505 : Adds possibility to sort saved logins
...
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
4 years ago
mcarare
9177871edc
For #10408 : Check current destination before navigating.
4 years ago
ekager
9fd835de0f
For #10433 - Pass in viewLifecycleScope to BrowserAnimator
4 years ago
ekager
9ec1f8e2d8
For #8981 - Sort devices in share list by last access time
4 years ago
Michael Comella
4cf7280916
No issue: add clarifying kdoc for BookmarkFragment.
4 years ago
David Walsh
8b27a48635
For #10329 - Implement tab tray divider
4 years ago
Simon Chae
609936d632
For #10196 : Remove clickable locks for enable and private-browsing UI ( #10445 )
4 years ago
Simon Chae
a851b76ea3
Update Android Components version to 41.0.20200506130132 ( #10443 )
4 years ago
Mihai Branescu
6f97e75579
For #8643 and #7606 - illustrations are now connected to their radio buttons
4 years ago
Mihai Branescu
cde31cf785
For #8643 and #7606 - Changed toolbar picker illustrations according to theme
4 years ago
Mihai Branescu
16b7a9399b
For #8643 and #7606 - Changed theme picker illustrations according to theme
4 years ago
Mihai Branescu
4c0af91b7b
For #8643 and #7606 - Changed tint for onboarding icons
4 years ago
Arturo Mejia
398b516fb7
No issue: Add Fingerprinters to the standard trancking protection policy
4 years ago
Christian Sadilek
fee09c3092
No issue: Show article/page url instead of reader extension url
4 years ago
Jeff Boek
d72e455c0d
No Issue - Update to AC 41.0.20200505190119
4 years ago
Mihai Adrian
43d30793f5
For #9794 : Announce installing state for screen readers ( #10111 )
4 years ago
Mihai Adrian
5106134786
For #10408 : Dismiss menu when navigating away. ( #10415 )
...
The menu is dismissed when toolbar view is detached from window.
4 years ago
David Walsh
542f31f970
For #10392 - Don't provide a "Save to collection" button in private mode for the tabs tray ( #10399 )
4 years ago
Sören Hentzschel
10d07912da
no issue - removed unused feature flag
4 years ago
Jeff Boek
94cd195dc7
Adds swipe to delete tab ( #10355 )
...
* No Issue - Increases tap area of close button
* For #10331 - Adds swipe to delete to the tab tray
4 years ago
Simon Chae
3dcd52ef7a
For #10195 , #10196 : Allow private browsing mode switch to sync with enable state
4 years ago
Jeff Boek
5c7e9b98cd
Fix home navigation ( #10350 )
4 years ago
Jeff Boek
a8a90bd4d6
For #1063 : Put tab tray behind a feature flag and hidden pref ( #10313 )
...
* For #1063 - Adds feature flag and pref for new tab tray
* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled
* For #1063 - Creates hidden preference to use new tab tray
* For #1063 - Hides tabs on home screen when setting is enabled
* For #1063 - Navigate to new tab tray from browser with setting enabled
* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections
* For #1063 - Fixes crash when toggling to private mode on the home screen
* For #1063 - combines both settings. Cleans up lint errors
4 years ago
Chenxia Liu
390c5a0189
Issue #7996 : fix lint issues
4 years ago
Jovan Gerodetti
4a12f1b6aa
For #7996 : Private mode doesn't play nicely with sites added to home screen
...
Site Controls Notification should reflect the browsing mode of the
currernt web app session.
4 years ago
Arturo Mejia
56bb3e38ec
For issue #10142 Update sitePermissions state when toggling its value
4 years ago
ekager
2e27bbd15d
No issue - Remove unused data class TopSiteItem
4 years ago
Sawyer Blatz
38e9b34659
For #10071 : Fixes PWA showing toolbar onPause ( #10306 )
4 years ago
mcarare
4006501d41
For #9728 : Add actionbar search for language list.
4 years ago
ekager
52d09930a6
No issue - Update new strings for quarantine
4 years ago
Mihai Eduard Badea
02bd0cc203
For issue #8648
4 years ago
Jonathan Almeida
76002c5987
Fix breaking API changes in CrashReporter
5 years ago
Falaye Iyanuoluwa
c86209ff98
Closes #9694 Bug when user denies permission
5 years ago
mcarare
3c5d8d31ea
For #10083 : Adjust thumb offset to thumb circumference to avoid cutoff
5 years ago
David Walsh
6afcd2cee6
For #10201 - Provide proper button padding and no tabs message visibility in tabs tray
5 years ago
Arturo Mejia
e55a4fd274
No issue: Partially update the add-on manager list
5 years ago
mcarare
1aa473b112
For #9913 , For #9914 : Remove touch delegate when button is disabled.
5 years ago
ekager
a9692d9bce
For #10204 - Address viewLifecycleOwner IllegalStateException crashes
5 years ago
Mihai Branescu
a16bfb27ef
For #6557 - added unit tests
5 years ago
Mihai Branescu
0c2d22f595
For #6557 - add in_content telemetry class
5 years ago
Mihai Branescu
28496fecc0
For #6557 - split base extension functionality from ads
5 years ago
Mihai Branescu
f09bc4566c
For #6557 - added metric for in_content
5 years ago
mcarare
e830da59b7
For #10180 : Remove touch delegate when button is disabled.
...
Also refactored multiple if's into a when.
5 years ago
mcarare
3e13927c25
For #10180 : Add extension to remove touch delegate from parent.
5 years ago
Mihai Branescu
c4d76dce5a
For #6558 - cleanup + added unit tests
5 years ago
Mihai Branescu
f03d65b13d
For #6558 - added logic for ad_clicked metric
5 years ago
Mihai Branescu
93ca1f6d9f
For #6558 - added handling of web extension + sending metric for has_ads
5 years ago
Simon Chae
f1559ed2da
For #10162 : Set switch back to prev state when failed to enable/disable addon ( #10164 )
5 years ago
mcarare
2edd4b39a4
For #9913 , For #9914 : Remove button when disabling it.
...
Setting visibility to GONE allows clicks to parent view in that space.
5 years ago
Arturo Mejia
956bf01cd5
For issue #9493 : Reload after cleaning individual site permissions exceptions
5 years ago
David Walsh
6f5f48c30e
For #10148 - Add basic tab tray implementation without exposing to rest of app ( #9934 )
5 years ago
Vlad Filippov
e51e1c878b
Add 'useEmail' and 'useEmailProblem' metrics event
...
Fixes #9834
5 years ago
Simon Chae
b3248ec769
For #6123 : Expose WebExtensions in private browsing control
5 years ago
mcarare
cc67de29bf
For #10091 Also disable play/pause button when hiding it.
5 years ago
mcarare
9dd8314d14
For #10091 Add extension to remove and disable button
5 years ago
mcarare
932fd44823
For #7387 : Change ETP onboarding from popup to a dialog.
...
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
5 years ago
mcarare
72fe52fcb8
For #9987 : Set FLAG_SECURE to dialog when flag set in activity.
5 years ago
ValentinTimisica
da3fca0f29
Fixes #10109 : Adds content description for browse privately card content
5 years ago
mcarare
e11f1b62dc
For #10027 : Make toolbar context menu popup dismissible on SDK<23
5 years ago
ekager
c4e83367f6
For #6832 - Fix various fragment not attached to a context crashes
5 years ago
ekager
6457a02a82
For #2818 - Enable PiP for all builds
5 years ago
Roger Yang
0227e953ae
Close #9760 : Add external app links context menu candidate
5 years ago
Sawyer Blatz
dce16964c0
For #9208 : Adds in-product prompt to homescreen ( #9836 )
5 years ago
Arturo Mejia
0a23d66756
For issue #7566 Handle deny & don't ask again for site permissions
5 years ago
Arturo Mejia
995da59fa8
For issue #9493 : Reload after cleaning all site permissions exceptions
5 years ago
ekager
70755adf6e
For #10036 - Workaround for System Theme changes with config change
5 years ago
Michael
1f8b7ff962
Closes #8541 : Hide find bar when entering fullscreen
5 years ago
Jeff Boek
164e6cd079
For #9816 - Adds SessionObserver to session on selection
5 years ago
Jonathan Almeida
6ad046714d
Close #9338 : Enable WebPush engine integration in all builds
5 years ago
ekager
f3847d0d7c
For #8735 - Adjust fontInflation engine setting when toggling useAutoSize
5 years ago
ekager
66d9a24b28
Closes #9928 - Updates private browsing text description
5 years ago
ekager
5d51c4f059
Don't use ProcessLifecycleOwner for view-tied consume
5 years ago
ekager
f801f32027
No issue: Fix leaks in BookmarkFragment
5 years ago
ekager
5014cd78ec
No issue: Fix leaking sessionControlInteractor
5 years ago
Grisha Kruglov
853a0acab4
Closes #4046 : Always display 'Desktop' bookmarks folder
...
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.
In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
5 years ago
Jonathan Almeida
c16283a923
For #9932 : Fix navigation icon theme missing from migration UI
...
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
5 years ago
Sawyer Blatz
a8e624959e
For #6940 : Fixes top dynamic toolbar behavior ( #9900 )
5 years ago
Roger Yang
40550e88de
Close #9960 : Launch URI in Fenix if failed to launch in custom tab ( #9964 )
5 years ago
Christian Sadilek
ec1d4e8fca
For #8399 : Hide keyboard to prevent content resizes
...
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
5 years ago
Michael Comella
f3ed207bdb
For #8803 - review: Add clarifying comments to onAppInit capture methods.
5 years ago
Michael Comella
f49fc6dad2
For #8803 : hook up frameworkStart metric.
5 years ago
Michael Comella
dbf733d70a
For #8803 : add StartupFrameworkStartMeasurement.
...
This class controls the central logic around the metrics we want to
record.
5 years ago
Michael Comella
7f618a6a7c
For #8803 : add Stat and test.
...
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
5 years ago
Emily Kager
39107b4036
For #9703 - Exit fullscreen in onPause and onSessionSelected ( #10016 )
...
* For #9703 - Call fullScreenChanged in onPause
* For #10015 - Exit full screen if new session selected
5 years ago
ekager
6f77ec5951
Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver
5 years ago
Grisha Kruglov
0ec6d266e8
Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry
...
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
5 years ago
Mihai Adrian
72fe9fad0c
For #9987 : Set FLAG_SECURE to dialog when flag set in activity. ( #9998 )
...
* For #9987 : Add extension to secures dialog if parent activity is secured
* For #9987 : Set FLAG_SECURE to dialog when flag set in activity
5 years ago
Mihai Eduard Badea
725ba1e856
For #9951 - Removed the extra empty spaces that were causing the spacing issue
5 years ago
mcarare
83d2208c6b
For #9536 : Open report issue tab depending on current browsing mode.
...
Checking if session is private uses the new browser state API.
5 years ago
Sawyer Blatz
1f8f69548a
For #7158 : Fixes browser to search animation fade
5 years ago
Jonathan Almeida
25d5b0d31c
For #8422 : Add spacing between migration items
5 years ago
ekager
4a06a228f3
For #9981 - Make Bookmark Menu UI respond to session selection
5 years ago
mcarare
25e12e2f77
For #9984 : Update addon before settings visibility check
5 years ago
Sawyer Blatz
8185ba793e
For #9857 : Create button style ( #9858 )
...
* For #9857 : Creates text button style
* Adds lint check
* Fixes onboarding cards
5 years ago
Jonathan Almeida
997f6c72d6
For #9409 : Add app icon to Leanplum push notifications
5 years ago