* fixes#4434 - made close button for collections more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for #4193 - close button for tabs
* fixes#4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button
set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
* Add no-op experiment to test service-experiments integration
* Shorten metric name to meet schema
* Add active_experiment metric to docs
* Add approved data review
To fix the overlapping issue I used Guideline and
layout_constraintWidth_default property. I also used the
layout_constraintHorizontal_bias property to make the back_button to
lean to the left and the select_all_button to lean to the right.
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
Yeon Taek Jeong
Mihai Adrian
Michael Cooper
Tiger Oakes
Colin Lee
Emily Kager
Sourabh
(´⌣`ʃƪ)
Sebastian Kaspari
Jorge De Los Santos
Grisha Kruglov
Christian Sadilek
Sawyer Blatz
Axel Hecht
Jonathan Almeida
ValentinTimisica
Mathieu Leplatre
Hakkı Kaan Çalışkan
Emily Kager